Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Mark Brown
On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > One of the biggest roadblocks on the way of S3C64xx to DeviceTree support > is its DMA driver, which is completely platform-specific and provides > private API (s3c-dma), not even saying that its design is completely > against multiplat

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > > One of the biggest roadblocks on the way of S3C64xx to DeviceTree > > support is its DMA driver, which is completely platform-specific and > > provides private API (s3c-dma), n

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Arnd Bergmann
On Wednesday 19 June 2013, Tomasz Figa wrote: > On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > > On Sun, Jun 16, 2013 at 10:54:07PM +0200, Tomasz Figa wrote: > > > One of the biggest roadblocks on the way of S3C64xx to DeviceTree > > > support is its DMA driver, which is completely platf

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Mark Brown
On Wed, Jun 19, 2013 at 08:26:12PM +0200, Tomasz Figa wrote: > On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > > - ret = pd->get_signal(plchan->cd); > > + ret = (pd->get_signal)(plchan->cd); > Hmm, that's strange. The former is a completely valid piece of code... I

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Mark Brown
On Wed, Jun 19, 2013 at 09:01:33PM +0200, Arnd Bergmann wrote: > On Wednesday 19 June 2013, Tomasz Figa wrote: > > > if (plchan->mux_use++ == 0 && pd->get_signal) { > > > - ret = pd->get_signal(plchan->cd); > > > + ret = (pd->get_signal)(plchan->cd); > > Hmm, that's

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 20:22:11 Mark Brown wrote: > On Wed, Jun 19, 2013 at 08:26:12PM +0200, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > > > - ret = pd->get_signal(plchan->cd); > > > + ret = (pd->get_signal)(plchan->cd); > > > > Hmm, that

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-19 Thread Mark Brown
On Wed, Jun 19, 2013 at 09:32:44PM +0200, Tomasz Figa wrote: > On Wednesday 19 of June 2013 20:22:11 Mark Brown wrote: > > No, I didn't - that's most likely it, I didn't really investigate. I > > didn't test the watchdog stuff as the clocks didn't get sent to me. > I always try to keep you on Cc

RE: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-20 Thread Phil Carmody
(Apologies if this is mangled, fighting both Outlook and remote desktop :-( ) linux-kernel-ow...@vger.kernel.org wrote on Behalf Of Mark Brown > On Wed, Jun 19, 2013 at 08:26:12PM +0200, Tomasz Figa wrote: > > On Wednesday 19 of June 2013 18:40:47 Mark Brown wrote: > > > > - ret = pd->get

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-20 Thread Mark Brown
On Thu, Jun 20, 2013 at 12:24:47PM +0300, Phil Carmody wrote: > Can you just make that minimal change, and diff the objdump of the two .o's? > It would be worth a bug-report against the toolchain if different code was > being generated. If objdump spews huge numbers of diffs (due to one address >

RE: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-20 Thread Phil Carmody
> -Original Message- > On Thu, Jun 20, 2013 at 12:24:47PM +0300, Phil Carmody wrote: > > Can you just make that minimal change, and diff the objdump of the > two .o's? > > It would be worth a bug-report against the toolchain if different > code > > was being generated. If objdump spews huge

Re: [RFC PATCH 00/11] ARM: s3c64xx: Let amba-pl08x driver handle DMA

2013-06-21 Thread Mark Brown
On Thu, Jun 20, 2013 at 02:14:53PM +0300, Phil Carmody wrote: > With my language-lawyer hat on, I'd suggest ``(get_signal)'' to prevent the > macro expansion: Right, which the patch I posted in the mail was doing IIRC. > However, it's more tempting (i.e. sensible) to just rename the > one with