Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Uwe Kleine-König
On Wed, Jan 20, 2010 at 10:01:55AM +, Mark Brown wrote: > On Wed, Jan 20, 2010 at 02:02:02AM +, Ben Dooks wrote: > > > I've written a git pre-commit[1] hook which stops any commits happening if > > checkpatch.pl reports problems with the patch. Any comments? > > > [1] http://www.fluff.org

Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Mark Brown
On Wed, Jan 20, 2010 at 02:02:02AM +, Ben Dooks wrote: > I've written a git pre-commit[1] hook which stops any commits happening if > checkpatch.pl reports problems with the patch. Any comments? > [1] http://www.fluff.org/ben/linux/githooks/pre-commit Checkpatch does sometimes generate the o

Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Russell King - ARM Linux
On Wed, Jan 20, 2010 at 02:02:02AM +, Ben Dooks wrote: > I've written a git pre-commit[1] hook which stops any commits happening if > checkpatch.pl reports problems with the patch. Any comments? Very bad - checkpatch can be wrong at times. Eg 1, asm/irq.h vs linux/irq.h Eg 2, asm/memory.h vs

git pre-commit hook running checkpatch.pl

2010-01-19 Thread Ben Dooks
I've written a git pre-commit[1] hook which stops any commits happening if checkpatch.pl reports problems with the patch. Any comments? [1] http://www.fluff.org/ben/linux/githooks/pre-commit -- Ben Q: What's a light-year? A: One-third less calories than a regular year. signature.as