[PATCH v3 1/6] mmc: pwrseq: Document that simple sequence support more than one GPIO

2015-01-29 Thread Javier Martinez Canillas
Many SDIO/MMC attached WLAN chips need more than one ping for their reset sequence. Extend the pwrseq_simple binding to support more than one pin. Signed-off-by: Javier Martinez Canillas --- Changes since v2: None. Changes since v1: - Make the explanation clearer by adding an explicit "

Re: [RFC] drm/exynos: move hdmi clk disable out of pm ops

2015-01-30 Thread Javier Martinez Canillas
Hello Joonyoung, On Fri, Jan 30, 2015 at 3:02 AM, Joonyoung Shim wrote: > +Cc Kukjin, > > Hi, > > On 01/29/2015 10:31 PM, Gustavo Padovan wrote: >> From: Prathyush K >> >> When VPLL clock of less than 140 MHz was used and all the three >> clocks - hdmiphy, hdmi, sclk_hdmi are disabled, the syste

Re: [RFC] drm/exynos: move hdmi clk disable out of pm ops

2015-01-30 Thread Javier Martinez Canillas
Hello, On Fri, Jan 30, 2015 at 9:03 AM, Javier Martinez Canillas wrote: > > I haven't the S2R case since it is broken in mainline for Exynos5420 > (even with $subject applied) but $subject fixes for me the system > crash we have discussed before [0]. That is when mixer_pow

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-01-30 Thread Javier Martinez Canillas
Hello Paul, Thanks a lot for your feedback. On 01/29/2015 10:11 PM, Paul Bolle wrote: >> >> +config CROS_EC_LPC >> +tristate "ChromeOS Embedded Controller (LPC)" >> +depends on MFD_CROS_EC >> + > > Please drop this empty line. > Ok. >> +help >> + If you say Y here, you get

Re: [PATCH v3 4/6] mmc: pwrseq_simple: Add optional reference clock support

2015-01-30 Thread Javier Martinez Canillas
Hello Ulf, On 01/30/2015 12:17 PM, Ulf Hansson wrote: >> }; >> @@ -39,6 +42,11 @@ static void mmc_pwrseq_simple_pre_power_on(struct >> mmc_host *host) >> struct mmc_pwrseq_simple *pwrseq = container_of(host->pwrseq, >> struct mmc_pwrseq_simple, pwr

Re: [PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-01-30 Thread Javier Martinez Canillas
Hello Ulf, On 01/30/2015 12:13 PM, Ulf Hansson wrote: >> >> Patch #1 extends the simple MMC power sequence DT binding to support more >> than one GPIO and patch #2 adds the actual implementation. >> >> In the same way, patch #3 and #4 extend the simple MMC power sequence DT >> binding and pwrseq_s

Re: [PATCH v2 0/3] Add support for hardware reset of eMMC card on reboot

2015-02-02 Thread Javier Martinez Canillas
m system reboot procedure. > Patches looks good to me, I've only one comment on patch 1/3. Once that is addressed, feel free to add for all the series: Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc&

Re: [PATCH v2 1/3] mmc: pwrseq: add driver for emmc hardware reset

2015-02-02 Thread Javier Martinez Canillas
Hello Marek, On Mon, Feb 2, 2015 at 9:33 AM, Marek Szyprowski wrote: > + > +Required properties: > +- compatible : contains "mmc-pwrseq-emmc". > +- reset-gpios : contains a GPIO specifier. The reset GPIO is pulled The DT binding says that the "reset-gpios" is a required property... > +int mmc_p

[PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-02 Thread Javier Martinez Canillas
owing patches: Bill Richardson (4): platform/chrome: Add cros_ec_lpc driver for x86 devices platform/chrome: Add Chrome OS EC userspace device interface platform/chrome: Create sysfs attributes for the ChromeOS EC platform/chrome: Expose Chrome OS Lightbar to users Javier Martinez Canill

[PATCH v5 1/7] mfd: cros_ec: Use fixed size arrays to transfer data with the EC

2015-02-02 Thread Javier Martinez Canillas
byte boundaries, use fixed size arrays instead of pointers for transferring ingoing and outgoing data with the Embedded Controller. Also, re-arrange struct members by decreasing alignment requirements to reduce the needing padding size. Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones

[PATCH v5 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-02-02 Thread Javier Martinez Canillas
The ChromeOS EC character device is an user-space interface to allow applications to access the Embedded Controller. Add a cell for this device so it's spawned from the mfd driver. Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones --- Changes since v4: None. Changes since v3:

[PATCH v5 6/7] platform/chrome: Create sysfs attributes for the ChromeOS EC

2015-02-02 Thread Javier Martinez Canillas
t; reboot cat version echo rw > reboot cat version echo cold > reboot That last command will reboot the AP too. Signed-off-by: Bill Richardson Reviewed-by: Olof Johansson Signed-off-by: Javier Martinez Canillas --- Changes since v4: None. Changes since v3: None. Changes

[PATCH v5 7/7] platform/chrome: Expose Chrome OS Lightbar to users

2015-02-02 Thread Javier Martinez Canillas
d-off-by: Bill Richardson Reviewed-by: Olof Johansson Tested-by: Doug Anderson Reviewed-by: Benson Leung Signed-off-by: Javier Martinez Canillas --- Changes since v4: None. Changes since v3: None. Changes since v2: None. Changes since v1: - Moved from drivers/mfd to drivers/platf

[PATCH v5 3/7] platform/chrome: Add cros_ec_lpc driver for x86 devices

2015-02-02 Thread Javier Martinez Canillas
are drivers to communicate with the EC over I2C and SPI and this driver adds support for LPC. Signed-off-by: Bill Richardson Signed-off-by: Javier Martinez Canillas --- Changes since v4: - Move from drivers/misc to drivers/platform/chrome/ since is a better fit. - Remove space in Kconfig text

[PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-02 Thread Javier Martinez Canillas
From: Bill Richardson This patch adds a device interface to access the Chrome OS Embedded Controller from user-space. Signed-off-by: Bill Richardson Reviewed-by: Simon Glass Signed-off-by: Javier Martinez Canillas Reviewed-by: Gwendal Grignou --- Changes since v4: None. Changes since v3

[PATCH v5 2/7] mfd: cros_ec: Add char dev and virtual dev pointers

2015-02-02 Thread Javier Martinez Canillas
The ChromeOS Embedded Controller has to be accessed by applications. A virtual character device is used as an interface with user-space. Extend the struct cros_ec_device with the fields needed by the driver of this virtual character device. Signed-off-by: Javier Martinez Canillas Acked-by: Lee

Re: [PATCH v4 3/7] misc: Add cros_ec_lpc driver for x86 devices

2015-02-02 Thread Javier Martinez Canillas
Hello, On 01/30/2015 01:51 PM, Javier Martinez Canillas wrote: > On 01/29/2015 10:11 PM, Paul Bolle wrote: >>> + help >>> + If you say Y here, you get support for talking to the ChromeOS EC >>> + over an LPC bus. This uses a simple byte-level protocol with

Re: [PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-02-04 Thread Javier Martinez Canillas
Hello Kukjin, On 01/30/2015 02:06 PM, Javier Martinez Canillas wrote: > On 01/30/2015 12:13 PM, Ulf Hansson wrote: >>> >>> Patch #1 extends the simple MMC power sequence DT binding to support more >>> than one GPIO and patch #2 adds the actual implementation. >>

Re: [PATCH v3 0/6] Add multiple GPIO and external clock to MMC pwrseq_simple

2015-02-04 Thread Javier Martinez Canillas
Hello Kukjin, On 02/04/2015 04:19 PM, Kukjin Kim wrote: > On 02/05/15 00:06, Javier Martinez Canillas wrote: >> >> I noticed that you are applying patches to your Samsung tree, do you want me >> to >> re-send patches #5 and #6 or is OK for you to pick them from fro

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-02-05 Thread Javier Martinez Canillas
for Exynos5420 platform' [2]. > It was successfully tested on OdroidXU3. > > [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743 Your patches looks good to me so please feel free to add: Reviewed-by: Javier Martinez Canillas I also tested on an Exynos5420 Peach Pit

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-02-06 Thread Javier Martinez Canillas
Hello Joonyoung, On 02/06/2015 06:27 AM, Joonyoung Shim wrote: > On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote: >> >> I also tested on an Exynos5420 Peach Pit Chromebook and both the "Power >> domain power-domain disable failed" message and the system

Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-02-06 Thread Javier Martinez Canillas
Hello Andrzej, On 02/06/2015 11:55 AM, Andrzej Hajda wrote: > FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), > therefore their clocks should be enabled during power domain switch. > > Signed-off-by: Andrzej Hajda > --- > Hi, > > This is 2nd version of the patch. After

[PATCH 1/1] ARM: dts: Add mclk entry for Snow and Peach Pit/Pi boards

2015-02-06 Thread Javier Martinez Canillas
From: Tushar Behera On Snow, Peach Pit and Peach Pi boards, the Exynos SoC XCLKOUT output pin provides the master clock (mclk) to codecs. So make them a clock consumer. Signed-off-by: Tushar Behera Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5250-snow.dts | 2

[PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-06 Thread Javier Martinez Canillas
PD enable or disable failed. Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420.dtsi | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index b63b569ca4b4..4642cec50c0d 100644 ---

[PATCH 1/1] ARM: exynos_defconfig: Enable HDMI support

2015-02-06 Thread Javier Martinez Canillas
Many Exynos boards have an HDMI port so enable Exynos DRM HDMI support. Signed-off-by: Javier Martinez Canillas --- Exynos DRM HDMI has some issues that were fixed by Andrzej's [0] series. So now is safe to HDMI support for Exynos boards. [0]: https://lkml.org/lkml/2015/2/5/265 arc

[PATCH v2 1/1] ARM: dts: Add mclk entry for Snow and Peach Pit/Pi boards

2015-02-06 Thread Javier Martinez Canillas
From: Tushar Behera On Snow, Peach Pit and Peach Pi boards, the Exynos SoC XCLKOUT output pin provides the master clock (mclk) to codecs. So make them a clock consumer. Signed-off-by: Tushar Behera Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Rebased on top of Kukjin&#

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-06 Thread Javier Martinez Canillas
Hello Sergei, Thanks a lot for your feedback. On 02/06/2015 08:09 PM, Sergei Shtylyov wrote: > Hello. > > On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote: > >> All the device nodes for the Exynos5420 power-domains have a quite >> generic "power-domain&q

Re: [PATCH] ARM: dts: exynos5420: Add maudio power domain

2015-02-09 Thread Javier Martinez Canillas
us the > patch should not introduce any functional change except of visibility of > this domain to the system. > > Signed-off-by: Krzysztof Kozlowski > --- Your patch looks good to me, I just have two small comments below. With those changes, feel free to add: Reviewed-by: Javier Ma

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-10 Thread Javier Martinez Canillas
Hello, On 02/10/2015 01:30 PM, Krzysztof Kozlowski wrote: > On wto, 2015-02-10 at 15:21 +0300, Sergei Shtylyov wrote: >> On 2/10/2015 3:17 PM, Krzysztof Kozlowski wrote: >> >> >>> Additionally (on Arndale Octa): >> >> >>> $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary >> >>> domain

Re: [PATCH] ARM: EXYNOS: Use platform device name as power domain name

2015-02-10 Thread Javier Martinez Canillas
to have even more info like 100440e0.mau-power-domain. Maybe using the OF aliases approach that Sylwester suggested? But in any case that could be complementary to your patch. > Signed-off-by: Krzysztof Kozlowski > Suggested-by: Javier Martinez Canillas > Suggested-by: Sergei Shtylyov

[PATCH 0/2] clk: Some fixes for the per-user clk API changes.

2015-02-11 Thread Javier Martinez Canillas
Hello, I found a couple of issues with todays' next (tag next-20150211) when booting an Exynos5420 Peach Pit Chromebook. These were regressions introduced when converting the clk API to return a per-user clk. This series is composed of the following trivial fixes: Javier Martinez Canill

[PATCH 1/2] clk: Don't dereference parent clock if is NULL

2015-02-11 Thread Javier Martinez Canillas
") Signed-off-by: Javier Martinez Canillas --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 7f53166af5e6..7bd8893c94d6 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -799,7 +799,7 @@ clk_mux_de

[PATCH 2/2] clk: composite: Set clk_core to composite rate and mux components

2015-02-11 Thread Javier Martinez Canillas
API return per-user struct clk instances") Signed-off-by: Javier Martinez Canillas --- Hello, I set the rate and mux components' .core in clk_composite_determine_rate() because that is the least intrusive change and where the .clk field is set too but I wonder if there is a reason to chang

Re: [PATCH 2/2] clk: composite: Set clk_core to composite rate and mux components

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, On 02/11/2015 07:50 PM, Stephen Boyd wrote: >> --- > > Thanks for the patch. > Thanks a lot for your feedback. >> >> Hello, >> >> I set the rate and mux components' .core in clk_composite_determine_rate() >> because that is the least intrusive change and where the .clk field i

Re: [PATCH 1/2] clk: Don't dereference parent clock if is NULL

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, Thanks a lot for your feedback. On 02/11/2015 07:54 PM, Stephen Boyd wrote: > On 02/11, Javier Martinez Canillas wrote: >> --- a/drivers/clk/clk.c >> +++ b/drivers/clk/clk.c >> @@ -799,7 +799,7 @@ clk_mux_determine_rate_flags(struct clk_hw *hw, u

[PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function

2015-02-12 Thread Javier Martinez Canillas
change the assignments twice in all the drivers, add a helper function to have an indirection level. Signed-off-by: Javier Martinez Canillas --- Changes since v1: None, new patch. --- include/linux/clk-provider.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/clk-provider.h b

[PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk

2015-02-12 Thread Javier Martinez Canillas
;dst->hw, hw); Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances") Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Don't only fix the case of composite clocks but in all the places where a struct clk was assigned. Suggested by Stephen Boyd.

[PATCH v2 1/3] clk: Don't dereference parent clock if is NULL

2015-02-12 Thread Javier Martinez Canillas
andle that case. Fixes: 035a61c314eb3 ("clk: Make clk API return per-user struct clk instances") Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Pass NULL struct clk_hw argument to __clk_determine_rate() if parent is NULL. suggested by Stephen Boyd. --- driver

[PATCH v2 0/3] clk: Some fixes for the per-user clk API changes.

2015-02-12 Thread Javier Martinez Canillas
] and this addresses issues pointed out by Stephen Boyd. This series is composed of the following patches: Javier Martinez Canillas (3): clk: Don't dereference parent clock if is NULL clk: Add __clk_hw_set_clk helper function clk: Replace explicit clk assignment with __clk_hw_se

Re: [PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, On 02/12/2015 08:55 PM, Stephen Boyd wrote: > On 02/12/15 05:58, Javier Martinez Canillas wrote: >> >> The changes were made using the following cocinelle semantic patch: >> >> @i@ >> @@ >> >> @depends on i@ >> identifier dst; >

Re: [PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, On 02/12/2015 08:55 PM, Stephen Boyd wrote: > On 02/12/15 05:58, Javier Martinez Canillas wrote: >> After the clk API change to return a per-user clock instance, both the >> struct clk_core and struct clk pointers from the hw clock needs to be >> assigned to

Re: [PATCH RESEND] ARM: dts: exynos5422-odroidxu3: add mmc detect gpio

2015-02-13 Thread Javier Martinez Canillas
samsung,dw-mshc-ddr-timing = <0 2>; > pinctrl-names = "default"; > - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; > + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_cd>; > bus-width

[PATCH] ARM: exynos_defconfig: Enable Marvell WiFi-Ex support

2015-02-15 Thread Javier Martinez Canillas
Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a MMC/SDIO Marvell WiFi-Ex chip. This patch enables wireless support and the mwifiex driver. Signed-off-by: Javier Martinez Canillas --- arch/arm/configs/exynos_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-16 Thread Javier Martinez Canillas
Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: > Hello, > > The mainline ChromeOS Embedded Controller (EC) driver is still missing some > features that are present in the downstream ChromiumOS tree. These are: > > - Low Pin Count (LPC) interface >

[PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-02-17 Thread Javier Martinez Canillas
by: Javier Martinez Canillas --- arch/arm/configs/exynos_defconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 70e5d0bdb4e4..3d22aae39a83 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-02-17 Thread Javier Martinez Canillas
Hello Krzysztof, On 02/17/2015 01:20 PM, Krzysztof Kozlowski wrote: > On wto, 2015-02-17 at 12:38 +0100, Javier Martinez Canillas wrote: >> Enabling Exynos DRM IOMMU support for Exynos is currently broken and >> causes a BUG on exynos-iommu driver. This was not an issue since the

Re: [PATCH] Revert "drm/exynos: IOMMU support should not be selectable by user"

2015-02-17 Thread Javier Martinez Canillas
Hello Charles, On Tue, Feb 17, 2015 at 5:58 PM, Charles Keepax wrote: > This reverts commit 8dcc14f82f06fce997e35f4c77ced9d4ed192f31. > > This patch causes this error on Arndale: IMHO the commit you are referring is correct so it should not be reverted but I also had the same error on different

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-18 Thread Javier Martinez Canillas
Hello Simon, On 02/18/2015 03:26 AM, Simon Glass wrote: > > On 16 February 2015 at 01:19, Javier Martinez Canillas > wrote: >> Hello Olof, >> >> On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: >>> Hello, >>> >>> The mainline ChromeOS

Re: [PATCH] ARM: dts: Update exynos5250-spring with mmc node changes

2015-02-19 Thread Javier Martinez Canillas
exynos5250-spring.dts | 16 > 1 file changed, 4 insertions(+), 12 deletions(-) > Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vge

Re: [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring

2015-02-19 Thread Javier Martinez Canillas
Hello Andreas, On 02/18/2015 05:17 PM, Andreas Färber wrote: > Configure the pins in external interrupt mode, as done for Snow in > e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for > exynos5250-snow"). > > Reported-by: Kukjin Kim > Suggested-by: Javie

Re: [PATCH v2 1/1] ARM: dts: Add mclk entry for Snow and Peach Pit/Pi boards

2015-02-19 Thread Javier Martinez Canillas
Hello Kukjin, On 02/06/2015 06:52 PM, Javier Martinez Canillas wrote: > From: Tushar Behera > > On Snow, Peach Pit and Peach Pi boards, the Exynos SoC XCLKOUT output pin > provides the master clock (mclk) to codecs. So make them a clock consumer. > > Signed-off-by: Tushar Be

Re: [PATCH 1/6] ASoC: max98088: Document DT bindings

2015-02-19 Thread Javier Martinez Canillas
Hello Andreas, On 02/18/2015 07:25 PM, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > Documentation/devicetree/bindings/sound/max98088.txt | 16 > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/max98088.txt > > diff

Re: [PATCH 6/6] ARM: dts: Add sound support to exynos5250-spring

2015-02-19 Thread Javier Martinez Canillas
Hello Andreas, On 02/18/2015 07:25 PM, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > arch/arm/boot/dts/exynos5250-spring.dts | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts > b/arch/arm/boot/dts/exynos5

Re: [PATCH 1/6] ASoC: max98088: Document DT bindings

2015-02-19 Thread Javier Martinez Canillas
Hello Andreas, We already talked over irc but for completeness I'll comment here as well. On 02/19/2015 07:54 PM, Andreas Färber wrote: > Am 19.02.2015 um 19:40 schrieb Andreas Färber: >> Am 19.02.2015 um 18:48 schrieb Doug Anderson: >>> On Thu, Feb 19, 2015 at 6:13 AM, Andreas Färber wrote: >>>

Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling

2015-02-23 Thread Javier Martinez Canillas
reas Färber >> --- >> sound/soc/codecs/max98088.c | 24 >> 1 file changed, 24 insertions(+) >> > > Looks good. > > Acked-by: Tushar Behera > Looks good to me as well. Reviewed-by: Javier Martinez Canillas Best regards, Javier --

Re: [PATCH 1/6] ASoC: max98088: Document DT bindings

2015-02-23 Thread Javier Martinez Canillas
Hello Sylwester, On 02/20/2015 01:12 PM, Sylwester Nawrocki wrote: > On 20/02/15 01:36, Andreas Färber wrote: >> So it seems the mclk is not always set up properly by the kernel, >> relying on firmware. Who's in charge of setting that clock up? >>> > >>> > Right, it seems audio is only

[PATCH 1/1] drivers/rtc/rtc-s3c.c: Add .needs_src_clk to s3c6410 RTC data

2015-02-24 Thread Javier Martinez Canillas
which uses the s3c6410 RTC IP block. This commit fixes the S3C rtc on the Exynos5250 Snow and Exynos5420 Peach Pit and Pi Chromebooks. Signed-off-by: Javier Martinez Canillas --- Hello, I see that Exynos4 uses the same s3c6410 RTC IP version but at least the Exynos4412 Odroid boards don't defin

Re: [PATCH v5 8/9] ARM: dts: exynos5250: add display power domain

2015-02-25 Thread Javier Martinez Canillas
; [mszyprow: rebased onto generic power domains dt bindings] >> Signed-off-by: Marek Szyprowski >> Tested-by: Javier Martinez Canillas >> Reviewed-by: Javier Martinez Canillas > > On Spring, > > Tested-by: Andreas Färber > > Andreas > Any comments on

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Javier Martinez Canillas
Hello Olof, Thanks a lot for your feedback. On 02/26/2015 02:13 AM, Gwendal Grignou wrote: > Olof, > > I think the way Javier did it is fine, the 'major' of the ioctl is > 0xEC, from ':'. > > Gwendal. > As Gwendal said, I deliberately changed the IOCTL mayor number to make it different in both

[PATCH 3/3] ARM: dts: Add mclk entry for Peach Pit/Pi boards

2015-02-26 Thread Javier Martinez Canillas
From: Tushar Behera On Peach Pit and Pi boards, the Exynos SoC XCLKOUT pin provides master clock (mclk) to the codec. So make it a clock consumer. Signed-off-by: Tushar Behera Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420-peach-pit.dts | 2 ++ arch/arm/boot/dts

[PATCH 2/3] ARM: dts: Add WiFi module support for Peach boards

2015-02-26 Thread Javier Martinez Canillas
Peach Pit and Pi boards have a WiFi module that is always powered but needs toggling an enable pin and ungating a 32kHz reference clock as part of their power sequencing. Add a dev node for the SDIO slot and a MMC power sequence provider. Signed-off-by: Javier Martinez Canillas --- arch/arm

[PATCH 0/3] ARM: dts: Peach boards WiFi and audio support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, This series adds support for the remaining peripherals that were not supported in the Exynos5420 Peach Pit and Exynos5800 Peach Pi boards. Javier Martinez Canillas (2): ARM: dts: Mux XMMCnDATA[0] pad correctly for Exynos5420 boards. ARM: dts: Add WiFi module support for Peach

[PATCH 1/3] ARM: dts: Mux XMMCnDATA[0] pad correctly for Exynos5420 boards.

2015-02-26 Thread Javier Martinez Canillas
o in the nodes pinctrl to not rely on the bootloader. Suggested-by: Doug Anderson Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++-- arch/arm/boot/dts/exynos5420-peach-pit.dts| 4 ++-- arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++--

Re: [PATCH 0/3] ARM: dts: Peach boards WiFi and audio support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, On 02/26/2015 04:55 PM, Kukjin Kim wrote: > Javier Martinez Canillas wrote: >> >> After this series all the peripherals in the Peach boards are working >> at least at a basic level, more work is needed to make the ASoC audio >> driver more robust

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Javier Martinez Canillas
Hello, On 02/27/2015 01:11 AM, Olof Johansson wrote: > On Thu, Feb 26, 2015 at 3:35 PM, Gwendal Grignou wrote: >> Tested-by: Gwendal Grignou >> Reviewed-by: Gwendal Grignou >> >> Tested on a chromebook pixel with kernel 4.0.0-rc1 and ectool using >> the enclosed patch in chromiumos platform/ec

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, On 02/17/2015 12:38 PM, Javier Martinez Canillas wrote: > Enabling Exynos DRM IOMMU support for Exynos is currently broken and > causes a BUG on exynos-iommu driver. This was not an issue since the > options was disabled in exynos_defconfig but after commit 8dcc14f82f0

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-02 Thread Javier Martinez Canillas
Hello Kukjin, On 03/02/2015 08:43 PM, Kukjin Kim wrote: > On 02/27/15 15:20, Javier Martinez Canillas wrote: >> Hello Kukjin, >> > Hi, > >> On 02/17/2015 12:38 PM, Javier Martinez Canillas wrote: >> >> Can you please pick this patch? linux-next is still

Re: [PATCH 8/9] ARM: EXYNOS: suspend requires regulator access

2015-03-02 Thread Javier Martinez Canillas
x27; statement in Kconfig to ensure the symbols > are available. > > Signed-off-by: Arnd Bergmann The patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc"

Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-03-03 Thread Javier Martinez Canillas
Hello Kukjin, On 02/06/2015 12:27 PM, Javier Martinez Canillas wrote: > Hello Andrzej, > > On 02/06/2015 11:55 AM, Andrzej Hajda wrote: >> FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), >> therefore their clocks should be enabled durin

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-04 Thread Javier Martinez Canillas
+Gustavo which has been looking at the issues Hello, On 03/04/2015 09:50 AM, Marek Szyprowski wrote: > Hello, > > On 2015-03-03 21:36, Kevin Hilman wrote: >> Javier Martinez Canillas writes: >> >>> Enabling Exynos DRM IOMMU support for Exynos is currently broken

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-04 Thread Javier Martinez Canillas
Hello Arnd, On Thu, Mar 5, 2015 at 12:04 AM, Arnd Bergmann wrote: > On Wednesday 04 March 2015 21:04:40 Arnd Bergmann wrote: >> On Tuesday 03 March 2015 04:00:14 Kukjin Kim wrote: >> > Please pull Samsung tmu and hdmi regression fixes for v4.0 and I know >> > this is quite big for fixes but I cou

Re: [PATCH] ARM: dts: exynos4: add nodes for jpeg codec

2015-03-05 Thread Javier Martinez Canillas
Hello Marek, Patch looks good to me. Just a small comment below so feel free to add my Reviewed by: Javier Martinez Canillas On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski wrote: > This patch adds nodes for hardware JPEG codec found in Exynos 4210 and > 4x12 SoCs. > > Signed-o

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-06 Thread Javier Martinez Canillas
Hello Kukjin, On Fri, Mar 6, 2015 at 10:43 AM, Kukjin Kim wrote: > Javier Martinez Canillas wrote: >> >> Hello Arnd, >> > Hi, > >> On Thu, Mar 5, 2015 at 12:04 AM, Arnd Bergmann wrote: >> > On Wednesday 04 March 2015 21:04:40 Arnd Bergmann wrote: >

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-06 Thread Javier Martinez Canillas
Hello Inki, On 03/06/2015 02:32 PM, Inki Dae wrote: >> >> Another interesting data point is that the error in next-20150303 for >> these 2 boards was the NULL pointer dereference in exynos_plane_destroy >> that I got with 4.0-rc2 (when IOMMU is disabled) in Snow and Peach Pit. > > I think the NU

[PATCH 1/1] ARM: exynos_defconfig: Enable ChromeOS EC chardev driver

2015-03-07 Thread Javier Martinez Canillas
Exynos Chromebooks have an Embedded Controller known as the ChromeOS EC Enable the driver that provides an interface to access from user-space. Signed-off-by: Javier Martinez Canillas --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-09 Thread Javier Martinez Canillas
Hello Inki, On 03/10/2015 03:50 AM, Inki Dae wrote: > On 2015년 03월 07일 00:07, Javier Martinez Canillas wrote: >>>> >>>> Another thing that may be useful to detect these issues early is to have >>>> exynos-drm-next be pulled by linux-next since otherwise t

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-03-10 Thread Javier Martinez Canillas
Hello Kukjin, On 02/05/2015 03:45 PM, Javier Martinez Canillas wrote: > Hello Andrzej, > > Thanks a lot for finally finding what was causing the HDMI issue. > > On 02/05/2015 01:35 PM, Andrzej Hajda wrote: >> Hi, >> >> Exynos chipsets since 542x have asynchro

[PATCH 1/8] mfd: cros ec: Remove parent field

2015-03-12 Thread Javier Martinez Canillas
From: Gwendal Grignou parent and dev were pointing to the same device structure. parent is unused, removed. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Barber Tested-by: Stephen Barber Reviewed-by: Puthikorn Voravootivat Signed-off-by: Javier Martinez Canillas --- drivers/mfd

[PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support

2015-03-12 Thread Javier Martinez Canillas
eld mfd: cros-ec: Support multiple EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Sanity check in and out sizes platform/chrome: cros_ec_lpc - Use existing function to check EC result Stephen Barber (3): mfd: cros_ec: rev cros_ec_commands.h mfd: cros_ec: add proto v3 skele

[PATCH 2/8] mfd: cros_ec: Sanity check in and out sizes

2015-03-12 Thread Javier Martinez Canillas
d-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index c4aecc6f8373..07c53c27c82a 100644 --- a/drivers/mfd/cros_ec.c +++ b/drivers/mfd/cros_ec.c @@ -70,6 +70,20 @

[PATCH 6/8] mfd: cros_ec: rev cros_ec_commands.h

2015-03-12 Thread Javier Martinez Canillas
From: Stephen Barber Update cros_ec_commands.h to the latest version in the EC firmware sources and add power domain and passthru commands. Also, update lightbar to use new command names. Signed-off-by: Stephen Barber Reviewed-by: Randall Spangler Signed-off-by: Javier Martinez Canillas

[PATCH 5/8] mfd: cros-ec: Support multiple EC in a system

2015-03-12 Thread Javier Martinez Canillas
Torokhov Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 7 ++- drivers/platform/chrome/cros_ec_dev.c | 4 ++-- include/linux/mfd/cros_ec.h | 2 ++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd

[PATCH 8/8] mfd: cros_ec: add bus-specific proto v3 code

2015-03-12 Thread Javier Martinez Canillas
From: Stephen Barber Add proto v3 support to the SPI, I2C, and LPC. Signed-off-by: Stephen Barber Reviewed-by: Puthikorn Voravootivat Reviewed-by: Gwendal Grignou Tested-by: Puthikorn Voravootivat Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec_i2c.c | 166

[PATCH 4/8] mfd: cros_ec: Instantiate sub-devices from device tree

2015-03-12 Thread Javier Martinez Canillas
From: Todd Broch If the EC device tree node has sub-nodes, try to instantiate them as MFD sub-devices. We can configure the EC features provided by the board. Signed-off-by: Todd Broch Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 22 +++--- 1 file

[PATCH 7/8] mfd: cros_ec: add proto v3 skeleton

2015-03-12 Thread Javier Martinez Canillas
. Signed-off-by: Stephen Barber Reviewed-by: Puthikorn Voravootivat Reviewed-by: Gwendal Grignou Tested-by: Puthikorn Voravootivat Signed-off-by: Javier Martinez Canillas --- drivers/mfd/cros_ec.c | 338 +- drivers/mfd/cros_ec_i2c.c

[PATCH 3/8] platform/chrome: cros_ec_lpc - Use existing function to check EC result

2015-03-12 Thread Javier Martinez Canillas
ff-by: Javier Martinez Canillas --- drivers/platform/chrome/cros_ec_lpc.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index 860310513cf0..3a675817c95d 100644 --- a/drivers/pl

[PATCH 1/1] serial: samsung: Clear operation mode on UART shutdown

2015-03-13 Thread Javier Martinez Canillas
ng: remove redundant interrupt enabling") Signed-off-by: Javier Martinez Canillas --- I noticed this issue on an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos 5800 Peach Pi Chromebooks. This patch fixes the issue on all of them. The offending commit landed in v4.0-rc1 so this fix is -r

[PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250

2015-03-14 Thread Javier Martinez Canillas
omain. This patch fixes video display on an Exynos5250 Snow Chromebook. Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") Signed-off-by: Javier Martinez Canillas --- Hello Andrzej and Marek, I need this patch to have display working on an Snow Chromebook with

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-14 Thread Javier Martinez Canillas
Hello Kukjin, On Fri, Mar 6, 2015 at 10:43 AM, Kukjin Kim wrote: >> >> Yes, the problem is the Exynos DRM driver which has a lot of issues. >> It's broken if CONFIG_DRM_EXYNOS_IOMMU is enabled which defaults to >> yes after commit 8dcc14f82f06 ("drm/exynos: IOMMU support should not >> be selectab

Re: [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation

2015-03-16 Thread Javier Martinez Canillas
Hello Andreas, On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber wrote: > The UART status properties are indented one level too deep, and we want > to derive a device tree for the ODROID-XU. Fix this before it propagates. > > Signed-off-by: Andreas Färber > --- Reviewed-by:

Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree

2015-03-16 Thread Javier Martinez Canillas
,dw-mshc-ddr-timing = <1 2>; > + bus-width = <8>; > +}; > + > +&mmc_2 { > + status = "okay"; > + num-slots = <1>; > + cap-sd-highspeed; > + card-detect-delay = <200>; > + samsung,dw-mshc-ciu-div = <3>

Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu

2015-03-16 Thread Javier Martinez Canillas
gt; + red { > + label = "red:activity"; > + gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + linux,default-trigger = "mmc1"; > +

[PATCH 0/3] ARM: dts: Define stdout-patch for Exynos Chromebooks

2015-03-16 Thread Javier Martinez Canillas
composed of the following patches: Javier Martinez Canillas (3): ARM: dts: Define stdout-path property for Peach boards ARM: dts: Define stdout-path property for Snow board ARM: dts: Define stdout-path property for Spring board arch/arm/boot/dts/exynos5250-snow.dts | 1 + arch/arm/boot

[PATCH 2/3] ARM: dts: Define stdout-path property for Snow board

2015-03-16 Thread Javier Martinez Canillas
users that don't have a serial console on this board might be using it to have the boot log shown in the display. This will have more precedence than the stdout-path but it's fine since is only used when CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is enabled. Signed-off-by: Javier Martine

[PATCH 1/3] ARM: dts: Define stdout-path property for Peach boards

2015-03-16 Thread Javier Martinez Canillas
The kernel can use as the default console a serial port if is defined as stdout device in the Device Tree. This allows a board to be booted without the need of having a console parameter in the kernel command line. Signed-off-by: Javier Martinez Canillas --- arch/arm/boot/dts/exynos5420-peach

[PATCH 3/3] ARM: dts: Define stdout-path property for Spring board

2015-03-16 Thread Javier Martinez Canillas
users that don't have a serial console on this board might be using it to have the boot log shown in the display. This will have more precedence than the stdout-path but it's fine since is only used when CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is enabled. Signed-off-by: Javier Martine

Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree

2015-03-16 Thread Javier Martinez Canillas
Hello Andreas, On Mon, Mar 16, 2015 at 11:27 AM, Andreas Färber wrote: > Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas: >> >> I think this should be defined in exynos5410.dtsi instead since is an >> IP block in the SoC and referenced in the .dts using a label t

Re: [PATCH 3/3] ARM: dts: Define stdout-path property for Spring board

2015-03-16 Thread Javier Martinez Canillas
Hello Andreas, >> index f02775487cd4..b9ec763a5602 100644 >> --- a/arch/arm/boot/dts/exynos5250-spring.dts >> +++ b/arch/arm/boot/dts/exynos5250-spring.dts >> @@ -25,6 +25,7 @@ >> >> chosen { >> bootargs = "console=tty1"; >> + stdout-path = "serial3:115200n8"; > > I

Re: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250

2015-03-16 Thread Javier Martinez Canillas
Hello, On 03/16/2015 01:15 PM, Andreas Färber wrote: > Am 14.03.2015 um 09:11 schrieb Javier Martinez Canillas: >> By making the DP controller a consumer of DISP1, the PD is powered >> off when the exynos-dp probe is deferred and powered on again when >> the exynos

Re: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250

2015-03-16 Thread Javier Martinez Canillas
Hello, On 03/16/2015 03:16 PM, Javier Martinez Canillas wrote: >> >> Tested-by: Andreas Färber >> >> This fixes the display on the Spring Chromebook as well! >> > > Thanks for testing Andreas but this patch seems to only solve a symptom > rather th

<    1   2   3   4   5   6   7   8   9   10   >