[PATCH v2 01/10] mfd: max77686: Convert to use regmap_irq

2014-06-16 Thread Javier Martinez Canillas
By using the generic IRQ support in the Register map API, it is possible to get rid of max77686-irq.c and simplify the code. Suggested-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas --- drivers/mfd/Kconfig | 1 + drivers/mfd/Makefile | 2

[PATCH v2 09/10] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

2014-06-16 Thread Javier Martinez Canillas
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms. This patch adds support for the RTC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- drivers/mfd/max77802.c | 1 + drivers/rtc/Kconfig| 10

[PATCH v2 10/10] ARM: dts: Add max77802 device node for exynos5420-peach-pit

2014-06-16 Thread Javier Martinez Canillas
-by: Javier Martinez Canillas --- Changes since v1: - Use "regulators" for child node instead of "voltage-regulators" to be consistent with other PMIC. Suggested by Mark Brown. - Use regulators node names instead of the deprecated "regulator-compatible" pro

[PATCH v2 02/10] clk: max77686: add DT include for MAX77686 PMIC clock

2014-06-16 Thread Javier Martinez Canillas
This patch adds a dt-binding include for Maxim 77686 PMIC clock IDs that can be to be shared between the clk-max77686 clock driver and DeviceTree source files. Signed-off-by: Javier Martinez Canillas --- drivers/clk/clk-max77686.c | 7 +-- include/dt-bindings/clock/maxim

[PATCH v2 03/10] Documentation: dt: improve Maxim 77686 PMIC clocks binding

2014-06-16 Thread Javier Martinez Canillas
ks outputs. Also, explain that the clocks identifiers are defined in a header file that can be included by Device Tree source with client nodes to avoid using magic numbers. Signed-off-by: Javier Martinez Canillas --- .../devicetree/bindings/clock/maxim,max77686.txt | 15 ++---

[PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-16 Thread Javier Martinez Canillas
, clocks outputs and the RTC. This patch adds the core support for MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Convert max77{686,802} to regmap irq API and get rid of max77{686,802

[PATCH v2 05/10] clk: max77686: convert to the generic max clock driver

2014-06-16 Thread Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can be converted to use the generic Maxim clock driver. Also, while being there use module_platform_driver() helper macro to eliminate more boilerplate code. Signed-off-by: Javier Martinez Canillas --- drivers/clk/Kconfig| 1

[PATCH v2 04/10] clk: Add generic driver for Maxim PMIC clocks

2014-06-16 Thread Javier Martinez Canillas
Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these chips are duplicating code and are simpler enough that can be converted to use a generic driver to consolidate code and avoid duplication. Signed-off-by: Javier Martinez

[PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-16 Thread Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes

[PATCH v2 08/10] clk: Add driver for Maxim 77802 PMIC clocks

2014-06-16 Thread Javier Martinez Canillas
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with Low Jitter Mode. This patch adds support for these two clocks. Signed-off-by: Javier Martinez Canillas --- Changes since v1: - Use module_platform_driver() instead of having init/exit functions. Suggested by Mark Brown. - Use

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-17 Thread Javier Martinez Canillas
Hello Mark, Thanks a lot for your feedback. On 06/16/2014 09:25 PM, Mark Brown wrote: > On Mon, Jun 16, 2014 at 08:02:35PM +0200, Javier Martinez Canillas wrote: > >> --- a/drivers/mfd/max77802.c >> +++ b/drivers/mfd/max77802.c >> @@ -37,6 +37,7 @@ >> #include

Re: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-17 Thread Javier Martinez Canillas
Hello Mark, On 06/16/2014 09:27 PM, Mark Brown wrote: > On Mon, Jun 16, 2014 at 08:02:34PM +0200, Javier Martinez Canillas wrote: > >> +- max77802,pmic-buck-dvs-gpios: The DVS GPIOs. We'll try to set these GPIOs >> + to match pmic-buck-default-dvs-idx at probe time

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-17 Thread Javier Martinez Canillas
Hello Mark, On 06/17/2014 04:12 PM, Mark Brown wrote: > On Tue, Jun 17, 2014 at 12:49:56PM +0200, Javier Martinez Canillas wrote: >> On 06/16/2014 09:25 PM, Mark Brown wrote: > >> >> + config.dev = &pdev->dev; > >> > Are you sure this s

Re: [PATCH 2/2] ARM: dts: Add cros_ec to exynos5420-peach-pit and exynos5800-peach-pi

2014-06-17 Thread Javier Martinez Canillas
ee that cros-ec-spi driver is probed and also the keyboard is working on my Peach pit when testing with: $ evtest /dev/input/event0 Tested-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 01/10] mfd: max77686: Convert to use regmap_irq

2014-06-18 Thread Javier Martinez Canillas
Hello Doug, On 06/17/2014 10:57 PM, Doug Anderson wrote: > Javier, > > On Mon, Jun 16, 2014 at 11:02 AM, Javier Martinez Canillas > wrote: >> @@ -127,15 +175,48 @@ static int max77686_i2c_probe(struct i2c_client *i2c, >> } >> i2c_set_clie

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-18 Thread Javier Martinez Canillas
ver added by Simon >> Glass to the Chrome OS kernel 3.8 tree. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> Changes since v1: >> - Remove unneeded check if num_regulators != MAX77802_MAX_REGULATORS. >> - Fix .set_suspend_mode handler

Re: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-18 Thread Javier Martinez Canillas
Hello Lee, On 06/18/2014 10:32 AM, Lee Jones wrote: >> >> +config MFD_MAX77802 >> >> + tristate "Maxim Integrated MAX77802 PMIC Support" >> >> + depends on I2C=y >> >> + select MFD_CORE >> >> + select REGMAP_I2C >> >> + select REGMAP_IRQ >> >> + select IRQ_DOMAIN >> >> + help >> >> + Say yes her

[PATCH v3 00/14] Add Maxim 77802 PMIC support

2014-06-19 Thread Javier Martinez Canillas
interface. The patch-set has been tested on both Daisy/Snow (max77686) and Peach pit (max77802) Chromebooks and it's composed of the following patches: Doug Anderson (1): mfd: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas (13): mfd: max77686: Convert to use regma

[PATCH v3 14/14] ARM: dts: Add max77802 device node for exynos5420-peach-pit

2014-06-19 Thread Javier Martinez Canillas
-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: - Use "regulators" for child node instead of "voltage-regulators" to be consistent with other PMIC. Suggested by Mark Brown. - Use regulators node names instead of the deprecated "regulato

[PATCH v3 13/14] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

2014-06-19 Thread Javier Martinez Canillas
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms. This patch adds support for the RTC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- drivers/rtc/Kconfig| 10 + drivers/rtc/Makefile | 1

[PATCH v3 12/14] clk: max77802: Add DT binding documentation

2014-06-19 Thread Javier Martinez Canillas
Add Device Tree binding documentation for the clocks outputs in the Maxim 77802 Power Management IC. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Split the DT binding documentation in a separate patch. .../devicetree/bindings/clock/maxim,max77802.txt | 42

[PATCH v3 11/14] clk: Add driver for Maxim 77802 PMIC clocks

2014-06-19 Thread Javier Martinez Canillas
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with Low Jitter Mode. This patch adds support for these two clocks. Signed-off-by: Javier Martinez Canillas --- Changes since v2: None Changes since v1: - Use module_platform_driver() instead of having init/exit functions

[PATCH v3 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-19 Thread Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes

[PATCH v3 06/14] clk: max77686: Convert to the generic max clock driver

2014-06-19 Thread Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can be converted to use the generic Maxim clock driver. Also, while being there use module_platform_driver() helper macro to eliminate more boilerplate code. Signed-off-by: Javier Martinez Canillas --- drivers/clk/Kconfig| 1

[PATCH v3 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-19 Thread Javier Martinez Canillas
, clocks outputs and the RTC. This patch adds the core support for MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Split the DT binding docs in a separate patch and improve the

[PATCH v3 08/14] mfd: max77802: Add DT binding documentation

2014-06-19 Thread Javier Martinez Canillas
Add Device Tree binding documentation for Maxim 77802 PMIC. Signed-off-by: Javier Martinez Canillas --- Changes since v2: - Explain better the Dynamic Voltage Scaling (DVS) support in some Buck regulators and the max77802,pmic-buck-{dvs,selb}-gpios properties. Suggested by Mark Brown

[PATCH v3 09/14] regmap: Add regmap_reg_copy function

2014-06-19 Thread Javier Martinez Canillas
holding the regmap lock. Signed-off-by: Javier Martinez Canillas --- drivers/base/regmap/regmap.c | 34 ++ include/linux/regmap.h | 9 + 2 files changed, 43 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index

[PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-19 Thread Javier Martinez Canillas
ks outputs. Also, explain that the clocks identifiers are defined in a header file that can be included by Device Tree source with client nodes to avoid using magic numbers. Signed-off-by: Javier Martinez Canillas --- .../devicetree/bindings/clock/maxim,max77686.txt | 15 ++---

[PATCH v3 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-19 Thread Javier Martinez Canillas
Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these chips are duplicating code and are simpler enough that can be converted to use a generic driver to consolidate code and avoid duplication. Signed-off-by: Javier Martinez

[PATCH v3 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-19 Thread Javier Martinez Canillas
From: Doug Anderson The max77686 includes an RTC that keeps power during suspend. It's convenient to be able to use it as a wakeup source. Signed-off-by: Doug Anderson --- drivers/rtc/rtc-max77686.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/rtc/

[PATCH v3 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-19 Thread Javier Martinez Canillas
This patch adds a dt-binding include for Maxim 77686 PMIC clock IDs that can be to be shared between the clk-max77686 clock driver and DeviceTree source files. Signed-off-by: Javier Martinez Canillas --- drivers/clk/clk-max77686.c | 7 +-- include/dt-bindings/clock/maxim

[PATCH v3 01/14] mfd: max77686: Convert to use regmap_irq

2014-06-19 Thread Javier Martinez Canillas
By using the generic IRQ support in the Register map API, it is possible to get rid max77686-irq.c and simplify the code. Suggested-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones Reviewed-by: Doug Anderson Tested-by: Doug Anderson --- Changes since v2

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-23 Thread Javier Martinez Canillas
Hello Mark, On 06/21/2014 10:40 PM, Mark Brown wrote: > On Tue, Jun 17, 2014 at 06:05:29PM +0200, Javier Martinez Canillas wrote: >> On 06/17/2014 04:12 PM, Mark Brown wrote: > >> >> I just looked at regulator_register() and saw that it does >> >> rdev->

Re: [PATCH V4 04/10] drm/panel: Add driver for lvds/edp based panels

2014-06-23 Thread Javier Martinez Canillas
Hello Ajay, Not an extensive review since I'm not familiar with the graphics stack but a few things I noticed are commented below. On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar wrote: > This patch adds a simple driver to handle all the LCD and LED > powerup/down routines needed to support eDP/LVDS

Re: [PATCH V4 09/10] drm/bridge: Add ps8622/ps8625 bridge driver

2014-06-23 Thread Javier Martinez Canillas
Hello Ajay, On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar wrote: > From: Vincent Palatin > > This patch adds drm_bridge driver for parade DisplayPort > to LVDS bridge chip. > > Signed-off-by: Vincent Palatin > Signed-off-by: Andrew Bresticker > Signed-off-by: Sean Paul > Signed-off-by: Rahul Sh

Re: [PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-23 Thread Javier Martinez Canillas
a board. > Otherwise, can anyone give me tested-by? and I'd happy to give me > reviewed-by so that I can pick this patch series up. > > Thanks, > Inki Dae > I've also tested this series on an Exynos5420 Peach pit board and LVDS display was working for me. Test

Re: [RFC 4/4] ARM: dts: exynos5250: Add Spring device tree

2014-06-24 Thread Javier Martinez Canillas
Hello Doug, On 06/24/2014 06:05 AM, Doug Anderson wrote: > Andreas, > > On Mon, Jun 23, 2014 at 3:46 PM, Andreas Färber wrote: >> Hi Doug, >> >> Am 23.06.2014 21:47, schrieb Doug Anderson: >>> Thanks for posting! A first pass on this is below... >> >> Thanks a lot for your quick review! My firs

Re: [PATCH v2] ARM: dts: Add cros_ec to exynos5420-peach-pit and exynos5800-peach-pi

2014-06-24 Thread Javier Martinez Canillas
info from >>> DT node) to work properly and match the documented bindings. See >>> <https://patchwork.kernel.org/patch/4346701/> and >>> <https://patchwork.kernel.org/patch/4346711/> >>> >>> Signed-off-by: Doug Anderson >>> Tes

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-24 Thread Javier Martinez Canillas
Hello Mark, On 06/23/2014 11:47 AM, Mark Brown wrote: > On Mon, Jun 23, 2014 at 11:28:25AM +0200, Javier Martinez Canillas wrote: >> On 06/21/2014 10:40 PM, Mark Brown wrote: > >> > That's not really relevant here - I'm asking if the regulators get their >> &

Re: [PATCH 4/4] ARM: DTS: Add NTC thermistor nodes as child nodes to ADC

2014-06-25 Thread Javier Martinez Canillas
Hello Naveen, On Wed, Jun 25, 2014 at 7:04 AM, Naveen Krishna Ch wrote: > Doug, > > On 25 June 2014 03:24, Doug Anderson wrote: >> Naveen, >> >> On Tue, Jun 24, 2014 at 5:19 AM, Naveen Krishna Chatradhi >> wrote: >>> Exynos5420 based Peach PIT and Exynos5800 based PI boards have >>> 4 NTC therm

Re: [PATCH v3 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-25 Thread Javier Martinez Canillas
Hello Krzysztof, On 06/25/2014 12:05 PM, Krzysztof Kozlowski wrote: > On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote: >> From: Doug Anderson >> >> The max77686 includes an RTC that keeps power during suspend. It's >> convenient to be a

Re: [PATCH 2/4 v2] hwmon: ntc_thermistor: Use the manufacturer name properly

2014-06-25 Thread Javier Martinez Canillas
| 20 > ++-- > Documentation/hwmon/ntc_thermistor |8 > drivers/hwmon/Kconfig |5 +++-- > drivers/hwmon/ntc_thermistor.c | 14 +- > 5 files changed, 35 insertions(+), 14 dele

Re: [PATCH 4/4 v2] ARM: DTS: Add NTC thermistor nodes to Exynos5420 based Peach_PIT

2014-06-25 Thread Javier Martinez Canillas
quot;; > + pullup-uv = <180>; > + pullup-ohm = <47000>; > + pulldown-ohm = <0>; > + io-channels = <&adc 5>; > + }; > + ncp15wb473@6 { > + compatible = "murata,n

Re: [PATCH v3 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-25 Thread Javier Martinez Canillas
Hello Krzysztof, On 06/25/2014 04:19 PM, Krzysztof Kozlowski wrote: > On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote: >> Maxim Integrated Power Management ICs are very similar with >> regard to their clock outputs. Most of the clock drivers for >> these

Re: [PATCH v2] i2c: s3c2410: resume the I2C controller earlier

2014-06-25 Thread Javier Martinez Canillas
gt; .suspend_noirq = s3c24xx_i2c_suspend_noirq, > - .resume = s3c24xx_i2c_resume, > + .resume_noirq = s3c24xx_i2c_resume_noirq, > + .freeze_noirq = s3c24xx_i2c_suspend_noirq, > + .thaw_noirq = s3c24xx_i2c_resume_noirq, > + .poweroff_noirq = s3c24xx_i2c_suspend_noirq, > +

Re: [PATCH v3 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-25 Thread Javier Martinez Canillas
On 06/25/2014 07:24 PM, Doug Anderson wrote: > Hi, > > On Wed, Jun 25, 2014 at 3:29 AM, Javier Martinez Canillas > wrote: >> Yes, the original Chrome OS 3.8 max77xxx also called the irq worker thread to >> ack the interrupt. >> >> So the real problem is tha

Re: [PATCH v3 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-25 Thread Javier Martinez Canillas
Hello Doug, Thanks a lot for your feedback. On 06/25/2014 08:06 PM, Doug Anderson wrote: > Javier, > > On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas > wrote: >> @@ -33,6 +38,6 @@ Example: Clock consumer node >> foo@0 { >>

[PATCH v4 00/14] Add Maxim 77802 PMIC support

2014-06-25 Thread Javier Martinez Canillas
Doug Anderson (1): mfd: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas (13): mfd: max77686: Convert to use regmap_irq clk: max77686: Add DT include for MAX77686 PMIC clock clk: max77686: Improve Maxim 77686 PMIC clocks binding clk: Add generic driver for Ma

[PATCH v4 11/14] clk: Add driver for Maxim 77802 PMIC clocks

2014-06-25 Thread Javier Martinez Canillas
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with Low Jitter Mode. This patch adds support for these two clocks. Signed-off-by: Javier Martinez Canillas --- Changes since v3: None Changes since v2: None Changes since v1: - Use module_platform_driver() instead of having init

[PATCH v4 13/14] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

2014-06-25 Thread Javier Martinez Canillas
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms. This patch adds support for the RTC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes since v3: None drivers/rtc/Kconfig| 10 + drivers/rtc

[PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-25 Thread Javier Martinez Canillas
Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these chips are duplicating code and are simpler enough that can be converted to use a generic driver to consolidate code and avoid duplication. Signed-off-by: Javier Martinez

[PATCH v4 12/14] clk: max77802: Add DT binding documentation

2014-06-25 Thread Javier Martinez Canillas
Add Device Tree binding documentation for the clocks outputs in the Maxim 77802 Power Management IC. Signed-off-by: Javier Martinez Canillas --- Changes since v3: - Don't use the same clock driver name in clock-names since it's a consumer concept and most probably will be

[PATCH v4 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

2014-06-25 Thread Javier Martinez Canillas
. Signed-off-by: Javier Martinez Canillas --- Changes since v3: - Add support for Exynos5800 based Peach pi board. Suggested by Doug Anderson. - Model the actual regulators relationship instead of a simplistic model. Suggested by Mark Brown. Changes since v2: None Changes since v1: - Use

[PATCH v4 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-25 Thread Javier Martinez Canillas
, clocks outputs and the RTC. This patch adds the core support for MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes since v3: - Remove unnecessary OOM error message since the mm subsystem already logs

[PATCH v4 06/14] clk: max77686: Convert to the generic max clock driver

2014-06-25 Thread Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can be converted to use the generic Maxim clock driver. Also, while being there use module_platform_driver() helper macro to eliminate more boilerplate code. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski

[PATCH v4 09/14] regmap: Add regmap_reg_copy function

2014-06-25 Thread Javier Martinez Canillas
the regmap lock. Signed-off-by: Javier Martinez Canillas --- Changes since v3: None drivers/base/regmap/regmap.c | 34 ++ include/linux/regmap.h | 9 + 2 files changed, 43 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base

[PATCH v4 08/14] mfd: max77802: Add DT binding documentation

2014-06-25 Thread Javier Martinez Canillas
Add Device Tree binding documentation for Maxim 77802 PMIC. Signed-off-by: Javier Martinez Canillas --- Changes since v3: None Changes since v2: - Explain better the Dynamic Voltage Scaling (DVS) support in some Buck regulators and the max77802,pmic-buck-{dvs,selb}-gpios properties

[PATCH v4 01/14] mfd: max77686: Convert to use regmap_irq

2014-06-25 Thread Javier Martinez Canillas
By using the generic IRQ support in the Register map API, it is possible to get rid max77686-irq.c and simplify the code. Suggested-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones Reviewed-by: Doug Anderson Tested-by: Doug Anderson --- Changes since v3

[PATCH v4 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-25 Thread Javier Martinez Canillas
This patch adds a dt-binding include for Maxim 77686 PMIC clock IDs that can be to be shared between the clk-max77686 clock driver and DeviceTree source files. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- Changes since v3: None drivers/clk/clk-max77686.c

[PATCH v4 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-25 Thread Javier Martinez Canillas
ks outputs. Also, explain that the clocks identifiers are defined in a header file that can be included by Device Tree source with client nodes to avoid using magic numbers. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- Changes since v3: - Don't change clock-na

[PATCH v4 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-25 Thread Javier Martinez Canillas
up before the max77686 wakeup runs. Signed-off-by: Doug Anderson Reviewed-by: Javier Martinez Canillas --- Changes since v3: - Keep the note that this patch needs another change due wakeup ordering problems. drivers/rtc/rtc-max77686.c | 28 1 file changed, 28

[PATCH v4 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-25 Thread Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes

Re: [PATCH] ARM: dts: add hdmi regulators for exynos5420 based peach-pit board

2014-06-26 Thread Javier Martinez Canillas
ddc = <&i2c_2>; > + > + hdmi-en-supply = <&tps65090_fet7>; > + vdd-supply = <&ldo8_reg>; > + vdd_osc-supply = <&ldo10_reg>; > + vdd_pll-supply = <&ldo8_reg>; > }; > > &usbdrd_phy0 { > -- &g

Re: [PATCH] ARM: dts: add hdmi regulators for exynos5800 based peach-pi board

2014-06-26 Thread Javier Martinez Canillas
u had a line break between the ddc and the supplies on your patch for Peach pit, can you please add it here as well? I think that is more readable and also we may later factor out common DTS fragments on these two boards in .dtsi include files so is better to keep the diff as small as possible.

Re: [PATCH v4 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-26 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks a lot for your feedback. On 06/26/2014 11:31 AM, Krzysztof Kozlowski wrote: > Hi, > > Just a few nit-picks below but overall everything looks fine: > > Reviewed-by: Krzysztof Kozlowski > > >> + >> +static int max77802_i2c_probe(struct i2c_client *i2c, >> +

Re: [PATCH v4 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-26 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks a lot for your feedback. On 06/26/2014 12:08 PM, Krzysztof Kozlowski wrote: > On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote: >> The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout >> (LDO) regulators. This patch adds suppor

Re: [PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-26 Thread Javier Martinez Canillas
Hello Yadwinder, Thanks a lot for your feedback. On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote: > Hi Javier, > > Sorry for jumping in late, but just one concern mentioned inline. > > [ .. ] > >> + >> +static unsigned long max_gen_recalc_rate(struct clk_hw *hw, >> +

Re: [PATCH v4 00/14] Add Maxim 77802 PMIC support

2014-06-26 Thread Javier Martinez Canillas
Hello Naveen, Thanks a lot for testing! On 06/26/2014 03:32 PM, Naveen Krishna Ch wrote: > Hello Javier, > > On 26 June 2014 00:33, Javier Martinez Canillas > wrote: >> MAX77802 is a PMIC that contains 10 high efficiency Buck regulators, >> 32 Low-dropout (LDO) regula

Re: [PATCH 0/3] ARM: DTS: create common dtsi for Peach pit and pi boards

2014-06-26 Thread Javier Martinez Canillas
Hello Naveen, On Thu, Jun 26, 2014 at 2:19 PM, Naveen Krishna Chatradhi wrote: > This patchset does the following > 1. Create a common dtsi file cros-exynos-peach.dtsi for >exynos5420-peach-pit.dts and exynos5800-peach-pi.dts There was some previous discussion in this list about what's the b

Re: [PATCH v4 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-26 Thread Javier Martinez Canillas
Hello Doug, On 06/26/2014 06:12 PM, Doug Anderson wrote: > Javier, > > On Thu, Jun 26, 2014 at 4:13 AM, Javier Martinez Canillas > wrote: >>>> + >>>> +#ifdef CONFIG_PM_SLEEP >>>> +static int max77802_suspend(struct device *dev) >>>> +{

Re: [PATCH v4 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-26 Thread Javier Martinez Canillas
Hello Doug, On 06/26/2014 06:29 PM, Doug Anderson wrote: > Javier, > > On Thu, Jun 26, 2014 at 9:18 AM, Javier Martinez Canillas > wrote: >> Hello Doug, >> >> On 06/26/2014 06:12 PM, Doug Anderson wrote: >>> Javier, >>> >>> On Thu, Jun

[PATCH v5 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-26 Thread Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas Tested-by: Naveen

[PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

2014-06-26 Thread Javier Martinez Canillas
. Signed-off-by: Javier Martinez Canillas Tested-by: Naveen Krishna Chatradhi --- Changes since v4: None Changes since v3: - Add support for Exynos5800 based Peach pi board. Suggested by Doug Anderson. - Model the actual regulators relationship instead of a simplistic model. Suggested by Mark

[PATCH v5 12/14] clk: max77802: Add DT binding documentation

2014-06-26 Thread Javier Martinez Canillas
Add Device Tree binding documentation for the clocks outputs in the Maxim 77802 Power Management IC. Signed-off-by: Javier Martinez Canillas --- Changes since v4: None Changes since v3: - Don't use the same clock driver name in clock-names since it's a consumer concept and mos

[PATCH v5 11/14] clk: Add driver for Maxim 77802 PMIC clocks

2014-06-26 Thread Javier Martinez Canillas
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with Low Jitter Mode. This patch adds support for these two clocks. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- Changes since v4: None Changes since v3: None Changes since v2: None Changes since v1

[PATCH v5 13/14] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock

2014-06-26 Thread Javier Martinez Canillas
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms. This patch adds support for the RTC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas --- Changes since v4: None Changes since v3: None drivers/rtc/Kconfig

[PATCH v5 09/14] regmap: Add regmap_reg_copy function

2014-06-26 Thread Javier Martinez Canillas
the regmap lock. Signed-off-by: Javier Martinez Canillas --- Changes since v4: None Changes since v3: None drivers/base/regmap/regmap.c | 34 ++ include/linux/regmap.h | 9 + 2 files changed, 43 insertions(+) diff --git a/drivers/base/regmap

[PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-26 Thread Javier Martinez Canillas
This patch adds a dt-binding include for Maxim 77686 PMIC clock IDs that can be to be shared between the clk-max77686 clock driver and DeviceTree source files. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- Changes since v4: None Changes since v3: None drivers

[PATCH v5 01/14] mfd: max77686: Convert to use regmap_irq

2014-06-26 Thread Javier Martinez Canillas
By using the generic IRQ support in the Register map API, it is possible to get rid max77686-irq.c and simplify the code. Suggested-by: Krzysztof Kozlowski Signed-off-by: Javier Martinez Canillas Acked-by: Lee Jones Reviewed-by: Doug Anderson Tested-by: Doug Anderson --- Changes since v4

[PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-26 Thread Javier Martinez Canillas
Maxim Integrated Power Management ICs are very similar with regard to their clock outputs. Most of the clock drivers for these chips are duplicating code and are simpler enough that can be converted to use a generic driver to consolidate code and avoid duplication. Signed-off-by: Javier Martinez

[PATCH v5 00/14] Add Maxim 77802 PMIC support

2014-06-26 Thread Javier Martinez Canillas
oug Anderson (1): mfd: max77686: Allow the max77686 rtc to wakeup the system Javier Martinez Canillas (13): mfd: max77686: Convert to use regmap_irq clk: max77686: Add DT include for MAX77686 PMIC clock clk: max77686: Improve Maxim 77686 PMIC clocks binding clk: Add generic driver for Ma

[PATCH v5 08/14] mfd: max77802: Add DT binding documentation

2014-06-26 Thread Javier Martinez Canillas
Add Device Tree binding documentation for Maxim 77802 PMIC. Signed-off-by: Javier Martinez Canillas --- Changes since v4: None Changes since v3: None Changes since v2: - Explain better the Dynamic Voltage Scaling (DVS) support in some Buck regulators and the max77802,pmic-buck-{dvs,selb

[PATCH v5 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-06-26 Thread Javier Martinez Canillas
, clocks outputs and the RTC. This patch adds the core support for MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Tested-by: Naveen Krishna Chatradhi --- Changes since v4: - Use

[PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-06-26 Thread Javier Martinez Canillas
ks outputs. Also, explain that the clocks identifiers are defined in a header file that can be included by Device Tree source with client nodes to avoid using magic numbers. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Reviewed-by: Doug Anderson --- Changes sinc

[PATCH v5 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-26 Thread Javier Martinez Canillas
up before the max77686 wakeup runs. Signed-off-by: Doug Anderson Reviewed-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski --- Changes since v4: None Changes since v3: - Keep the note that this patch needs another change due wakeup ordering problems. drivers/rtc/rtc-max77

[PATCH v5 06/14] clk: max77686: Convert to the generic max clock driver

2014-06-26 Thread Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can be converted to use the generic Maxim clock driver. Also, while being there use module_platform_driver() helper macro to eliminate more boilerplate code. Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski

Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-27 Thread Javier Martinez Canillas
Hello Andreas, On 06/27/2014 09:48 AM, Andreas Färber wrote: > Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >> This patch adds a dt-binding include for Maxim 77686 >> PMIC clock IDs that can be to be shared between the > > "can be shared"? > As it s

Re: [PATCH v5 12/14] clk: max77802: Add DT binding documentation

2014-06-27 Thread Javier Martinez Canillas
Hello Andres, Thanks a lot for your feedback. On 06/27/2014 09:52 AM, Andreas Färber wrote: > Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >> Add Device Tree binding documentation for the clocks >> outputs in the Maxim 77802 Power Management IC. >> >> Sig

Re: [PATCH v5 08/14] mfd: max77802: Add DT binding documentation

2014-06-27 Thread Javier Martinez Canillas
Hello Andreas, Thanks a lot for your feedback. On 06/27/2014 10:06 AM, Andreas Färber wrote: > Am 26.06.2014 20:15, schrieb Javier Martinez Canillas: >> Add Device Tree binding documentation for Maxim 77802 PMIC. >> >> Signed-off-by: Javier Martinez Canillas >>

Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock

2014-06-27 Thread Javier Martinez Canillas
Hello Andreas, On 06/27/2014 10:26 AM, Andreas Färber wrote: > Hi Javier, > > Am 27.06.2014 09:53, schrieb Javier Martinez Canillas: >> Hello Andreas, >> >> On 06/27/2014 09:48 AM, Andreas Färber wrote: >>> Am 26.06.2014 20:15, schrieb Javier Martinez Canilla

Re: [PATCH v5 02/14] mfd: max77686: Allow the max77686 rtc to wakeup the system

2014-06-27 Thread Javier Martinez Canillas
Hello Lee, On 06/27/2014 11:21 AM, Lee Jones wrote: > On Thu, 26 Jun 2014, Javier Martinez Canillas wrote: > >> From: Doug Anderson >> >> The max77686 includes an RTC that keeps power during suspend. It's >> convenient to be able to use it as a wakeup

Re: [PATCH v5 10/14] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-27 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 06/27/2014 11:26 AM, Lee Jones wrote: > On Thu, 26 Jun 2014, Javier Martinez Canillas wrote: >> The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout >> (LDO) regulators. This patch adds support for all these regulators

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-30 Thread Javier Martinez Canillas
Hello Yadwinder, Thanks a lot for your feedback. On 06/30/2014 06:01 AM, Yadwinder Singh Brar wrote: > Hi Javier, > > On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas > wrote: >> Maxim Integrated Power Management ICs are very similar with >> regard to their cl

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-06-30 Thread Javier Martinez Canillas
Hello Russell, Thanks a lot for your suggestion. On 06/30/2014 01:35 PM, Russell King - ARM Linux wrote: > On Mon, Jun 30, 2014 at 12:58:57PM +0200, Javier Martinez Canillas wrote: >> >> + if (!max_gen->lookup) >> >> + return ERR_PTR(-ENOMEM);

Re: [PATCH v5 07/14] mfd: Add driver for Maxim 77802 Power Management IC

2014-07-01 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 07/01/2014 05:15 PM, Lee Jones wrote: > On Thu, 26 Jun 2014, Javier Martinez Canillas wrote: > >> Maxim MAX77802 is a power management chip that contains 10 high >> efficiency Buck regulators, 32 Low-dropout (LDO) regulators u

Re: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

2014-07-02 Thread Javier Martinez Canillas
Hello Tushar, Thanks a lot for your feedback. On 07/02/2014 11:20 AM, Tushar Behera wrote: > On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote: >> Peach pit and pi boards uses a Maxim 77802 power management >> IC to drive regulators and its Real Time Clock. This patch >

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

2014-07-02 Thread Javier Martinez Canillas
Hello Mike, On 07/01/2014 07:26 PM, Mike Turquette wrote: > Quoting Yadwinder Singh Brar (2014-06-29 21:01:36) >> Hi Javier, >> >> On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas >> wrote: >> > Maxim Integrated Power Management ICs are very sim

Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

2014-07-02 Thread Javier Martinez Canillas
Hello Mike, On 07/01/2014 07:29 PM, Mike Turquette wrote: > Quoting Javier Martinez Canillas (2014-06-26 11:15:36) >> Like most clock drivers, the Maxim 77686 PMIC clock binding >> follows the convention that the "#clock-cells" property is >> used to specify

[PATCH v6 06/23] mfd: max77686: Make error checking consistent

2014-07-04 Thread Javier Martinez Canillas
Error checking across the driver is mostly consistent besides a few exceptions, so change these exceptions for consistency. Signed-off-by: Javier Martinez Canillas --- drivers/mfd/max77686.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/max77686.c b

[PATCH v6 21/23] clk: max77802: Add DT binding documentation

2014-07-04 Thread Javier Martinez Canillas
Add Device Tree binding documentation for the clocks outputs in the Maxim 77802 Power Management IC. Signed-off-by: Javier Martinez Canillas --- Changes since v5: - Fix typo error in DT binding. Suggested by Andreas Farber. - Add "clock-output-names" as an optional property si

<    2   3   4   5   6   7   8   9   10   11   >