Re: [PATCH] ARM: dts: Add sd0_rst pinctrl node to exynos5420

2015-01-23 Thread Javier Martinez Canillas
Hello Jaehoon, On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Add sd0_rst node to exynos5420-pinctrl.dtsi. (It's used on odroid-xu3 board) It would be good to mention which device needs this pinctrl line. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com ---

Re: [PATCH v2 0/3] Add support for hardware reset of eMMC card on reboot

2015-02-02 Thread Javier Martinez Canillas
system reboot procedure. Patches looks good to me, I've only one comment on patch 1/3. Once that is addressed, feel free to add for all the series: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line

Re: [PATCH v2 1/3] mmc: pwrseq: add driver for emmc hardware reset

2015-02-02 Thread Javier Martinez Canillas
Hello Marek, On Mon, Feb 2, 2015 at 9:33 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: + +Required properties: +- compatible : contains mmc-pwrseq-emmc. +- reset-gpios : contains a GPIO specifier. The reset GPIO is pulled The DT binding says that the reset-gpios is a required

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-06 Thread Javier Martinez Canillas
Hello Marek, On Fri, Dec 5, 2014 at 11:22 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: On 2014-12-02 10:59, Sjoerd Simons wrote: This is another attempt to finally make Exynos SYSMMU driver fully integrated with DMA-mapping subsystem. The main change from previous version is a rebase

Re: [PATCH RESEND] ARM: exynos_defconfig: Enable options for display panel support

2015-01-05 Thread Javier Martinez Canillas
Hello Krzysztof, Hello Kukjin, You dropped this patch since exynos drm was causing boot hangs on some platforms but the fix for that issue is already in linux-next (commit: f1e9203 clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable failure due to domain being gated) so I think

Re: [PATCH RESEND] ARM: exynos_defconfig: Enable options for display panel support

2015-01-05 Thread Javier Martinez Canillas
Hello Kukjin, Hello Kukjin, Hi Javier, Happy new year :) Thanks, happy new year for you as well! You dropped this patch since exynos drm was causing boot hangs on some platforms but the fix for that issue is already in linux-next (commit: f1e9203 clk: samsung: Fix Exynos 5420

Re: 3.19-rc1: peach*: display not working (missing patches)

2015-01-05 Thread Javier Martinez Canillas
Hello Kukjin, On Mon, Jan 5, 2015 at 2:20 PM, Kukjin Kim kg...@kernel.org wrote: Javier Martinez Canillas wrote: I hope he can merge those patches as 3.19 fixes during the -rc cycle to avoid having another kernel release with a non-working display on Exynos5 boards. Hi, Hmm...Probably

Re: Exynos IOMMU driver doesn't work?

2015-01-12 Thread Javier Martinez Canillas
Hello Hongbo, On Mon, Jan 12, 2015 at 11:51 AM, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 9 January 2015 at 23:34, Javier Martinez Canillas Yes, please take a look to Marek series [0]. Keep in mind that the series does not support all sysmmu revisions so IOMMU is not supported for some

Re: [PATCH RESEND v2 0/7] platform/chrome: Add user-space dev inferface support

2015-01-12 Thread Javier Martinez Canillas
Hello, On 01/02/2015 02:32 PM, Javier Martinez Canillas wrote: The mainline ChromeOS Embedded Controller (EC) driver is still missing some features that are present in the downstream ChromiumOS tree. These are: - Low Pin Count (LPC) interface - User-space device interface - Access

Re: [PATCH RESEND 0/4] Small updates to Snow and Peach Pit/Pi DTS

2015-01-12 Thread Javier Martinez Canillas
Hello Kukjin, On 01/02/2015 04:24 PM, Javier Martinez Canillas wrote: This series adds some DTS snippets that were missing in the mainline Snow and Peach Pit/Pi Device Trees but are present in the downstream ChromeOS kernel. The series is composed of the following patches: Javier

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-12 Thread Javier Martinez Canillas
Hello Joonyoung, On 01/12/2015 07:40 AM, Joonyoung Shim wrote: And also making changes to the clocks in the clk-exynos5420 driver. Can you please explain the rationale for those changes? I'm asking because without your clock changes (only adding the DISP1 pd and making the devices as

Re: Exynos IOMMU driver doesn't work?

2015-01-09 Thread Javier Martinez Canillas
[adding Marek, Sjoerd and Joonyoung that were discussing about iommu support in another thread] Hello Hongbo, On Fri, Jan 9, 2015 at 8:31 AM, Hongbo Zhang hongbo.zh...@linaro.org wrote: Add linux-samsung-soc@vger.kernel.org mailing list. On 7 January 2015 at 18:31, Hongbo Zhang

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-07 Thread Javier Martinez Canillas
Hello Joonyoung, On 01/07/2015 03:03 AM, Joonyoung Shim wrote: On 01/06/2015 06:49 PM, Javier Martinez Canillas wrote: Also I tried forcing the kernel to not disable unused power domains by passing the pd_ignore_unused parameter to the kernel command line. I see on the kernel log a genpd

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-13 Thread Javier Martinez Canillas
On 01/14/2015 01:19 AM, Javier Martinez Canillas wrote: I dug further on this issue and found that the cause is that the exynos_mixer driver needs some clocks (CLK_HDMI and CLK_SCLK_HDMI) grabbed by exynos_hdmi to be kept enabled after hdmi_poweroff (drivers/gpu/drm/exynos/exynos_hdmi.c

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-13 Thread Javier Martinez Canillas
Hello Joonyoung, On 01/13/2015 09:40 AM, Joonyoung Shim wrote: These are the changes I have now [0]. Please let me know what you think. Good, it's working with your patch without u-boot changes and reverting of commit 2ed127697eb. But i also get stripe hdmi output if hdmi/mixer

Re: [PATCH v3 00/19] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem

2015-01-13 Thread Javier Martinez Canillas
Hello Joonyoung, On 01/13/2015 06:24 AM, Joonyoung Shim wrote: Also, the SW_ACLK_300_DISP1 and USER_ACLK_300_DISP1 are needed for the FIMD parent and input clock respectively. Adding those to the clocks list of the DISP1 power domain gives me working display + HDMI on my Exynos5800 Peach Pi.

Re: [PATCH] ARM: DTS: Exynos: convert to generic power domain bindings

2015-01-12 Thread Javier Martinez Canillas
-by: Kevin Hilman khil...@kernel.org Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com It looks to me like a very nice cleanup. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk and on an Exynos5800 Peach Pi Chromebook: Tested-by: Javier Martinez Canillas javier.marti

Re: [PATCH] ARM: dts: exynos5420: Add maudio power domain

2015-02-09 Thread Javier Martinez Canillas
not introduce any functional change except of visibility of this domain to the system. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Your patch looks good to me, I just have two small comments below. With those changes, feel free to add: Reviewed-by: Javier Martinez Canillas

Re: [PATCH 1/2] clk: Don't dereference parent clock if is NULL

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, Thanks a lot for your feedback. On 02/11/2015 07:54 PM, Stephen Boyd wrote: On 02/11, Javier Martinez Canillas wrote: --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -799,7 +799,7 @@ clk_mux_determine_rate_flags(struct clk_hw *hw, unsigned long rate

[PATCH v2 2/3] clk: Add __clk_hw_set_clk helper function

2015-02-12 Thread Javier Martinez Canillas
to change the assignments twice in all the drivers, add a helper function to have an indirection level. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v1: None, new patch. --- include/linux/clk-provider.h | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v2 3/3] clk: Replace explicit clk assignment with __clk_hw_set_clk

2015-02-12 Thread Javier Martinez Canillas
; + __clk_hw_set_clk(dst-hw, hw); Fixes: 035a61c314eb3 (clk: Make clk API return per-user struct clk instances) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v1: - Don't only fix the case of composite clocks but in all the places where a struct clk

Re: [PATCH 2/2] clk: composite: Set clk_core to composite rate and mux components

2015-02-12 Thread Javier Martinez Canillas
Hello Stephen, On 02/11/2015 07:50 PM, Stephen Boyd wrote: --- Thanks for the patch. Thanks a lot for your feedback. Hello, I set the rate and mux components' .core in clk_composite_determine_rate() because that is the least intrusive change and where the .clk field is set too but

[PATCH v2 1/3] clk: Don't dereference parent clock if is NULL

2015-02-12 Thread Javier Martinez Canillas
that case. Fixes: 035a61c314eb3 (clk: Make clk API return per-user struct clk instances) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v2: - Pass NULL struct clk_hw argument to __clk_determine_rate() if parent is NULL. suggested by Stephen Boyd

[PATCH v2 0/3] clk: Some fixes for the per-user clk API changes.

2015-02-12 Thread Javier Martinez Canillas
] and this addresses issues pointed out by Stephen Boyd. This series is composed of the following patches: Javier Martinez Canillas (3): clk: Don't dereference parent clock if is NULL clk: Add __clk_hw_set_clk helper function clk: Replace explicit clk assignment with __clk_hw_set_clk

Re: [PATCH] ARM: EXYNOS: Use platform device name as power domain name

2015-02-10 Thread Javier Martinez Canillas
using the OF aliases approach that Sylwester suggested? But in any case that could be complementary to your patch. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Suggested-by: Sergei Shtylyov sergei.shtyl

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-10 Thread Javier Martinez Canillas
Hello, On 02/10/2015 01:30 PM, Krzysztof Kozlowski wrote: On wto, 2015-02-10 at 15:21 +0300, Sergei Shtylyov wrote: On 2/10/2015 3:17 PM, Krzysztof Kozlowski wrote: Additionally (on Arndale Octa): $ cat /sys/kernel/debug/pm_genpd/pm_genpd_summary domain

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-16 Thread Javier Martinez Canillas
Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: Hello, The mainline ChromeOS Embedded Controller (EC) driver is still missing some features that are present in the downstream ChromiumOS tree. These are: - Low Pin Count (LPC) interface - User-space device interface

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-18 Thread Javier Martinez Canillas
+people involved in Exynos5420 S2R support (Abhilash, Vikas and Pankaj) Hello Kevin, On 03/17/2015 06:35 PM, Kevin Hilman wrote: I've tried suspend/resume on peach-pi using v4.0-rc4, next/master and samsung/for-next, and it doesn't seem to work on any of them. The first problem was the

Re: [PATCH v12 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2015-03-18 Thread Javier Martinez Canillas
Hello Thomas, On Tue, Feb 17, 2015 at 9:25 PM, Tobias Jakobi liquid.a...@gmx.net wrote: Hello! Lukasz Majewski wrote: Hi Krzysztof, Thomas, 2015-01-08 22:17 GMT+01:00 Kevin Hilman khil...@kernel.org: Hi Thomas, Do you plan to continue with this work? It would be very helpful. +1 from

Re: [PATCH v6] ARM: dts: Add HS400 support for exynos5420 and exynos5800

2015-03-18 Thread Javier Martinez Canillas
Hello Alim, On Wed, Mar 18, 2015 at 4:08 AM, Alim Akhtar alim.akh...@samsung.com wrote: From: Seungwon Jeon tgih@samsung.com HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards. This also adds RCLK GPIO line, this gpio should be in pull-down

Re: [rtc-s3c.c] add .needs_src_clk to s3c6410 RTC data / break exynos4

2015-03-18 Thread Javier Martinez Canillas
Hello Tobias, On 03/18/2015 02:00 PM, Tobias Jakobi wrote: Hello Javier, I noticed that this recent commit breaks rtc-s3c on my Odroid-X2 (Exynos4412). The exynos4 dtsi includes a rtc of type s3c6410. Hence all board files based on exynos4, and using the rtc-s3c, are now required to

Re: [PATCH 3/3] ARM: dts: Define stdout-path property for Spring board

2015-03-16 Thread Javier Martinez Canillas
Hello Andreas, index f02775487cd4..b9ec763a5602 100644 --- a/arch/arm/boot/dts/exynos5250-spring.dts +++ b/arch/arm/boot/dts/exynos5250-spring.dts @@ -25,6 +25,7 @@ chosen { bootargs = console=tty1; + stdout-path = serial3:115200n8; Is this a guess or did

Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree

2015-03-16 Thread Javier Martinez Canillas
Hello Andreas, On Mon, Mar 16, 2015 at 11:27 AM, Andreas Färber afaer...@suse.de wrote: Am 16.03.2015 um 08:56 schrieb Javier Martinez Canillas: I think this should be defined in exynos5410.dtsi instead since is an IP block in the SoC and referenced in the .dts using a label to change

Re: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250

2015-03-16 Thread Javier Martinez Canillas
Hello, On 03/16/2015 01:15 PM, Andreas Färber wrote: Am 14.03.2015 um 09:11 schrieb Javier Martinez Canillas: By making the DP controller a consumer of DISP1, the PD is powered off when the exynos-dp probe is deferred and powered on again when the exynos-drm driver is probed

Re: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250

2015-03-16 Thread Javier Martinez Canillas
Hello, On 03/16/2015 03:16 PM, Javier Martinez Canillas wrote: Tested-by: Andreas Färber afaer...@suse.de This fixes the display on the Spring Chromebook as well! Thanks for testing Andreas but this patch seems to only solve a symptom rather than the root cause. Since the error

Re: [PATCH 1/1] ARM: exynos_defconfig: Enable HDMI support

2015-03-17 Thread Javier Martinez Canillas
Hello Kukjin, On Fri, Feb 6, 2015 at 6:42 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Many Exynos boards have an HDMI port so enable Exynos DRM HDMI support. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Exynos DRM HDMI has some issues

Re: [PATCH v2 Resend] pwm: samsung: Fix output race on disabling

2015-03-19 Thread Javier Martinez Canillas
the behaviour is as expected on disable. Signed-off-by: Sjoerd Simons sjoerd.sim...@collabora.co.uk The patch looks good to me. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung

Re: [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node

2015-03-20 Thread Javier Martinez Canillas
the XrtcXTI source clock (32.768kHz). Looks good to me. Reviewed-by: Chanwoo Choi cw00.c...@samsung.com Yes, I also think this is the correct fix for these boards. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Thanks, Chanwoo Choi Best regards, Javier -- To unsubscribe

Re: [PATCH 1/1] serial: samsung: Clear operation mode on UART shutdown

2015-03-20 Thread Javier Martinez Canillas
Hello, On 03/13/2015 12:38 PM, Javier Martinez Canillas wrote: Exynos serial ports operate either in a DMA-based or interrupt-based modes. In DMA-based mode, the UART generates a transfer data request and a Transmission (Tx) interrupt in interrupt-based mode. The Tx IRQ is only unmasked

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-20 Thread Javier Martinez Canillas
Hello Abhilash, On 03/20/2015 06:40 PM, Abhilash Kesavan wrote: I have made some progress on this. This is the current state: If I use next-20141114 (which was when the S2R code first appeared in linux-next), then all is good. next-20141117 is fine too but things are broken in

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-20 Thread Javier Martinez Canillas
Hello Abhilash, On 03/20/2015 03:23 PM, Abhilash Kesavan wrote: On 03/17/2015 06:35 PM, Kevin Hilman wrote: Anyone else having better luck with suspend/resume on peach-pi? # echo +2 /sys/class/rtc/rtc0/wakealarm echo mem /sys/power/state Suspend and CPUs shutdown seems to succeed

Re: [PATCH v4 1/5] ARM: dts: Clean up exynos5410-smdk5410 indentation

2015-03-16 Thread Javier Martinez Canillas
--- Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/5] ARM: dts: Prepare exynos5410-odroidxu device tree

2015-03-16 Thread Javier Martinez Canillas
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] ARM: dts: Define stdout-path property for Peach boards

2015-03-16 Thread Javier Martinez Canillas
The kernel can use as the default console a serial port if is defined as stdout device in the Device Tree. This allows a board to be booted without the need of having a console parameter in the kernel command line. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch

[PATCH 3/3] ARM: dts: Define stdout-path property for Spring board

2015-03-16 Thread Javier Martinez Canillas
users that don't have a serial console on this board might be using it to have the boot log shown in the display. This will have more precedence than the stdout-path but it's fine since is only used when CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is enabled. Signed-off-by: Javier Martinez Canillas

[PATCH 0/3] ARM: dts: Define stdout-patch for Exynos Chromebooks

2015-03-16 Thread Javier Martinez Canillas
and is composed of the following patches: Javier Martinez Canillas (3): ARM: dts: Define stdout-path property for Peach boards ARM: dts: Define stdout-path property for Snow board ARM: dts: Define stdout-path property for Spring board arch/arm/boot/dts/exynos5250-snow.dts | 1 + arch/arm/boot

[PATCH 2/3] ARM: dts: Define stdout-path property for Snow board

2015-03-16 Thread Javier Martinez Canillas
users that don't have a serial console on this board might be using it to have the boot log shown in the display. This will have more precedence than the stdout-path but it's fine since is only used when CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is enabled. Signed-off-by: Javier Martinez Canillas

Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu

2015-03-16 Thread Javier Martinez Canillas
the node name but for example in pinctrl lines we were sorting using the GPIO bank and offset so if we want to use the same policy here, this should be green, blue and red. Either way is good to me though so is up to you. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-09 Thread Javier Martinez Canillas
Hello Inki, On 03/10/2015 03:50 AM, Inki Dae wrote: On 2015년 03월 07일 00:07, Javier Martinez Canillas wrote: Another thing that may be useful to detect these issues early is to have exynos-drm-next be pulled by linux-next since otherwise the integration is not tested until the changes

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-03-10 Thread Javier Martinez Canillas
Hello Kukjin, On 02/05/2015 03:45 PM, Javier Martinez Canillas wrote: Hello Andrzej, Thanks a lot for finally finding what was causing the HDMI issue. On 02/05/2015 01:35 PM, Andrzej Hajda wrote: Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-06 Thread Javier Martinez Canillas
Hello Inki, On 03/06/2015 02:32 PM, Inki Dae wrote: Another interesting data point is that the error in next-20150303 for these 2 boards was the NULL pointer dereference in exynos_plane_destroy that I got with 4.0-rc2 (when IOMMU is disabled) in Snow and Peach Pit. I think the NULL

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-06 Thread Javier Martinez Canillas
Hello Kukjin, On Fri, Mar 6, 2015 at 10:43 AM, Kukjin Kim kg...@kernel.org wrote: Javier Martinez Canillas wrote: Hello Arnd, Hi, On Thu, Mar 5, 2015 at 12:04 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 04 March 2015 21:04:40 Arnd Bergmann wrote: On Tuesday 03 March 2015 04:00

[PATCH 1/1] ARM: exynos_defconfig: Enable ChromeOS EC chardev driver

2015-03-07 Thread Javier Martinez Canillas
Exynos Chromebooks have an Embedded Controller known as the ChromeOS EC Enable the driver that provides an interface to access from user-space. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions

[PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250

2015-03-14 Thread Javier Martinez Canillas
. This patch fixes video display on an Exynos5250 Snow Chromebook. Fixes: 2d2c9a8d0a4f (ARM: dts: add display power domain for exynos5250) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Hello Andrzej and Marek, I need this patch to have display working on an Snow

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-14 Thread Javier Martinez Canillas
Hello Kukjin, On Fri, Mar 6, 2015 at 10:43 AM, Kukjin Kim kg...@kernel.org wrote: Yes, the problem is the Exynos DRM driver which has a lot of issues. It's broken if CONFIG_DRM_EXYNOS_IOMMU is enabled which defaults to yes after commit 8dcc14f82f06 (drm/exynos: IOMMU support should not be

[PATCH 1/8] mfd: cros ec: Remove parent field

2015-03-12 Thread Javier Martinez Canillas
-by: Puthikorn Voravootivat put...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec_i2c.c | 1 - drivers/mfd/cros_ec_spi.c | 1 - drivers/platform/chrome/cros_ec_lpc.c | 1 - include/linux/mfd/cros_ec.h | 2 -- 4

[PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support

2015-03-12 Thread Javier Martinez Canillas
EC in a system Javier Martinez Canillas (2): mfd: cros_ec: Sanity check in and out sizes platform/chrome: cros_ec_lpc - Use existing function to check EC result Stephen Barber (3): mfd: cros_ec: rev cros_ec_commands.h mfd: cros_ec: add proto v3 skeleton mfd: cros_ec: add bus

[PATCH 2/8] mfd: cros_ec: Sanity check in and out sizes

2015-03-12 Thread Javier Martinez Canillas
...@oracle.com Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c index c4aecc6f8373..07c53c27c82a 100644 --- a/drivers/mfd/cros_ec.c +++ b

[PATCH 6/8] mfd: cros_ec: rev cros_ec_commands.h

2015-03-12 Thread Javier Martinez Canillas
rspang...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/platform/chrome/cros_ec_lightbar.c | 14 +- include/linux/mfd/cros_ec_commands.h | 277 ++--- 2 files changed, 262 insertions(+), 29 deletions(-) diff --git

[PATCH 5/8] mfd: cros-ec: Support multiple EC in a system

2015-03-12 Thread Javier Martinez Canillas
...@chromium.org Reviewed-by: Dmitry Torokhov d...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec.c | 7 ++- drivers/platform/chrome/cros_ec_dev.c | 4 ++-- include/linux/mfd/cros_ec.h | 2 ++ 3 files changed

[PATCH 8/8] mfd: cros_ec: add bus-specific proto v3 code

2015-03-12 Thread Javier Martinez Canillas
...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec_i2c.c | 166 +- drivers/mfd/cros_ec_spi.c | 395 +- drivers/platform/chrome/cros_ec_lpc.c | 73 ++- include/linux/mfd

[PATCH 4/8] mfd: cros_ec: Instantiate sub-devices from device tree

2015-03-12 Thread Javier Martinez Canillas
From: Todd Broch tbr...@chromium.org If the EC device tree node has sub-nodes, try to instantiate them as MFD sub-devices. We can configure the EC features provided by the board. Signed-off-by: Todd Broch tbr...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH 7/8] mfd: cros_ec: add proto v3 skeleton

2015-03-12 Thread Javier Martinez Canillas
for handling proto v3 packets. Signed-off-by: Stephen Barber smbar...@chromium.org Reviewed-by: Puthikorn Voravootivat put...@chromium.org Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Puthikorn Voravootivat put...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti

[PATCH 3/8] platform/chrome: cros_ec_lpc - Use existing function to check EC result

2015-03-12 Thread Javier Martinez Canillas
Martinez Canillas javier.marti...@collabora.co.uk --- drivers/platform/chrome/cros_ec_lpc.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index 860310513cf0..3a675817c95d 100644

[PATCH 1/1] serial: samsung: Clear operation mode on UART shutdown

2015-03-13 Thread Javier Martinez Canillas
interrupt enabling) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- I noticed this issue on an Exynos5250 Snow, Exynos5420 Peach Pit and Exynos 5800 Peach Pi Chromebooks. This patch fixes the issue on all of them. The offending commit landed in v4.0-rc1 so this fix is -rc

Re: [PATCH 1/1] ARM: exynos_defconfig: Enable HDMI support

2015-03-24 Thread Javier Martinez Canillas
Hello Kukjin, On Tue, Mar 17, 2015 at 7:54 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Fri, Feb 6, 2015 at 6:42 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Many Exynos boards have an HDMI port so enable Exynos DRM HDMI support. Signed-off-by: Javier

[PATCH 1/1] ARM: exynos_defconfig: Enable options to mount a rootfs via NFS

2015-03-25 Thread Javier Martinez Canillas
This patch enables the needed options to mount a rootfs over NFS and also the needed support for automatic configuration of IP addresses during boot as needed by NFS. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/configs/exynos_defconfig | 6 ++ 1 file

[PATCH v2 1/1] ARM: exynos_defconfig: Enable options to mount a rootfs via NFS

2015-03-25 Thread Javier Martinez Canillas
This patch enables the options to mount a rootfs over NFS and also support for automatic configuration of IP addresses during boot as needed by NFS. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes since v1: - Found a typo in the changelog after posting

[RFC PATCH v3 1/2] clk: samsung: Add a clock lookup function

2015-03-30 Thread Javier Martinez Canillas
as an index so it has a linear search time. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/clk/samsung/clk.c | 6 ++ drivers/clk/samsung/clk.h | 3 +++ 2 files changed, 9 insertions(+) diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c

[RFC PATCH v3 0/2] ARM: EXYNOS: Fix Suspend-to-RAM on Exynos5420

2015-03-30 Thread Javier Martinez Canillas
suspend and resume callbacks [0] and a re-spin [1] but was asked by Abhilash and Chanwoo to do it in the clock driver instead. So this series is an attempt to fix the issue and is composed of patches: Javier Martinez Canillas (2): clk: samsung: Add a clock lookup function clk: exynos5420: Make

Re: [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

2015-03-31 Thread Javier Martinez Canillas
, rtc_src; +}; Exynos's RTC must need the XrtcXTI source clock (32.768kHz). Looks good to me. Reviewed-by: Chanwoo Choi cw00.c...@samsung.com Thanks, Chanwoo Choi Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send

Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id

2015-03-31 Thread Javier Martinez Canillas
Choi cw00.c...@samsung.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 2/2] ARM: dts: s3c-rtc: Use s3c6410-rtc instead of exynos3250-rtc

2015-03-31 Thread Javier Martinez Canillas
...@samsung.com Thanks, Chanwoo Choi -- Looks good to me also. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/2] drivers/rtc/rtc-s3c.c: Integrate Exynos3250 into S3C6410

2015-03-31 Thread Javier Martinez Canillas
k.kozlow...@samsung.com Acked-by: Alexandre Belloni alexandre.bell...@free-electrons.com Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [RFC PATCH v3 1/2] clk: samsung: Add a clock lookup function

2015-03-31 Thread Javier Martinez Canillas
it in the exynos5420 clk driver instead but maybe you have a different opinion on that. Best regards, Javier [0]: From c118df83da8cac65cc218ae944362259f5d0 Mon Sep 17 00:00:00 2001 From: Javier Martinez Canillas javier.marti...@collabora.co.uk Date: Mon, 30 Mar 2015 17:11:40 +0200 Subject: [RFC] clk

[RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-03-30 Thread Javier Martinez Canillas
runtime Power Management support v12) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/clk/samsung/clk-exynos5420.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-30 Thread Javier Martinez Canillas
Hello Chanwoo, Thanks a lot for your feedback. On 03/30/2015 04:04 AM, Chanwoo Choi wrote: I faced on the similiar issue. If some clock was disabled, Exynos SoC could not enter the suspend mode But, I think it is not prpper method to resolve this issue. about that that specific clock

Re: [RFC PATCH v3 1/2] clk: samsung: Add a clock lookup function

2015-03-30 Thread Javier Martinez Canillas
Hello Tomasz, On 03/30/2015 06:02 PM, Tomasz Figa wrote: Hi Javier, 2015-03-31 0:53 GMT+09:00 Javier Martinez Canillas javier.marti...@collabora.co.uk: The Samsung helpers functions to register clocks, add the clock instance returned by the common clock framework to a lookup table

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-03-30 Thread Javier Martinez Canillas
Hello Tomasz, Thanks a lot for your feedback. On 03/30/2015 06:07 PM, Tomasz Figa wrote: Hi Javier, Please see my comments inline. 2015-03-31 0:53 GMT+09:00 Javier Martinez Canillas javier.marti...@collabora.co.uk: [snip] diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers

Re: [PATCH V4 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node

2015-03-31 Thread Javier Martinez Canillas
Hello Markus, On 03/31/2015 01:48 PM, Markus Reichl wrote: The Exynos5422 SoC has a s3c6410 RTC where the source clock is now a mandatory property. This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards. It is based on v4.0-rc2. --- Changes since v3: 1. Readded slipped #include

Re: [RFC PATCH v3 1/2] clk: samsung: Add a clock lookup function

2015-04-01 Thread Javier Martinez Canillas
Hello Mike, On 04/01/2015 03:29 AM, Michael Turquette wrote: Quoting Javier Martinez Canillas (2015-03-31 01:59:39) +Tomeu who I forgot to add to the cc list. Hello Mike, Thanks a lot for your feedback. On 03/31/2015 03:40 AM, Michael Turquette wrote: I don't performance is a big

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-04-01 Thread Javier Martinez Canillas
Hello Sylwester, On 04/01/2015 01:03 PM, Sylwester Nawrocki wrote: On 31/03/15 22:00, Javier Martinez Canillas wrote: On 03/31/2015 04:38 PM, Abhilash Kesavan wrote: javier.marti...@collabora.co.uk wrote: Unfortunately I don't fully understand why this clock needs to be enabled. It would

Re: [PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer

2015-03-27 Thread Javier Martinez Canillas
Hello Inki, On Fri, Mar 27, 2015 at 2:47 AM, Inki Dae inki@samsung.com wrote: Right, this is not documented but if you have ever checked exynos drm driver tree, then I think you could know how we use the prefix. Of course, I don't like to force the use of this prefix but if you and other

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-27 Thread Javier Martinez Canillas
Hello Abhilash, On 03/20/2015 06:40 PM, Abhilash Kesavan wrote: Regarding the mdma0 disablement, it looks like for the system to suspend properly the mdma0 pclk needs to stay on. I had time today again to work on this issue and the best place I found to enable and disable the mdma0 clock

[RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Javier Martinez Canillas
runtime Power Management support v12) Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/mach-exynos/suspend.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index 1521eaf99265

[RFC PATCH 0/2] ARM: EXYNOS: Fix Suspend-to-RAM on Exynos5420

2015-03-27 Thread Javier Martinez Canillas
: Javier Martinez Canillas (2): clk: exynos5420: Add alias for MDMA0 controller clock ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend arch/arm/mach-exynos/suspend.c | 15 +++ drivers/clk/samsung/clk-exynos5420.c | 2 +- 2 files changed, 16

Re: exynos5800-peach-pi: suspend/resume (still) broken

2015-03-27 Thread Javier Martinez Canillas
Hello Abhilash, On 03/27/2015 03:06 PM, Abhilash Kesavan wrote: Hello Javier, On Fri, Mar 27, 2015 at 6:59 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Abhilash, On 03/20/2015 06:40 PM, Abhilash Kesavan wrote: Regarding the mdma0 disablement, it looks like

[RFC PATCH 1/2] clk: exynos5420: Add alias for MDMA0 controller clock

2015-03-27 Thread Javier Martinez Canillas
enabled during suspend, an alias has to be added so a clock lookup for a clock is registered. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/clk/samsung/clk-exynos5420.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/samsung/clk

Re: [PATCH 1/1] Revert ARM: dts: add display power domain for exynos5250

2015-03-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 03/27/2015 03:29 PM, Krzysztof Kozlowski wrote: 2015-03-23 11:49 GMT+01:00 Javier Martinez Canillas I looked at the DP and FIMD drivers and with great help of Andrzej Hajda found the issue: the FIMD driver does not enable DP clock (DP_MIE_CLKCON register). The process

Re: [RFC PATCH 2/2] ARM: EXYNOS: Make sure that the Exynos5420 MDMA0 clock is enabled during suspend

2015-03-27 Thread Javier Martinez Canillas
Hello Sylwester, Thanks a lot for your feedback. On 03/27/2015 03:36 PM, Sylwester Nawrocki wrote: * GIC wake-up support @@ -374,6 +376,16 @@ static void exynos5420_pm_prepare(void) { unsigned int tmp; +/* + * Exynos5420 requires the MDMA0 controller clock to be + *

Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend

2015-03-31 Thread Javier Martinez Canillas
Hello Abhilash, On 03/31/2015 04:38 PM, Abhilash Kesavan wrote: javier.marti...@collabora.co.uk wrote: On 03/30/2015 06:07 PM, Tomasz Figa wrote: If look-up speed is important here, maybe all the relevant clocks could be looked up once at initialization time and just prepared and

[PATCH 1/1] Revert ARM: dts: add display power domain for exynos5250

2015-03-23 Thread Javier Martinez Canillas
off when not needed which is better in terms of power consumption but for now is safer to just revert the commit to avoid adding a regression in some machines. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- arch/arm/boot/dts/exynos5250.dtsi | 10 -- 1 file

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-02 Thread Javier Martinez Canillas
Hello Kukjin, On 03/02/2015 08:43 PM, Kukjin Kim wrote: On 02/27/15 15:20, Javier Martinez Canillas wrote: Hello Kukjin, Hi, On 02/17/2015 12:38 PM, Javier Martinez Canillas wrote: Can you please pick this patch? linux-next is still broken for many Exynos boards after commit

Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-03-03 Thread Javier Martinez Canillas
Hello Kukjin, On 02/06/2015 12:27 PM, Javier Martinez Canillas wrote: Hello Andrzej, On 02/06/2015 11:55 AM, Andrzej Hajda wrote: FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), therefore their clocks should be enabled during power domain switch. Signed-off

Re: [PATCH 8/9] ARM: EXYNOS: suspend requires regulator access

2015-03-02 Thread Javier Martinez Canillas
. Signed-off-by: Arnd Bergmann a...@arndb.de The patch looks good to me. Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Javier Martinez Canillas
Hello, On 02/27/2015 01:11 AM, Olof Johansson wrote: On Thu, Feb 26, 2015 at 3:35 PM, Gwendal Grignou gwen...@chromium.org wrote: Tested-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested on a chromebook pixel with kernel 4.0.0-rc1 and ectool

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, On 02/17/2015 12:38 PM, Javier Martinez Canillas wrote: Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos

Re: [GIT PULL 2/2] Samsung fixes-2 for v4.0

2015-03-04 Thread Javier Martinez Canillas
Hello Arnd, On Thu, Mar 5, 2015 at 12:04 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 04 March 2015 21:04:40 Arnd Bergmann wrote: On Tuesday 03 March 2015 04:00:14 Kukjin Kim wrote: Please pull Samsung tmu and hdmi regression fixes for v4.0 and I know this is quite big for fixes but

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-03-04 Thread Javier Martinez Canillas
+Gustavo which has been looking at the issues Hello, On 03/04/2015 09:50 AM, Marek Szyprowski wrote: Hello, On 2015-03-03 21:36, Kevin Hilman wrote: Javier Martinez Canillas javier.marti...@collabora.co.uk writes: Enabling Exynos DRM IOMMU support for Exynos is currently broken

Re: [PATCH] ARM: dts: exynos4: add nodes for jpeg codec

2015-03-05 Thread Javier Martinez Canillas
Hello Marek, Patch looks good to me. Just a small comment below so feel free to add my Reviewed by: Javier Martinez Canillas javier.marti...@collabora.co.uk On Thu, Mar 5, 2015 at 1:28 PM, Marek Szyprowski m.szyprow...@samsung.com wrote: This patch adds nodes for hardware JPEG codec found

<    4   5   6   7   8   9   10   11   12   13   >