Re: [PATCH] zfcp: updates for -bk

2005-01-24 Thread Heiko Carstens
> > > I thought that having release methods that just called kfree() were > > > also verboten? > > We do a kmalloc(sizeof(struce device),...) somewhere and this > > is how we get rid of it again. > > How are we supposed to free this object otherwise? The release > > function gets called when there

mptfusion: delete watchdogs timers from mptctl and mptscsih

2005-01-24 Thread Moore, Eric Dean
Here is a patch for mpt fusion drivers, which removes the watchdog timers from mptctl/mptscsih. The patch and changelog follows. Pls note, this patch should be applied against a recent patch from Andi Kleen "Add compat_ioctl to mptctl" before applying this patch. Andi's patch was applied against.

Re: [PATCH] add iSCSI session creation sysfs attributes

2005-01-24 Thread James Bottomley
On Mon, 2005-01-24 at 02:39 -0800, Mike Christie wrote: > The attached patch built against scsi-misc-2.6 moves the > target iSCSI attributes to a new structure representing > a iSCSI session. The reason for doing this is to > create a interface that allows the Sourceforge iSCSI driver > to create a

Re: [PATCH] zfcp: updates for -bk

2005-01-24 Thread James Bottomley
On Mon, 2005-01-24 at 15:48 +0100, Heiko Carstens wrote: > > I thought that having release methods that just called kfree() were > > also verboten? > > We do a kmalloc(sizeof(struce device),...) somewhere and this > is how we get rid of it again. > How are we supposed to free this object otherwis

Re: [PATCH] zfcp: updates for -bk

2005-01-24 Thread Heiko Carstens
> > void > > -zfcp_dummy_release(struct device *dev) > > +zfcp_generic_services_release(struct device *dev) > > { > > - return; > > + kfree(dev); > > } > > > > /* > > I thought that having release methods that just called kfree() were > also verboten? We do a kmalloc(sizeof(struce device

Re: [PATCH] zfcp: updates for -bk

2005-01-24 Thread Matthew Wilcox
On Mon, Jan 24, 2005 at 10:46:29AM +0100, Heiko Carstens wrote: > @@ -1099,9 +1099,9 @@ > } > > void > -zfcp_dummy_release(struct device *dev) > +zfcp_generic_services_release(struct device *dev) > { > - return; > + kfree(dev); > } > > /* I thought that having release methods that

[PATCH] add iSCSI session creation sysfs attributes

2005-01-24 Thread Mike Christie
The attached patch built against scsi-misc-2.6 moves the target iSCSI attributes to a new structure representing a iSCSI session. The reason for doing this is to create a interface that allows the Sourceforge iSCSI driver to create and setup a session through sysfs (no more IOCTL at all in our driv

[PATCH] zfcp: updates for -bk

2005-01-24 Thread Heiko Carstens
Hi James, could you please apply the patch below? Thanks, Heiko From: Heiko Carstens <[EMAIL PROTECTED]> From: Andreas Herrmann <[EMAIL PROTECTED]> From: Maxim Shchetynin <[EMAIL PROTECTED]> zfcp changes: - revert kfree patch leftovers - don't call del_timer_sync() in interrupt context - cor