RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
I have to reject this change since pci_module_init() has a different return code than pci_register_driver(). The patch should look like: - error = pci_module_init(&aac_pci_driver); + error = pci_register_driver(&aac_pci_driver); - if (error) + if (error < 0)

2.6.11-mm3: megaraid_sas.c: stack usage

2005-03-15 Thread Adrian Bunk
On Sat, Mar 12, 2005 at 03:42:22AM -0800, Andrew Morton wrote: >... > All 606 patches: >... > megaraid_sas-announcing-new-module-for.patch > megaraid_sas: Announcing new module for LSI Logic's SAS based MegaRAID > controllers >... Enormous stack usage: - megasas_init_mfi (due to ctrl_info) Big

RE: 2.6.11-mm3: megaraid_sas.c: stack usage

2005-03-15 Thread Bagalkote, Sreenivas
>On Sat, Mar 12, 2005 at 03:42:22AM -0800, Andrew Morton wrote: >>... >> All 606 patches: >>... >> megaraid_sas-announcing-new-module-for.patch >> megaraid_sas: Announcing new module for LSI Logic's SAS >based MegaRAID controllers >>... > >Enormous stack usage: >- megasas_init_mfi (due to ctrl_i

Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Domen Puncer
On 15/03/05 08:38 -0500, Salyzyn, Mark wrote: > I have to reject this change since pci_module_init() has a different > return code than pci_register_driver(). pci.h: #define pci_module_init pci_register_driver pci-driver.c: pci_register_driver: "Returns a negative value on error, otherwis

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
We have tested and seen a positive number being returned on late model distributions (FC3) Sincerely -- Mark Salyzyn -Original Message- From: Domen Puncer [mailto:[EMAIL PROTECTED] Sent: Tuesday, March 15, 2005 10:57 AM To: Salyzyn, Mark Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org;

Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Domen Puncer
On 15/03/05 10:59 -0500, Salyzyn, Mark wrote: > We have tested and seen a positive number being returned on late model > distributions (FC3) Function tree from 2.6.11-bk9: pci_register_driver driver_register bus_add_driver kobject_set_name - ok kobject_register kobject_a

RE: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Salyzyn, Mark
FC3 != kernel.org, and the problem may not exist in latest tree. The code for pci_module_init used to do a return (ret < 0) ? ret : 0. The problem is then a 'transition' issue, as patches that appear here can and will be used for kernel revisions a few back. By changing the aacraid driver to check

Re: [PATCH 1/2] SCSI tape fixes (new version): sense descriptor init, bsf->weof, blkno, debugging

2005-03-15 Thread James Bottomley
On Sat, 2005-03-12 at 19:04 +0200, Kai Makisara wrote: > This is an updated version of the patch I sent March 7. The sense descriptor > initialization has been made lighter. > > The patch at the end of this message applies to 2.6.11-bk7 + st descriptor > sense > patch + st auto eof patch (i.e., s

Re: [PATCH 1/2] SCSI tape fixes (new version): sense descriptor init, bsf->weof, blkno, debugging

2005-03-15 Thread Kai Makisara
On Tue, 15 Mar 2005, James Bottomley wrote: > On Sat, 2005-03-12 at 19:04 +0200, Kai Makisara wrote: > > This is an updated version of the patch I sent March 7. The sense descriptor > > initialization has been made lighter. > > > > The patch at the end of this message applies to 2.6.11-bk7 + st d

Re: [patch 06/11] drivers/scsi/aacraid/*: convert to pci_register_driver

2005-03-15 Thread Domen Puncer
On 15/03/05 12:59 -0500, Salyzyn, Mark wrote: > FC3 != kernel.org, and the problem may not exist in latest tree. The > code for pci_module_init used to do a return (ret < 0) ? ret : 0. > > The problem is then a 'transition' issue, as patches that appear here > can and will be used for kernel revis

Re: 2.6.10 devfs oops without devfs mounted at all

2005-03-15 Thread Andrew Morton
(This is from Feb 10).. An oops during execution of megamgr.bin. Sergey, I assume this bug is still happening in current kernels? If so, could you please remind us how to reproduce it and send the .config file? Thanks. "Sergey S. Kostyliov" <[EMAIL PROTECTED]> wrote: > > On Thursday 10 Februa

Problem with MPT in 2.4.X

2005-03-15 Thread Jean Tourrilhes
Hi, I have a problem with a system which use a MPT SCSI host and a Maxtor drive. After a few days the scsi subsystem throw zillions of errors and can't access the disk anymore. The only way out is the reset button. The system came with SCSI preinstalled, the MPT is on the m

[BK PATCH] SCSI updates for 2.6.11

2005-03-15 Thread James Bottomley
This is my current tranch of patches that were waiting the transition from -rc to released (sorry it's late ... I've been on holiday). The patch is available here: bk://linux-scsi.bkbits.net/scsi-for-linus-2.6 The short log is: Adrian Bunk: o SCSI NCR_D700.c: make some code static o SCSI si

Re: [PATCH] dc395x: Fix support for highmem

2005-03-15 Thread Jens Axboe
On Thu, Mar 03 2005, Linux Kernel Mailing List wrote: > ChangeSet 1.1982.29.77, 2005/03/03 10:41:40+02:00, [EMAIL PROTECTED] > > [PATCH] dc395x: Fix support for highmem > > From: Guennadi Liakhovetski <[EMAIL PROTECTED]> > > Removes the page_to_virt and maps sg list