Re: [2.6 patch] drivers/scsi/sg.c: several against 2.6.12-rc1

2005-03-28 Thread Yum Rayan
In the diff >+ if (old_hdr) >+ kfree(old_hdr); >+ return retval; The check for NULL is not needed. Thanks, Rayan On Mon, 28 Mar 2005 19:48:10 +1000, Douglas Gilbert <[EMAIL PROTECTED]> wrote: > The attachment combines the most recent patch from > Yum Rayan <[EMAIL PROTEC

[PATCH 1/1] 3ware 9000 driver update for linux-2.6.12-rc1-mm4

2005-03-28 Thread adam radford
The attached patch updates the driver for the 3ware 9000 series to do the following: - Add support for PAE mode. - Add lun support. - Fix twa_remove() to free irq handler/unregister_chrdev() before shutting down the card. - Change to new 'change_queue_depth' api. (From James) - Fix 'handled=1' ISR

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Mark Haverkamp
On Mon, 2005-03-28 at 15:28 -0800, Mark Haverkamp wrote: > On Mon, 2005-03-28 at 22:59 +0100, Christoph Hellwig wrote: > > On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: > > > A patch from Adaptec with byte order changes: > > > - drop byte swapping on all 0's and all 1's content >

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Randy.Dunlap
Mark Haverkamp wrote: On Mon, 2005-03-28 at 22:59 +0100, Christoph Hellwig wrote: On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: A patch from Adaptec with byte order changes: - drop byte swapping on all 0's and all 1's content - fix up missing swapping directives - ensure swapping

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Mark Haverkamp
On Mon, 2005-03-28 at 22:59 +0100, Christoph Hellwig wrote: > On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: > > A patch from Adaptec with byte order changes: > > - drop byte swapping on all 0's and all 1's content > > - fix up missing swapping directives > > - ensure swapping o

RE: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Salyzyn, Mark
The new cardtype was a documentation. Could have been handled separately I agree. *I* have to support the broken port for reasons of expediency. Dropping this behavior from the kernel.org patch is perfectly fine by me. I was not sure how extensive this problem was. Sincerely -- Mark Salyzyn

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 14:04 -0800, Mark Haverkamp wrote: > On Mon, 2005-03-28 at 15:58 -0600, James Bottomley wrote: > > What exactly is this for? I know of no platforms that implement readl > > and friends incorrectly, so all of this should be unnecessary. > > I wondered about this. Mark S. tho

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Mark Haverkamp
On Mon, 2005-03-28 at 22:59 +0100, Christoph Hellwig wrote: > On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: > > A patch from Adaptec with byte order changes: > > - drop byte swapping on all 0's and all 1's content > > - fix up missing swapping directives > > - ensure swapping o

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Mark Haverkamp
On Mon, 2005-03-28 at 15:58 -0600, James Bottomley wrote: > On Mon, 2005-03-21 at 10:41 -0800, Mark Haverkamp wrote: > > + Adaptec 2130S That was in the TODO file I think. There isn't a new card supported in this patch set. > > Why are we getting updated card support in an endian cleanup pat

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Christoph Hellwig
On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: > A patch from Adaptec with byte order changes: > - drop byte swapping on all 0's and all 1's content > - fix up missing swapping directives > - ensure swapping on 16 bit values does not use 32 bit swap > - reconcile the readl/writ

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread James Bottomley
On Mon, 2005-03-21 at 10:41 -0800, Mark Haverkamp wrote: > + Adaptec 2130S Why are we getting updated card support in an endian cleanup patch? > +/* > + * Some configurations of BE Linux have writel and readl automatically > perform > + * byte swapping, and some configurations (embedded) do

Re: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-28 Thread Christoph Hellwig
> > note that if adaptec simply opensourced their managment tools we > wouldn't > > have this problem at all. I wonder why Adaptec did that for the old > > i2o-based controllers but not aacraid. > > Oh yes, that, worked hard on the powers-that-be to permit this. Could > not release a substantial

Handling ordered tags

2005-03-28 Thread Brian King
I'm trying to understand all the implications of allowing ordered tags for a SCSI LLD, especially when running QERR=0 with autosense and no ACA. Are any of these problems a concern given how ordered tags are used in Linux? 1. If an ordered tag is sent and a previously sent simple tagged op comple

scsi device discovery/assignment

2005-03-28 Thread Ying Li
Hi, I was wondering if there is a dynamic way to discover/identify the set of, let say scsi hard drives in a Storage Device that uses FC, attached to a specific HBA card. Like know which dev in /dev is connected through the HBA. Thanks -Ying

RE: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-28 Thread Moore, Eric Dean
On Saturday, March 26, 2005 4:21 AM, Christoph Hellwig wrote: > I took a quick look an a here's a few comments: > > - I don't think renaming mptscsih.c to mpt_core.c makes sense. >the new name is confusing at best, and keeping the old name allows >to keep SCCS history aswell. That means

RE: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-28 Thread Moore, Eric Dean
On Sunday, March 27, 2005 8:04 AM, James Bottomley wrote: > > > On Sun, 2005-03-27 at 01:16 -0800, Jeremy Higdon wrote: > > James, actually this queue depth code predates your > change_queue_depth > > API. I don't think it was ever converted to the new API. > > Erk, you're right. My todo list

Re: program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 09:34 -0300, Marcelo Tosatti wrote: > I'm using FC2 - FC3 probably has it updated. > > Sorry for the noise. Heh, not necessarily ... the reason for making the SCSI subsystem print these messages is that no-one was updating any user level programs to move to the new API ... n

Re: program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO

2005-03-28 Thread Marcelo Tosatti
On Mon, Mar 28, 2005 at 09:39:23AM -0600, James Bottomley wrote: > On Mon, 2005-03-28 at 07:33 -0300, Marcelo Tosatti wrote: > > You probably already know about this, but just in case: > > > > v2.6.12-rc1 yields > > > > program scsi_unique_id is using a deprecated SCSI ioctl, please convert it >

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 17:29 +0200, Arjan van de Ven wrote: > how about a CONFIG_SCSI_DRIVER_DEBUG ? In principle, that's fine ... in practice does the few bytes saved by this really justify adding yet another option? James - To unsubscribe from this list: send the line "unsubscribe linux-scsi"

Re: program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 07:33 -0300, Marcelo Tosatti wrote: > You probably already know about this, but just in case: > > v2.6.12-rc1 yields > > program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to > SG_IO Actually, a lot of programs do this. Since about 2.6.11 (I think,

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread Arjan van de Ven
On Mon, 2005-03-28 at 09:21 -0600, James Bottomley wrote: \ > > - remove the following unused functions: > > - scsi.h: print_driverbyte > > - scsi.h: print_hostbyte > > - #if 0 the following unused functions: > > - constants.c: scsi_print_hostbyte > > - constants.c: scsi_print_driverbyte >

program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO

2005-03-28 Thread Marcelo Tosatti
Hi SCSI gurus, You probably already know about this, but just in case: v2.6.12-rc1 yields program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO program scsi_unique_id is using a d

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread James Bottomley
On Sun, 2005-03-27 at 22:21 +0200, Adrian Bunk wrote: > This patch contains the following cleanups: [..] No to all of this: > - remove the following unused functions: > - scsi.h: print_driverbyte > - scsi.h: print_hostbyte > - #if 0 the following unused functions: > - constants.c: scsi_prin

[PATCH] add block/unblock to iscsi class

2005-03-28 Thread Mike Christie
The attached patch adds session block and unblock functions similar to the rport block and unblock code. The patch was built against scsi misc (but also pathces against scsi rc fixes) and this patch http://marc.theaimsgroup.com/?l=linux-scsi&m=81778109783&w=2 which adds a scsi_flush_work functi

[2.6 patch] drivers/scsi/sg.c: several against 2.6.12-rc1

2005-03-28 Thread Douglas Gilbert
; +static int sg_version_num = 30533; /* 2 digits for each component */ +#define SG_VERSION_STR "3.5.33" /* * D. P. Gilbert ([EMAIL PROTECTED], [EMAIL PROTECTED]), notes: @@ -60,7 +60,7 @@ #ifdef CONFIG_SCSI_PROC_FS #include -static char *sg_version_date = "20050117&