Re: PATCH [4/5] qla2xxx: cleanup DMA mappings...

2005-04-15 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: > > + struct page *page; > > + unsigned long offset; > > + > > + page = virt_to_page(cmd->request_buffer); > > + offset = ((unsigned long)cmd->request_buffer & ~PAGE_MASK); > > + req_dma = pci_map

Re: PATCH [6/5] qla2xxx: update version :)

2005-04-15 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: > On Wed, Apr 13, 2005 at 01:50:07PM -0700, Andrew Vasquez wrote: > > Update version. > > Btw, Documentation/scsi/qla2xxx.revision.notes hasn't been updated for > ages. Either scrap it or give it some love, I don't mind too much which > of these yo

RE: Question about scsi_device_online() usage in mptscsih

2005-04-15 Thread James Bottomley
On Fri, 2005-04-15 at 10:11 -0600, Moore, Eric Dean wrote: > Thus I think its safe to say, we can remove the > scsi_device_online from mptscsih_flush_running_cmds. > Right?? Yes, as long as you now tear down all the outstanding commands while the error handler is executing, you should be safe fro

RE: Question about scsi_device_online() usage in mptscsih

2005-04-15 Thread Moore, Eric Dean
On Friday, April 15, 2005 8:30 AM, James Bottomley wrote: > > On Fri, 2005-04-15 at 19:13 +0900, Masao Fukuchi wrote: > > The sequence is: > > 1.Host issues SCSI command to fusion MPT driver. > > 2.Mid layer detects command timeout and then performs > > error recovery sequence. > > But the

[2.6 patch] drivers/scsi/gdth.c: cleanups

2005-04-15 Thread Adrian Bunk
This patch contains the following cleanups: - make some needlessly global functions static - remove one more kernel 2.2 #ifdef Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 28 Feb 2005 drivers/scsi/gdth.c | 24 drivers/scsi/gdth

Re: Question about scsi_device_online() usage in mptscsih

2005-04-15 Thread James Bottomley
On Fri, 2005-04-15 at 19:13 +0900, Masao Fukuchi wrote: > The sequence is: > 1.Host issues SCSI command to fusion MPT driver. > 2.Mid layer detects command timeout and then performs > error recovery sequence. > But the sequence fails and it causes device offline. > (fusion MPT driver still

Re: [GIT PATCH] scsi updates for 2.6.12-rc2

2005-04-15 Thread James Bottomley
On Fri, 2005-04-15 at 13:25 +0200, Pavel Machek wrote: > Okay, so du -s is: > > [EMAIL PROTECTED]:~# du -sh /tmp/delme.git/ > 109M/tmp/delme.git/ > > Not as bad as I expected, but still quite a lot of data for few > changes. Erm, but that's why it's an rsync archive. You're supposed to have

RE: [2.6 patch] drivers/scsi/dpt*: remove version.h dependencies

2005-04-15 Thread Salyzyn, Mark
You can not remove the entries in sys_info.h (osMajorVersion & friends), this communicates information to the application via the ioctls and the structure shape is important. Change the code to zero the values, leave osType set to OS_LINUX. Sincerely -- Mark Salyzyn -Original Message- Fr

Re: [GIT PATCH] scsi updates for 2.6.12-rc2

2005-04-15 Thread Pavel Machek
Hi! > > This is a small set of bugfixes for 2.6.12-rc2 ... you asked me to try > > git, so I did (I actually updated my bk backport script simply to export > > from a BK tree to a git tree). For the time being, I plan to keep the > > scsi changes in BK, but I'll export them for you to try merging

Re: [GIT PATCH] scsi updates for 2.6.12-rc2

2005-04-15 Thread Pavel Machek
Hi! > This is a small set of bugfixes for 2.6.12-rc2 ... you asked me to try > git, so I did (I actually updated my bk backport script simply to export > from a BK tree to a git tree). For the time being, I plan to keep the > scsi changes in BK, but I'll export them for you to try merging > > Th

Re: Question about scsi_device_online() usage in mptscsih

2005-04-15 Thread Masao Fukuchi
Hi Eric. The problem was caused by calling pci_unmap_sg() after device offline. The sequence is: 1.Host issues SCSI command to fusion MPT driver. 2.Mid layer detects command timeout and then performs error recovery sequence. But the sequence fails and it causes device offline. (fusion M