Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Andrew Vasquez
On Wed, 13 Apr 2005, Christoph Hellwig wrote: > > atomic_set(&fcport->state, FCS_ONLINE); > > + if (ha->flags.init_done) > > + qla2x00_reg_remote_port(ha, fcport); > > } > > ... > > > - goto probe_failed; > > + goto probe_alloc_failed; > > } > > > > +

Re: [PATCH] remove some dead code in qla2xxx

2005-04-19 Thread Andrew Vasquez
On Mon, 18 Apr 2005, Christoph Hellwig wrote: > > = drivers/scsi/qla2xxx/qla_dbg.c 1.12 vs edited = > --- 1.12/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-13 17:45:53 +02:00 > +++ edited/drivers/scsi/qla2xxx/qla_dbg.c 2005-04-18 16:22:48 +02:00 > @@ -1063,8 +1063,7 @@ >

Re: [ANNOUNCE] sdparm 0.90

2005-04-19 Thread Douglas Gilbert
Jeff Garzik wrote: Douglas Gilbert wrote: sdparm is a new command line utility designed to get and set SCSI disk parameters (cf hdparm for ATA disks). More generally it gets and sets mode page information on SCSI devices or devices that use a SCSI command set (e.g. CD/DVD drives (any transport) and

Re: [ANNOUNCE] sdparm 0.90

2005-04-19 Thread Douglas Gilbert
[EMAIL PROTECTED] wrote: oh wait, 2.6 yes? In lk 2.4 you get to use sg device nodes as noted in the man page ;-) sg_map (in sg3_utils) will show the mapping. If sdparm is popular I could add a SCSI_IOCTL_SEND_COMMAND interface for lk 2.4 as a fall back. Alternatively sdparm could internally iterate

Re: Can a non-sg scsi write command be more than PAGE_SIZE length?

2005-04-19 Thread Christoph Hellwig
On Tue, Apr 19, 2005 at 11:24:31AM +0200, Olivier Galibert wrote: > > Yes, it's allowed. > > Thanks. Pages in that case are continuous then, right? Good question actually. I know XFS does passed vmalloc'ed memory down the block I/O path, but that's as a scatter/gather request. All non-s/g requ

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread Jens Axboe
On Mon, Apr 18 2005, Tejun Heo wrote: > And, James, regarding REQ_SOFTBARRIER, if the REQ_SOFTBARRIER thing can > be removed from SCSI midlayer, do you agree to change REQ_SPECIAL to > mean special requests? If so, I have three proposals. > > * move REQ_SOFTBARRIER setting to right after the al

[PATCH] fix microtek.c compile failure

2005-04-19 Thread Barry K. Nathan
This is with gcc 3.4.3, against linux-2.6 head 9d469ee9f21c680c41dbffe5b0f36ab5010ca8b1 (the latest as of this writing): CC [M] drivers/usb/image/microtek.o drivers/usb/image/microtek.c: In function `mts_scsi_abort': drivers/usb/image/microtek.c:338: error: `FAILURE' undeclared (first use in th

[PATCH] fix ultrastor.c compile error

2005-04-19 Thread Barry K. Nathan
This is against linux-2.6 head 9d469ee9f21c680c41dbffe5b0f36ab5010ca8b1: CC [M] drivers/scsi/ultrastor.o drivers/scsi/ultrastor.c: In function `ultrastor_queuecommand': drivers/scsi/ultrastor.c:302: warning: matching constraint does not allow a register drivers/scsi/ultrastor.c:302: warning: ma

[PATCH] fix aic7xxx_osm.c compile failure (gcc 2.95.x only)

2005-04-19 Thread Barry K. Nathan
I get this compile error on linux-2.6 head 9d469ee9f21c680c41dbffe5b0f36ab5010ca8b1, but only with gcc 2.95.3, not gcc 3.4.3: CC [M] drivers/scsi/aic7xxx/aic7xxx_osm.o drivers/scsi/aic7xxx/aic7xxx_osm.c: In function `ahc_linux_init': drivers/scsi/aic7xxx/aic7xxx_osm.c:3608: parse error before `

Re: Can a non-sg scsi write command be more than PAGE_SIZE length?

2005-04-19 Thread James Bottomley
On Tue, 2005-04-19 at 10:29 +0100, Christoph Hellwig wrote: > Good question actually. I know XFS does passed vmalloc'ed memory down > the block I/O path, but that's as a scatter/gather request. All non-s/g > request should be contingous I think. > > We really need to write down the rules about w

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread James Bottomley
On Tue, 2005-04-19 at 14:34 +0200, Jens Axboe wrote: > On Mon, Apr 18 2005, Tejun Heo wrote: > > And, James, regarding REQ_SOFTBARRIER, if the REQ_SOFTBARRIER thing can > > be removed from SCSI midlayer, do you agree to change REQ_SPECIAL to > > mean special requests? If so, I have three proposal

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread Jens Axboe
On Tue, Apr 19 2005, James Bottomley wrote: > On Tue, 2005-04-19 at 14:34 +0200, Jens Axboe wrote: > > On Mon, Apr 18 2005, Tejun Heo wrote: > > > And, James, regarding REQ_SOFTBARRIER, if the REQ_SOFTBARRIER thing can > > > be removed from SCSI midlayer, do you agree to change REQ_SPECIAL to > >

[PATCH scsi-misc-2.6 00/04] scsi: misc timer fixes (reworked)

2005-04-19 Thread Tejun Heo
Hello, James. This patchset contains the following patches from the previous timer update patchset. 02_scsi_timer_eh_timer_fix.patch 03_scsi_timer_dispatch_race_fix.patch 04_scsi_timer_remove_delete_timer_from_reset_provider.patch eh_timer_fix is reworked as you suggested and split into tw

Re: [PATCH scsi-misc-2.6 03/04] scsi: remove a timer race in scsi_queue_insert()

2005-04-19 Thread Tejun Heo
03_scsi_timer_dispatch_race_fix.patch scsi_queue_insert() has four callers. Three callers call with timer disabled and one (the second invocation in scsi_dispatch_cmd()) calls with timer activated. scsi_queue_insert() used to always call scsi_delete_timer()

Re: Regarding posted scsi midlyaer patchsets

2005-04-19 Thread Jens Axboe
On Tue, Apr 19 2005, Jens Axboe wrote: > On Tue, Apr 19 2005, James Bottomley wrote: > > On Tue, 2005-04-19 at 14:34 +0200, Jens Axboe wrote: > > > On Mon, Apr 18 2005, Tejun Heo wrote: > > > > And, James, regarding REQ_SOFTBARRIER, if the REQ_SOFTBARRIER thing can > > > > be removed from SCSI mid

Re: [PATCH scsi-misc-2.6 04/04] scsi: remove unnecessary scsi_delete_timer() call in scsi_reset_provider()

2005-04-19 Thread Tejun Heo
04_scsi_timer_remove_delete_timer_from_reset_provider.patch scsi_reset_provider() calls scsi_delete_timer() on exit which isn't necessary. Remove it. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> scsi_error.c |1 - 1 files changed, 1 deletion(-) Index: scsi-reqfn-export/dri

Re: [PATCH scsi-misc-2.6 02/04] scsi: remove spurious if tests from scsi_eh_{times_out|done}

2005-04-19 Thread Tejun Heo
02_scsi_timer_eh_timer_remove_spurious_if.patch If tests which check if eh_action isn't NULL in both functions are always true. Remove the if's. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> scsi_error.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) Index: scs

Re: [PATCH scsi-misc-2.6 01/04] scsi: make scsi_send_eh_cmnd use its own timer instead of scmd->eh_timeout

2005-04-19 Thread Tejun Heo
01_scsi_timer_eh_timer_fix.patch scmd->eh_timeout is used to resolve the race between command completion and timeout. However, during error handling, scsi_send_eh_cmnd uses scmd->eh_timeout. This creates a race condition between eh and normal completion for a requ

fastfail operation and retries

2005-04-19 Thread Andreas Herrmann
Hi, I have question(s) regarding the fastfail operation of the SCSI stack. Performing multipath-tests with an IBM ESS I encountered problems. During certain operations on an ESS (quiesce/resume and such) requests on all paths fail temporarily with an data underrun (resid is set in the FCP-respons

[PATCH] aic7xxx: remove inquiry sniffing leftovers

2005-04-19 Thread Christoph Hellwig
--- 1.66/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-04-17 19:03:05 +02:00 +++ edited/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-04-19 21:33:10 +02:00 @@ -2335,8 +2335,6 @@ AHC_TRANS_GOAL, /*paused*/FALSE); ahc_update_neg_request(ahc, &devinfo, tstate, tinfo, AHC_NEG_AL

[PATCH 3/7] mptfusion: mptctl Remove credits and update copyright

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 3/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) mptctl.c: Remove credits and update copyright (2) mptctl.c: cleanup in get_iocinfo Signed-off-by: Eric Moore <[EMAIL PROTECTED]> patc

[PATCH 2/7] mptfusion: mptbase cleanup, split driver support, DMA 32_BIT_MASK

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 2/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) mptbase.c: Move registering pci ids to scsi lld drivers (2) mptbase.c: Use the DMA_32BIT_MASK constant (3) mptbase.c: Fix for multiple pci d

[PATCH 1/7] mptfusion: Kconfig Adding new bus type drivers for fu sion drivers.

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 1/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) Kconfig - added new mptspi and mptfc scsi lld drivers (2) Kconfig - increased MAX_SGE from 40 to 128 (2) Makefile - compilation support for

[PATCH 4/7] mptfusion: mptlan Remove credits and update copyright

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 4/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) mptlan.c: Remove credits and update copyright (2) mptlan.c: Remove -sralston references Signed-off-by: Eric Moore <[EMAIL PROTECTED]> pat

[PATCH 5/7] mptfusion: mptscsih Split driver support

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 5/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) mptscsih.c: Remove credits, -sralston references , update copyright (2) mptscsih.c: split driver support (3) mptscsih.c: module_init, module

[PATCH 7/7] mptfusion: mptfc Adding Stub Driver - Fiber Channel

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 7/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) mptfc.c: This driver is having module_init, module_exit, and probe. (2) mptfc.c: Registering for Fibre Channel pci ids are done from this mod

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Christoph Hellwig
On Tue, Apr 19, 2005 at 12:27:51AM -0700, Andrew Vasquez wrote: > > why do you still need > > the special case for delaying registration of the targets? > > > > Ok, this is actually a concern I have with the current fc_rport > implementation (and yes, I realize I'm a day late) -- the auto-scan >

Re: PATCH [6/5] qla2xxx: update version :)

2005-04-19 Thread Christoph Hellwig
On Wed, Apr 13, 2005 at 02:24:36PM -0700, Andrew Vasquez wrote: > Ok, here's the deal -- QLogic's standard 8.01.00 driver contains the > following major additions: > > * support for 4Gb ISPs > * FCIP support Btw, any plans to do proper FCIP support integrated with the transport class code? (and

[PATCH 6/7] mptfusion: mptspi Adding Stub Driver - SCSI Parallel

2005-04-19 Thread Moore, Eric Dean
mptfusion patch 6/7: This patch can also be found at this URL: ftp://ftp.lsil.com/HostAdapterDrivers/linux/FiberChannel/2.6-kernel/3.03.00/ Changelog: (1) mptspi.c: This driver is having module_init, module_exit, and probe. (2) mptspi.c: Registering for SCSI pci ids are done from this module. (3

test of 'good_bytes' in scsi_io_completion is always true (in drivers/scsi/scsi_lib.c)

2005-04-19 Thread Jesper Juhl
in drivers/scsi/scsi_lib.c::scsi_io_completion() 'good_bytes' is tested for being >= 0, but 'good_bytes' is an unsigned int, so that test is always true. My *guess* is that what was intended was to test if good_bytes is > 0, but I don't know this code well enough to be sure. The patch below ma

writev to SCSI disks: Does sg work?

2005-04-19 Thread Dheeraj Pandey
Hi! I was wondering if I did a simple writev to a SCSI disk, does it take the sg path to the device? I am guessing this sg (REQ_SPECIAL) is only true for character devices (and ioctl's) and not block devices. These are my questions: - Is sg a common feature among SCSI disks these days? How do

[PATCH scsi-misc-2.6 00/05] scsi: change REQ_SPECIAL/REQ_SOFTBARRIER usages

2005-04-19 Thread Tejun Heo
Hello, James, Jens and Christoph. This patchset is reworked version of the previous REQ_SPECIAL update patchset. Patches #01 and #05 update blk layer. The other patches update SCSI midlayer. I've opted for automatically setting REQ_SOFTBARRIER together with REQ_STARTED in elv_next_request().

Re: [PATCH scsi-misc-2.6 04/05] scsi: make scsi_requeue_request() use blk_requeue_request()

2005-04-19 Thread Tejun Heo
04_scsi_REQ_SPECIAL_semantic_scsi_requeue_command.patch scsi_requeue_request() used to use blk_insert_request() for requeueing requests. This depends on the unobvious behavior of blk_insert_request() setting REQ_SPECIAL and REQ_SOFTBARRIER when requeueing. This pa

Re: [PATCH scsi-misc-2.6 05/05] scsi: remove requeue feature from blk_insert_request()

2005-04-19 Thread Tejun Heo
05_scsi_blk_insert_request_no_requeue.patch blk_insert_request() has a unobivous feature of requeuing a request setting REQ_SPECIAL|REQ_SOFTBARRIER. SCSI midlayer was the only user and as previous patches removed the usage, remove the feature from blk_insert_reques

Re: [PATCH scsi-misc-2.6 03/05] scsi: make scsi_queue_insert() use blk_requeue_request()

2005-04-19 Thread Tejun Heo
03_scsi_REQ_SPECIAL_semantic_scsi_queue_insert.patch scsi_queue_insert() used to use blk_insert_request() for requeueing requests. This depends on the unobvious behavior of blk_insert_request() setting REQ_SPECIAL and REQ_SOFTBARRIER when requeueing. This patch ma

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-19 Thread Tejun Heo
01_scsi_blk_make_started_requests_ordered.patch Reordering already started requests is without any real benefit and causes problems if the request has its driver-specific resources allocated (as in SCSI). This patch makes elv_next_request() set REQ_SOFTBARRIER auto

Re: [PATCH scsi-misc-2.6 02/05] scsi: remove REQ_SPECIAL in scsi_init_io()

2005-04-19 Thread Tejun Heo
02_scsi_REQ_SPECIAL_semantic_scsi_init_io.patch scsi_init_io() used to set REQ_SPECIAL when it fails sg allocation before requeueing the request by returning BLKPREP_DEFER. REQ_SPECIAL is being updated to mean special requests. So, remove REQ_SPECIAL setting. Sig

streamlining the sym2 io submission path

2005-04-19 Thread Matthew Wilcox
I've been looking at speeding up sym2's queuecommand method. In my current development tree, I've removed most of sym_queue_command() and inlined the remains into sym53c8xx_queuecommand(). There's some funny stuff I wouldn't mind some advice with: We fail the first command to the device if the

Re: streamlining the sym2 io submission path

2005-04-19 Thread Christoph Hellwig
On Wed, Apr 20, 2005 at 12:43:23AM +0100, Matthew Wilcox wrote: > We fail the first command to the device if the device is marked as > NOSCAN or the lun is non-0 and the device isn't marked as SCAN LUNS. > I think the first part should be moved to slave_alloc(); it's a little > weird, but supportab

Removing a disk from the qla2xxx driver.

2005-04-19 Thread Rajat Jain, Noida
Hi, I do not know whether this is the corect forum to discuss this, but I recently saw a post related to qla2xxx driver and thought that I may get some help. I'm using Linux kernel 2.6 and plan to use the qla2xxx driver. The driver documentstion says it has the "qlascan" command which can help i

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-19 Thread Jens Axboe
On Wed, Apr 20 2005, Tejun Heo wrote: > 01_scsi_blk_make_started_requests_ordered.patch > > Reordering already started requests is without any real > benefit and causes problems if the request has its > driver-specific resources allocated (as in SCSI). This patch > makes e

Re: [PATCH scsi-misc-2.6 01/05] scsi: make blk layer set REQ_SOFTBARRIER when a request is dispatched

2005-04-19 Thread Tejun Heo
Jens Axboe wrote: On Wed, Apr 20 2005, Tejun Heo wrote: 01_scsi_blk_make_started_requests_ordered.patch Reordering already started requests is without any real benefit and causes problems if the request has its driver-specific resources allocated (as in SCSI). This patch