[PATCH RESEND 1/2] SCSI: use scsi_device-timeout consistently

2006-11-19 Thread Tejun Heo
Each high level driver uses scsi_device-timeout diffrently. * sd sets sdev-timeout to SD_TIMEOUT if it's zero on attach. sdev-timeout is used for commands received from block queue but internal commands use SD_TIMEOUT directly. * sr uses constant SR_TIMEOUT for all non-ioctl commands and

Re: [PATCH RESEND 2/2] SCSI: add scsi_device-retries

2006-11-19 Thread Kai Makisara
On Sun, 19 Nov 2006, Tejun Heo wrote: Add scsi_device-retries to provide generic control over command retries, which is very similar to sdev-timeout. The initial value is -1 and high level driver is free to override on attach if negative. Note that -1 has the same effect as 0 (no retry) and

Re: [PATCH RESEND 1/2] SCSI: use scsi_device-timeout consistently

2006-11-19 Thread Tejun Heo
Kai Makisara wrote: On Sun, 19 Nov 2006, Tejun Heo wrote: Each high level driver uses scsi_device-timeout diffrently. ... Index: scsi-misc-2.6/drivers/scsi/st.c === --- scsi-misc-2.6.orig/drivers/scsi/st.c +++

Re: [PATCH RESEND 2/2] SCSI: add scsi_device-retries

2006-11-19 Thread Tejun Heo
Hello, Kai Makisara wrote: * st uses three retry limits - MAX_RETRIES, MAX_WRITE_RETRIES and MAX_READY_RETRIES, which are all zero. This patch only converts MAX_RETRIES to sdev-retries. Defining WRITE and READY retries in terms of sdev-retries would make more sense. I am neither acking