RE: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Moore, Eric
On Tuesday, January 09, 2007 2:33 PM, Edward Goggin wrote: > multi-pathing. This requirement shouldn't be a problem for the IBM > RDAC/MPP driver either since it should already be setting the > REQ_FAILFAST attribute of I/Os for which it is providing > multi-pathing, > similar to what the Linux

[PATCH] megaraid: more kernel-doc fixes

2007-01-09 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> More megaraid kernel-doc fixes. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- drivers/scsi/megaraid/mbox_defs.h |2 +- drivers/scsi/megaraid/mega_common.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.20-rc3-mm1.orig

Re: description on KEYs in .config file

2007-01-09 Thread Randy Dunlap
On Tue, 9 Jan 2007 16:40:05 -0800 Allexio Ju wrote: > Hi, > > Where can I get detail description on each KEYs in .config file? > I'm trying to understand what are the meaning of those before turn thme > on/off. In the many Kconfig and Kconfig.* files in the kernel tree. Or by using one of the c

description on KEYs in .config file

2007-01-09 Thread Allexio Ju
Hi, Where can I get detail description on each KEYs in .config file? I'm trying to understand what are the meaning of those before turn thme on/off. Thanks in advance. Allexio - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] M

Re: REGRESSION: 2.6.20-rc3-git4: EIO not returned to direct i/o application following disk error

2007-01-09 Thread Michael Reed
More info. Linux duck 2.6.20-rc3-git4 #10 SMP PREEMPT Fri Jan 5 10:58:11 CST 2007 ia64 ia64 ia64 GNU/Linux For this test I used an Emulex host adapter, but the problem is not unique to it. It also occurs when the targets are connected to either LSI or QLogic adapters. Using O_DIRECT, once the

Re: PATCH: SNI RM 53c710 driver

2007-01-09 Thread Thomas Bogendoerfer
On Tue, Jan 02, 2007 at 11:52:41AM +, Christoph Hellwig wrote: > On Mon, Dec 25, 2006 at 09:32:04PM +0100, Thomas Bogendoerfer wrote: > > This patch adds a SCSI driver for the onboard 53c710 chip of some > > SNI RM machines. > > Nice, this looks really clean. I haven't seen the code to declar

Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Edward Goggin
On Tue, 2007-01-09 at 12:55 -0800, Petr Vandrovec wrote: > Adam Zimman wrote: > > Adding VMware engineering... > > > > -Original Message- > > From: Manon Goo [mailto:[EMAIL PROTECTED] > > Sent: Tuesday, January 09, 2007 9:49 AM > > To: Michael Reed; Moore, Eric; David Berghoff > > Cc: Ja

Fix the reproducible oops in scsi

2007-01-09 Thread OGAWA Hirofumi
I got the oops after some hotplug events. And the similar oops can reproduce by the following step. plug usb-storage (e.g. scsi_host of usb is "host5", and device is sde) # mount /dev/sde1 /mnt # echo 1 > /sys/block/sde/device/delete # echo - - - > /sys/class/scsi_host/host5/scan #

Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Petr Vandrovec
Adam Zimman wrote: Adding VMware engineering... -Original Message- From: Manon Goo [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 09, 2007 9:49 AM To: Michael Reed; Moore, Eric; David Berghoff Cc: James Bottomley; Adam Zimman; linux-scsi@vger.kernel.org; Shirron, Stephen Subject: Re

Re: [PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Andrew Vasquez
On Tue, 09 Jan 2007, Matthew Wilcox wrote: > On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote: > > Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding > > starget_for_each_device() calls. > > As Matthew W. pointed out, starget_for_each_device() can be called under > > a spinlock

Re: [PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Matthew Wilcox
On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote: > Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding > starget_for_each_device() calls. > As Matthew W. pointed out, starget_for_each_device() can be called under > a spinlock being held. > The change has been tested and verified

[PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Seokmann Ju
Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding starget_for_each_device() calls. As Matthew W. pointed out, starget_for_each_device() can be called under a spinlock being held. The change has been tested and verified on qla2xxx.ko module. Thanks Matthew W. and Hisashi H. for help. Sign

Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net]

2007-01-09 Thread Stephen Hemminger
On Tue, 09 Jan 2007 12:01:14 +0300 Dmitriy Monakhov <[EMAIL PROTECTED]> wrote: > network pci drivers have to return correct error code during resume stage in > case of errors. > Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> > - Please don't introduce one dev_err() call into a device dri

Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Manon Goo
Hmm why don't w make the whole thing configurable (david implemented this for us) +/* + * cmd line parameters + */ +static int mpt_mpi_busy; +module_param(mpt_mpi_busy, int, 0); +MODULE_PARM_DESC(mpt_mpi_busy, " MPT MPI busy workaround for VMWare ESX (default=0)"); + /*=-=-=-=-=-=-=-=-=

RE: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Adam Zimman
Adding VMware engineering... -Original Message- From: Manon Goo [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 09, 2007 9:49 AM To: Michael Reed; Moore, Eric; David Berghoff Cc: James Bottomley; Adam Zimman; linux-scsi@vger.kernel.org; Shirron, Stephen Subject: Re: [PATCH 2/5] fusion:

Re: [PATCH 2/5] fusion: vmware bug fix prevent inifinite retries

2007-01-09 Thread Michael Reed
Moore, Eric wrote: > On Monday, January 08, 2007 3:25 PM, James Bottomley wrote: > >> Right, I sort of suspected something like this. BUSY/QUEUE_FULL >> handling was a bit iffy in 2.4; but it was sorted out in the 2003/4 >> timeframe. Nowadays, I think you want to translate the >> MPI_SCSI_ST

Re: [PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]

2007-01-09 Thread Dmitriy Monakhov
Russell King <[EMAIL PROTECTED]> writes: > On Tue, Jan 09, 2007 at 12:01:58PM +0300, Dmitriy Monakhov wrote: >> serial pci drivers have to return correct error code during resume stage in >> case of errors. > > Sigh. *hate* *hate* *hate*. > >> diff --git a/drivers/serial/8250_pci.c b/drivers/seri

Re: [PATCH] SCSI core: better initialization for sdev->scsi_level

2007-01-09 Thread Alan Stern
On Mon, 8 Jan 2007, Douglas Gilbert wrote: > Alan Stern wrote: > > Both scsi_device and scsi_target include a scsi_level field, and the > > SCSI core makes a half-hearted effort to keep the values equal. > > Ultimately this effort may be doomed, since as far as I know there is > > no reason why al

Re: [PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]

2007-01-09 Thread Russell King
On Tue, Jan 09, 2007 at 12:01:58PM +0300, Dmitriy Monakhov wrote: > serial pci drivers have to return correct error code during resume stage in > case of errors. Sigh. *hate* *hate* *hate*. > diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c > index 52e2e64..e26e4a6 100644 > ---

Re: [PATCH] qla2xxx: spin_unlock_irq in IRQ context

2007-01-09 Thread Matthew Wilcox
On Tue, Jan 09, 2007 at 04:46:34PM +0900, Hisashi Hifumi wrote: > Hi > > >If the function can be called with interrupts disabled as well as > >enabled, then the spin_lock_irq needs to become a spin_lock_irqsave() > >which is the correct API for this case. > > I know that spin_lock_irqsave()/spin_

[PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]

2007-01-09 Thread Dmitriy Monakhov
serial pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/drivers/parport/parport_serial.c b/drivers/parport/parport_serial.c index 78c0a26..1e14906 100644 --- a/drivers/parport/parport_serial.c

[PATCH 4/5] fixing errors handling during pci_driver resume stage [misc]

2007-01-09 Thread Dmitriy Monakhov
pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/drivers/ide/pci/sc1200.c b/drivers/ide/pci/sc1200.c index ff80937..a426905 100644 --- a/drivers/ide/pci/sc1200.c +++ b/drivers/ide/pci/sc1200.c

[PATCH 3/5] fixing errors handling during pci_driver resume stage [fusion]

2007-01-09 Thread Dmitriy Monakhov
fusion pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 6e068cf..51a3621 100644 --- a/drivers/message/fusion/mptbase.c

[PATCH 2/5] fixing errors handling during pci_driver resume stage [ata]

2007-01-09 Thread Dmitriy Monakhov
ata pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index b517d24..0656334 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1372,7 +1372,9

[PATCH 1/5] fixing errors handling during pci_driver resume stage [net]

2007-01-09 Thread Dmitriy Monakhov
network pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov <[EMAIL PROTECTED]> - diff --git a/Makefile b/Makefile diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c index 80bdcf8..ed06e48 100644 --- a/drivers/net/3c59x.c +++

[PATCH 0/5] fixing errors handling during pci_driver resume stage

2007-01-09 Thread Dmitriy Monakhov
Where are several places where errors ignored during pci_driver resume stage. In most most cases return value of 'pci_enable_device()' was ignored. drivers from such subsystems affected: - ata - fusion - ide - mmc - net - parisc - parport - pci - serial - To unsubscribe from this list: se

Re: [PATCH] qla2xxx: spin_unlock_irq in IRQ context

2007-01-09 Thread Hisashi Hifumi
Hi >If the function can be called with interrupts disabled as well as >enabled, then the spin_lock_irq needs to become a spin_lock_irqsave() >which is the correct API for this case. I know that spin_lock_irqsave()/spin_unlock_irqrestore() is correct . But in this case, many places need to be mod