Got the following on executing tar tpf /dev/st0l on two different
systems (x86):
kernel BUG at mm/slab.c:597!
invalid opcode: [#1]
Modules linked in: sg st sym53c8xx netconsole tg3 e1000
CPU:0
EIP:0060:[c014b720]Not tainted VLI
EFLAGS: 00010246 (2.6.20.3-luna #1)
EIP is at
@@ -1768,7 +1781,8 @@ static void iscsi_start_session_recovery
* flush queues.
*/
spin_lock_bh(session-lock);
- fail_all_commands(conn);
+ fail_all_commands(conn,
+ STOP_CONN_RECOVER ? DID_BUS_BUSY : DID_ERROR);
[EMAIL PROTECTED] wrote:
fast_io_fail_tmo
iscsi: session recovery_tmo
fc: rport fast_io_fail_tmo
The difference is that when the timer fires, for iscsi we unblock the
queue and fail commands in the blocked queue. FC just fails IO running
in the driver/fw/hw. The IO in the blocked queue sits
Background:
The states, in the transport are:
event state
n/arunning
lose connectivityblocked
fastfail timeout still blocked, but with fastfail indicator
dev_loss timeout unblocked/removed
James Smart wrote:
@@ -1768,7 +1781,8 @@ static void iscsi_start_session_recovery
* flush queues.
*/
spin_lock_bh(session-lock);
-fail_all_commands(conn);
+fail_all_commands(conn,
+STOP_CONN_RECOVER ? DID_BUS_BUSY : DID_ERROR);
James Smart wrote:
Background:
The states, in the transport are:
event state
n/arunning
lose connectivityblocked
fastfail timeout still blocked, but with fastfail indicator
My patch changed this
ah OK.
At first glance, I didn't like simple addition of another flag. Although simple,
it grows data structures quickly. It seems more representative of a state flag,
or a iftest based on the state checking (e.g. we know we're blocked and whether
we have failfast pending). But this is
So my position changes a little now that you pointed out that you
release the request queue when fastfail kicks in.
Mike Christie wrote:
Do we want to fail IO that was sitting in the queue _and_ all new
incoming IO or just what was sitting in the queue?
I believe all i/o - so that the upper
The following 7 patches contain various updates described in each mail.
Patches apply to the scsi-misc-2.6 tree.
aachba.c | 386 ++-
aacraid.h |9 -
commctrl.c | 282 ++---
commsup.c | 106 +-
Received from Mark Salyzyn,
This patch updates the adapter restart function to deal with some
adapters that have specific IOP reset needs. Since the code for
restarting the adapter was in two places, changed over to utilizing a
platform function in one place.
Signed-off-by: Mark Haverkamp [EMAIL
Received from Mark Salyzyn,
This patch is to resolve a namespace issue that will result from a patch
expected in the future that adds a new interface; rationalized as
correcting a long term issue where hw_fib, instead of hw_fib_va, refers
to the virtual address space and hw_fib_pa refers to the
Received from Mark Salyzyn,
The aac_probe_container call blocks. This is an issue because it is called on
occasion in the context of the queuecommand handler. Once in a blue moon this
has resulted in a kernel panic sleeping during interrupt; or problems with some
embedded system versions of the
Received from Mark Salyzyn,
This little patch removes the ',cid)' container identification argument
from some of the functions. The argument is used in some cases as merely
a debug helper and thus not used, and in others, the value can be
quickly acquired from the scsi command in their single
Received from Mark Salyzyn,
Outstanding ioctl calls still have some problems with aborting cleanly
in the face of a reset iop recovery action should the adapter ever enter
into a Firmware Assert (BlinkLED) condition. The enclosed patch resolves
some uncovered flawed handling.
Signed-off-by: Mark
Received from Mark Salyzyn,
The raw srb ioctl is supposed to be able to take packets with 32 and 64 bit
virtual address SG elements, it did not handle the frames with 64 bit SG
elements well when communicating with 64 bit DMA capable adapters, and it did
not handle the 32 bit limited DMA adapters
Received from Mark Salyzyn,
This set of fixes improve error handling stability of the driver. A popular
manifestation of the problems is an NULL pointer reference in the interrupt
handler when referencing portions of the scsi command context, or in the
scsi_done handling when an offlined device
Received from Mark Salyzyn,
The aac_probe_container call blocks. This is an issue because it is called on
occasion in the context of the queuecommand handler. Once in a blue moon this
has resulted in a kernel panic sleeping during interrupt; or problems with some
embedded system versions of the
This is a note to let you know that I've just added the patch titled
Subject: sysfs and driver core: add callback helper, used by SCSI and S390
to my gregkh-2.6 tree. Its filename is
sysfs-and-driver-core-add-callback-helper-used-by-scsi-and-s390.patch
This tree can be found at
This patch (as868) adds a helper routine for device drivers that need
to set up a callback to perform some action in a different process's
context. This is intended for use by attribute methods that want to
unregister themselves or their parent device. Attribute method calls
are mutually
19 matches
Mail list logo
