Re: [patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Andrew Morton
On Thu, 05 Jul 2007 20:02:08 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > May I assume that I may delete the patches from Kristen, and assume that > you will resend an updated version of her AN and ALPM patches to me? > Sure. But I have a sneaking feeling that Kristen sneaks sneaky fixes int

Re: [patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Jeff Garzik
May I assume that I may delete the patches from Kristen, and assume that you will resend an updated version of her AN and ALPM patches to me? Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Jeff Garzik
Andrew Morton wrote: I guess we can bump ATA_DFLAG_CFG_MASK up to 12, like this? Yep Jeff - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Jeff Garzik
Andrew Morton wrote: On Thu, 5 Jul 2007 13:05:30 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: + ATA_DFLAG_IPM = (1 << 6), /* device supports interface PM */ ATA_DFLAG_CFG_MASK = (1 << 8) - 1, I had to bump this to (1<<7), so we've run out. You can sh

Re: [PATCH] Is it time to kill ide-scsi.c?

2007-07-05 Thread Jeff Garzik
Boaz Harrosh wrote: I have attempted (below) to convert ide-scsi to the new data accessors and cleanup the !use_sg code paths. Inspecting the code I can see places that still assume scsi_cmnd->request_buffer is a linear char pointer. Though I admit this assumption is hidden behind a flag "te

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread James Bottomley
On Fri, 2007-07-06 at 00:02 +0100, Al Viro wrote: > On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote: > > Since gendisk will now become part of struct scsi_device, we don't need > > to store this value in any private data structs where they already store > > scsi_device. Thi

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Al Viro
On Thu, Jul 05, 2007 at 06:09:27PM -0400, Douglas Gilbert wrote: > Since a scsi_device object is usually a SCSI logical unit, > one wonders why it would contain a gendisk object. Logical > units aren't necessarily disks, they might be enclosures or > just place holders that respond to an INQUIRY (e

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Al Viro
On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote: > Since gendisk will now become part of struct scsi_device, we don't need > to store this value in any private data structs where they already store > scsi_device. This series cleans up a few drivers which did this. What the

Re: [patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Andrew Morton
On Thu, 5 Jul 2007 15:33:34 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 5 Jul 2007 13:05:30 -0700 > Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > > > + ATA_DFLAG_IPM = (1 << 6), /* device supports interface PM */ > > ATA_DFLAG_CFG_MASK = (1 << 8) - 1, > >

Re: [patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Andrew Morton
On Thu, 5 Jul 2007 13:05:30 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > + ATA_DFLAG_IPM = (1 << 6), /* device supports interface PM */ > ATA_DFLAG_CFG_MASK = (1 << 8) - 1, I had to bump this to (1<<7), so we've run out. - To unsubscribe from this list: send

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Douglas Gilbert
Kristen Carlson Accardi wrote: > Since gendisk will now become part of struct scsi_device, we don't need > to store this value in any private data structs where they already store > scsi_device. This series cleans up a few drivers which did this. Since a scsi_device object is usually a SCSI logic

[patch 3/3] SCSI: st: remove gendisk from private data struct

2007-07-05 Thread Kristen Carlson Accardi
Since gendisk is now part of scsi_device, don't store this struct in private data struct Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/st.c === --- 2.6-git.orig/drivers/scsi/st.c +++ 2.6-git/d

[patch 2/3] SCSI: sr: remove gendisk from private data struct

2007-07-05 Thread Kristen Carlson Accardi
Since gendisk is now part of scsi_device, don't store this struct in private data struct Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-git.orig/drivers/scsi/sr.c +++ 2.6-git/

[patch 1/3] SCSI: osst: remove gendisk from private data struct

2007-07-05 Thread Kristen Carlson Accardi
Since gendisk is now part of scsi_device, don't store this struct in private data struct Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/osst.c === --- 2.6-git.orig/drivers/scsi/osst.c +++ 2.6-g

[patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Kristen Carlson Accardi
Since gendisk will now become part of struct scsi_device, we don't need to store this value in any private data structs where they already store scsi_device. This series cleans up a few drivers which did this. Kristen -- - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [SCSI] SD driver question

2007-07-05 Thread James Bottomley
On Wed, 2007-07-04 at 18:44 +0200, Gabriel C wrote: > Is there any reason why sd is printing the driver informations for each > disk twice in dmesg ? Yes, it's because of the genhd revalidate rework done by Al Viro in the block device revalidation path. The problem is that we need to run a disk

[PATCH 2/2] qla2xxx: add support for NPIV

2007-07-05 Thread Seokmann Ju
Following patch bump up the driver version reflecting NPIV addition to the qla2xxx. - version changed from 8.01.07-k7 to 8.02.00-k1. The patch has been inlined and attached in a plain text format as well just to provide alternative way for using it in the case where the inlined not working. Also,

[patch 4/4] Enable Aggressive Link Power management for AHCI controllers.

2007-07-05 Thread Kristen Carlson Accardi
This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci driver. This will cause the controller and disk to negotiate a lower power state for the link when there is no activity (see the AHCI 1.x spec for details). This feature is mutually exclusive with

[patch 3/4] Enable link power management for ata drivers

2007-07-05 Thread Kristen Carlson Accardi
libata drivers can define a function (enable_pm) that will perform hardware specific actions to enable whatever power management policy the user set up from the scsi sysfs interface if the driver supports it. This power management policy will be activated after all disks have been enumerated an

[patch 2/4] Expose Power Management Policy option to users

2007-07-05 Thread Kristen Carlson Accardi
This patch will modify the scsi subsystem to allow users to set a power management policy for the link. The scsi subsystem will create a new sysfs file for each host in /sys/class/scsi_host called "link_power_management_policy". This file can have 3 possible values: Value Meaning --

[patch 1/4] Store interrupt value

2007-07-05 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/ahci.c =

[patch 0/4] SATA power savings patches (ALPM)

2007-07-05 Thread Kristen Carlson Accardi
Hi Jeff, Here's the most recent patches for ALPM. These are also located at: http://www.kernel.org/pub/linux/kernel/people/kristen/patches/SATA/alpm These patches implement Aggressive Link Power management for AHCI controllers. This feature is described in detail in the AHCI 1.x spec. It provid

RE: [RFC 1/8] stex driver BROKEN

2007-07-05 Thread Lin Yu
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Boaz Harrosh > Sent: Thursday, July 05, 2007 6:43 AM > To: James Bottomley; FUJITA Tomonori; Andrew Morton; linux-scsi > Subject: [RFC 1/8] stex driver BROKEN > > > > I just comment out the code,

[PATCH] stex: use resid for xfer len information

2007-07-05 Thread Ed Lin
The original implementation in stex_ys_commands() is inappropriate. For xfer len information, we should use resid instead. Signed-off-by: Ed Lin <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index adda296..72f6d80 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scs

Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

2007-07-05 Thread Matthew Wilcox
On Thu, Jul 05, 2007 at 11:28:38AM -0700, Andrew Morton wrote: > Well you've sent it a couple of times, and I've sent it in five more times > over the past year. Once we were told "awaiting maintainer ack". > > This situation is fairly stupid. How about we make you the maintainer? Last time I l

Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

2007-07-05 Thread Andrew Morton
On Mon, 2 Jul 2007 13:39:17 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: > > Various PCI bus errors can be signaled by newer PCI controllers. > This patch adds the PCI error recovery callbacks to the Symbios > SCSI device driver. The patch has been tested, and appears to > work well. > y

RE: NPIV mapping problems (was Re: [PATCH 1/19] add data buffer accessors)

2007-07-05 Thread Seokmann Ju
On Wed, 2007-07-04 at 1:26 +0900, FUJITA Tomonori wrote: > On Fri, 29 Jun 2007 06:23:32 -0700 Andrew Vasquez wrote: > > One possiblity (the least intrusive) would be to add a > > scsi_dma_map_with_device() function which takes the proper (LLD > > defined) 'struct device' as a parameter, as was orig

Re: [SCSI] SD driver question

2007-07-05 Thread Uwe Kiewel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gabriel C schrieb: > Uwe Kiewel wrote: >> Please, can you tell the version of the kernel you use? I use: >> [EMAIL PROTECTED] ~]$ uname -r >> 2.6.21-1.3228.fc7 >> It is the current Fedora 7 kernel. >> >> > Sure. > > [EMAIL PROTECTED]:~$ uname -r >

Add Brownie 1200U3P to blacklist

2007-07-05 Thread Matthew Wilcox
On Thu, Jul 05, 2007 at 04:38:57PM +0200, Adrien Corbi?re wrote: > You've helped me last year with a bogus scsi device > (http://www.spinics.net/lists/linux-scsi/msg08048.html). I'm going to > work on another campus of my university, and i get the same problem with > a different model. I've added t

[RFC 8/8] Remove compatibility with unconverted drivers

2007-07-05 Thread Boaz Harrosh
Old IO members are removed from struct scsi_cmnd Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/scsi_error.c | 10 -- drivers/scsi/scsi_lib.c | 11 --- include/scsi/scsi_cmnd.h |5 - 3 files changed, 0 insertions(+), 26 deletions(-) diff --git

[RFC 7/8] sd.c and sr.c move to scsi_sgtable implementation

2007-07-05 Thread Boaz Harrosh
- sd and sr would adjust IO size to align on device's block size. So code needs to change once we move to scsi_sgtable implementation. (Not compatible with un-converted drivers) - Convert code to use scsi_for_each_sg - Use Data accessors wherever is appropriate. Signed-off-by: Boaz

[RFC 6/8] scsi_error.c move to scsi_sgtable implementation

2007-07-05 Thread Boaz Harrosh
- Careful considerations in scsi_send_eh_cmnd. Everything is kept on the stack as before. - This code is backward compatible with unconverted drivers. Compatibility will be removed in last patch. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/scsi_error.c | 46 ++

[RFC 4/8] scsi-ml: scsi_sgtable implementation

2007-07-05 Thread Boaz Harrosh
As proposed by James Bottomley all I/O members of struc scsi_cmnd and the resid member, which need to be duplicated for bidirectional transfers. Can be allocated together with the sg-list they are pointing to. This way when bidi comes the all structure can be duplicated with minimal chan

[RFC 5/8] Remove old code from scsi_lib.c

2007-07-05 Thread Boaz Harrosh
For easier viewing old code is removed in this patch. Also SCSI_MAX_PHYS_SEGMENTS is no longer used. Remove it. Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 55 -- include/scsi/scsi.h |7 -- inclu

[RFC 3/8] libata-scsi don't set max_phys_segments higher than scsi-ml

2007-07-05 Thread Boaz Harrosh
- The set can actually be removed completely as suggested by Tomo Boaz --- drivers/ata/libata-scsi.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index c228df2..13603a0 100644 --- a/drivers/ata/libata-scsi.c +++ b

[RFC 2/8] Restrict scsi accessors access to read-only

2007-07-05 Thread Boaz Harrosh
- Users of scsi_cmnd might not change sg_count bufflen or sglist. So reflect that in code. --- include/scsi/scsi_cmnd.h | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index 53e1705..aaf8282 100644 ---

[RFC 1/8] stex driver BROKEN

2007-07-05 Thread Boaz Harrosh
I just comment out the code, but now user-mode is broken what to do ?? --- drivers/scsi/stex.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c index adda296..935e2a6 100644 --- a/drivers/scsi/stex.c +++ b/drivers/scsi/stex.

[RFC 0/7] scsi_sgtable implementation

2007-07-05 Thread Boaz Harrosh
This is a proposed implementation of the scsi sg tables solution to scsi-ml in preparations for support of bidirectional scsi commands. A complete bidirectional solution on top of these patches can be found in the usual place: http://www.bhalevy.com/open-osd/download/sgtable_bidi_varlen It