Re: What does scsi_level mean?

2007-07-22 Thread jidong xiao
Any one can kindly explain this? Thanks Jason Xiao On 7/21/07, jidong xiao <[EMAIL PROTECTED]> wrote: I noticed that there is a char scsi_level in the struct scsi_device, what does scsi_level mean? struct scsi_device { ... char scsi_level; ... } Is it SCSI revision? If the answer is tr

Re: [PATCH 4/9] qla2xxx: Validate mid-layer 'underflow' during check-condition handling.

2007-07-22 Thread Boaz Harrosh
Andrew Vasquez wrote: > From: Shyam Sundar <[EMAIL PROTECTED]> > > Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> > --- > drivers/scsi/qla2xxx/qla_isr.c | 19 +++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/sc

Re: [PATCH 4/9] qla2xxx: Validate mid-layer 'underflow' during check-condition handling.

2007-07-22 Thread James Bottomley
On Sun, 2007-07-22 at 13:50 +0300, Boaz Harrosh wrote: > NACK. Breaks data buffers accessors patch. > (385d70b4e2659ae525a00e46a9f97146949cfc14) > should be: This isn't bad enough to eject the entire qla enhancement from the tree on the day the merge window closes to force a rewrite. > diff --gi

drivers/scsi/sym53c416.c - address of 'sym53c416*' will always evaluate as 'true' , warnings

2007-07-22 Thread Gabriel C
Hi, I got this warnings on current git with gcc 4.2.1 : ... drivers/scsi/sym53c416.c: In function 'sym53c416_detect': drivers/scsi/sym53c416.c:638: warning: the address of 'sym53c416' will always evaluate as 'true' drivers/scsi/sym53c416.c:644: warning: the address of 'sym53c416_1' will always

Re: [PATCH 4/9] qla2xxx: Validate mid-layer 'underflow' during check-condition handling.

2007-07-22 Thread Boaz Harrosh
James Bottomley wrote: > On Sun, 2007-07-22 at 13:50 +0300, Boaz Harrosh wrote: >> NACK. Breaks data buffers accessors patch. >> (385d70b4e2659ae525a00e46a9f97146949cfc14) >> should be: > > This isn't bad enough to eject the entire qla enhancement from the tree > on the day the merge window close

[PATCH] drivers/scsi/g_NCR5380.c - "NCR53C400_PSEUDO_DMA" is not defined

2007-07-22 Thread Gabriel C
Hi, got this warning with current git : ... In file included from drivers/scsi/g_NCR5380_mmio.c:9: drivers/scsi/g_NCR5380.c:559:5: warning: "NCR53C400_PSEUDO_DMA" is not defined ... Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi

drivers/scsi/ultrastor.c - matching constraint does not allow a register , warnings

2007-07-22 Thread Gabriel C
Hi, I got this warnings on current git with gcc 4.2.1 : ... drivers/scsi/ultrastor.c: In function 'find_and_clear_bit_16': drivers/scsi/ultrastor.c:303: warning: matching constraint does not allow a register drivers/scsi/ultrastor.c:302: warning: matching constraint does not allow a register d

Re: drivers/scsi/sym53c416.c - address of 'sym53c416*' will always evaluate as 'true' , warnings

2007-07-22 Thread Matthew Wilcox
On Sun, Jul 22, 2007 at 03:52:21PM +0200, Gabriel C wrote: > drivers/scsi/sym53c416.c: In function 'sym53c416_detect': > drivers/scsi/sym53c416.c:638: warning: the address of 'sym53c416' will always > evaluate as 'true' > drivers/scsi/sym53c416.c:644: warning: the address of 'sym53c416_1' will >

Re: drivers/scsi/sym53c416.c - address of 'sym53c416*' will always evaluate as 'true' , warnings

2007-07-22 Thread Gabriel C
Matthew Wilcox wrote: > On Sun, Jul 22, 2007 at 03:52:21PM +0200, Gabriel C wrote: >> drivers/scsi/sym53c416.c: In function 'sym53c416_detect': >> drivers/scsi/sym53c416.c:638: warning: the address of 'sym53c416' will >> always evaluate as 'true' >> drivers/scsi/sym53c416.c:644: warning: the addre

[PATCH] Fix drivers/scsi/fdomain.c , CONFIG_PCI=n warnings

2007-07-22 Thread Gabriel C
Hi, I get this warnings on current git when CONFIG_PCI is not set : ... drivers/scsi/fdomain.c:390: warning: 'PCI_dev' defined but not used drivers/scsi/fdomain.c:1768: warning: 'fdomain_pci_tbl' defined but not used ... Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- diff --git

[PATCH] libsas: make ATA functions selectable by a config option

2007-07-22 Thread James Bottomley
Not everyone wants libsas automatically to pull in libata. This patch makes the behaviour configurable, so you can build libsas with or without ATA support. James diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig index aafdc92..1d6efef 100644 --- a/drivers/scsi/libsas/Kconfi

[GIT PATCH] final piece of the SCSI merge for 2.6.22

2007-07-22 Thread James Bottomley
This final piece contains driver updates (mainly qla2xx and the long delayed ATA update for libsas) plus fix ups for bsg which Jens and Tomo want to take through the scsi tree. The patch is available here: master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git The short changelog is:

Re: What does scsi_level mean?

2007-07-22 Thread Randy Dunlap
On Sun, 22 Jul 2007 18:42:14 +0800 jidong xiao wrote: > Any one can kindly explain this? > > Thanks > Jason Xiao > > On 7/21/07, jidong xiao <[EMAIL PROTECTED]> wrote: > > I noticed that there is a char scsi_level in the struct scsi_device, > > what does scsi_level mean? > > > > struct scsi_devi

Re: [patch 3/3] scsi: wd33c93 needs

2007-07-22 Thread Al Viro
On Fri, Jul 20, 2007 at 11:50:50AM -0600, Matthew Wilcox wrote: > On Fri, Jul 20, 2007 at 09:43:47PM +0400, Sergei Shtylyov wrote: > > Hello Christoph: > > > > >>>+#include > > > > >>These days that should probably be . > > > > >Not at all, linux/irq.h is something entirely different. > > > >

Re: [PATCH 4/9] qla2xxx: Validate mid-layer 'underflow' during check-condition handling.

2007-07-22 Thread Andrew Vasquez
On Sun, 22 Jul 2007, Boaz Harrosh wrote: > From: Boaz Harrosh <[EMAIL PROTECTED]> > Date: Sun, 22 Jul 2007 17:24:18 +0300 > Subject: [PATCH] qla2xxx: Data accessors Cleanup of last merge > > - Left overs from last code merges of qla2xxx > > Sign-off-by: Boaz Harrosh <[EMAIL PROTECTED]> Than

[PATCH 2/2] ibmvscsi: use shost_priv

2007-07-22 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/ibmvscsi/ibmvscsi.c | 34 +++--- 1 files changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 6735260..65f7fc1 100644 ---

[PATCH 1/2] ibmvscsi: remove unnecessary map_sg check

2007-07-22 Thread FUJITA Tomonori
No need to check use_sg since sg_tablesize is set appropriately in the scsi host template. Brian King's patch (2a7309372fe56ae46c499b772d811ad31c501dd9) did this cleanup but the data buffer accessors patch (written before the patch and merged after it) restored the check. Signed-off-by: FUJITA To

2.6.23 regression: lpfc_sli.c: off-by-10

2007-07-22 Thread Adrian Bunk
The Coverity checker spotted the following off-by-10 in drivers/scsi/lpfc/lpfc_sli.c: <-- snip --> ... static int lpfc_sli_process_unsol_iocb(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, struct lpfc_iocbq *saveq) { ... saveq->context3

[PATCH 1/2] bsg: use lib/idr.c to find a unique minor number

2007-07-22 Thread FUJITA Tomonori
This replaces the current linear search for a unique minor number with lib/idr.c. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c | 69 ++ include/linux/bsg.h |1 - 2 files changed, 30 insertions(+), 40 deletions(-)

[PATCH 2/2] bsg: remove unnecessary code and comments

2007-07-22 Thread FUJITA Tomonori
- kill uhdr in bsg_command structure - it's not necessary to put SG v4 stuff to block/scsi_ioctl.c Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- block/bsg.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index f0259c2..2b5e72b 1

[PATCH] simscsi: convert to use the data buffer accessors

2007-07-22 Thread FUJITA Tomonori
- remove the unnecessary map_single path. - convert to use the new accessors for the sg lists and the parameters. Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- arch/ia64/hp/sim/simscsi.c | 66 ++-- 1 files changed, 15 insertions(+), 51 deletions

[PATCH] ps3rom: convert to use the data buffer accessors

2007-07-22 Thread FUJITA Tomonori
This is against Linus' tree since scsi-misc doesn't include ps3rom driver yet. --- From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: [PATCH] ps3rom: convert to use the data buffer accessors This converts ps3rom driver to use the new accessors for the sg lists and the parameters. Signed-off-by:

Re: [PATCH 1/2] bsg: use lib/idr.c to find a unique minor number

2007-07-22 Thread Jens Axboe
On Mon, Jul 23 2007, FUJITA Tomonori wrote: > This replaces the current linear search for a unique minor number with > lib/idr.c. > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> Awesome, that's a very nice improvement both for code and performance. Acked-by: Jens Axboe <[EMAIL PROTECTED]>