Re: unexpected scsi timeout

2007-07-24 Thread Albert Lee
Vasily Averin wrote: > Tejun Heo wrote: > >>[cc'ing Albert] >> >>Vasily Averin wrote: >> >>>Tejun, Jeff >>> >>>I've noticed that some scsi commands for DVD-drive attached to pata_via >>>successfully finishes without any delays but reports about TIMEOUT >>>condition. It >>>happens because of ATA_E

Re: [PATCH 3/5] mpt fusion: Changes in mptscsih.c for logging support

2007-07-24 Thread Prakash, Sathya
Resubmitting the patch with the following change: In function mptscsih_info_scsiio(), the bufflen and resid fields of the Scsi_cmnd structure were accessed directly in the previous patch. In this modified patch data accessor functions are used to access those fields. signed-off-by: Sathya Prakas

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-24 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Tue, 24 Jul 2007 18:22:08 -0600 > > > I'm not sure what the intent of this else case. > > > > This code is for an "invisible" SMP target in LSI SAS HBAs. There are > > better ways to

Re: [Bug 8366] aic79xx and aic7xxx driver issues

2007-07-24 Thread James Bottomley
On Tue, 2007-07-24 at 18:05 -0700, [EMAIL PROTECTED] wrote: > --> (http://bugzilla.kernel.org/attachment.cgi?id=12126&action=view) > failed driver dmesg > > This driver fails at time of boot up. there are many scsi errors shown in the > output. It is the "new" aic7xxx driver. This is about the

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Wed, 25 Jul 2007 11:09:21 +1000 Paul Mackerras <[EMAIL PROTECTED]> wrote: > Also, I prefer the style where the ? and : operators have a space > after them but not before them, rather than a space either side. Could I point out that your likes and dislikes are immaterial? The whole point here

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Paul Mackerras
Andy Whitcroft writes: > Ok, this is something we need to decide on. Currently we only ask for > consistent spacing on all the mathematic operators. This is mostly as > we do see a large number of non-spaced uses in defines and the like. > > I am happy to expand these tests so they are always s

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-24 Thread FUJITA Tomonori
From: "Moore, Eric" <[EMAIL PROTECTED]> Subject: RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg Date: Tue, 24 Jul 2007 18:22:08 -0600 > On Monday, July 23, 2007 11:28 PM, FUJITA Tomonori wrote: > > > > > With 2.6.23-rc1 + mptsas smp patch, you get directories /sys/class/bsg > > like

RE: [PATCH 3/3] mptsas: add SMP passthrough support via bsg

2007-07-24 Thread Moore, Eric
On Monday, July 23, 2007 11:28 PM, FUJITA Tomonori wrote: > > With 2.6.23-rc1 + mptsas smp patch, you get directories /sys/class/bsg > like: I hadn't enabled bsg support in the linux kernel, that was my problem. > > # ./sgv4-tools/smp_rep_manufacturer /sys/class/bsg/expander-0:1 > > > I thin

[PATCH] qla4xxx: use mempool_create_slab_pool

2007-07-24 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> --- drivers/scsi/qla4xxx/ql4_os.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index e69160a..15ff730 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/driv

RE: [PATCH 3/5] mpt fusion: Changes in mptscsih.c for logging support

2007-07-24 Thread Moore, Eric
On Tuesday, July 24, 2007 4:31 AM, Boaz Harrosh wrote: > > NACK > This driver was already converted to accessors please > don't use old (going a way soon) scsi_cmnd members > directly > Sathya - a little background on this. I believe this all started with the "Proposals to change the way all d

Re: QLGC,ISP SCSI driver not finding attached devices

2007-07-24 Thread David Miller
From: Mark Fortescue <[EMAIL PROTECTED]> Date: Tue, 24 Jul 2007 22:28:42 +0100 (BST) > I thought I rememberd seeing somthing about memset. > > Having changed the memset code, I have found that the ESP scsi BUS > Timeout can be reverted back to 250ms. Both SCSI drivers are now working > properly

Re: QLGC,ISP SCSI driver not finding attached devices

2007-07-24 Thread Mark Fortescue
Hi David and James, Thank you for your help in investigating the issues I have been having. I thought I rememberd seeing somthing about memset. Having changed the memset code, I have found that the ESP scsi BUS Timeout can be reverted back to 250ms. Both SCSI drivers are now working properly

Re: [PATCH RFC] qla2xxx: fix ignored size and offset parameters in qla2x00_sysfs_read_[nvram vpd]

2007-07-24 Thread Seokmann Ju
Richard A Lary wrote: > From: Richard Lary <[EMAIL PROTECTED]> > > This patch fixes Segmemtation fault which occurs when executing: > #udevinfo -a -p /sys/class/scsi_host/{qla2xxx_host} > > The qla2xxx driver ignores the size and offset parameters when > reading nvram and vpd attributes. Thank yo

Re: QLGC,ISP SCSI driver not finding attached devices

2007-07-24 Thread David Miller
From: Mark Fortescue <[EMAIL PROTECTED]> Date: Tue, 24 Jul 2007 18:46:06 +0100 (BST) > Looking into the issue a bit further, it turns out the the Sparc32 memset > is broaken - it does not always set the last byte. As a result, the > Control Field is set to random value (0xE0 in this case). This

Re: QLGC,ISP SCSI driver not finding attached devices

2007-07-24 Thread Mark Fortescue
Hi all, Timing does not apear to be an issue. I have checked all the udelay/msleep calls I could find and thoes that get called are delaying by the correct delay (4 to 7us > specified value). I have added some more debugging info and it looks like somthing is getting corrupted in the INQUIRY

Re: [PATCH] Enable 16-bit CDBs for aic7xxx/aic79xxx

2007-07-24 Thread James Bottomley
On Mon, 2007-07-23 at 10:47 +0200, Hannes Reinecke wrote: > Hi James, > > this patch enables 16-bit CDBs for aic7xxx and aic79xx. aic7xxx actuallys > supports up to 32-bit CDBs, so it might be that aic79xx does that, too. > But this would include some more hacking, so this is way easier. > > Plea

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andrew Morton
On Tue, 24 Jul 2007 08:37:09 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Andy Whitcroft wrote: > > Andrew Morton wrote: > > > >>> + start_sector = req->sector*priv->blocking_factor; > >>> + sectors = req->nr_sectors*priv->blocking_factor; > >> s/*/ * /. checkpatch missed this. > > > > Ok, th

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread James Bottomley
On Tue, 2007-07-24 at 17:01 +0300, Benny Halevy wrote: > FUJITA Tomonori wrote: > > I should have said that, was the approach to use separate buffer for > > sglists instead of putting the sglists and the parameters in one > > buffer completely rejected? > > I think that James should be asked this

[PATCH] libsas: SMP request handler shouldn't crash when rphy is NULL

2007-07-24 Thread Darrick J. Wong
sas_smp_handler crashes when smp utils are used with an aic94xx host because certain devices (the sas_host itself, specifically) lack rphy structures. No rphy means no SMP target support, but we shouldn't crash here. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/scsi/libsas/sas

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-24 Thread Randy Dunlap
On Tue, 24 Jul 2007 13:12:19 +0300 Boaz Harrosh wrote: > Randy Dunlap wrote: > > I prefer either of the !HIGHMEM or slave_alloc changes to adding > > a BUG_ON(). However, the SCSI people likely won't want to use the > > slave_alloc() change because then the driver may never get fixed. > > (Of cou

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread Benny Halevy
FUJITA Tomonori wrote: > I should have said that, was the approach to use separate buffer for > sglists instead of putting the sglists and the parameters in one > buffer completely rejected? I think that James should be asked this question. My understanding was that he preferred allocating the sgt

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andreas Schwab wrote: Jeff Garzik <[EMAIL PROTECTED]> writes: Andy Whitcroft wrote: Andrew Morton wrote: + start_sector = req->sector*priv->blocking_factor; + sectors = req->nr_sectors*priv->blocking_factor; s/*/ * /. checkpatch missed this. Ok, this is something we need to de

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread FUJITA Tomonori
From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Tue, 24 Jul 2007 20:12:47 +0900 > From: Boaz Harrosh <[EMAIL PROTECTED]> > Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large > IO s

Re: 2.6.23 regression: lpfc_sli.c: off-by-10

2007-07-24 Thread James Smart
Adrian, Thanks. Syntax-wise, it is incorrect. However there's no risk. The datastructure its indexing into is a union, and its size is sufficient for the index. The union supports old and new firmware interfaces. We mistakenly used the array for the old interface and should have used the (large

[PATCH RFC] qla2xxx: fix ignored size and offset parameters in qla2x00_sysfs_read_[nvram vpd]

2007-07-24 Thread Richard A Lary
From: Richard Lary <[EMAIL PROTECTED]> This patch fixes Segmemtation fault which occurs when executing: #udevinfo -a -p /sys/class/scsi_host/{qla2xxx_host} The qla2xxx driver ignores the size and offset parameters when reading nvram and vpd attributes. Signed-off-by: Richard Lary <[EMAIL PROTECT

Re: [PATCH AB1/5] SCSI: SG pools allocation cleanup.

2007-07-24 Thread Boaz Harrosh
Boaz Harrosh wrote: > First patch will not apply on scsi-misc-2.6 because there > is a missing NULL in the call to kmem_cache_create(). (linux-2.6.23-rcx) > (If any one need a patchset for that please ask) It will have more problems if Jens's: ac133644304cd1721dfb77193e0502f8afd4ea9b - scsi: simpl

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andreas Schwab
Jeff Garzik <[EMAIL PROTECTED]> writes: > Andy Whitcroft wrote: >> Andrew Morton wrote: >> + start_sector = req->sector*priv->blocking_factor; + sectors = req->nr_sectors*priv->blocking_factor; >>> s/*/ * /. checkpatch missed this. >> >> Ok, this is something we need to decide on.

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Jeff Garzik
Andy Whitcroft wrote: Andrew Morton wrote: + start_sector = req->sector*priv->blocking_factor; + sectors = req->nr_sectors*priv->blocking_factor; s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all th

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andy Whitcroft
Andrew Morton wrote: >> +start_sector = req->sector*priv->blocking_factor; >> +sectors = req->nr_sectors*priv->blocking_factor; > > s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators

Re: [PATCH] unexport sg v3 helper functions

2007-07-24 Thread Jens Axboe
On Tue, Jul 24 2007, Douglas Gilbert wrote: > Jens Axboe wrote: > > On Mon, Jul 23 2007, Douglas Gilbert wrote: > >> Jens Axboe wrote: > >>> On Sun, Jul 22 2007, FUJITA Tomonori wrote: > blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were > exported for bsg, however bsg

Re: SCSI support broken in latest 2.4 kernel

2007-07-24 Thread Matthew Wilcox
On Tue, Jul 24, 2007 at 11:33:33AM +0300, Abdelrahman wrote: > It seems impossible to compile the latest 2.4.35.6 kernel with the > scsi_mod module and produce a usable system. I have used the attached > config file and the normal compile procedure (make dep; make bzImage; > make modules) and ended

Re: [PATCH] unexport sg v3 helper functions

2007-07-24 Thread Douglas Gilbert
Jens Axboe wrote: > On Mon, Jul 23 2007, Douglas Gilbert wrote: >> Jens Axboe wrote: >>> On Sun, Jul 22 2007, FUJITA Tomonori wrote: blk_fill_sghdr_rq, blk_unmap_sghdr_rq, and blk_complete_sghdr_rq were exported for bsg, however bsg was changed to support only sg v4. Signed-off-

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Tue, 24 Jul 2007 13:01:34 +0300 > FUJITA Tomonori wrote: > > From: Boaz Harrosh <[EMAIL PROTECTED]> > > Subject: [PATCHSET 0/5] Peaceful co-existence of scsi_sgt

Re: [PATCH 3/5] mpt fusion: Changes in mptscsih.c for logging support

2007-07-24 Thread Boaz Harrosh
Prakash, Sathya wrote: > This patch contains changes in mptscsih.c to support logging in MPT fusion > drivers. > > The changes are majorly in debug printks, the existing debugprintk are > modified accroding to new debug macros defined in the file mptbdebug.h > > A new sysfs attribute is added to

Re: [PATCH] Enable 16-bit CDBs for aic7xxx/aic79xxx

2007-07-24 Thread Benny Halevy
Just wondering, have you tried testing it with our patches to support long cdb? If not, it would be great if you could try doing that. A snapshot of them is in http://www.bhalevy.com/open-osd/download/sgtable_bidi_varlen/ Benny Hannes Reinecke wrote: > Hannes Reinecke wrote: >> Hi James, >> >>

[PATCH 5/5] mpt fusion: Changes in mptctl.c for logging support

2007-07-24 Thread Prakash, Sathya
This patch contains changes in mptctl.c to support logging in MPT fusion drivers The changes are majorly in debug printks, the existing debugprintk are modified accroding to new debug macros defined in the file mptbdebug.h signed-off-by: Sathya Prakash <[EMAIL PROTECTED]> --- diff -Naurp b/driv

[PATCH 4/5] mpt fusion: Changes in mptfc.c mptlan.c mptsas.c and mptspi.c for logging support

2007-07-24 Thread Prakash, Sathya
This patch contains changes in mptfc.c, mptlan.c, mptsas.c and mptspi.c to support logging in MPT fusion drivers. The changes are majorly in debug printks, the existing debugprintk are modified accroding to new debug macros defined in the file mptbdebug.h signed-off-by: Sathya Prakash <[EMAIL PR

[PATCH 3/5] mpt fusion: Changes in mptscsih.c for logging support

2007-07-24 Thread Prakash, Sathya
This patch contains changes in mptscsih.c to support logging in MPT fusion drivers. The changes are majorly in debug printks, the existing debugprintk are modified accroding to new debug macros defined in the file mptbdebug.h A new sysfs attribute is added to retrieve and modify the debug level.

[PATCH 2/5] mpt fusion: Changes in mptbase.c for logging support

2007-07-24 Thread Prakash, Sathya
This patch contains changes in mptbase.c to support logging in MPT fusion drivers. The changes are majorly in debug printks, the existing debugprintk are modified accroding to new debug macros defined in the file mptbdebug.h A new module parameter mpt_debug_level is added to pass the debug level

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-24 Thread Boaz Harrosh
Randy Dunlap wrote: > I prefer either of the !HIGHMEM or slave_alloc changes to adding > a BUG_ON(). However, the SCSI people likely won't want to use the > slave_alloc() change because then the driver may never get fixed. > (Of course, it hasn't got fixed with the BUG happening either.) > > Anyw

[PATCH 1/5] mpt fusion: Changes for logging support in Kconfig, Makefile, mptbase.h and addition of mptdebug.h

2007-07-24 Thread Prakash, Sathya
This patch adds a new file mptdebug.h in the fusion source directory, which contains different debug macros. The existing debug macros and flags are removed from the mptbase.h and Makefile In Kconfig a new configuration parameter FUSION_LOGGING is added to enable/disable the logging support durin

[PATCH 0/5] mpt fusion: Add logging support

2007-07-24 Thread Prakash, Sathya
The patches in this patch set adds support for logging facility that can be used to debug a number of Fusion MPT related problems. The logging support can be enabled or disabled changing the kernel configuration flag CONFIF_FUSION_LOGGING The debug level can be programmed on the fly via SysFS (he

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread Boaz Harrosh
FUJITA Tomonori wrote: > From: Boaz Harrosh <[EMAIL PROTECTED]> > Subject: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO > sg-chaining > Date: Tue, 24 Jul 2007 11:47:50 +0300 > >> As Jens said, there is nothing common to scsi_sgtable and >> sglists. Save the fact that it is a

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Tue, 24 Jul 2007 11:47:50 +0300 > As Jens said, there is nothing common to scsi_sgtable and > sglists. Save the fact that it is a massive conflict at > scsi-ml. Th

[PATCH B3/5] SCSI: scsi_sgtable over sg-chainning

2007-07-24 Thread Boaz Harrosh
As proposed by James Bottomley all I/O members of struct scsi_cmnd and the resid member, which need to be duplicated for bidirectional transfers. Can be allocated together with the sg-list they are pointing to. This way when bidi comes the structure can be duplicated with minimal change

[PATCH B2/5] SCSI: support for allocating large scatterlists

2007-07-24 Thread Boaz Harrosh
A slightly revised sg-chaining patch to accommodate for the cleanup of sg-pools allocations. from Jens: This is what enables large commands. If we need to allocate an sgtable that doesn't fit in a single page, allocate several SCSI_MAX_SG_SEGMENTS sized tables and ch

[PATCH A3/5] SCSI: sg-chaining over scsi_sgtable

2007-07-24 Thread Boaz Harrosh
Based on Jens code for sg-chaining but over scsi_sgtable implementation - Previous scsi_{alloc,free}_sgtable() renamed to scsi_{alloc,free}_sgtable_page() - scsi_{alloc,free}_sgtable() using the above now supports sg-chaining with multiple sgtable allocations. - Report arbitrary

[PATCH A2/5] SCSI: scsi_sgtable implementation

2007-07-24 Thread Boaz Harrosh
As proposed by James Bottomley all I/O members of struct scsi_cmnd and the resid member, which need to be duplicated for bidirectional transfers. Can be allocated together with the sg-list they are pointing to. This way when bidi comes the structure can be duplicated with minimal change

[PATCH AB1/5] SCSI: SG pools allocation cleanup.

2007-07-24 Thread Boaz Harrosh
- The code Automatically calculates at compile time the maximum size sg-array that will fit in a memory-page and will allocate pools of BASE_2 size, up to that maximum size. - split scsi_alloc() into an helper scsi_sgtable_index() that will return the index of the pool for a given

[PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-07-24 Thread Boaz Harrosh
As Jens said, there is nothing common to scsi_sgtable and sglists. Save the fact that it is a massive conflict at scsi-ml. They touch all the same places. Proposed is a simple way out. Two patchsets That produce the same output at the end. One: scsi_sgtable_than_sg-chaining Two: sg-chaining_tha

SCSI support broken in latest 2.4 kernel

2007-07-24 Thread Abdelrahman
Dear Kernel Maintainer, It seems impossible to compile the latest 2.4.35.6 kernel with the scsi_mod module and produce a usable system. I have used the attached config file and the normal compile procedure (make dep; make bzImage; make modules) and ended up with unloadable modules (unresolved symb

Re: unexpected scsi timeout

2007-07-24 Thread Tejun Heo
[cc'ing Albert] Vasily Averin wrote: > Tejun, Jeff > > I've noticed that some scsi commands for DVD-drive attached to pata_via > successfully finishes without any delays but reports about TIMEOUT condition. > It > happens because of ATA_ERR bit is set in status register. As result for each > com