Re: [PATCH 1/2] zfcp: whitespace cleanup

2007-09-08 Thread Heiko Carstens
/* - * function: + * function: * - * purpose: + * purpose: * * returns: If you do a whitespace cleanup you might as well kill these lines. They don't contain that much information... ;) - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH 2/2] zfcp: zfcp: add statistics and other zfcp relatedinformation to sysfs

2007-09-08 Thread Heiko Carstens
+dev_set_drvdata(adapter-stat_services, adapter); + +if (device_register(adapter-stat_services)) +goto services_failed; + +if (zfcp_sysfs_statistic_services_create_files(adapter-stat_services)) +{ +device_unregister(adapter-stat_services); Sorry,

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-08 Thread Christoph Hellwig
On Wed, Sep 05, 2007 at 02:27:02PM -0700, Anil Veerabhadrappa wrote: This is a very tricky proposal as this header file is automatically generated by a well defined process and is shared between various driver supporting multiple platform/OS and the firmware. If it is not of a big issue I

Re: [Linux-usb-users] usb-storage and Motorola Z6

2007-09-08 Thread Peter Rasmussen
Alan Stern wrote: On Fri, 7 Sep 2007, Peter Rasmussen wrote: I'm sorry if this is a little late, but I had once had access to a Z6 and believe I had it successfully connected to my Linux host, and was therefore puzzled by this message exchange. I have now borrowed the device again for

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Andi Kleen
Folkert van Heusden [EMAIL PROTECTED] writes: Hi, Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected? This has also bitten me one or two times. A reasonable

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Randy Dunlap
On 08 Sep 2007 18:07:00 +0200 Andi Kleen wrote: Folkert van Heusden [EMAIL PROTECTED] writes: Hi, Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Matthew Wilcox
On Sat, Sep 08, 2007 at 09:50:08AM -0700, Randy Dunlap wrote: On 08 Sep 2007 18:07:00 +0200 Andi Kleen wrote: This has also bitten me one or two times. A reasonable way would be to just select SD automatically for !EMBEDDED I'd say that someone needs to use a vendor kernel, or at least

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-08 Thread Anil Veerabhadrappa
On Sat, 2007-09-08 at 07:49 -0700, Michael Chan wrote: Christoph Hellwig wrote: Most of it should just go away, and the other bits shouldn't change over the lifetime of the driver except for additions. So there really isn't any point in auto-generating it. Yes, I agree with

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Andi Kleen
I'd say that someone needs to use a vendor kernel, or at least begin with a vendor .config file... Vendor kernels tend to compile forever and require initrds. For just testing a kernel quickly compiling only a few drivers in is much more convenient. Also when you've been using CONFIG_IDE

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Stefan Richter
Andi Kleen wrote: when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk. Switching to different drivers without reading the help text? Tough. -- Stefan Richter -=-=-=== =--= -=--- http://arcgraph.de/sr/ - To unsubscribe from this list:

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Andi Kleen
On Sat, Sep 08, 2007 at 08:30:06PM +0200, Stefan Richter wrote: Andi Kleen wrote: when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk. Switching to different drivers without reading the help text? Tough. The individual driver

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Stefan Richter
Andi Kleen wrote: On Sat, Sep 08, 2007 at 08:30:06PM +0200, Stefan Richter wrote: Andi Kleen wrote: when you've been using CONFIG_IDE before it is not completely obvious you need BLK_SD for your hard disk. Switching to different drivers without reading the help text? Tough. The individual

Re: [Linux-usb-users] usb-storage and Motorola Z6

2007-09-08 Thread Alan Stern
On Sat, 8 Sep 2007, Peter Rasmussen wrote: In fact there was another patch from earlier in the email thread, which was needed to work around the PQ = 1 problem. Since you didn't apply that patch, the SCSI disk driver wasn't bound to your Z6. Now I applied that patch, too, and it