Re: [PATCH 09/24] libata-scsi: convert to use the data buffer accessors

2007-09-12 Thread Boaz Harrosh
On 9/12/07, Matthew Dharm [EMAIL PROTECTED] wrote: On Tue, Sep 11, 2007 at 08:09:51PM -0400, Jeff Garzik wrote: I would much rather see the !use_sg cleanup in a separate patch series... Are we really sure this can all go? No requests, not even ones from SG_IO will ever use the non-sg paths?

Re: [PATCH 07/24] arm: scsi convert to accessors and !use_sg cleanup

2007-09-12 Thread Russell King
On Wed, Sep 12, 2007 at 02:55:19AM +0300, Boaz Harrosh wrote: - if (SCpnt-request_bufflen != len) + if (scsi_bufflen(SCpnt) != len) { + WARN_ON(1); NAK. The call trace generally doesn't provide any additional information on the cause of the error.

Re: [PATCH ver2 5/5] arm: fas216 Use scsi_eh API for REQUEST_SENSE invocation

2007-09-12 Thread Russell King
On Mon, Sep 10, 2007 at 10:39:11PM +0300, Boaz Harrosh wrote: - Use new scsi_eh_prep/restor_cmnd() for synchronous REQUEST_SENSE invocation. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/arm/fas216.c | 16 +++- drivers/scsi/arm/fas216.h |3 +++

Re: [PATCH ver2 5/5] arm: fas216 Use scsi_eh API for REQUEST_SENSE invocation

2007-09-12 Thread Benny Halevy
Russell King wrote: On Mon, Sep 10, 2007 at 10:39:11PM +0300, Boaz Harrosh wrote: - Use new scsi_eh_prep/restor_cmnd() for synchronous REQUEST_SENSE invocation. Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] --- drivers/scsi/arm/fas216.c | 16 +++-

Re: [patchset 0/24] Lots of the Accessors patches and !use_sg cleanup

2007-09-12 Thread Maciej W. Rozycki
On Tue, 11 Sep 2007, Boaz Harrosh wrote: [esp family] - Maciej W. Rozycki [EMAIL PROTECTED] 0020 drivers/scsi/NCR53C9x.c drivers/scsi/NCR53C9x.h drivers/scsi/dec_esp.c drivers/scsi/oktagon_esp.c drivers/scsi/sun3x_esp.c Not really, but I have suitable hardware and can test your

[PATCH] scsi: use notifier chain for Asynchronous Event Notification

2007-09-12 Thread Kristen Carlson Accardi
Add a notifier chain for SCSI asynchronous events. Add a notifier block for events which should be sent to user space, and add support for the MEDIA_CHANGE event, which would be used by a driver when new media has been inserted. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- This

Re: Problems with USB disk [solved]

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 06:10:50PM -0400, Mark Lord wrote: Chuck Ebbert wrote: On 08/13/2007 10:50 AM, Niels wrote: On Sunday 12 August 2007 11:54, Niels wrote: On Friday 10 August 2007 14:43, Niels wrote: On Wednesday 08 August 2007 12:57, Ismail D??nmez wrote: On Wednesday 08 August