Re: What still uses the block layer?

2007-10-15 Thread Greg KH
On Sun, Oct 14, 2007 at 06:45:44PM -0500, Rob Landley wrote: On Sunday 14 October 2007 5:24:32 pm James Bottomley wrote: On Sat, 2007-10-13 at 16:05 -0600, Matthew Wilcox wrote: On Thu, Oct 11, 2007 at 08:11:21PM -0500, Rob Landley wrote: My impression from asking questions on the

Re: [PATCH] hptiop: avoid buffer overflow when returning sense data

2007-10-15 Thread Andrew Morton
On Mon, 15 Oct 2007 14:42:52 +0800 HighPoint Linux Team [EMAIL PROTECTED] wrote: avoid buffer overflow when returning sense data. That's really not enough information, sorry. index 8b384fa..d32a4a9 100644 --- a/drivers/scsi/hptiop.c +++ b/drivers/scsi/hptiop.c @@ -375,8 +375,9 @@

[PATCH] hptiop: avoid buffer overflow when returning sense data

2007-10-15 Thread HighPoint Linux Team
avoid buffer overflow when returning sense data. Signed-off-by: HighPoint Linux Team [EMAIL PROTECTED] --- diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c index 8b384fa..d32a4a9 100644 --- a/drivers/scsi/hptiop.c +++ b/drivers/scsi/hptiop.c @@ -375,8 +375,9 @@ static void

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Sunday 14 October 2007 7:45:46 pm Luben Tuikov wrote: Matthew's expletive and extremely rude response really shows the general attitude of the linux-scsi people. No, it doesn't. James Bottomley has been exceedingly polite and helpful, as were several other people on the linux-scsi list

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: On Sun, Oct 14, 2007 at 06:45:44PM -0500, Rob Landley wrote: I admit a certain amount of personal annoyance that once the SCSI layer consumes a category of device (USB, SATA, PATA), they can often _only_ be used by going through the

OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 18:04, Rob Landley wrote: On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: excuse for conflating different categories of devices in the first place. See the thinkpad Ultrabay drive example above. Last week I drove my laptop so deep into swap (with a

Re: What still uses the block layer?

2007-10-15 Thread Luben Tuikov
--- Rob Landley [EMAIL PROTECTED] wrote: On Sunday 14 October 2007 7:45:46 pm Luben Tuikov wrote: Matthew's expletive and extremely rude response really shows the general attitude of the linux-scsi people. No, it doesn't. James Bottomley has been exceedingly polite and helpful, as were

Re: What still uses the block layer?

2007-10-15 Thread Christoph Hellwig
On Sun, Oct 14, 2007 at 11:00:15PM -0700, Greg KH wrote: If you hate USB storage devices using scsi, please use the ub driver, that is what it was written for. The ub driver is a really dumb piece of shit. It only drivers usb storage devices using a scsi protocol set, and duplicates the scsi

Re: What still uses the block layer?

2007-10-15 Thread Julian Calaby
On 10/15/07, Rob Landley [EMAIL PROTECTED] wrote: I note that the eth0 and eth1 names are dynamically assigned on a first come first serve basis (like scsi). This never causes me a problem because the driver loading order is constant, and once you figure out that eth0 is gigabit and eth1 is

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 1:00:15 am Greg KH wrote: If you hate USB storage devices using scsi, please use the ub driver, that is what it was written for. For the embedded space, the ability to configure out the scsi layer is interesting from a size perspective. I bookmarked that a while

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 12:44:19 am Stefan Richter wrote: Rob Landley wrote: I was at least attempting to ask a serious question. ... Actually, I was going through Documentation/block thinking about making a 00-INDEX for it, but my earlier questions of the scsi guys left me with the

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 8:37:44 am Nick Piggin wrote: Virtual memory isn't perfect. I've _always_ been able to come up with examples where it just doesn't work for me. This doesn't mean VM overcommit should be abolished, because it's useful more often than not. I hate to go completely

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Nick Piggin
On Monday 15 October 2007 19:52, Rob Landley wrote: On Monday 15 October 2007 8:37:44 am Nick Piggin wrote: Virtual memory isn't perfect. I've _always_ been able to come up with examples where it just doesn't work for me. This doesn't mean VM overcommit should be abolished, because

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 4:06:20 am Julian Calaby wrote: On 10/15/07, Rob Landley [EMAIL PROTECTED] wrote: I note that the eth0 and eth1 names are dynamically assigned on a first come first serve basis (like scsi). This never causes me a problem because the driver loading order is

Re: [PATCH 3/3] faster workaround

2007-10-15 Thread Bernd Schubert
On Friday 12 October 2007 23:08:21 Jeff Garzik wrote: Bernd Schubert wrote: a) 2.6.23 + sil-patch I posted, this is on a customer system (though my former group), I wouldn't like to use -mm there. b) .config is attached c) attached d) attached (don't get irritaded by those machine

Re: What still uses the block layer?

2007-10-15 Thread Douglas Gilbert
Theodore Tso wrote: On Mon, Oct 15, 2007 at 03:04:00AM -0500, Rob Landley wrote: Ok, I'll bite. If it's all real scsi, why does ioctl(SG_EMULATED_HOST) exist? exist if it's all real scsi? SG_EMULATED_HOST was added before Linux 2.4, at least six or seven years ago. SG_EMULATED_HOST was

Re: What still uses the block layer?

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 04:26:04AM -0500, Rob Landley wrote: For example, usb devices are never easy to order. IDE devices (back when they had their own namespace) were trivial to order back when /dev/hda couldn't move without use of a screwdriver. Ah, but it could. If you had more than

Re: What still uses the block layer?

2007-10-15 Thread Stefan Richter
Matthew Wilcox wrote: On Mon, Oct 15, 2007 at 04:26:04AM -0500, Rob Landley wrote: Combining USB and IDE into the same /dev/sd? namespace makes enumerating the IDE devices much harder than in the traditional /dev/hdb doesn't move without a screwdriver model. The merger creates a new problem

[PATCHSET 0/3] pluto/fc - some fixes and cleanups

2007-10-15 Thread Boaz Harrosh
I'm sending a small lift-up to the drivers/scsi/pluto.c and drivers/fc4/fc.c pair, that where a bit stepped on lately. Matthew this includes your patch, I just fixed up the patch comment, since You had a good comment on the first patch but sent a better second patch with no comment. (And my set

[PATCH 1/3] pluto/fc - Remove uses of the scsi_cmnd-done

2007-10-15 Thread Boaz Harrosh
From: Matthew Wilcox [EMAIL PROTECTED] Remove uses of the scsi_cmnd -done method from the fc4 driver. It was being abused to flag commands that had already been through queuecommand; use the fcmd-proto value for that instead. The fcmd-done pointer now becomes irrelevant. Reuse the

Re: What still uses the block layer?

2007-10-15 Thread Greg KH
On Mon, Oct 15, 2007 at 03:36:15AM -0500, Rob Landley wrote: The point I was trying to make is that it seems to me like it would be possible to keep the namespace separate here, and thus reduce the enumeration problems to the point where common cases (like my laptop) aren't impacted by

[PATCH 2/3] pluto/fc - Enable compilation for all ARCHs

2007-10-15 Thread Boaz Harrosh
- It was suggested on the linux-scsi-ml that: Well if fc4.c compiles OK on non-sparc64 then perhaps we should enable compilation on non-sparc64. It will increase maintainability and code quality and stuff. - WATCH OUT Distro maintainers: otoh people might end up

Re: What still uses the block layer?

2007-10-15 Thread Greg KH
On Mon, Oct 15, 2007 at 05:08:36AM -0500, Rob Landley wrote: On Monday 15 October 2007 4:06:20 am Julian Calaby wrote: On 10/15/07, Rob Landley [EMAIL PROTECTED] wrote: I note that the eth0 and eth1 names are dynamically assigned on a first come first serve basis (like scsi). This never

[PATCH 3/3] pluto/fc - fix INQUIRY still using !use_sg commands

2007-10-15 Thread Boaz Harrosh
- pluto.c was still issuing use_sg == 0 commands down to fc.c, which was already converted. Fix that by adding a member to hold the inquiry_buffer in struct fcp_cmnd and using it when mapping/unmapping of command payload, if needed. - Also fix a compilation warning in

Re: What still uses the block layer?

2007-10-15 Thread Jeff Garzik
Alan Cox wrote: You can pull a Model and Serial number via hdparm -i, but it's not as easy to manipulate as a fixed-length MAC address. That's why people tend to use filesystem UUID's. ATA8 at the moment looks set to add a true MAC or WWN type identifier to each device.. Right now

Re: [PATCH 1/3] pluto/fc - Remove uses of the scsi_cmnd-done

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 07:25:14PM +0200, Boaz Harrosh wrote: From: Matthew Wilcox [EMAIL PROTECTED] Remove uses of the scsi_cmnd -done method from the fc4 driver. It was being abused to flag commands that had already been through queuecommand; use the fcmd-proto value for that instead.

[PATCH 3/3 ver2] pluto/fc - fix INQUIRY still using !use_sg commands

2007-10-15 Thread Boaz Harrosh
Some people, me included, might like this approach better - pluto.c was still issuing use_sg == 0 commands down to fc.c, which was already converted. Fix that by adding a member to hold the inquiry_sg in struct fcp_cmnd and using it when mapping/unmapping of command payload,

Re: What still uses the block layer?

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 10:25:13AM -0700, Greg KH wrote: Use mount-by-label instead, it's much saner and handles device name movement just fine (as does the UUID method that you seem to hate.) Look in /dev/disk/ for a wide range of options that you have in which to choose how to pick your

Re: [PATCH 2/3] pluto/fc - Enable compilation for all ARCHs

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 07:26:51PM +0200, Boaz Harrosh wrote: @@ -22,6 +22,8 @@ source drivers/misc/Kconfig source drivers/ide/Kconfig +source drivers/fc4/Kconfig + source drivers/scsi/Kconfig source drivers/ata/Kconfig I think I see two problems ... one is that fc4 plainly

Re: [PATCH 3/3 ver2] pluto/fc - fix INQUIRY still using !use_sg commands

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 08:00:22PM +0200, Boaz Harrosh wrote: Some people, me included, might like this approach better I think I prefer this approach too. -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this

Re: [PATCH 2/3] pluto/fc - Enable compilation for all ARCHs

2007-10-15 Thread Boaz Harrosh
Matthew Wilcox wrote: On Mon, Oct 15, 2007 at 07:26:51PM +0200, Boaz Harrosh wrote: @@ -22,6 +22,8 @@ source drivers/misc/Kconfig source drivers/ide/Kconfig +source drivers/fc4/Kconfig + source drivers/scsi/Kconfig source drivers/ata/Kconfig I think I see two problems ... one

[PATCH 3/3 ver3] pluto/fc - fix INQUIRY still using !use_sg commands

2007-10-15 Thread Boaz Harrosh
oofff that was to fast, sorry. Wrong sg_count in unmapping. --- - pluto.c was still issuing use_sg == 0 commands down to fc.c, which was already converted. Fix that by adding a member to hold the inquiry_sg in struct fcp_cmnd and using it when mapping/unmapping of command payload,

Re: [PATCH 2/3] pluto/fc - Enable compilation for all ARCHs

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 08:18:24PM +0200, Boaz Harrosh wrote: This is all new territory for me. But CONFIG_SCSI_PLUTO is dependent on SCSI and fc.c is not the real driver just the needed bits from the sparc side. So the code mess calls for a Kconfig mess, I guess. I've spent a lot of time

Re: What still uses the block layer?

2007-10-15 Thread Jeff Garzik
Greg KH wrote: On Mon, Oct 15, 2007 at 03:36:15AM -0500, Rob Landley wrote: The point I was trying to make is that it seems to me like it would be possible to keep the namespace separate here, and thus reduce the enumeration problems to the point where common cases (like my laptop) aren't

Re: What still uses the block layer?

2007-10-15 Thread Matthew Garrett
On Mon, Oct 15, 2007 at 07:00:22AM -0700, Arjan van de Ven wrote: that's a choice Ubuntu made in their udev scripts... if you don't like it, complain to them. Keeping the naming as hda while changing the semantics (such as the reduced number of partitions) would have been differently

[PATCH 2/2] pluto fix disable/enable irq

2007-10-15 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Pluto drivers uses disable/enable_irq(), so add prototypes for them. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/pluto.c |1 + 1 file changed, 1 insertion(+) --- linux-2.6.23-git7.orig/drivers/scsi/pluto.c +++

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 5:32:32 am Loïc Grenié wrote: You are really looking like you are out for a fight. ... Your objection is interesting. It is lost in the middle of e-mails which, to the untrained eye, look like you are trying to fight everyone and everybody. ... ...holy

Re: What still uses the block layer?

2007-10-15 Thread Rob Landley
On Monday 15 October 2007 8:10:49 am James Bottomley wrote: OK, so could we get back to the original discussion? The question I think you meant to ask is does SCSI use the block layer, and if so; how? The answer is yes (just do an ls /sys/block on any scsi machine). The how is that it

Re: What still uses the block layer?

2007-10-15 Thread Alan Cox
This is where we disagree. The existence of devices you cannot stably enumerate does not eliminate the existence of devices you trivially can. trivially You are I assume familiar in full with EDD 3.0, EDD 1.x and the Ralf Brown documentation on the BIOS drive mappings and tables for

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread James Bottomley
On Sat, 2007-10-13 at 22:35 -0700, Paul Jackson wrote: From: Paul Jackson [EMAIL PROTECTED] The added line in scsi_eh.h: struct scatterlist sense_sgl; fails to compile, with the error: field 'sense_sgl' has incomplete type unless scatterlist.h happens to be included somehow

Re: What still uses the block layer?

2007-10-15 Thread Neil Brown
On Monday October 15, [EMAIL PROTECTED] wrote: Therefore it is best to not have stable single-number naming schemes for any devices on any machines. Why? Because it ensure there will not be any second class citizens. This is where we disagree. The existence of devices you cannot stably

Re: What still uses the block layer?

2007-10-15 Thread Julian Calaby
[adding back CCs which were dropped because I'm stupid - sorry!] On 10/16/07, Rob Landley [EMAIL PROTECTED] wrote: On Monday 15 October 2007 5:27:55 am Julian Calaby wrote: On 10/15/07, Rob Landley [EMAIL PROTECTED] wrote: On Monday 15 October 2007 4:06:20 am Julian Calaby wrote: On

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread Andrew Morton
On Mon, 15 Oct 2007 19:35:30 -0400 James Bottomley [EMAIL PROTECTED] wrote: On Sat, 2007-10-13 at 22:35 -0700, Paul Jackson wrote: From: Paul Jackson [EMAIL PROTECTED] The added line in scsi_eh.h: struct scatterlist sense_sgl; fails to compile, with the error: field

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread Paul Jackson
James wrote: The requirement for struct scatterlist is the same before and after the gid scsi-misc patch. Not so. The git-scsi-misc.patch in 2.6.23-mm1 clearly adds the line: struct scatterlist sense_sgl; as part of the added struct scsi_eh_save in scsi/scsi_eh.h. This bit me while I

[PATCH 1/4] docbook: fix kernel-api content

2007-10-15 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-api docbook warnings. Warning(linux-2.6.23-git8//drivers/message/fusion/mptscsih.c:2618): No description found for parameter 'sc' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/message/fusion/mptscsih.c | 10 +++--- 1 file

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread James Bottomley
On Mon, 2007-10-15 at 17:08 -0700, Paul Jackson wrote: James wrote: The requirement for struct scatterlist is the same before and after the gid scsi-misc patch. Not so. The git-scsi-misc.patch in 2.6.23-mm1 clearly adds the line: struct scatterlist sense_sgl; as part of the

Re: [PATCH] git scsi misc include fix

2007-10-15 Thread Paul Jackson
James wrote: In that case, the correct fix is actually to move the scatterlist include from scsi_error.c (where the scatterlist was originally used locally) into scsi_eh.h, like this. I suspect you're correct, yes. -- I won't rest till it's the best ...

Re: What still uses the block layer?

2007-10-15 Thread david
On Tue, 16 Oct 2007, Neil Brown wrote: On Monday October 15, [EMAIL PROTECTED] wrote: Therefore it is best to not have stable single-number naming schemes for any devices on any machines. Why? Because it ensure there will not be any second class citizens. This is where we disagree. The

Re: What still uses the block layer?

2007-10-15 Thread david
On Mon, 15 Oct 2007, Theodore Tso wrote: On Mon, Oct 15, 2007 at 03:04:00AM -0500, Rob Landley wrote: just as Ethernet and PPP interfaces really are fundamentally the same thing. They're the same thing? Do you mean that on a system with both, going: ifconfig eth1 66.92.53.140 ifconfig

Re: What still uses the block layer?

2007-10-15 Thread david
On Mon, 15 Oct 2007, Greg KH wrote: On Mon, Oct 15, 2007 at 05:08:36AM -0500, Rob Landley wrote: On Monday 15 October 2007 4:06:20 am Julian Calaby wrote: On 10/15/07, Rob Landley [EMAIL PROTECTED] wrote: I note that the eth0 and eth1 names are dynamically assigned on a first come first

Re: What still uses the block layer?

2007-10-15 Thread david
On Mon, 15 Oct 2007, Stefan Richter wrote: Subject: Re: What still uses the block layer? Matthew Wilcox wrote: On Mon, Oct 15, 2007 at 04:26:04AM -0500, Rob Landley wrote: Combining USB and IDE into the same /dev/sd? namespace makes enumerating the IDE devices much harder than in the

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Eric W. Biederman
Nick Piggin [EMAIL PROTECTED] writes: On Monday 15 October 2007 18:04, Rob Landley wrote: On Sunday 14 October 2007 8:45:03 pm Theodore Tso wrote: excuse for conflating different categories of devices in the first place. See the thinkpad Ultrabay drive example above. Last week I

Re: What still uses the block layer?

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: do PCI devices reorder their bus numbers spontaniously, or only if you change the hardware? The only system I've had that reordered PCI bus numbers was when I had a partitionable system and changed the partitioning. Not quite

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread david
On Mon, 15 Oct 2007, Eric W. Biederman wrote: Nick Piggin [EMAIL PROTECTED] writes: How much swap do you have configured? You really shouldn't configure so much unless you do want the kernel to actually use it all, right? No. There are three basic swapping scenarios. - Pushing unused data

Re: What still uses the block layer?

2007-10-15 Thread david
On Mon, 15 Oct 2007, Matthew Wilcox wrote: On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: do PCI devices reorder their bus numbers spontaniously, or only if you change the hardware? The only system I've had that reordered PCI bus numbers was when I had a partitionable

Re: What still uses the block layer?

2007-10-15 Thread Arjan van de Ven
On Mon, 15 Oct 2007 22:04:01 -0600 Matthew Wilcox [EMAIL PROTECTED] wrote: On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: do PCI devices reorder their bus numbers spontaniously, or only if you change the hardware? The only system I've had that reordered PCI bus numbers

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Nick Piggin
On Tuesday 16 October 2007 13:55, Eric W. Biederman wrote: Nick Piggin [EMAIL PROTECTED] writes: How much swap do you have configured? You really shouldn't configure so much unless you do want the kernel to actually use it all, right? No. There are three basic swapping scenarios. -

Re: What still uses the block layer?

2007-10-15 Thread Greg KH
On Mon, Oct 15, 2007 at 10:04:01PM -0600, Matthew Wilcox wrote: On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: do PCI devices reorder their bus numbers spontaniously, or only if you change the hardware? The only system I've had that reordered PCI bus numbers was when I

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: on some kernel versions you are correct about needing swap ram, but on current versions you are not. the swap space gets allocated as needed, and re-used as needed (I don't know the mechanism of this, but I remember the last time this changed from

Re: OOM killer gripe (was Re: What still uses the block layer?)

2007-10-15 Thread Nick Piggin
On Tuesday 16 October 2007 14:38, Eric W. Biederman wrote: Nick Piggin [EMAIL PROTECTED] writes: On Tuesday 16 October 2007 13:55, Eric W. Biederman wrote: I don't follow your logic. We don't need SWAP RAM in order to swap effectively, IMO. The steady state of a system that is heavily

Re: What still uses the block layer?

2007-10-15 Thread david
On Mon, 15 Oct 2007, Greg KH wrote: On Mon, Oct 15, 2007 at 10:04:01PM -0600, Matthew Wilcox wrote: On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: do PCI devices reorder their bus numbers spontaniously, or only if you change the hardware? The only system I've had that

Re: linux-2.6.23-mm1 crashed

2007-10-15 Thread Dave Milter
On 10/14/07, Andrew Morton [EMAIL PROTECTED] wrote: I didn't notice that qemu was involved. Does qemu have an emulator for the gdth hardware? I think no, the kernel just probe exist or not hardware, and hangs after that. - To unsubscribe from this list: send the line unsubscribe linux-scsi in

Re: What still uses the block layer?

2007-10-15 Thread Stefan Richter
[EMAIL PROTECTED] wrote: On Mon, 15 Oct 2007, Stefan Richter wrote: Low-level networking drivers suggest a default interface name (per interface or as a template like eth%d into which the networking core inserts a lowest spare number). ... Could low-level SCSI drivers provide similar name