On Thu, 18 Oct 2007 22:30:23 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote:
>
> On Thu, 18 Oct 2007 22:20:17 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote:
> >
> > Please explain "why" in the changelog (what changelog?).
> >
> > E.g.:
> > so that make allmodconfig on powerpc will have a better cha
Gilbert Wu wrote:
> diff -urN a/drivers/scsi/aic94xx/aic94xx_init.c
> b/drivers/scsi/aic94xx/aic94xx_init.c ---
> a/drivers/scsi/aic94xx/aic94xx_init.c 2007-10-10 17:13:29.0 -0700
> +++ b/drivers/scsi/aic94xx/aic94xx_init.c 2007-10-11 19:31:03.0
> -0700
> @@ -313,6 +315,180 @@
On Thu, 18 Oct 2007 22:20:17 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote:
> On Fri, 19 Oct 2007 15:04:31 +1000 Stephen Rothwell wrote:
>
> > At least for now.
>
> Please explain "why" in the changelog (what changelog?).
>
> E.g.:
> so that make allmodconfig on powerpc will have a better chance
On Fri, 19 Oct 2007 15:04:31 +1000 Stephen Rothwell wrote:
> At least for now.
Please explain "why" in the changelog (what changelog?).
E.g.:
so that make allmodconfig on powerpc will have a better chance
of building.
or whatever.
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
> ---
>
From: Stephen Rothwell <[EMAIL PROTECTED]>
Date: Fri, 19 Oct 2007 15:04:31 +1000
> At least for now.
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a mess
At least for now.
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
drivers/scsi/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
--
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 30905ce..325
On Thu, 18 Oct 2007 17:45:21 +0900
FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Thu, 18 Oct 2007 10:27:34 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
> > On Thu, Oct 18 2007 at 9:57 +0200, FUJITA Tomonori <[EMAIL PROTECTED]>
> > wrote:
> > > On Thu, 18 Oct 2007 09:51:10 +0200
> > > Boaz
On Thu, Oct 18, 2007 at 02:05:21PM -0700, Seokmann Ju wrote:
> Matthew Wilcox wrote:
> > I don't understand why you care to print it at this point. If you know
> > the device, you know the sector size, right?
> As the debug message doesn't get displayed in normal situation, just wanted
> to keep
Matthew Wilcox wrote:
> On Thu, Oct 18, 2007 at 11:57:33AM -0700, Seokmann Ju wrote:
>> Matthew Wilcox wrote:
>>> As part of their debug routines, both of these drivers print out the
>>> transfersize. That's just unnecessary, particularly since neither driver
>>> actually uses it.
>> NACK for qla2
On Thu, Oct 18, 2007 at 11:57:33AM -0700, Seokmann Ju wrote:
> Matthew Wilcox wrote:
> > As part of their debug routines, both of these drivers print out the
> > transfersize. That's just unnecessary, particularly since neither driver
> > actually uses it.
> NACK for qla2xxx - I would rather chang
Matthew Wilcox wrote:
> As part of their debug routines, both of these drivers print out the
> transfersize. That's just unnecessary, particularly since neither driver
> actually uses it.
NACK for qla2xxx - I would rather change it to 'cmd->device->sector_size'
instead of removing it.
A patch wil
On Wed, Oct 17 2007 at 14:28 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-10-16 at 14:28 -0700, [EMAIL PROTECTED] wrote:
>> From: James Bottomley <[EMAIL PROTECTED]>
>>
>> On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote:
>>> On Sun, 14 Oct 2007 22:45:47 +0400 "Dave Milter
On Wed, Oct 17 2007 at 14:28 +0200, James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2007-10-16 at 14:28 -0700, [EMAIL PROTECTED] wrote:
>> From: James Bottomley <[EMAIL PROTECTED]>
>>
>> On Sun, 2007-10-14 at 12:21 -0700, Andrew Morton wrote:
>>> On Sun, 14 Oct 2007 22:45:47 +0400 "Dave Milter
- Indentation fix of last patch. Don't be fooled by diff,
all I did was back-indent from open-bracket to close-bracket,
and remove the brackets.
Signed-off-by: Boaz Harrosh <[EMAIL PROTECTED]>
---
drivers/scsi/qla1280.c | 290
1 files c
- rearrange the elements of the scsi_pointer
- shrink and move the eh_eflags element
- turn sc_data_direction into an unsigned char
- move tag
By doing this, we reduce the size of scsi_cmnd from 376 to 352 bytes
on x86-64 and from 272 to 260 bytes on i386.
Signed-off-by: Matthew Wilcox <[EMAI
It's more intuitive to go straight to the struct device for the
sector_size, when that's what we want, rather than using transfersize
as a replacement.
Also fix a bug in handling of GPCMD_READ_CD where we were pulling the
wrong bytes out of the packet to calculate the length. I checked this
again
As part of their debug routines, both of these drivers print out the
transfersize. That's just unnecessary, particularly since neither driver
actually uses it.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/qla1280.c |4 +---
drivers/scsi/qla2xxx/qla_dbg.c |3
Only two drivers remain that use scmd->transfersize, but they both
look like legitimate uses. So add a new function that returns what
that element would have been, and we can remove the element. Shuffling
'result' into its place saves us 8 bytes on x86-64 (down to 344 bytes)
and 4 bytes on i386 (
On Thu, Oct 18, 2007 at 10:26:58AM -0400, Alan Stern wrote:
> > Even that's still pretty foul (and i have my grave doubts about using
> > stringify in that manner). It's definitely past my bedtime now ... but
> > a hack like that could save us another 8 bytes on x86-64.
>
> This may seem heretica
On Thu, 18 Oct 2007, Matthew Wilcox wrote:
> > I will grab your tool and play with it. The sglist pointer shuffle
> > is good, and also I know that if you put the scsi_data_buffer
> > at the beginning of scsi_cmnd, than you can fill the holes with small types
> > following the sub-structure. I'll
On Tue, Oct 16, 2007 at 05:34:15PM +1000, Nick Piggin wrote:
> > It's a hard call. The I/O time for 1MB of contiguous disk data
> > is about the I/O time of 512 bytes of contiguous disk data.
>
> And if you're thrashing, then by definition you need to throw
> out 1MB of your working set in order
On Thu, 2007-10-18 at 08:13 -0400, James Bottomley wrote:
> On Thu, 2007-10-18 at 13:57 +0200, Mathieu Fluhr wrote:
> > On Thu, 2007-10-18 at 06:06 -0400, Jeff Garzik wrote:
> >
> > > The SCSI midlayer makes a lot of "if scsi version <= 2" choices. In the
> > > case of ATAPI, we do not want to f
On Wed, 2007-10-17 at 16:13 +0200, Hannes Reinecke wrote:
> Hi James,
>
> due to popular demand I've clobbered together a patch for
> suspend/resume support in aic79xx/aic7xxx.
>
> Looks reasonable enough, boots, but now I'd need someone
> to actually test it :-)
>
> As usual, comments, results,
On Thu, 2007-10-18 at 13:57 +0200, Mathieu Fluhr wrote:
> On Thu, 2007-10-18 at 06:06 -0400, Jeff Garzik wrote:
>
> > The SCSI midlayer makes a lot of "if scsi version <= 2" choices. In the
> > case of ATAPI, we do not want to force ATAPI down the path of ancient
> > SCSI devices, as this disab
On Thu, 2007-10-18 at 06:06 -0400, Jeff Garzik wrote:
> The SCSI midlayer makes a lot of "if scsi version <= 2" choices. In the
> case of ATAPI, we do not want to force ATAPI down the path of ancient
> SCSI devices, as this disables some MMC features that modern ATAPI
> devices support.
If I
Hi Andrew, James,
On Monday 15 October 2007 14:53, Gabriel C wrote:
> >> Compile tested and applies cleanly to 2.6.23.
> >> I don't have this hardware anymore and cannot run test these patches.
> >
> > I can test these patches on an aic7892 controller later on today if you
> > want.
>
> Works f
On Wed, 2007-10-17 at 21:31 -0400, Jeff Garzik wrote:
> Robert Hancock wrote:
> > This doesn't seem a very reliable way to identify an IDE device, as all
> > that 0 means is that the device does not claim conformance to any
> > standard. I would think it would be legitimate for an IDE device to put
This patch fixes a typo introduced by
commit bbfbbbc1182f8b44c8cc4c99f4a3f3a512149022.
It wasn't a compile error since CONFIG_LPFC_DEBUG_FS is not (yet?)
available as an option.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
74e14a2a4ed066aa8fedd557a6768fdfec5eb883
diff --git a/drivers/scs
Commit bbfbbbc1182f8b44c8cc4c99f4a3f3a512149022 accidentally reversed
the logic of this NULL check.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
ee645f41f64ebeb782a0ca2e724dff929f854b68
diff --git a/drivers/scsi/aic7xxx_old.c b/drivers/scsi/aic7xxx_old.c
This patch fixes the following build warnings:
<-- snip -->
...
MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0xbcffdb): Section mismatch: reference to
.init.text.20:gdth_search_drives (between 'gdth_pci_probe_one' and
'gdth_start_timeout')
WARNING: vmlinux.o(.text+0xbd0102): Section mismatch:
On Thu, Oct 18 2007 at 10:46 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> By
> - rearranging the elements of the scsi_pointer
> - shrinking and moving the eh_eflags element
> - turning sc_data_direction into an unsigned char
> - moving tag
>
> we achieve a size reduction in scsi_cmnd of
On Thu, Oct 18 2007 at 10:54 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 18, 2007 at 10:16:38AM +0200, Boaz Harrosh wrote:
>> Sorry Matthew, my mistake I forgot to send the last [33/33] patch
>> this here should be done on top of that last one.
>
> Yeah. I'll rebase the series
Hi James,
appearently the lpfc driver is sligtly confused about the meaning
of the 'scmd->tag' value. It should rather inspect the correct
flags to detect the proper SCSI Tag value.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
[EMAIL PROTECTED]
On Wed, 2007-10-17 at 21:31 -0400, Jeff Garzik wrote:
> Robert Hancock wrote:
> > This doesn't seem a very reliable way to identify an IDE device, as all
> > that 0 means is that the device does not claim conformance to any
> > standard. I would think it would be legitimate for an IDE device to put
Mathieu Fluhr wrote:
On Wed, 2007-10-17 at 21:31 -0400, Jeff Garzik wrote:
Robert Hancock wrote:
This doesn't seem a very reliable way to identify an IDE device, as all
that 0 means is that the device does not claim conformance to any
standard. I would think it would be legitimate for an IDE de
On Thu, 18 Oct 2007 10:27:34 +0200
Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 18 2007 at 9:57 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> > On Thu, 18 Oct 2007 09:51:10 +0200
> > Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> >
> >> On Thu, Oct 18 2007 at 1:40 +0200, FUJITA Tomonori
On Thu, Oct 18, 2007 at 10:16:38AM +0200, Boaz Harrosh wrote:
> Sorry Matthew, my mistake I forgot to send the last [33/33] patch
> this here should be done on top of that last one.
Yeah. I'll rebase the series of 4 patches I just sent on top of it when
I wake up in the morning.
> I will grab yo
Only two drivers remain that use scmd->transfersize, but they both
look like legitimate uses. So add a new function that returns what
that element would have been, and we can remove the element. Shuffling
'result' into its place saves us 8 bytes on x86-64 (down to 344 bytes)
and 4 bytes on i386 (
It's more intuitive to go straight to the struct device for the
sector_size, when that's what we want, rather than using transfersize
as a replacement.
Also fix a bug in handling of GPCMD_READ_CD where we were pulling the
wrong bytes out of the packet to calculate the length. I checked this
again
As part of their debug routines, both of these drivers print out the
transfersize. That's just unnecessary, particularly since neither driver
actually uses it.
Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]>
---
drivers/scsi/qla1280.c |4 +---
drivers/scsi/qla2xxx/qla_dbg.c |3
By
- rearranging the elements of the scsi_pointer
- shrinking and moving the eh_eflags element
- turning sc_data_direction into an unsigned char
- moving tag
we achieve a size reduction in scsi_cmnd of 376 to 352 bytes on x86-64
and from 272 to 260 bytes on i386.
Signed-off-by: Matthew Wilcox
On Oct. 18, 2007, 10:06 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 18, 2007 at 08:59:58AM +0200, Benny Halevy wrote:
>> yeah. The sglist pointer shuffle makes sense and so are the field type
>> changes and coalescing, but the union holding the deprecated fields
>> of scsi_data_b
On Thu, Oct 18 2007 at 9:57 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Thu, 18 Oct 2007 09:51:10 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> On Thu, Oct 18 2007 at 1:40 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
>>> On Wed, 17 Oct 2007 20:21:15 +0200
>>> Boaz Harrosh <[
On Thursday 11 October 2007 4:49:28 pm David Miller wrote:
> From: Rob Landley <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 17:47:02 -0500
>
> > On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote:
> > > Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions
> > > (and the funct
On Thu, Oct 18 2007 at 8:59 +0200, Benny Halevy <[EMAIL PROTECTED]> wrote:
>>
>> Updated patch below. I'm fully expecting the 'result' shenanigan to get
>> it NACKed, but I'd like to see if it inspires anyone else to a more
>> creative way of saving this space.
>
>
> yeah. The sglist pointer shu
On Thu, Oct 18, 2007 at 08:59:58AM +0200, Benny Halevy wrote:
> yeah. The sglist pointer shuffle makes sense and so are the field type
> changes and coalescing, but the union holding the deprecated fields
> of scsi_data_buff is going away.
Indeed. We could always do ...
union {
On Thu, 18 Oct 2007 09:51:10 +0200
Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 18 2007 at 1:40 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> > On Wed, 17 Oct 2007 20:21:15 +0200
> > Boaz Harrosh <[EMAIL PROTECTED]> wrote:
> >
> >> In preparation for bidi we abstract all IO membe
On Thu, Oct 18 2007 at 1:40 +0200, FUJITA Tomonori <[EMAIL PROTECTED]> wrote:
> On Wed, 17 Oct 2007 20:21:15 +0200
> Boaz Harrosh <[EMAIL PROTECTED]> wrote:
>
>> In preparation for bidi we abstract all IO members of scsi_cmnd,
>> that will need to duplicate, into a substructure.
>>
>> - Grou
- So we can separate the move to scsi_data_buffer
into several patches, we have introduced a compatibility
hack in the very first patch, that let the patchset be
completely bisectable. Now that the entire tree is converted
We can finally remove OLD I/O members from scsi_cmnd.
Si
On Oct. 18, 2007, 2:47 +0200, Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 17, 2007 at 08:21:15PM +0200, Boaz Harrosh wrote:
>> - Group all IO members of scsi_cmnd into a scsi_data_buffer
>> structure.
>
>> +struct scsi_data_buffer {
>> +unsigned length;
>> +int resid;
>>
50 matches
Mail list logo
