Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Cornelia Huck
On Mon, 29 Oct 2007 12:24:06 -0500, James Bottomley [EMAIL PROTECTED] wrote: Can you determine which subset of the attributes you want just before actually creating the group? Then you could do something like: create_group(grp, kobj) { grp-update_creation_mask(kobj);

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Cornelia Huck
On Mon, 29 Oct 2007 12:29:27 -0500, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2007-10-29 at 13:27 -0400, Jeff Garzik wrote: James Bottomley wrote: visibility and creation are the same thing, aren't they? An invisible attribute doesn't appear in the sysfs directory, so it's

[PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Convert to use the generic boolean. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Diffed against linus-git Checked with script/checkpatch.pl (warned about long lines, but it is not introduced by this patch) dpt_i2o.c | 22 +++--- dpti.h|9 ++--- 2 files

[EMAIL PROTECTED]: [EMAIL PROTECTED]:

2007-10-30 Thread jameshsu
Hello James Bottomley, This driver has nothing changed since last time submit. However recently we check the 2.6.23.1 kernel and found code is not up-to-date (still remain @2005). Resend this message to submit the same driver again. (.c diff file under atp870u.c.diff.bz2 format) Please help Acard

Re: Questions about scsi.c

2007-10-30 Thread Jeff Garzik
Randy Dunlap wrote: On Thu, 25 Oct 2007 16:40:35 -0500 Rob Landley wrote: On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote: Entirely possible I'm doing something wrong: sect1 id=scsi_device.h titleinclude/scsi/scsi_device.h/title para /para

Re: [GIT PATCH] final SCSI pieces for the merge window

2007-10-30 Thread Denys Vlasenko
On Wednesday 24 October 2007 15:27, Matthew Wilcox wrote: On Wed, Oct 24, 2007 at 09:28:10AM -0400, James Bottomley wrote: OK, so it's no secret that I'm the last of the subsystem maintainers whose day job isn't working on the linux kernel. If you want a full time person, who did you have

Re: [RFC 0/3] [SCSI/libata] libata EH conversion for ipr SAS

2007-10-30 Thread Jeff Garzik
Brian King wrote: The following three patches convert ipr to use the new libata EH APIs. In the process of doing this, I first looked into implementing this in a similar manner to how libata SAS is done today, which is hooking into target_alloc/target_destroy to allocate/delete sata ports. While

Re: Questions about scsi.c

2007-10-30 Thread James Bottomley
On Tue, 2007-10-30 at 08:34 -0400, Jeff Garzik wrote: Randy Dunlap wrote: On Thu, 25 Oct 2007 16:40:35 -0500 Rob Landley wrote: On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote: Entirely possible I'm doing something wrong: sect1 id=scsi_device.h

RE: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Salyzyn, Mark
ACK Sincerely -- Mark Salyzyn -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Richard Knutsson Sent: Tuesday, October 30, 2007 6:54 AM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; linux-scsi@vger.kernel.org; Richard Knutsson Subject:

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Matthew Wilcox
On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool initialized:8; + bool in_use:8; /* is the management node open*/ Are you serious?

Re: [PATCH 4/5] qla2xxx: add target mode support

2007-10-30 Thread Seokmann Ju
FUJITA Tomonori wrote: On Sun, 30 Sep 2007 03:57:07 -0700 Seokmann Ju [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: On Thu, 27 Sep 2007 07:34:52 -0700 Seokmann Ju [EMAIL PROTECTED] wrote: FUJITA Tomonori wrote: On Fri, 21 Sep 2007 07:34:18 -0700 Seokmann Ju [EMAIL PROTECTED] wrote:

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Matthew Wilcox
On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote: Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool initialized:8; + bool in_use:8; /* is the

Re: [EMAIL PROTECTED]: [EMAIL PROTECTED]:

2007-10-30 Thread Christoph Hellwig
On Tue, Oct 30, 2007 at 07:36:05PM +0800, jameshsu wrote: Hello James Bottomley, This driver has nothing changed since last time submit. However recently we check the 2.6.23.1 kernel and found code is not up-to-date (still remain @2005). Resend this message to submit the same driver again.

Re: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

2007-10-30 Thread Denys Vlasenko
On Tuesday 30 October 2007 10:54, Richard Knutsson wrote: Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6f56528 100644 ---

RE: [PATCH 1/8] scsi: megaraid_sas - add hibernation support

2007-10-30 Thread James Bottomley
On Mon, 2007-10-29 at 14:26 -0600, Yang, Bo wrote: James, We submitted the 03.16-rc1 (megaraid_sas) patches about three weeks back. Do you have any feedback or we need to re-submit the patches? Randy Dunlap asked you why the module parameters were invisible ... is there a reason (if not

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Stefan Richter
James Bottomley wrote: OK, so is this latest revision acceptable to everyone? No complaint from me. (I'm more or less by accident in this thread anyway. Once this feature is available in mainline, I may have use for it in drivers/firewire/ though.) Thanks, -- Stefan Richter -=-=-=== =-=-

[PATCH 1/2] Wean NCR_Q720 off the dma_declare_coherent_memory interface

2007-10-30 Thread Matthew Wilcox
By restructuring the ncr53c8xx driver a little, we can provide the same functionality as the dma_declare_coherent_memory interface without touching the generic dma paths. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- drivers/scsi/NCR_Q720.c | 45 ---

[PATCH 2/2] Remove dma_coherent_mem interface

2007-10-30 Thread Matthew Wilcox
This interface only had one user (and two implementations). It complicates other work, so remove it. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] --- Documentation/DMA-API.txt | 78 Documentation/driver-model/devres.txt |1 -

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Kay Sievers
On Tue, 2007-10-30 at 13:25 -0500, James Bottomley wrote: On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote: James Bottomley wrote: struct attribute_group { const char *name; + int (*filter_show)(struct kobject *, int);

[PATCH 1/1] aacraid: forced reset override

2007-10-30 Thread Salyzyn, Mark
Some of our vendors have requested that our adapters ignore the hardware reset attempts during recovery and have enforced this with changes in Adapter Firmware. Some of our customers have requested the option to be able to reset the adapter under adverse adapter failure, we even had a few defects

Re: [PATCH 2/2] Remove dma_coherent_mem interface

2007-10-30 Thread James Bottomley
On Tue, 2007-10-30 at 15:43 -0400, Matthew Wilcox wrote: This interface only had one user (and two implementations). It complicates other work, so remove it. Its design was basically to facilitate the use of bus remote memory. There's a long thread somewhere discussing this with the ARM people.

Re: [PATCH 2/2] Remove dma_coherent_mem interface

2007-10-30 Thread Matthew Wilcox
On Tue, Oct 30, 2007 at 03:26:31PM -0500, James Bottomley wrote: Its design was basically to facilitate the use of bus remote memory. There's a long thread somewhere discussing this with the ARM people. They had some type of SoC implementation that needed to allocate local memory for device

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote: I just don't see the reason why expressing a boolean as an integer. Some advantage? This is C, not Java, or some other highly-typed language. if (int) and if (ptr) are perfectly acceptable in C.

Re: Questions about scsi.c

2007-10-30 Thread Rob Landley
On Tuesday 30 October 2007 9:43:29 am James Bottomley wrote: On Tue, 2007-10-30 at 08:34 -0400, Jeff Garzik wrote: Randy Dunlap wrote: On Thu, 25 Oct 2007 16:40:35 -0500 Rob Landley wrote: On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote: !E is for exported symbols and that

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Mark M. Hoffman
Hi James: * James Bottomley [EMAIL PROTECTED] [2007-10-30 13:25:43 -0500]: On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote: James Bottomley wrote: struct attribute_group { const char *name; + int (*filter_show)(struct kobject *,

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Kay Sievers
On Oct 31, 2007 1:40 AM, Mark M. Hoffman [EMAIL PROTECTED] wrote: * James Bottomley [EMAIL PROTECTED] [2007-10-30 13:25:43 -0500]: On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote: James Bottomley wrote: struct attribute_group { const char *name; +

Re: [PATCH RESEND] SCSI not showing tray status correctly

2007-10-30 Thread James Bottomley
On Sat, 2007-10-27 at 22:58 +, Maarten Bressers wrote: This patch is too simplistic. ide-cd.c:ide_cdrom_drive_status() looks to be a reasonable implementation. However, the worry is that GET_EVENT_NOTIFICATION is a MMC command; devices not conforming to MMC won't support it. In

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Greg KH
On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote: James Bottomley wrote: struct attribute_group { const char *name; + int (*filter_show)(struct kobject *, int);

[PATCH] aacraid: don't assign cpu_to_le32(constant) to u8

2007-10-30 Thread Stephen Rothwell
Noticed on PowerPC allmod config build: drivers/scsi/aacraid/commsup.c:1342: warning: large integer implicitly truncated to unsigned type drivers/scsi/aacraid/commsup.c:1343: warning: large integer implicitly truncated to unsigned type drivers/scsi/aacraid/commsup.c:1344: warning: large integer

Re: BUG in: Driver core: convert block from raw kobjects to core devices (fwd)

2007-10-30 Thread Greg KH
On Mon, Oct 29, 2007 at 02:47:59PM -0400, Alan Stern wrote: On Mon, 29 Oct 2007, James Bottomley wrote: I'm not sure if we can do this patch. If you kill a device, you see there's a processing state in scsi_prep_fn() for SDEV_DEL, which has a printk message I see quite often when I

Re: BUG in: Driver core: convert block from raw kobjects to core devices (fwd)

2007-10-30 Thread Greg KH
On Mon, Oct 29, 2007 at 08:13:17PM +0100, Kay Sievers wrote: On Mon, 2007-10-29 at 14:47 -0400, Alan Stern wrote: On Mon, 29 Oct 2007, James Bottomley wrote: I'm not sure if we can do this patch. If you kill a device, you see there's a processing state in scsi_prep_fn() for SDEV_DEL,

Re: [PATCH 2/2] Remove dma_coherent_mem interface

2007-10-30 Thread Paul Mundt
On Tue, Oct 30, 2007 at 02:35:14PM -0600, Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 03:26:31PM -0500, James Bottomley wrote: Its design was basically to facilitate the use of bus remote memory. There's a long thread somewhere discussing this with the ARM people. They had some type of