RE: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

2008-02-05 Thread Ballabio_Dario
Good to know that somebody still uses the Ultrastor 14f board :). Yes, this typo was introduced by somebody doing massive editing to all scsi drivers long ago. Cheers, --db -Original Message- From: Roel Kluin [mailto:[EMAIL PROTECTED] Sent: Monday, February 04, 2008 11:37 PM To:

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
On Feb 4, 2008 11:57 PM, Jeff Garzik [EMAIL PROTECTED] wrote: Networked block devices are attractive because the concepts and implementation are more simple than networked filesystems... but usually you want to run some sort of filesystem on top. At that point you might as well run NFS or

Re: [PATCH][drivers/scsi/u14-34f.c] duplicate test 'SCpnt-sc_data_direction == DMA_FROM_DEVICE'

2008-02-05 Thread Roel Kluin
[EMAIL PROTECTED] wrote: Good to know that somebody still uses the Ultrastor 14f board :). Yes, this typo was introduced by somebody doing massive editing to all scsi drivers long ago. Cheers, --db Actually, I do not own a Ultrastor 14f board. I found this by searching for if (test) ...

Re: [patch 08/13] sg: nopage

2008-02-05 Thread Andrew Morton
On Mon, 04 Feb 2008 23:53:21 -0800 [EMAIL PROTECTED] wrote: From: Nick Piggin [EMAIL PROTECTED] Convert SG from nopage to fault. Please give this some additional attention. We'd like to remove vm_operations_struct.nopage() altogether and we can't do that while it's hanging around in

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-05 Thread Boaz Harrosh
On Mon, Feb 04 2008 at 22:05 +0200, Alan Stern [EMAIL PROTECTED] wrote: On Sun, 3 Feb 2008, Matthew Dharm wrote: But, the modifications to usb_stor_access_xfer_buf() look good -- no request from a sub-driver should be allowed to scribble into memory. The current code does make the implicit

Re: [PATCH 5/24][RFC] dpt_i2o: Use new scsi_eh_cpy_sense()

2008-02-05 Thread Boaz Harrosh
On Mon, Feb 04 2008 at 20:32 +0200, Salyzyn, Mark [EMAIL PROTECTED] wrote: ACK with condition that community accepts the RFC's entire premise. The removed code that shunted the REQUEST_SENSE was based on the assumption that the sense data in the current scsi command packet was left over from

Re: [PATCH 0/7] blk_end_request: full I/O completion handler

2008-02-05 Thread Jens Axboe
On Tue, Feb 05 2008, S, Chandrakala (STSD) wrote: Hello, We would like to know in which kernel version these patches are available. They were merged after 2.6.24 was released, so they will show up in the 2.6.25 kernel. -- Jens Axboe - To unsubscribe from this list: send the line

RE: [PATCH 0/7] blk_end_request: full I/O completion handler

2008-02-05 Thread S, Chandrakala (STSD)
Hello, We would like to know in which kernel version these patches are available. Thanks, Chandrakala -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jens Axboe Sent: Monday, September 03, 2007 1:16 PM To: Kiyoshi Ueda Cc: [EMAIL PROTECTED];

diskdump fails on x3850 (x86_64)

2008-02-05 Thread Ciju Rajan K
Hello folks, Diskdump on x3850 with adp94xx driver is not working (Redhat Enterprise Linux 4.6). 'Service diskdump restart' fails. Is there any plan to support it? Thanks Ciju - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED]

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Olivier Galibert
On Mon, Feb 04, 2008 at 05:57:47PM -0500, Jeff Garzik wrote: iSCSI and NBD were passe ideas at birth. :) Networked block devices are attractive because the concepts and implementation are more simple than networked filesystems... but usually you want to run some sort of filesystem on top.

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-05 Thread Ke Wei
Added support for hotplug and wide port. Signed-off-by: Ke Wei [EMAIL PROTECTED] --- drivers/scsi/mvsas.c | 445 ++ 1 files changed, 339 insertions(+), 106 deletions(-) diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c index

RE: [PATCH 5/24][RFC] dpt_i2o: Use new scsi_eh_cpy_sense()

2008-02-05 Thread Salyzyn, Mark
I do not think the midlayer needs to be fixed. I think this was a bug/feature that presented itself in the 2.2 tree when we were developing this driver in 1996... Sincerely -- Mark Salyzyn -Original Message- From: Boaz Harrosh [mailto:[EMAIL PROTECTED] Sent: Tuesday, February 05,

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: James Bottomley schrieb: These are both features being independently worked on, are they not? Even if they weren't, the combination of the size of SCST in kernel plus the problem of having to find a migration

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 05:43:10 +0100 Matteo Tescione [EMAIL PROTECTED] wrote: Hi all, And sorry for intrusion, i am not a developer but i work everyday with iscsi and i found it fantastic. Altough Aoe, Fcoe and so on could be better, we have to look in real world implementations what is needed

Re: new scsi sense handling

2008-02-05 Thread FUJITA Tomonori
On Mon, 4 Feb 2008 18:39:22 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, Boaz Harrosh [EMAIL PROTECTED] wrote: There are 3 usages of sense handling in drivers 1. sense is available in driver internal structure and is mem-copied to upper level 2. A

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Mon, 4 Feb 2008 20:07:01 -0600 Chris Weiss [EMAIL PROTECTED] wrote: On Feb 4, 2008 11:30 AM, Douglas Gilbert [EMAIL PROTECTED] wrote: Alan Cox wrote: better. So for example, I personally suspect that ATA-over-ethernet is way better than some crazy SCSI-over-TCP crap, but I'm

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-05 Thread Alan Stern
On Tue, 5 Feb 2008, Boaz Harrosh wrote: However the interface to usb_stor_access_xfer_buf() will have to change slightly. Right now if it sees that *sgptr is NULL, it assumes this means it should start at the beginning of the s-g buffer. But with Boaz's change, *sgptr == NULL means the

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread James Bottomley
On Mon, 2008-02-04 at 21:35 -0800, Luben Tuikov wrote: I guess the same could be said for STGT and SCST, right? You mean both of their kernel pieces are modular? That's correct. No, you know very well what I mean. By the same logic you're preaching to include your solution part

Re: [patch 01/13] git-scsi-misc: fix isa/pcmcia compile problem

2008-02-05 Thread James Bottomley
On Mon, 2008-02-04 at 23:53 -0800, [EMAIL PROTECTED] wrote: From: Tejun Heo [EMAIL PROTECTED] aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given

[PATCH] [SCSI] fix BUG when sum(scatterlist) bufflen

2008-02-05 Thread Tony Battersby
When sending a SCSI command to a tape drive via the SCSI Generic (sg) driver, if the command has a data transfer length more than scatter_elem_sz (32 KB default) and not a multiple of 512, then I either hit BUG_ON(!valid_dma_direction(direction)) in dma_unmap_sg() or else the command never

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Alan D. Brunelle wrote: commit 9b73e76f3cf63379dcf45fcd4f112f5812418d0a Merge: 50d9a12... 23c3e29... Author: Linus Torvalds [EMAIL PROTECTED] Date: Fri Jan 25 17:19:08 2008 -0800 Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6 *

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Tomasz Chmielewski
FUJITA Tomonori schrieb: On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: James Bottomley schrieb: These are both features being independently worked on, are they not? Even if they weren't, the combination of the size of SCST in kernel plus the problem of having

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Andrew Vasquez wrote: On Tue, 05 Feb 2008, Alan D. Brunelle wrote: commit 9b73e76f3cf63379dcf45fcd4f112f5812418d0a Merge: 50d9a12... 23c3e29... Author: Linus Torvalds [EMAIL PROTECTED] Date: Fri Jan 25 17:19:08 2008 -0800 Merge

Re: [PATCH 1/24][RFC] scsi_eh: Define new API for sense handling

2008-02-05 Thread Boaz Harrosh
On Mon, Feb 04 2008 at 19:33 +0200, James Bottomley [EMAIL PROTECTED] wrote: On Mon, 2008-02-04 at 17:30 +0200, Boaz Harrosh wrote: This patch defines a new API for sense handling. All drivers will be converted to this API, before the sense handling implementation will change. API is as

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Ming Zhang
On Tue, 2008-02-05 at 17:07 +0100, Tomasz Chmielewski wrote: FUJITA Tomonori schrieb: On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: James Bottomley schrieb: These are both features being independently worked on, are they not? Even if they weren't,

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Andrew Vasquez wrote: Could you load the (default 2.6.24) driver with ql2xextended_error_logging modules parameter set: # insmod qla2xxx ql2xextended_error_logging=1 and send the resultant kernel logs? Could you tray the patch referenced here: qla2xxx:

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
Regarding the performance tests I promised to perform: although until now I only have been able to run two tests (STGT + iSER versus SCST + SRP), the results are interesting. I will run the remaining test cases during the next days. About the test setup: dd and xdd were used to transfer 2 GB of

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Alan D. Brunelle
Andrew Vasquez wrote: On Tue, 05 Feb 2008, Alan D. Brunelle wrote: commit 9b73e76f3cf63379dcf45fcd4f112f5812418d0a Merge: 50d9a12... 23c3e29... Author: Linus Torvalds [EMAIL PROTECTED] Date: Fri Jan 25 17:19:08 2008 -0800 Merge

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Alan D. Brunelle
Andrew Vasquez wrote: On Tue, 05 Feb 2008, Andrew Vasquez wrote: On Tue, 05 Feb 2008, Alan D. Brunelle wrote: commit 9b73e76f3cf63379dcf45fcd4f112f5812418d0a Merge: 50d9a12... 23c3e29... Author: Linus Torvalds [EMAIL PROTECTED] Date: Fri Jan 25 17:19:08 2008 -0800 Merge

Re: 2.6.24 regression w/ QLA2300

2008-02-05 Thread Andrew Vasquez
On Tue, 05 Feb 2008, Alan D. Brunelle wrote: and send the resultant kernel logs? Here's the output to the console (if there are other logs you need, let me know). I'll try the patch next, and sorry, hadn't realized merges were still coming in under 2.6.24 in Linus' tree... QLogic Fibre

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 17:07:07 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: FUJITA Tomonori schrieb: On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: James Bottomley schrieb: These are both features being independently worked on, are they not? Even

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-05 Thread Boaz Harrosh
On Tue, Feb 05 2008 at 17:42 +0200, Alan Stern [EMAIL PROTECTED] wrote: On Tue, 5 Feb 2008, Boaz Harrosh wrote: However the interface to usb_stor_access_xfer_buf() will have to change slightly. Right now if it sees that *sgptr is NULL, it assumes this means it should start at the beginning

Re: (fwd) Bug#11922: I/O error on blank tapes

2008-02-05 Thread Kai Makisara
On Mon, 4 Feb 2008, James Bottomley wrote: On Mon, 2008-02-04 at 22:28 +0100, Borislav Petkov wrote: On Mon, Feb 04, 2008 at 03:22:06PM +0100, maximilian attems wrote: (Added Bart to CC) hello borislav, may i forward you that *old* Debian kernel bug, have seen you

Re: [PATCH 21/24][RFC] scsi_tgt: use of sense accessors

2008-02-05 Thread FUJITA Tomonori
On Tue, 5 Feb 2008 11:21:33 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote on Mon, 04 Feb 2008 19:53 +0200: FIXME: I need help with this driver (Pete?) I used scsi_sense() in a none const way. But since scsi_tgt is the ULD here, it can just access it's own

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Erez Zilber
Bart Van Assche wrote: On Jan 30, 2008 12:32 AM, FUJITA Tomonori [EMAIL PROTECTED] wrote: iSER has parameters to limit the maximum size of RDMA (it needs to repeat RDMA with a poor configuration)? Please specify which parameters you are referring to. As you know I had already

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Erez Zilber
Bart Van Assche wrote: As you probably know there is a trend in enterprise computing towards networked storage. This is illustrated by the emergence during the past few years of standards like SRP (SCSI RDMA Protocol), iSCSI (Internet SCSI) and iSER (iSCSI Extensions for RDMA). Two different

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Matteo Tescione
On 5-02-2008 14:38, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: James Bottomley schrieb: These are both features being independently worked on, are they not? Even if they weren't, the combination of the size of

aic7xxx build failure

2008-02-05 Thread Adrian Bunk
Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make O=../out/x86-full ... SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h CC drivers/scsi/aic7xxx/aic79xx_core.o gcc: drivers/scsi/aic7xxx/aic79xx_core.c:

Re: [PATCH] bugfix for an underflow condition in usb storage isd200.c

2008-02-05 Thread Matthew Dharm
On Mon, Feb 04, 2008 at 03:05:58PM -0500, Alan Stern wrote: On Sun, 3 Feb 2008, Matthew Dharm wrote: I think the correct approach is to modify those routines so that they will never overrun the s-g buffer (like Boaz has done), and _document_ this behavior. Then the callers can feel free

Re: [PATCH 21/24][RFC] scsi_tgt: use of sense accessors

2008-02-05 Thread Jeff Garzik
FUJITA Tomonori wrote: On Tue, 5 Feb 2008 11:21:33 -0500 Pete Wyckoff [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote on Mon, 04 Feb 2008 19:53 +0200: FIXME: I need help with this driver (Pete?) I used scsi_sense() in a none const way. But since scsi_tgt is the ULD here, it can

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Jeff Garzik
Bart Van Assche wrote: On Feb 4, 2008 11:57 PM, Jeff Garzik [EMAIL PROTECTED] wrote: Networked block devices are attractive because the concepts and implementation are more simple than networked filesystems... but usually you want to run some sort of filesystem on top. At that point you might

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Jeff Garzik
Olivier Galibert wrote: On Mon, Feb 04, 2008 at 05:57:47PM -0500, Jeff Garzik wrote: iSCSI and NBD were passe ideas at birth. :) Networked block devices are attractive because the concepts and implementation are more simple than networked filesystems... but usually you want to run some sort

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make O=../out/x86-full ... SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h CC

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make O=../out/x86-full ... SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h CC

Re: aic7xxx build failure

2008-02-05 Thread Adrian Bunk
On Tue, Feb 05, 2008 at 12:18:04PM -0600, James Bottomley wrote: On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make O=../out/x86-full ... SHIPPED

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 20:24 +0200, Adrian Bunk wrote: On Tue, Feb 05, 2008 at 12:18:04PM -0600, James Bottomley wrote: On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make

Re: aic7xxx build failure

2008-02-05 Thread Adrian Bunk
On Tue, Feb 05, 2008 at 12:30:56PM -0600, James Bottomley wrote: On Tue, 2008-02-05 at 20:24 +0200, Adrian Bunk wrote: On Tue, Feb 05, 2008 at 12:18:04PM -0600, James Bottomley wrote: On Tue, 2008-02-05 at 19:40 +0200, Adrian Bunk wrote: Commit

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread James Bottomley
This email somehow didn't manage to make it to the list (I suspect because it had html attachments). James --- From: Julian Satran [EMAIL PROTECTED] To: Nicholas A. Bellinger [EMAIL PROTECTED] Cc:

Re: aic7xxx build failure

2008-02-05 Thread Arjan van de Ven
On Tue, 05 Feb 2008 12:30:56 -0600 make: *** [sub-make] Error 2 Do I assume from this that you have different source and object directories? There shouldn't be a failure if this is building in /home/bunk/linux/kernel-2.6/git/linux-2.6/ because the source file should be there. James

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Vladislav Bolkhovitin
Erez Zilber wrote: Bart Van Assche wrote: As you probably know there is a trend in enterprise computing towards networked storage. This is illustrated by the emergence during the past few years of standards like SRP (SCSI RDMA Protocol), iSCSI (Internet SCSI) and iSER (iSCSI Extensions for

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Jeff Garzik
Vladislav Bolkhovitin wrote: Jeff Garzik wrote: iSCSI is way, way too complicated. I fully agree. From one side, all that complexity is unavoidable for case of multiple connections per session, but for the regular case of one connection per session it must be a lot simpler. Actually,

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 21:59 +0300, Vladislav Bolkhovitin wrote: Hmm, how can one write to an mmaped page and don't touch it? I meant from user space ... the writes are done inside the kernel. Sure, the mmap() approach agreed to be unpractical, but could you elaborate more on this

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Vladislav Bolkhovitin
Jeff Garzik wrote: iSCSI is way, way too complicated. I fully agree. From one side, all that complexity is unavoidable for case of multiple connections per session, but for the regular case of one connection per session it must be a lot simpler. Actually, think about those multiple

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread Luben Tuikov
--- On Tue, 2/5/08, James Bottomley [EMAIL PROTECTED] wrote: I guess the same could be said for STGT and SCST, right? You mean both of their kernel pieces are modular? That's correct. No, you know very well what I mean. By the same logic you're preaching to include

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Vladislav Bolkhovitin
Jeff Garzik wrote: Alan Cox wrote: better. So for example, I personally suspect that ATA-over-ethernet is way better than some crazy SCSI-over-TCP crap, but I'm biased for simple and low-level, and against those crazy SCSI people to begin with. Current ATAoE isn't. It can't support NCQ. A

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Vladislav Bolkhovitin
Linus Torvalds wrote: I'd assumed the move was primarily because of the difficulty of getting correct semantics on a shared filesystem .. not even shared. It was hard to get correct semantics full stop. Which is a traditional problem. The thing is, the kernel always has some internal

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Vladislav Bolkhovitin
James Bottomley wrote: On Mon, 2008-02-04 at 21:38 +0300, Vladislav Bolkhovitin wrote: James Bottomley wrote: On Mon, 2008-02-04 at 20:56 +0300, Vladislav Bolkhovitin wrote: James Bottomley wrote: On Mon, 2008-02-04 at 20:16 +0300, Vladislav Bolkhovitin wrote: James Bottomley

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Vladislav Bolkhovitin
Linus Torvalds wrote: So just going by what has happened in the past, I'd assume that iSCSI would eventually turn into connecting/authentication in user space with data transfers in kernel space. This is exactly how iSCSI-SCST (iSCSI target driver for SCST) is implemented, credits to IET and

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Bart Van Assche
On Feb 5, 2008 6:10 PM, Erez Zilber [EMAIL PROTECTED] wrote: One may claim that STGT should have lower performance than SCST because its data path is from userspace. However, your results show that for non-IB transports, they both show the same numbers. Furthermore, with IB there shouldn't be

Re: new scsi sense handling

2008-02-05 Thread Luben Tuikov
--- On Tue, 2/5/08, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Mon, 4 Feb 2008 18:39:22 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, Boaz Harrosh [EMAIL PROTECTED] wrote: There are 3 usages of sense handling in drivers 1. sense is available in driver

Re: aic7xxx build failure

2008-02-05 Thread Sam Ravnborg
On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote: On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make O=../out/x86-full ... SHIPPED

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-05 Thread Mike Christie
James Bottomley wrote: On Mon, 2008-02-04 at 12:15 -0800, Chandra Seetharaman wrote: On Mon, 2008-02-04 at 12:58 -0600, James Bottomley wrote: On Wed, 2008-01-23 at 16:32 -0800, Chandra Seetharaman wrote: Subject: scsi_dh: Add support for SDEV_PASSIVE From: Chandra Seetharaman [EMAIL

Re: aic7xxx build failure

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 21:06 +0100, Sam Ravnborg wrote: On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote: On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $ make

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 11:33 -0800, Luben Tuikov wrote: Wrong ... we don't export non-SCSI devices as SCSI (with the single and rather annoying exception of ATA via SAT). I didn't say you should do that. I had already mentioned that vendors export such controls as either enclosure or

Re: [PATCH] [SCSI] fix BUG when sum(scatterlist) bufflen

2008-02-05 Thread Mike Christie
Tony Battersby wrote: When sending a SCSI command to a tape drive via the SCSI Generic (sg) driver, if the command has a data transfer length more than scatter_elem_sz (32 KB default) and not a multiple of 512, then I either hit BUG_ON(!valid_dma_direction(direction)) in dma_unmap_sg() or else

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread Luben Tuikov
--- On Tue, 2/5/08, James Bottomley [EMAIL PROTECTED] wrote: Wrong ... we don't export non-SCSI devices as SCSI (with the single and rather annoying exception of ATA via SAT). I didn't say you should do that. I had already mentioned that vendors export such controls as either

Re: aic7xxx build failure

2008-02-05 Thread Adrian Bunk
On Tue, Feb 05, 2008 at 09:06:23PM +0100, Sam Ravnborg wrote: On Tue, Feb 05, 2008 at 07:47:35PM +0100, Sam Ravnborg wrote: On Tue, Feb 05, 2008 at 07:40:24PM +0200, Adrian Bunk wrote: Commit 8891fec65ac5b5a74b50c705e31b66c92c3eddeb broke aic7xxx compilation: -- snip -- $

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-05 Thread Luben Tuikov
--- On Tue, 2/5/08, Ke Wei [EMAIL PROTECTED] wrote: + for_each_phy(port-wide_port_phymap, no, j, mvi-chip-n_phy) { + mvs_write_port_cfg_addr(mvi, no, PHYR_WIDE_PORT); + mvs_write_port_cfg_data(mvi, no , port-wide_port_phymap); + } else { +

Re: aic7xxx build failure

2008-02-05 Thread Sam Ravnborg
index 4c54954..6aa49e7 100644 --- a/drivers/scsi/aic7xxx/Makefile +++ b/drivers/scsi/aic7xxx/Makefile @@ -44,8 +44,8 @@ clean-files += aic79xx_seq.h aic79xx_reg.h aic79xx_reg_print.c # Dependencies for generated files need to be listed explicitly -$(addprefix

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-05 Thread Mike Anderson
Mike Christie [EMAIL PROTECTED] wrote: When IO is sent to a path that cannot execute IO optimally, the scsi hw handler hook for sense processing (see rdac_check_sense in [PATCH 8/9] scsi_dh: add lsi rdac device handler and the scsi_error.c hook in in scsi_dh: add skeleton for SCSI Device

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Nicholas A. Bellinger
On Tue, 2008-02-05 at 22:21 +0300, Vladislav Bolkhovitin wrote: Jeff Garzik wrote: iSCSI is way, way too complicated. I fully agree. From one side, all that complexity is unavoidable for case of multiple connections per session, but for the regular case of one connection per session

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread Andrew Morton
On Sun, 03 Feb 2008 18:16:51 -0600 James Bottomley [EMAIL PROTECTED] wrote: From: James Bottomley [EMAIL PROTECTED] Date: Sun, 3 Feb 2008 15:40:56 -0600 Subject: [SCSI] enclosure: add support for enclosure services The enclosure misc device is really just a library providing sysfs

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Nicholas A. Bellinger
On Tue, 2008-02-05 at 14:12 -0500, Jeff Garzik wrote: Vladislav Bolkhovitin wrote: Jeff Garzik wrote: iSCSI is way, way too complicated. I fully agree. From one side, all that complexity is unavoidable for case of multiple connections per session, but for the regular case of one

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-05 Thread Chandra Seetharaman
On Tue, 2008-02-05 at 13:56 -0800, Mike Anderson wrote: Mike Christie [EMAIL PROTECTED] wrote: When IO is sent to a path that cannot execute IO optimally, the scsi hw handler hook for sense processing (see rdac_check_sense in [PATCH 8/9] scsi_dh: add lsi rdac device handler and the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Nicholas A. Bellinger
On Tue, 2008-02-05 at 22:01 +0300, Vladislav Bolkhovitin wrote: Jeff Garzik wrote: Alan Cox wrote: better. So for example, I personally suspect that ATA-over-ethernet is way better than some crazy SCSI-over-TCP crap, but I'm biased for simple and low-level, and against those crazy SCSI

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Nicholas A. Bellinger
On Tue, 2008-02-05 at 16:48 -0800, Nicholas A. Bellinger wrote: On Tue, 2008-02-05 at 22:01 +0300, Vladislav Bolkhovitin wrote: Jeff Garzik wrote: Alan Cox wrote: better. So for example, I personally suspect that ATA-over-ethernet is way better than some crazy SCSI-over-TCP crap,

Re: new scsi sense handling

2008-02-05 Thread FUJITA Tomonori
On Tue, 5 Feb 2008 11:43:58 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Tue, 2/5/08, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Mon, 4 Feb 2008 18:39:22 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, Boaz Harrosh [EMAIL PROTECTED] wrote: There

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread FUJITA Tomonori
On Tue, 05 Feb 2008 18:09:15 +0100 Matteo Tescione [EMAIL PROTECTED] wrote: On 5-02-2008 14:38, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote: James Bottomley schrieb: These are both features being

Re: Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Nicholas A. Bellinger
On Tue, 2008-02-05 at 16:11 -0800, Nicholas A. Bellinger wrote: On Tue, 2008-02-05 at 22:21 +0300, Vladislav Bolkhovitin wrote: Jeff Garzik wrote: iSCSI is way, way too complicated. I fully agree. From one side, all that complexity is unavoidable for case of multiple connections

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-05 Thread Nicholas A. Bellinger
On Wed, 2008-02-06 at 10:29 +0900, FUJITA Tomonori wrote: On Tue, 05 Feb 2008 18:09:15 +0100 Matteo Tescione [EMAIL PROTECTED] wrote: On 5-02-2008 14:38, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Tue, 05 Feb 2008 08:14:01 +0100 Tomasz Chmielewski [EMAIL PROTECTED] wrote:

Re: new scsi sense handling

2008-02-05 Thread Luben Tuikov
--- On Tue, 2/5/08, FUJITA Tomonori [EMAIL PROTECTED] wrote: --- On Tue, 2/5/08, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Mon, 4 Feb 2008 18:39:22 -0800 (PST) Luben Tuikov [EMAIL PROTECTED] wrote: --- On Mon, 2/4/08, Boaz Harrosh [EMAIL PROTECTED] wrote: There are 3

Re: [PATCH] enclosure: add support for enclosure services

2008-02-05 Thread James Bottomley
On Tue, 2008-02-05 at 16:12 -0800, Andrew Morton wrote: On Sun, 03 Feb 2008 18:16:51 -0600 James Bottomley [EMAIL PROTECTED] wrote: From: James Bottomley [EMAIL PROTECTED] Date: Sun, 3 Feb 2008 15:40:56 -0600 Subject: [SCSI] enclosure: add support for enclosure services The