Re: Investigating potential flaw in scsi error handling

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 22:59 +0100, Elias Oltmanns wrote: > Hi there, > > I'm experiencing system lockups with 2.6.24 which I believe to be > related to scsi error handling. Actually, I have patched the mainline > kernel with a disk shock protection patch [1] and in my case it is indeed > the shock

[PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
[PATCH] scsi: ses fix mem leaking when fail to add intf fix leaking with scomp leaking when failing. also remove one extra space. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/ses.c === --- linux-2.6.or

Investigating potential flaw in scsi error handling

2008-02-09 Thread Elias Oltmanns
Hi there, I'm experiencing system lockups with 2.6.24 which I believe to be related to scsi error handling. Actually, I have patched the mainline kernel with a disk shock protection patch [1] and in my case it is indeed the shock protection mechanism that triggers the lockups. However, some rather

Re: [PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
On Feb 9, 2008 7:00 AM, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-09 at 04:13 -0800, Yinghai Lu wrote: > > [PATCH] scsi: ses fix for len and mem leaking when fail to add intf > > > > change to u32 before left shifting char > > This one is a bit unnecessary; C promotion rules gu

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-09 Thread Joshua Hoblitt
Hi James, I can give it a try. What commit id do you think fixed it? -J -- On Sat, Feb 09, 2008 at 12:01:16PM -0600, James Bottomley wrote: > > On Sat, 2008-02-09 at 16:31 +0100, Kim H??jgaard-Hansen wrote: > > The following was reported by Joshua Hoblitt on Gentoo bugzilla when > > using the

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 09:35 -1000, Joshua Hoblitt wrote: > Hi James, > > I can give it a try. What commit id do you think fixed it? commit 76d78300a6eb8b7f08e47703b7e68a659ffc2053 Author: Nick Cheng <[EMAIL PROTECTED]> Date: Mon Feb 4 23:53:24 2008 -0800 [SCSI] arcmsr: updates (1.20.00.1

Re: can all 53c7xx-related stuff be removed?

2008-02-09 Thread Robert P. J. Day
On Sat, 9 Feb 2008, Matthew Wilcox wrote: > On Sat, Feb 09, 2008 at 02:12:07PM -0500, Robert P. J. Day wrote: > > On Sat, 9 Feb 2008, Matthew Wilcox wrote: > > > On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote: > > > > just an observation that, even though 53c7xx content has bee

Re: can all 53c7xx-related stuff be removed?

2008-02-09 Thread Matthew Wilcox
On Sat, Feb 09, 2008 at 02:12:07PM -0500, Robert P. J. Day wrote: > On Sat, 9 Feb 2008, Matthew Wilcox wrote: > > On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote: > > > just an observation that, even though 53c7xx content has been > > > officially removed, there are still a few d

Re: can all 53c7xx-related stuff be removed?

2008-02-09 Thread Robert P. J. Day
On Sat, 9 Feb 2008, Matthew Wilcox wrote: > On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote: > > just an observation that, even though 53c7xx content has been > > officially removed, there are still a few droppings hanging around the > > tree: > > Erm. It's not just a driver,

Re: can all 53c7xx-related stuff be removed?

2008-02-09 Thread Matthew Wilcox
On Sat, Feb 09, 2008 at 11:54:43AM -0500, Robert P. J. Day wrote: > just an observation that, even though 53c7xx content has been > officially removed, there are still a few droppings hanging around the > tree: Erm. It's not just a driver, it's also the name of some chips. > $ grep -r 53c7xx *

Re: arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 16:31 +0100, Kim Højgaard-Hansen wrote: > The following was reported by Joshua Hoblitt on Gentoo bugzilla when > using the arcmsr driver (see https://bugs.gentoo.org/208493) > > When starting up the Areca RAID card http pass through proxy called > archttp dmesg is completely

[Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-09 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9880 --- Comment #6 from [EMAIL PROTECTED] 2008-02-09 09:34 --- Reply-To: [EMAIL PROTECTED] On Sat, 2008-02-09 at 17:21 +, Russell King wrote: > On Sat, Feb 09, 2008 at 10:51:16AM -0600, James Bottomley wrote: > > On Mon, 2008-02-04 at 0

RE: [PATCH 1/3] mpt fusion: Request I/O resources only whenrequired

2008-02-09 Thread James Bottomley
On Sun, 2008-02-10 at 01:26 +0800, Prakash, Sathya wrote: > Thanks James for pointing the missing of checkpatch.pl check. I will do > it before submitting the future patches. Great, thanks ... I still haven't seen PATCH 2/3 in this series, by the way. James - To unsubscribe from this list: send

Re: [Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 17:21 +, Russell King wrote: > On Sat, Feb 09, 2008 at 10:51:16AM -0600, James Bottomley wrote: > > On Mon, 2008-02-04 at 08:19 +, Russell King wrote: > > > On Sun, Feb 03, 2008 at 09:55:37PM -0600, James Bottomley wrote: > > > > I've cc'd the people responsible for th

RE: [PATCH 1/3] mpt fusion: Request I/O resources only whenrequired

2008-02-09 Thread Prakash, Sathya
Thanks James for pointing the missing of checkpatch.pl check. I will do it before submitting the future patches. -Original Message- From: James Bottomley [mailto:[EMAIL PROTECTED] Sent: Friday, February 08, 2008 10:54 PM To: Prakash, Sathya Cc: linux-scsi@vger.kernel.org; Moore, Eric Su

[Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-09 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9880 --- Comment #5 from [EMAIL PROTECTED] 2008-02-09 09:24 --- On Sat, Feb 09, 2008 at 10:51:16AM -0600, James Bottomley wrote: > On Mon, 2008-02-04 at 08:19 +, Russell King wrote: > > On Sun, Feb 03, 2008 at 09:55:37PM -0600, James Bott

Re: [Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-09 Thread Russell King
On Sat, Feb 09, 2008 at 10:51:16AM -0600, James Bottomley wrote: > On Mon, 2008-02-04 at 08:19 +, Russell King wrote: > > On Sun, Feb 03, 2008 at 09:55:37PM -0600, James Bottomley wrote: > > > I've cc'd the people responsible for this apparent bit of idiocy. Since > > > the API addition to dma

can all 53c7xx-related stuff be removed?

2008-02-09 Thread Robert P. J. Day
just an observation that, even though 53c7xx content has been officially removed, there are still a few droppings hanging around the tree: $ grep -r 53c7xx * arch/m68k/Makefile:# without -fno-strength-reduce the 53c7xx.c driver fails ;-( Documentation/scsi/sym53c8xx_2.txt:by the 53c7xx and 53c8

[Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-09 Thread bugme-daemon
http://bugzilla.kernel.org/show_bug.cgi?id=9880 --- Comment #4 from [EMAIL PROTECTED] 2008-02-09 08:52 --- Reply-To: [EMAIL PROTECTED] On Mon, 2008-02-04 at 08:19 +, Russell King wrote: > On Sun, Feb 03, 2008 at 09:55:37PM -0600, James Bottomley wrote: > > I've cc'd the people re

Re: [Bug 9880] dma_free_coherent in arcmsr when calling areca tools

2008-02-09 Thread James Bottomley
On Mon, 2008-02-04 at 08:19 +, Russell King wrote: > On Sun, Feb 03, 2008 at 09:55:37PM -0600, James Bottomley wrote: > > I've cc'd the people responsible for this apparent bit of idiocy. Since > > the API addition to dma_alloc_coherent() was the GFP flags so you could > > call it from interru

arcmsr + archttp64 calls dma_free_coherent() with irqs disabled - dmesg filled with warnings

2008-02-09 Thread Kim Højgaard-Hansen
The following was reported by Joshua Hoblitt on Gentoo bugzilla when using the arcmsr driver (see https://bugs.gentoo.org/208493) When starting up the Areca RAID card http pass through proxy called archttp dmesg is completely filled with messages as: WARNING: at arch/x86/kernel/pci-dma_64.c:169

Re: [PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread James Bottomley
On Sat, 2008-02-09 at 04:13 -0800, Yinghai Lu wrote: > [PATCH] scsi: ses fix for len and mem leaking when fail to add intf > > change to u32 before left shifting char This one is a bit unnecessary; C promotion rules guarantee that everything is promoted to int (or above) before doing arithmetic.

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-09 Thread Alan Cox
On Fri, 08 Feb 2008 20:32:54 -0500 Douglas Gilbert <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > The word "illegal" has a precise dictionary meaning of "prohibited by > > law". > > Also "contrary to or forbidden by official rules, regulations, etc". The OED I have here doesn't seem to think

Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE

2008-02-09 Thread Matthew Wilcox
On Mon, Feb 04, 2008 at 01:19:30PM -0800, Chandra Seetharaman wrote: > The device does send these error messages currently, but it takes some > time to get the check condition back, which adds up the time to boot > especially when the # of LUNS is huge. > > For example, in my test configuration, I

[PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
[PATCH] scsi: ses fix for len and mem leaking when fail to add intf change to u32 before left shifting char also fix leaking with scomp leaking when failing. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/ses.c

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-09 Thread Luben Tuikov
--- On Fri, 2/8/08, Alan Cox <[EMAIL PROTECTED]> wrote: > The word "illegal" has a precise dictionary > meaning of "prohibited by > law". The error messages are therefore incorrect as so > far nobody has > made SCSI violations a criminal offence. > > This corrects scsi to match various other subsy