[PATCH] scsi/mvsas: Fix oops when ata command timeout.

2012-08-01 Thread majianpeng
Kernel message follows: [ 511.712011] sd 11:0:0:0: [sdf] command 8800a4e81400 timed out [ 511.712022] sas: Enter sas_scsi_recover_host busy: 1 failed: 1 [ 511.712024] sas: trying to find task 0x8800a4d24c80 [ 511.712026] sas: sas_scsi_find_task: aborting task 0x8800a4d24c80 [ 511.

[PATCH] scsi/mvsas: Fix memeleak when remove mvsas.ko.

2012-08-01 Thread majianpeng
unreferenced object 0x8800a83d6e80 (size 64): comm "insmod", pid 10288, jiffies 4296886959 (age 662.587s) hex dump (first 32 bytes): 01 04 01 00 00 00 00 00 00 00 a8 76 00 88 ff ff ...v 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 backtrace: [

RE: [PATCH] scsi/mvsas: Fix oops when ata command timeout.

2012-08-01 Thread Xiangliang Yu
Hi, Jianpeng I think MVSAS shouldn't care the completion sign here, just modify task state is ok. > -Original Message- > From: majianpeng [mailto:majianp...@gmail.com] > Sent: 2012年8月1日 15:15 > To: JBottomley > Cc: Xiangliang Yu; linux-scsi > Subject: [PATCH] scsi/mvsas: Fix oops when

Re: [PATCH V3 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-08-01 Thread Arnd Bergmann
On Thursday 26 July 2012, Vinayak Holikatti wrote: > -static void ufshcd_remove(struct pci_dev *pdev) > +void ufshcd_remove(struct ufs_hba *hba) > { > - struct ufs_hba *hba = pci_get_drvdata(pdev); > - > /* disable interrupts */ > ufshcd_int_config(hba, UFSHCD_INT_DISABLE); > -

Re: [PATCH V3 2/4] [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver

2012-08-01 Thread Arnd Bergmann
On Thursday 26 July 2012, Vinayak Holikatti wrote: > diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c > new file mode 100644 > index 000..d078744 > --- /dev/null > +++ b/drivers/scsi/ufs/ufshcd-pci.c > @@ -0,0 +1,228 @@ > +/* > + * Universal Flash Storage Host control

Re: [PATCH V3 0/4] [SCSI] ufs: Adds glue drivers to ufshcd

2012-08-01 Thread Arnd Bergmann
On Thursday 26 July 2012, Vinayak Holikatti wrote: > > This patch set adds following features > - Seggregate PCI specific code in ufshcd.c > - Adds PCI glue driver ufshcd-pci.c and ufshcd.c become core module > - Adds Platform glue driver ufshcd-pltfrm.c > - Update correct transfer size in Com

[PATCH 2/3] sd: handle errors in sd_start_stop_device()

2012-08-01 Thread Oliver Neukum
Errors are not handled correctly in sd_start_stop_device(). First, if a device cannot be stopped because a medium has been removed, this is not an error. This fixes a bug when suspending the system right after pulling a medium out of a card reader. Second, if the full system is to be suspended, a

[PATCH 3/3] sd: error handling synchronizing caches

2012-08-01 Thread Oliver Neukum
sd_sync_cache() can fail in several manners. As the error return is passed to the generic layer, it must be correctly processed. Failures due to unplugged devices or removed media should be ignored. In the other cases retryable and fatal errors must be differentiated. This fixes a problem with un

cleanup error handling during suspend/resume of sd

2012-08-01 Thread Oliver Neukum
This series fixes an issue mostly seen with eSATA devices and card readers. The errors don't arise on the SCSI level must be processed and sorted for the generic code, so that issue like recently disconnected devices don't impede system sleep. Signed-off-by: Oliver Neukum -- To unsubscribe from t

[PATCH 1/3] sd: SCSI error codes must not be returned to generic code

2012-08-01 Thread Oliver Neukum
sd_start_stop_device leaks SCSI specific error codes to the generic driver code Signed-off-by: Oliver Neukum --- drivers/scsi/sd.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 4df73e5..cef06f5 100644 --- a/drivers/scsi/

Re: [PATCH 3/3] sd: error handling synchronizing caches

2012-08-01 Thread James Bottomley
On Wed, 2012-08-01 at 16:44 +0200, Oliver Neukum wrote: > sd_sync_cache() can fail in several manners. > As the error return is passed to the generic layer, > it must be correctly processed. > > Failures due to unplugged devices or removed media > should be ignored. In the other cases retryable an

Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-08-01 Thread Paolo Bonzini
Il 20/07/2012 18:30, Paolo Bonzini ha scritto: > These commands cannot be issued right now without giving CAP_SYS_RAWIO to > the process who wishes to send them. These commands can be useful also to > non-privileged programs who have access to the block devices. For example > a virtual machine mo

Re: [PATCH 3/3] sd: error handling synchronizing caches

2012-08-01 Thread Mike Christie
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index a344220..49b0c52 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -1278,8 +1278,32 @@ static int sd_sync_cache(struct scsi_disk *sdkp) > > if (res) { > sd_print_result(sdkp, res); > + > i

Re: RE: [PATCH] scsi/mvsas: Fix oops when ata command timeout.

2012-08-01 Thread majianpeng
On 2012-08-01 19:21 Xiangliang Yu Wrote: >Hi, Jianpeng > >I think MVSAS shouldn't care the completion sign here, just modify task state >is ok. > > > [snip] >> >> Signed-off-by: Jianpeng Ma >> --- >> drivers/scsi/mvsas/mv_sas.c |5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >>