[PATCH] be2iscsi: cleanup format strings using literal string concatenations

2012-08-12 Thread Masatake YAMATO
In format strings for printk in be2iscsi, literal c string concatenations are used widely. However, the log output is a bit difficult to read because whitespaces are missed in the literal c strings like: SE_DEBUG(DBG_LVL_1, CQ Error %d, reset received/sent on CID

Re: [PATCH] be2iscsi: cleanup format strings using literal string concatenations

2012-08-12 Thread Joe Perches
On Mon, 2012-08-13 at 00:25 +0900, Masatake YAMATO wrote: In format strings for printk in be2iscsi, literal c string concatenations are used widely. However, the log output is a bit difficult to read because whitespaces are missed in the literal c strings like: SE_DEBUG(DBG_LVL_1, CQ

Re: [PATCH] libiscsi: avoid unnecessary multiple NULL assignments

2012-08-12 Thread Michael Christie
Replacing linux-scsi list with linux-kernel. On Aug 12, 2012, at 9:15 AM, Masatake YAMATO yam...@redhat.com wrote: In iscsi_free_task, NULL is assigned to task-sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session-lock, so multiple NULL