[PATCH] [SCSI] bfa: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/scsi/bfa/bfa_ioc.c | 3

[PATCH] [SCSI] lpfc 8.3.32: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/scsi/lpfc/lpfc_sli.c | 3

[PATCH v2] [SCSI] bfa: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- v1 - v2: add cleanup for

[V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
This patch contains the first set of the header files for csiostor driver. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- V2: - Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead. - Removed driver-specific return values, using errno values instead. - Retained

[V2 PATCH 9/9] cxgb4vf: Chelsio FCoE offload driver submission (header compatibility fixes).

2012-09-05 Thread Naresh Kumar Inna
This patch contains minor fixes to make cxgb4vf driver work with the updates to shared firmware/hardware header files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff

[V2 PATCH 0/9] csiostor: Chelsio FCoE offload driver submission

2012-09-05 Thread Naresh Kumar Inna
This is the initial submission of the Chelsio FCoE offload driver (csiostor) to the upstream kernel. This driver currently supports FCoE offload functionality over Chelsio T4-based 10Gb Converged Network Adapters. The following patches contain the driver sources for csiostor driver and updates to

[V2 PATCH 8/9] cxgb4: Chelsio FCoE offload driver submission (cxgb4 common header updates).

2012-09-05 Thread Naresh Kumar Inna
This patch contains updates to firmware/hardware header files shared between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4 source files. Signed-off-by: Naresh Kumar Inna nar...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-

Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

2012-09-05 Thread Paolo Bonzini
Il 04/09/2012 22:11, Nicholas A. Bellinger ha scritto: As tgt-tgt_lock is taken in virtscsi_queuecommand_multi() before the atomic_inc_return(tgt-reqs) check, it seems like using atomic_dec() w/o smp_mb__after_atomic_dec or tgt_lock access here is not using atomic.h accessors properly, no..?

[Ping^3] Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-05 Thread Paolo Bonzini
Il 28/08/2012 13:04, Paolo Bonzini ha scritto: Il 01/08/2012 17:53, Paolo Bonzini ha scritto: Il 20/07/2012 18:30, Paolo Bonzini ha scritto: These commands cannot be issued right now without giving CAP_SYS_RAWIO to the process who wishes to send them. These commands can be useful also to

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-05 Thread Aaron Lu
On Tue, Sep 04, 2012 at 08:47:15PM +0200, Oliver Neukum wrote: On Tuesday 04 September 2012 13:59:38 Alan Stern wrote: On Tue, 4 Sep 2012, Oliver Neukum wrote: On Tuesday 04 September 2012 22:24:34 Aaron Lu wrote: From: Aaron Lu aaron...@intel.com The ODD will be placed into

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-05 Thread Alan Stern
On Wed, 5 Sep 2012, Aaron Lu wrote: That flag is badly named. Something like insert_event_during_suspend would be better. This flag means, the reason the device gets runtime resumed is due to user as described by the above situation 2, not by software(e.g. by sr_check_events). I

Re: [V2 PATCH 1/9] csiostor: Chelsio FCoE offload driver submission (sources part 1).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 18:03:54 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +/* FCoE Adapter types its description */ +static struct csio_adap_desc csio_fcoe_adapters[] = { Tables like this should be const. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the

Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 18:03:55 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: This patch contains code for driver initialization, driver resource allocation and the Work Request module functionality. Driver initialization includes module entry/exit points, registration with PCI, FC transport

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r)) This is similar to existing round_up() in kernel.h could you use that? -- To unsubscribe from this list: send the line unsubscribe

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +#define CSIO_ASSERT(cond) \ +do { \ + if (unlikely(!((cond

Re: [V2 PATCH 1/9] csiostor: Chelsio FCoE offload driver submission (sources part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 9:53 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:54 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +/* FCoE Adapter types its description */ +static struct csio_adap_desc csio_fcoe_adapters[] = { Tables like this should be const. Thanks for reviewing. I

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 10:01 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r)) This is similar to existing round_up() in kernel.h could you use that? I will replace

Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 9:59 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:55 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: This patch contains code for driver initialization, driver resource allocation and the Work Request module functionality. Driver initialization includes module

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Naresh Kumar Inna
On 9/5/2012 10:03 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: + +#define CSIO_ASSERT(cond) \ +do { \

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-05 Thread Oliver Neukum
On Wednesday 05 September 2012 23:22:55 Aaron Lu wrote: On Tue, Sep 04, 2012 at 08:47:15PM +0200, Oliver Neukum wrote: On Tuesday 04 September 2012 13:59:38 Alan Stern wrote: What requirement are you talking about? The no media and door closed thing? How is that a layering violation?

Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region

2012-09-05 Thread Lukáš Czerner
On Fri, 17 Aug 2012, Martin K. Petersen wrote: Date: Fri, 17 Aug 2012 12:11:50 -0400 From: Martin K. Petersen martin.peter...@oracle.com To: Lukas Czerner lczer...@redhat.com Cc: linux-scsi@vger.kernel.org, jbottom...@parallels.com, ty...@mit.edu, pbonz...@redhat.com,

Re: [PATCH] scsi_debug: Fix off-by-one bug when unmapping region

2012-09-05 Thread Douglas Gilbert
On 12-08-17 12:11 PM, Martin K. Petersen wrote: Lukas == Lukas Czerner lczer...@redhat.com writes: Lukas Currently it is possible to unmap one more block than user Lukas requested to due to the off-by-one error in unmap_region(). This Lukas is probably due to the fact that the end variable

Re: [Ping^3] Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO

2012-09-05 Thread Ric Wheeler
On 09/05/2012 10:41 AM, Paolo Bonzini wrote: Il 28/08/2012 13:04, Paolo Bonzini ha scritto: Il 01/08/2012 17:53, Paolo Bonzini ha scritto: Il 20/07/2012 18:30, Paolo Bonzini ha scritto: These commands cannot be issued right now without giving CAP_SYS_RAWIO to the process who wishes to send

[PATCH] fc-transport: Remove unnecessary include

2012-09-05 Thread Robert Love
This header file is included in user space applications that are doing FC Passthrough. This include causes them to also include scsi/scsi.h. Since this header file doesn't actually need scsi/scsi.h, remove the include line. This patch was tested with 'make allyesconfig'. Signed-off-by: Robert

Re: [V2 PATCH 2/9] csiostor: Chelsio FCoE offload driver submission (sources part 2).

2012-09-05 Thread Stephen Hemminger
On Wed, 5 Sep 2012 23:13:46 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: On 9/5/2012 9:59 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:55 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: This patch contains code for driver initialization, driver resource allocation and

Re: [V2 PATCH 6/9] csiostor: Chelsio FCoE offload driver submission (headers part 1).

2012-09-05 Thread Ben Hutchings
On Wed, 2012-09-05 at 22:56 +0530, Naresh Kumar Inna wrote: On 9/5/2012 10:01 PM, Stephen Hemminger wrote: On Wed, 5 Sep 2012 18:03:59 +0530 Naresh Kumar Inna nar...@chelsio.com wrote: +#define CSIO_ROUNDUP(__v, __r)(((__v) + (__r) - 1) / (__r)) This is similar to

[PATCH] isci: Fix interrupt coalescing assumption of active TCs

2012-09-05 Thread Dave Jiang
We always assign a dummy task context to a port in order to address a silicon issue. We have 4 ports per controller. So when idle, there are always exactly 4 TCs active. The adaptive interrupt coalescing code uses number of active TCs to figure out the coalescing values. However, we never hit 0

Re: [PATCH] target: use list_move_tail instead of list_del/list_add_tail

2012-09-05 Thread Nicholas A. Bellinger
On Wed, 2012-09-05 at 14:42 +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun

Re: [PATCH v6 5/7] scsi: pm: add may_power_off flag

2012-09-05 Thread Aaron Lu
On Tue, Sep 04, 2012 at 06:01:22PM +0200, Oliver Neukum wrote: On Tuesday 04 September 2012 22:24:38 Aaron Lu wrote: From: Aaron Lu aaron...@intel.com Add a new flag may_power_off for scsi device, it gives the user a chance to control when the device is runtime suspended, can we remove

Re: [PATCH 2/5] virtio: introduce an API to set affinity for a virtqueue

2012-09-05 Thread Rusty Russell
Paolo Bonzini pbonz...@redhat.com writes: From: Jason Wang jasow...@redhat.com Sometimes, virtio device need to configure irq affinity hint to maximize the performance. Instead of just exposing the irq of a virtqueue, this patch introduce an API to set the affinity for a virtqueue. The api

Re: [PATCH 1/5] virtio-ring: move queue_index to vring_virtqueue

2012-09-05 Thread Rusty Russell
Paolo Bonzini pbonz...@redhat.com writes: From: Jason Wang jasow...@redhat.com Instead of storing the queue index in transport-specific virtio structs, this patch moves them to vring_virtqueue and introduces an helper to get the value. This lets drivers simplify their management and tracing

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-05 Thread Aaron Lu
On Tue, Sep 04, 2012 at 05:57:35PM +0200, Oliver Neukum wrote: diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 902b5a4..64ba43d 100644 --- a/drivers/ata/libata-acpi.c +++ b/drivers/ata/libata-acpi.c @@ -985,8 +985,10 @@ static void ata_acpi_wake_dev(acpi_handle

Re: [PATCH 0/4] qla4xxx: Updates for scsi misc branch.

2012-09-05 Thread Mike Christie
On 08/22/2012 06:45 AM, vikas.chaudh...@qlogic.com wrote: From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Vikas. Vikas Chaudhary (4): qla4xxx: Fix lockdep warning in

Re: [PATCH v6 1/7] scsi: sr: support runtime pm for ODD

2012-09-05 Thread Aaron Lu
On Wed, Sep 05, 2012 at 08:06:27PM +0200, Oliver Neukum wrote: 2 It's not easy to implement. Imagine user just inserts a disc, and the sr_suspend routine checks that door is closed so that it wants to suspend the device. But actually, after user just inserts a disc, he definitely wants to