[patch] [SCSI] lpfc: fix an '&&' vs '&' typo

2012-09-17 Thread Dan Carpenter
The intent here was clearly to do a bitwise AND similar to the others in this file. The current condition is never true. Signed-off-by: Dan Carpenter --- Only needed in linux-next. diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c index 7ffabb7..65f9fb6 100644 --- a/drivers

Re: [V4 PATCH 0/8] csiostor: Chelsio FCoE offload driver submission

2012-09-17 Thread Naresh Kumar Inna
Hi James, Could you please consider merging version V4 of the driver patches, if you think they are in good shape now? Thanks, Naresh. On 9/12/2012 10:48 PM, Naresh Kumar Inna wrote: > This is the initial submission of the Chelsio FCoE offload driver (csiostor) > to the upstream kernel. This dri

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-17 Thread Yijing Wang
On 2012/9/18 2:15, Giridhar Malavali wrote: > > > On 9/17/12 5:06 AM, "Yijing Wang" wrote: > >> [ 769.531289] qla2xxx [:08:00.0]-001d: : Found an ISP2532 irq 32 >> iobase 0xc90016bcc000. >> [ 769.531748] qla2xxx :08:00.0: irq 91 for MSI/MSI-X >> [ 769.531768] qla2xxx :08:00.0

Re: [PATCH] drivers/target/target_core_configfs.c: fix error return code

2012-09-17 Thread Nicholas A. Bellinger
On Mon, 2012-09-17 at 20:05 +0200, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > > A simplified version of the semantic match that finds this problem is as > follows: (http://cocc

Re: [PATCH 22/24] scsi: eesox: use __iomem pointers for MMIO

2012-09-17 Thread Russell King - ARM Linux
On Sat, Sep 15, 2012 at 10:30:43AM +, Arnd Bergmann wrote: > On Saturday 15 September 2012, Russell King - ARM Linux wrote: > > On Sat, Sep 15, 2012 at 08:00:35AM +, Arnd Bergmann wrote: > > > On Friday 14 September 2012, Russell King - ARM Linux wrote: > > > > On Fri, Sep 14, 2012 at 11:34

Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug

2012-09-17 Thread Giridhar Malavali
On 9/17/12 5:06 AM, "Yijing Wang" wrote: >[ 769.531289] qla2xxx [:08:00.0]-001d: : Found an ISP2532 irq 32 >iobase 0xc90016bcc000. >[ 769.531748] qla2xxx :08:00.0: irq 91 for MSI/MSI-X >[ 769.531768] qla2xxx :08:00.0: irq 92 for MSI/MSI-X >[ 799.503673] qla2xxx [:08:00.0

[PATCH] drivers/target/target_core_configfs.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } |

Re: Linux kernel crash (3.2.0-2-amd64) when trying to play audio CD

2012-09-17 Thread Borislav Petkov
On Thu, Sep 13, 2012 at 02:58:25PM +0200, Borislav Petkov wrote: > Here's the script, let me know how it goes: Here's a more correct version. I'm not saying yours won't work based on the rdmsr and setpci output on your box, but here's a version which should pay attention to one other workaround an

Re: [scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

2012-09-17 Thread Saurav Kashyap
>On Sat, 2012-09-15 at 07:57 +0800, Fengguang Wu wrote: >> Hi Saurav, >> >> FYI, there are new compile warnings show up in >> >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git >>for-next >> head: 71cfff4af0525891941199b142b759d00b293959 >> commit: 387fddaa3564503c9f82d091d

Re: [PATCH 1/2] scsi: sd: set ready_to_power_off for scsi disk

2012-09-17 Thread Aaron Lu
On Fri, Sep 14, 2012 at 09:54:16PM +0800, Aaron Lu wrote: > On Fri, Sep 14, 2012 at 11:26:29AM +0100, James Bottomley wrote: > > On Fri, 2012-09-14 at 16:48 +0800, Aaron Lu wrote: > > > So if we program the device to let it enter standby/stopped power > > > condition with the start_stop_unit comman

Re: [RESEND][PATCH][SCSI] mpt2sas: Fix for issue - Unable to boot from the drive connected to HBA

2012-09-17 Thread James Bottomley
On Wed, 2012-08-22 at 16:55 +0530, sreekanth.re...@lsi.com wrote: > Fix for issue - Unable to boot from the SAS drive connected to HBA > > This patch checks whether HBA is SAS2008 B0 controller. > if it is a SAS2008 B0 controller then it use IO-APIC interrupt instead of > MSIX, > as SAS2008 B0 co

Re: [scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

2012-09-17 Thread James Bottomley
On Sat, 2012-09-15 at 07:57 +0800, Fengguang Wu wrote: > Hi Saurav, > > FYI, there are new compile warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next > head: 71cfff4af0525891941199b142b759d00b293959 > commit: 387fddaa3564503c9f82d091d2ebe390f3af

RE: pm8001_hwi.c uldd_task - missing spin_lockirqsave?

2012-09-17 Thread Jack Wang
> > The file drivers/scsi/pm8001/pm8001_hwi.c contains the piece of code below, > at > the end of mpi_sata_completion() and mpi_sata_event(), which appears wrong. > While the test is opposite, the executed branch does exactly the same. I believe > one of the branches should spin_lockirqsave inste

pm8001_hwi.c uldd_task - missing spin_lockirqsave?

2012-09-17 Thread roel kluin
The file drivers/scsi/pm8001/pm8001_hwi.c contains the piece of code below, at the end of mpi_sata_completion() and mpi_sata_event(), which appears wrong. While the test is opposite, the executed branch does exactly the same. I believe one of the branches should spin_lockirqsave instead? not 100%