[PATCH] scsi/aacraid: user upper/lower_address() macro to avoid "right shift count >= width of type" warning.

2012-11-21 Thread Sebastian Andrzej Siewior
Avoids the following warning: |drivers/scsi/aacraid/src.c: In function 'aac_src_deliver_message': |drivers/scsi/aacraid/src.c:410:3: warning: right shift count >= width of type [enabled by default] |BUG_ON((u32)(address >> 32) != 0L); |^ |drivers/scsi/aacraid/src.c:434:2: warning: right sh

[PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-11-21 Thread Rob Evers
These patches replace the original t10 type 2 dif mempool implementation by increasing the block and scsi cdb maximum sizes from 16 to 32 bytes. The cdb embedded in the request structure can then be used for type 2 dif commands, or other 32 byte cdbs as required. Motivation for this is that type-2

[PATCH 2/2] Change dif type 2 commands to use embedded 32 byte cdb

2012-11-21 Thread Rob Evers
The original implementation of type 2 dif in sd.c used a mempool to allocate scsi cdbs that were 32 bytes in length. With the previous change in this set, 32 byte cdbs are available in the request structure, removing the need for the mempool. Also fixed up a comment regarding MAX_COMMAND_SIZE Si

[PATCH 1/2] Change the cdb size limits in block and scsi to 32 bytes

2012-11-21 Thread Rob Evers
Signed-off-by: Rob Evers --- include/linux/blkdev.h | 2 +- include/scsi/scsi_cmnd.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 1756001..cafce6e 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@

[PATCH] UAPI: (Scripted) Disintegrate include/rdma

2012-11-21 Thread David Howells
Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E. McKenney Acked-by: Dave Jones --- include/rdma/Kbuild |6 -- include/rdma/rdma_netlink.h | 36 +--- includ

[PATCH] UAPI: (Scripted) Disintegrate include/scsi/fc

2012-11-21 Thread David Howells
Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E. McKenney Acked-by: Dave Jones --- include/scsi/fc/Kbuild|4 include/uapi/scsi/fc/Kbuild |4 include/uapi/scsi/fc/fc_els.h |0 include/u

[PATCH] UAPI: (Scripted) Disintegrate include/scsi

2012-11-21 Thread David Howells
Signed-off-by: David Howells Acked-by: Arnd Bergmann Acked-by: Thomas Gleixner Acked-by: Michael Kerrisk Acked-by: Paul E. McKenney Acked-by: Dave Jones --- include/scsi/Kbuild |3 --- include/uapi/scsi/Kbuild|3 +++ include/uapi/scsi/scsi_bsg_fc.h |

Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-21 Thread Bart Van Assche
On 11/21/12 08:19, Hannes Reinecke wrote: On 11/20/2012 03:24 PM, Bart Van Assche wrote: If I interpret the SCSI error handler source code correctly then scsi_unjam_host() may proceed concurrently with scsi_remove_host(). This means that the LLD eh_abort_handler callback may get invoked after sc

Re: [PATCH 192/493] scsi: remove use of __devinit

2012-11-21 Thread Guennadi Liakhovetski
On Mon, 19 Nov 2012, Bill Pemberton wrote: > drivers/scsi/tmscsim.c| 16 +++--- Acked-by: Guennadi Liakhovetski Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the

Re: [PATCH 6/7] Fix race between starved list processing and device removal

2012-11-21 Thread Bart Van Assche
On 11/02/12 07:32, Chanho Min wrote: >> Yes. Here's the warning. >> For the trace below, I used scsi_device_get/scsi_device_put() in >> scsi_run_queue(). (A little different >>from your patch). But I think it's the same. > > I think it's correct. cancel_work_sync can sleep. It is caught under >

Re: [PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-11-21 Thread vinayak holikatti
On Wed, Nov 21, 2012 at 4:26 PM, James Bottomley wrote: > On Wed, 2012-11-21 at 16:02 +0530, vinayak holikatti wrote: >> On Wed, Nov 14, 2012 at 2:56 AM, James Bottomley >> wrote: >> > On Thu, 2012-10-18 at 17:37 +0530, vinayak holikatti wrote: >> >> I am Vacation will look into it when i am back

Re: [PATCH 192/493] scsi: remove use of __devinit

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:22:21PM -0500, Bill Pemberton wrote: > drivers/scsi/arm/acornscsi.c | 2 +- > drivers/scsi/arm/arxescsi.c | 2 +- > drivers/scsi/arm/cumana_1.c | 2 +- > drivers/scsi/arm/cumana_2.c | 2 +- > drivers/scsi/arm/ees

Re: [PATCH 097/493] scsi: remove use of __devexit_p

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:20:46PM -0500, Bill Pemberton wrote: > drivers/scsi/arm/acornscsi.c | 2 +- > drivers/scsi/arm/arxescsi.c | 2 +- > drivers/scsi/arm/cumana_1.c | 2 +- > drivers/scsi/arm/cumana_2.c | 2 +- > drivers/scsi/arm/eesox.c

Re: [PATCH 6/7] Fix race between starved list processing and device removal

2012-11-21 Thread Bart Van Assche
On 11/02/12 11:48, Bart Van Assche wrote: [PATCH] Fix race between starved list processing and device removal [ ... ] diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index ce5224c..2f0f31e 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -348,7 +348,6 @

Re: [PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-11-21 Thread James Bottomley
On Wed, 2012-11-21 at 16:02 +0530, vinayak holikatti wrote: > On Wed, Nov 14, 2012 at 2:56 AM, James Bottomley > wrote: > > On Thu, 2012-10-18 at 17:37 +0530, vinayak holikatti wrote: > >> I am Vacation will look into it when i am back to work. > >> > This doesn't apply on 3.7-rc1. Am I missing an

[PATCH 1/1] iscsi_target: Remove redundant null check before kfree

2012-11-21 Thread Sachin Kamat
kfree on null pointer is a no-op. Signed-off-by: Sachin Kamat --- drivers/target/iscsi/iscsi_target_login.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c index 7bf9ccc..fdb632f

Re: [PATCH V4 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code

2012-11-21 Thread vinayak holikatti
On Wed, Nov 14, 2012 at 2:56 AM, James Bottomley wrote: > On Thu, 2012-10-18 at 17:37 +0530, vinayak holikatti wrote: >> I am Vacation will look into it when i am back to work. >> > This doesn't apply on 3.7-rc1. Am I missing any patches in between ? > > OK, so it doesn't apply for me either: > >

[PATCH] megaraid_sas: fix memory leak if SGL has zero length entries

2012-11-21 Thread Bjørn Mork
commit 98cb7e44 ([SCSI] megaraid_sas: Sanity check user supplied length before passing it to dma_alloc_coherent()) introduced a memory leak. Memory allocated for entries following zero length SGL entries will not be freed. Reference: http://bugs.debian.org/688198 Cc: Signed-off-by: Bjørn Mork -

Re: [PATCH 2/5] qla2xxx: Test and clear FCPORT_UPDATE_NEEDED atomically.

2012-11-21 Thread Saurav Kashyap
Hi, This needs to be copied to stable, added in cc. Thanks, ~Saurav >From: David Jeffery > >When the qla2xxx driver loses access to multiple, remote ports, there is >a race >condition which can occur which will keep the request stuck on a scsi >request >queue indefinitely. > >This bad state oc