Re: [PATCH] csiostor: Fix sparse warnings.

2012-11-26 Thread Naresh Kumar Inna
Hi James, Could you please let me know when this patch would be pushed? Thanks, Naresh. On 11/20/2012 6:15 PM, Naresh Kumar Inna wrote: > This patch fixes sparse warnings related to endian-ness, which were > reported by the 0-day kernel build and testing tool. > > Signed-off-by: Naresh Kumar In

Re: [PATCH 097/493] scsi: remove use of __devexit_p

2012-11-26 Thread vinayak holikatti
> drivers/scsi/ufs/ufshcd.c | 2 +- Acked-by: Vinayak Holikatti only for drivers/scsi/ufs/ufshcd.c > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 58f4ba6..4a370f8 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -1947,

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Or Gerlitz
On 27/11/2012 06:04, David Dillow wrote: We can push it through James's tree if need be, but Bart's code is pretty self-contained, and going through the SCSI tree will introduce merge dependencies. It'd be much easier to push it all through the RDMA tree Yep, this makes sense to me even witho

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 09:57 +0200, Or Gerlitz wrote: > On Mon, Nov 26, 2012 at 6:44 AM, David Dillow wrote: > > One may also pull this series from github: > > git pull git://github.com/dillow/srp-initiator.git ha-merge-v1 > > Hi Dave, > > The kernel maintainers file specifies the followi

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 23:15 +0400, James Bottomley wrote: > On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > > - I think the srp_transport stuff should go through linux-scsi / > > James B. > >instead of my tree, esp. since it's shared with the IBM vscsi stuff > > (I think) > > - I se

Re: [PATCH 02/11] IB/srp: simplify state tracking

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:46 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > The state of the target has several conditions that overlap, making it > > easier to model as a bit-field of exceptional conditions rather than an > > enum of all possible states. > > > > Bart Van

Re: [PATCH 03/11] IB/srp: don't send anything on a bad QP

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:17 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > Once we know we have an issue with the QP, there is no point trying to > > send anything else down the pipe. This also allows us to consolidate > > code in the SCSI EH path. > After I posted the

Re: [PATCH 04/11] IB/srp: keep processing commands during host removal

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:43 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > From: Bart Van Assche > > > > Some SCSI upper layer drivers, e.g. sd, issue SCSI commands from > > inside scsi_remove_host() (see also the sd_shutdown() call in > > sd_remove()). Make sure that

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-26 Thread Aaron Lu
On 11/26/2012 09:17 PM, James Bottomley wrote: > On Mon, 2012-11-26 at 16:27 +0800, Aaron Lu wrote: >> Well, ZPREADY is not a power state that we can program the ODD to >> enter(figure 234 and table 323 of the SPEC), it servers more like an >> information provided by ODD to host so that host does n

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-11-26 Thread Martin K. Petersen
> "Rob" == Rob Evers writes: Rob> These patches replace the original t10 type 2 dif mempool Rob> implementation by increasing the block and scsi cdb maximum sizes Rob> from 16 to 32 bytes. The cdb embedded in the request structure can Rob> then be used for type 2 dif commands, or other 32 by

Re: [PATCH] firewire: sbp2: allow WRITE SAME and REPORT SUPPORTED OPERATION CODES

2012-11-26 Thread Martin K. Petersen
> "Stefan" == Stefan Richter writes: Stefan, Stefan> I did not try "sg_write_same" on any of the devices; but since Stefan> the two SPC-3 devices are correctly identified as "fully Stefan> provisioned", won't issue WRITE SAME to them either. What if you have an SSD behind one of them? Ste

Re: Error handling on FC devices

2012-11-26 Thread James Smart
On 11/19/2012 7:41 AM, Hannes Reinecke wrote: Hi all, just when we thought we'd finally nailed the error handling on FC ... A customer of ours recently hit this really nasty issue: He had a 'drain' on the SAN, in the sense that the link was still intact, but no commands were coming back from t

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Roland Dreier
> I'm amenable to that, but we do need an agreed patch set, as Roland > says. I also hate to apply the pressure, but I suspect -rc7 was the > last -rc, so I'm expecting the merge window to open on 2/12. I think the srp_transport bits are all simple and non-controversial. So at least from my persp

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-26 Thread James Bottomley
On Mon, 2012-11-26 at 11:21 -0500, Alan Stern wrote: > On Mon, 26 Nov 2012, James Bottomley wrote: > > > I'm also curious about driving sleep from autopm, since mode page timers > > don't control the sleep transition. > > Is it feasible to do this the other way around? That is, to drive > runti

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread James Bottomley
On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > - I think the srp_transport stuff should go through linux-scsi / > James B. >instead of my tree, esp. since it's shared with the IBM vscsi stuff > (I think) > - I see Bart had a few comments about a few of your patches, I'll > wait >

Re: [PATCH 05/11] IB/srp: destroy and recreate QP and CQs on each connection

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: From: Ishai Rabinovitz HW QP FATAL errors persist over a reset operation, but we can recover from that by recreating the QP and associated CQs for each connection. Creating a new QP/CQ also completely forecloses any possibility of getting stale completions

Re: [PATCH] UAPI: (Scripted) Disintegrate include/rdma

2012-11-26 Thread Roland Dreier
Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Roland Dreier
> This series compiles, but is otherwise UNTESTED. I'll be working on that > over the next few days, with an eye on getting as much of Bart's work > into 3.8 as possible. Hi Dave, Great to have you back. Certainly I'd like to get this stuff into 3.8 too. A couple of comments: - I think the

Re: [Pv-drivers] [PATCH 192/493] scsi: remove use of __devinit

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 19, 2012 at 01:22:21PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devinit is no longer > needed. > ... > drivers/scsi/vmw_pvscsi.c | 6 +- For vmw_pvscsi: Acked-by: Dmitry Torokhov Thanks, Dmitry -- To unsubscribe from this li

Re: [Pv-drivers] [PATCH 097/493] scsi: remove use of __devexit_p

2012-11-26 Thread Dmitry Torokhov
On Mon, Nov 19, 2012 at 01:20:46PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer > needed. > ... > drivers/scsi/vmw_pvscsi.c | 2 +- For vmw_pvscsi: Acked-by: Dmitry Torokhov Thanks, Dmitry -- To unsubscribe from this l

Re: SCSI LLDs, the SCSI error handler and host resource lifetime

2012-11-26 Thread Bart Van Assche
On 11/21/12 08:19, Hannes Reinecke wrote: > Hmm. > This would still mean that the eh thread will run until finished. > Which can take _A LOT_ of time (we're speaking hours here). > I would rather have an additional return code in the various > scsi_try_XXX functions to terminate the loop quickly.

Re: [PATCH 0/7 v5] More device removal fixes

2012-11-26 Thread Bart Van Assche
On 11/23/12 11:37, Bart Van Assche wrote: > On 10/26/12 14:00, Bart Van Assche wrote: >> Fix a few race conditions that can be triggered by removing a device: >> [ ... ] > > I'd like to add the patch below to this series. [ ... ] Below is another patch (hopefully the last) that I'd like to add to

Re: [PATCH 0/2] Change type-2 dif to use rq embedded 32 byte cdb

2012-11-26 Thread Rob Evers
cc Lukasz and Maciej from Intel and changing Dan William's email On 11/21/2012 03:07 PM, Rob Evers wrote: These patches replace the original t10 type 2 dif mempool implementation by increasing the block and scsi cdb maximum sizes from 16 to 32 bytes. The cdb embedded in the request structure c

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, James Bottomley wrote: > I'm also curious about driving sleep from autopm, since mode page timers > don't control the sleep transition. Is it feasible to do this the other way around? That is, to drive runtime suspend by noticing when the device decides to put itself into

[PATCH 5/7] ipr: Reduce lock contention

2012-11-26 Thread wenxiong
This patch reduces lock contention while implementing distributed completion processing. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 322 + drivers/scsi/ipr.h | 21 +-- 2 files changed, 239 insertions(+), 104 deletions(-) Index: b/d

[PATCH 7/7] ipr: Driver version 2.6.0

2012-11-26 Thread wenxiong
Bump driver version. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/scsi/ipr.h === --- a/drivers/scsi/ipr.h2012-11-19 12:18:58.263935158 -0600 +

[PATCH 6/7] ipr: Implement block iopoll

2012-11-26 Thread wenxiong
This patch implements blk iopoll in ipr driver for performance improvement. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 218 + drivers/scsi/ipr.h |6 + 2 files changed, 175 insertions(+), 49 deletions(-) Index: b/drivers/scsi/ipr.c

[PATCH 4/7] ipr: Add support for MSI-X and distributed completion

2012-11-26 Thread wenxiong
The new generation IBM SAS Controllers will support MSI-X interrupts and Distributed Completion Processing features. This patch add these support in ipr device driver. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 716 - drivers/scsi/ipr.h

[PATCH 2/7] ipr: Handler ID memory allocation failure

2012-11-26 Thread wenxiong
Add code to handle memory allocation failures at module load time. Reported-by: Fengguang Wu Signed-off-by: Brian King --- drivers/scsi/ipr.c |7 +++ 1 file changed, 7 insertions(+) Index: b/drivers/scsi/ipr.c === --- a/

[PATCH 1/7] ipr: Add sereral new CCIN definitions for new adapters support

2012-11-26 Thread wenxiong
Add the appropriate definitions and table entries for new adapter support. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 10 ++ drivers/scsi/ipr.h |5 + 2 files changed, 15 insertions(+) Index: b/drivers/scsi/ipr.c ==

[PATCH 0/7] Add support for new IBM SAS controllers

2012-11-26 Thread wenxiong
The new generation IBM SAS controllers will support MSI-X interrupt and Distributed Completion Processing features. The patches in this series add the code to support these new hardware features and also add some patches for performance improvement such as block iopoll and reducing lock contention

[PATCH 3/7] ipr: Resource path error logging cleanup

2012-11-26 Thread wenxiong
The resource path as displayed by the ipr driver is the location string identifying a location on the SAS fabric. This patch adds the SCSI host number such that error logs can be more easily correlated in multiple adapter configurations. Signed-off-by: Brian King --- drivers/scsi/ipr.c | 78 +

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-26 Thread James Bottomley
On Mon, 2012-11-26 at 16:27 +0800, Aaron Lu wrote: > Well, ZPREADY is not a power state that we can program the ODD to > enter(figure 234 and table 323 of the SPEC), it servers more like an > information provided by ODD to host so that host does not need to do TUR > and then examine the sense code

Re: [PATCH 02/11] IB/srp: simplify state tracking

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: The state of the target has several conditions that overlap, making it easier to model as a bit-field of exceptional conditions rather than an enum of all possible states. Bart Van Assche did the hard work of identifying the states that can be removed, and

Re: [PATCH 04/11] IB/srp: keep processing commands during host removal

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: > From: Bart Van Assche > > Some SCSI upper layer drivers, e.g. sd, issue SCSI commands from > inside scsi_remove_host() (see also the sd_shutdown() call in > sd_remove()). Make sure that these commands have a chance to reach > the SCSI device. > > Signed-o

Re: [PATCH 03/11] IB/srp: don't send anything on a bad QP

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: Once we know we have an issue with the QP, there is no point trying to send anything else down the pipe. This also allows us to consolidate code in the SCSI EH path. [ ... ] @@ -1683,7 +1681,7 @@ static int srp_send_tsk_mgmt(struct srp_target_port *targe

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-26 Thread Aaron Lu
On 11/26/2012 03:32 PM, James Bottomley wrote: > On Mon, 2012-11-26 at 13:09 +0800, Aaron Lu wrote: >> On 11/26/2012 01:03 PM, James Bottomley wrote: >>> On Mon, 2012-11-26 at 01:33 +0100, Rafael J. Wysocki wrote: On Monday, November 19, 2012 03:06:51 PM James Bottomley wrote: >> I really