Re: Error handling on FC devices

2012-11-30 Thread Mike Christie
On 11/30/2012 05:44 AM, Hannes Reinecke wrote: > On 11/29/2012 05:02 PM, James Smart wrote: >> Always possible - but Our f/w works at the FCP level and >> below, which means it doesn't know/do SCSI commands - e.g what the >> cdb within the FCP CMD frame is; know anything about SCSI device >>

Re: [PATCH 2/7] ipr: Handler ID memory allocation failure

2012-11-30 Thread James Bottomley
On Mon, 2012-11-26 at 09:55 -0600, wenxi...@linux.vnet.ibm.com wrote: > plain text document attachment (fix_mem_alloc_fail) > Add code to handle memory allocation failures at module load time. > > Reported-by: Fengguang Wu > > Signed-off-by: Brian King The signoff chain on a lot of these patch

Re: Error handling on FC devices

2012-11-30 Thread Hannes Reinecke
On 11/29/2012 05:02 PM, James Smart wrote: Always possible - but Our f/w works at the FCP level and below, which means it doesn't know/do SCSI commands - e.g what the cdb within the FCP CMD frame is; know anything about SCSI device classes and state; etc. And it shouldn't be required to do

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-30 Thread Rafael J. Wysocki
On Friday, November 30, 2012 04:55:56 PM Aaron Lu wrote: > On 11/28/2012 09:39 AM, Tejun Heo wrote: > > Hey, Rafael. > > > > On Wed, Nov 28, 2012 at 01:51:00AM +0100, Rafael J. Wysocki wrote: > >> Having considered that a bit more I'm now thinking that in fact the power > >> state > >> the device

Re: [PATCH 5/5] arcmsr: Modify ARC-1214 IO Behavior

2012-11-30 Thread James Bottomley
On Fri, 2012-11-16 at 19:56 +0800, NickCheng wrote: > From: Nick Cheng > > Modify ARC-1214 IO behavior to make up for HW seldom malfunction. > Signed-off-by: Nick Cheng This still isn't right. I said you could ignore most of the warnings (like lines over 80 characters), but you have a lot of t

Re: [PATCH] scsi: prevent stack buffer overflow in host_reset

2012-11-30 Thread James Bottomley
On Thu, 2012-11-15 at 15:51 -0500, Sasha Levin wrote: > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > index ce5224c..77ba946 100644 > --- a/drivers/scsi/scsi_sysfs.c > +++ b/drivers/scsi/scsi_sysfs.c > @@ -249,9 +249,9 @@ static DEVICE_ATTR(active_mode, S_IRUGO | S_IWUSR, >

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-11-30 Thread Aaron Lu
On 11/28/2012 09:39 AM, Tejun Heo wrote: > Hey, Rafael. > > On Wed, Nov 28, 2012 at 01:51:00AM +0100, Rafael J. Wysocki wrote: >> Having considered that a bit more I'm now thinking that in fact the power >> state >> the device is in at the moment doesn't really matter, so the polling code >> nee