Re: megaraid_sas: which patches are needed for 2.6.32.y?

2012-12-03 Thread Jonathan Nieder
tags 666108 - moreinfo quit Torbjørn Thorsen wrote: > The kernel boots with no problems, the storage controller seems to be > working nicely. > > root@xen14:~# dmesg | grep -i mega > [3.340638] megasas: 00.00.05.38-rc1 Wed. May. 11 17:00:00 PDT 2011 > [3.340742] megasas: 0x1000:0x005b:0x1

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-03 Thread Aaron Lu
On 12/04/2012 02:56 AM, Jeff Garzik wrote: > On 12/03/2012 11:23 AM, Tejun Heo wrote: >> Hello, James. >> >> On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index e65c62e..1756151 100644 --- a/inclu

Re: [PATCH] megaraid_sas: fix memory leak if SGL has zero length entries

2012-12-03 Thread adam radford
On Wed, Nov 21, 2012 at 12:54 AM, Bjørn Mork wrote: > commit 98cb7e44 ([SCSI] megaraid_sas: Sanity check user > supplied length before passing it to dma_alloc_coherent()) > introduced a memory leak. Memory allocated for entries > following zero length SGL entries will not be freed. > > Reference:

Re: [patch,v3,repost 07/10] megaraid_sas: use scsi_host_alloc_node

2012-12-03 Thread adam radford
On Tue, Nov 27, 2012 at 8:46 AM, Jeff Moyer wrote: > > Signed-off-by: Jeff Moyer > --- > drivers/scsi/megaraid/megaraid_sas_base.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c > b/drivers/scsi/megaraid/megaraid_sas_b

[PATCH 2/3] fnic:fixing issues in device and firmware reset code

2012-12-03 Thread Hiral Patel
1. Handling overlapped firmware resets This fix serialize multiple firmware resets to avoid situation where fnic device fails to come up for link up event, when firmware resets are issued back to back. If there are overlapped firmware resets are issued, the firmware reset operat

[PATCH 3/3] fnic: Fix SGEs limit

2012-12-03 Thread Hiral Patel
Driver allows IOs with more SGEs than max SGEs supported by Palo. The current max SGEs supported by the fnic driver is 1024. The current register settings on Palo supports a max of 256 only. Palo would return any IO with more than 256 SGEs with an error indicating INVALID_SGLS. Fnic driver shoul

[PATCH 1/3] fnic: fix for trusted cos

2012-12-03 Thread Hiral Patel
Modified fnic driver to let hardware insert the COS value. Set bit in descriptor to 0 telling hardware to use its lif COS configurations to insert the COS value in the frames. Signed-off-by: Narsimhulu Musini Signed-off-by: Hiral Patel --- drivers/scsi/fnic/fnic_fcs.c |6 -- 1 file chan

RE: Error handling on FC devices

2012-12-03 Thread Elliott, Robert (Server Storage)
> Well, looking at QLogic and Emulex both emulate a bus reset with a > loop over each target and invoke a target reset there. > I somewhat fail to see the rationale behind it, other than emulating > the bus reset behaviour on SPI. > Given that the original target reset already failed (otherwise we

Re: [PATCH 4/6] scsi: megaraid: remove a useless call to memset().

2012-12-03 Thread adam radford
On Sat, Dec 1, 2012 at 6:40 PM, Cyril Roelandt wrote: > This call is followed by a call to memcpy() on the same memory area, so it can > be safely removed. > > Signed-off-by: Cyril Roelandt > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c |2 -- > 1 file changed, 2 deletions(-) > > diff -

Re: [PATCH 3/6] scsi: bnx2fc: remove useless calls to memset().

2012-12-03 Thread Bhanu Prakash Gollapudi
On 12/01/2012 06:40 PM, Cyril Roelandt wrote: These calls are followed by calls to memcpy() on the same memory area, so they can be safely removed. Signed-off-by: Cyril Roelandt --- drivers/scsi/bnx2fc/bnx2fc_hwi.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/bnx2fc

Re: Slow writes to SAS drives on LSI mpt2sas HBA

2012-12-03 Thread Ewan Milne
On Mon, 2012-12-03 at 14:48 -0500, Gregory Haskins wrote: > Hello, > > I am experiencing a significant performance issue in write thoughput with SAS > devices connected via an LSI 9207-8e (LSISAS2308 based) HBA. SATA devices > plugged into the same rig appear to be ok. I first noticed this in

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-03 Thread Dave Jiang
On 12/03/2012 02:36 PM, Chris Friesen wrote: > On 12/03/2012 03:21 PM, Dave Jiang wrote: >> On 12/03/2012 02:08 PM, Chris Friesen wrote: >>> On 12/03/2012 02:52 PM, Ric Wheeler wrote: >>> I jumped into this thread late - can you repost detail on the specific drive and HBA used here? In an

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-03 Thread Ric Wheeler
On 12/03/2012 04:08 PM, Chris Friesen wrote: On 12/03/2012 02:52 PM, Ric Wheeler wrote: I jumped into this thread late - can you repost detail on the specific drive and HBA used here? In any case, it sounds like this is a better topic for the linux-scsi or linux-ide list where most of the low l

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-03 Thread Chris Friesen
On 12/03/2012 03:21 PM, Dave Jiang wrote: On 12/03/2012 02:08 PM, Chris Friesen wrote: On 12/03/2012 02:52 PM, Ric Wheeler wrote: I jumped into this thread late - can you repost detail on the specific drive and HBA used here? In any case, it sounds like this is a better topic for the linux-scs

Re: [PATCH 2/7] ipr: Handler ID memory allocation failure

2012-12-03 Thread wenxiong
Quoting James Bottomley : On Mon, 2012-11-26 at 09:55 -0600, wenxi...@linux.vnet.ibm.com wrote: plain text document attachment (fix_mem_alloc_fail) Add code to handle memory allocation failures at module load time. Reported-by: Fengguang Wu Signed-off-by: Brian King The signoff chain on

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-03 Thread Dave Jiang
On 12/03/2012 02:08 PM, Chris Friesen wrote: > On 12/03/2012 02:52 PM, Ric Wheeler wrote: > >> I jumped into this thread late - can you repost detail on the specific >> drive and HBA used here? In any case, it sounds like this is a better >> topic for the linux-scsi or linux-ide list where most o

Re: getting I/O errors in super_written()...any ideas what would cause this?

2012-12-03 Thread Chris Friesen
On 12/03/2012 02:52 PM, Ric Wheeler wrote: > I jumped into this thread late - can you repost detail on the specific > drive and HBA used here? In any case, it sounds like this is a better > topic for the linux-scsi or linux-ide list where most of the low level > storage people lurk :) Okay, ex

Slow writes to SAS drives on LSI mpt2sas HBA

2012-12-03 Thread Gregory Haskins
Hello, I am experiencing a significant performance issue in write thoughput with SAS devices connected via an LSI 9207-8e (LSISAS2308 based) HBA. SATA devices plugged into the same rig appear to be ok. I first noticed this in kernel v3.0.13, but I confirmed the problem exists even in 3.7.0-r

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-03 Thread Jeff Garzik
On 12/03/2012 11:23 AM, Tejun Heo wrote: Hello, James. On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote: diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h index e65c62e..1756151 100644 --- a/include/scsi/scsi_device.h +++ b/include/scsi/scsi_device.h @@ -160,6

[PATCH 4/7] RESEND ipr: Add support for MSI-X and distributed completion

2012-12-03 Thread wenxiong
The new generation IBM SAS Controllers will support MSI-X interrupts and Distributed Completion Processing features. This patch add these support in ipr device driver. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 716 - drivers/scsi/ipr.h

[PATCH 7/7] RESEND ipr: Driver version 2.6.0

2012-12-03 Thread wenxiong
Bump driver version. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/scsi/ipr.h === --- a/drivers/scsi/ipr.h2012-11-19 12:18:58.263935158 -0600 +

[PATCH 5/7] RESEND ipr: Reduce lock contention

2012-12-03 Thread wenxiong
This patch reduces lock contention while implementing distributed completion processing. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 322 + drivers/scsi/ipr.h | 21 +-- 2 files changed, 239 insertions(+), 104 deletions(-) Index: b/d

[PATCH 6/7] RESEND ipr: Implement block iopoll

2012-12-03 Thread wenxiong
This patch implements blk iopoll in ipr driver for performance improvement. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 218 + drivers/scsi/ipr.h |6 + 2 files changed, 175 insertions(+), 49 deletions(-) Index: b/drivers/scsi/ipr.c

[PATCH 3/7] RESEND ipr: Resource path error logging cleanup

2012-12-03 Thread wenxiong
From: Brian King The resource path as displayed by the ipr driver is the location string identifying a location on the SAS fabric. This patch adds the SCSI host number such that error logs can be more easily correlated in multiple adapter configurations. Signed-off-by: Brian King Signed-off-by:

[PATCH 1/7] RESEND ipr: Add sereral new CCIN definitions for new adapters support

2012-12-03 Thread wenxiong
Add the appropriate definitions and table entries for new adapter support. Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c | 10 ++ drivers/scsi/ipr.h |5 + 2 files changed, 15 insertions(+) Index: b/drivers/scsi/ipr.c ==

[PATCH 0/7] RESEND Add support for new IBM SAS controllers

2012-12-03 Thread wenxiong
The new generation IBM SAS controllers will support MSI-X interrupt and Distributed Completion Processing features. The patches in this series add the code to support these new hardware features and also add some patches for performance improvement such as block iopoll and reducing lock contention

[PATCH 2/7] RESEND ipr: Handler ID memory allocation failure

2012-12-03 Thread wenxiong
From: Brian King Add code to handle memory allocation failures at module load time. Reported-by: Fengguang Wu Signed-off-by: Brian King Signed-off-by: Wen Xiong --- drivers/scsi/ipr.c |7 +++ 1 file changed, 7 insertions(+) Index: b/drivers/scsi/ipr.c =

Re: Error handling on FC devices

2012-12-03 Thread Jeremy Linton
On 12/3/2012 1:15 AM, Hannes Reinecke wrote: > Well, looking at QLogic and Emulex both emulate a bus reset with a loop > over each target and invoke a target reset there. I somewhat fail to see > the rationale behind it, other than emulating the bus reset behaviour on > SPI. It is actually

Re: [PATCH v6 10/13] Make scsi_remove_host() wait for device removal

2012-12-03 Thread Tejun Heo
Hello, Bart. On Mon, Dec 03, 2012 at 05:38:52PM +0100, Bart Van Assche wrote: > It is indeed possible to invoke complete() only if the device list > became empty with the host state equal to SHOST_CANCEL, > SHOST_CANCEL_RECOVERY, SHOST_DEL or SHOST_DEL_RECOVERY and in We can test this with !scsi_

Re: [PATCH v6 10/13] Make scsi_remove_host() wait for device removal

2012-12-03 Thread Bart Van Assche
On 12/03/12 17:15, Tejun Heo wrote: On Mon, Dec 03, 2012 at 09:23:59AM +0100, Bart Van Assche wrote: On 12/02/12 14:45, Tejun Heo wrote: On Wed, Nov 28, 2012 at 01:51:13PM +0100, Bart Van Assche wrote: +/* Test whether scsi_remove_host() may finish, and if so, wake it up. */ +void __scsi_check

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-03 Thread Tejun Heo
Hello, James. On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote: > > diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h > > index e65c62e..1756151 100644 > > --- a/include/scsi/scsi_device.h > > +++ b/include/scsi/scsi_device.h > > @@ -160,6 +160,7 @@ struct scsi_de

Re: [PATCH v6 10/13] Make scsi_remove_host() wait for device removal

2012-12-03 Thread Tejun Heo
Hello, Bart. On Mon, Dec 03, 2012 at 09:23:59AM +0100, Bart Van Assche wrote: > On 12/02/12 14:45, Tejun Heo wrote: > >On Wed, Nov 28, 2012 at 01:51:13PM +0100, Bart Van Assche wrote: > >>+/* Test whether scsi_remove_host() may finish, and if so, wake it up. */ > >>+void __scsi_check_remove_host_d

[PATCH] hpsa: fix potential resource leak

2012-12-03 Thread Tomas Henzl
I think we should free also the cfgtable allocated a few lines above this point. Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 796482b..3cc18aa 100644 --- a/drivers/scsi/hpsa.

[PATCH] scsi:gdth.c: fix compilation warning

2012-12-03 Thread Cong Ding
We do not allow old-style function definition. Always spell foo(void) if a function does not take any parameters. Signed-off-by: Cong Ding --- drivers/scsi/gdth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index 5d72274..9

[PATCH 1/1] [SCSI] mpt3sas: Remove unneeded version.h header inclusion

2012-12-03 Thread Sachin Kamat
linux/version.h is not necessary as detected by checkversion.pl script. Signed-off-by: Sachin Kamat --- drivers/scsi/mpt3sas/mpt3sas_base.c |1 - drivers/scsi/mpt3sas/mpt3sas_config.c |1 - drivers/scsi/mpt3sas/mpt3sas_ctl.c |1 - drivers/scsi/mpt3sas/mpt3sas_s

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-03 Thread Aaron Lu
On Mon, Dec 03, 2012 at 08:25:43AM +, James Bottomley wrote: > On Mon, 2012-12-03 at 16:13 +0800, Aaron Lu wrote: > > On Wed, Nov 28, 2012 at 08:56:09AM +, James Bottomley wrote: > > > On Tue, 2012-11-27 at 17:39 -0800, Tejun Heo wrote: > > > > Hey, Rafael. > > > > > > > > On Wed, Nov 28,

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-03 Thread James Bottomley
On Mon, 2012-12-03 at 16:13 +0800, Aaron Lu wrote: > On Wed, Nov 28, 2012 at 08:56:09AM +, James Bottomley wrote: > > On Tue, 2012-11-27 at 17:39 -0800, Tejun Heo wrote: > > > Hey, Rafael. > > > > > > On Wed, Nov 28, 2012 at 01:51:00AM +0100, Rafael J. Wysocki wrote: > > > > Having considered

Re: [PATCH v6 10/13] Make scsi_remove_host() wait for device removal

2012-12-03 Thread Bart Van Assche
On 12/02/12 14:45, Tejun Heo wrote: On Wed, Nov 28, 2012 at 01:51:13PM +0100, Bart Van Assche wrote: +/* Test whether scsi_remove_host() may finish, and if so, wake it up. */ +void __scsi_check_remove_host_done(struct Scsi_Host *shost) +{ + lockdep_assert_held(shost->host_lock); + +

Re: [PATCH v9 06/10] ata: zpodd: check zero power ready status

2012-12-03 Thread Aaron Lu
On Wed, Nov 28, 2012 at 08:56:09AM +, James Bottomley wrote: > On Tue, 2012-11-27 at 17:39 -0800, Tejun Heo wrote: > > Hey, Rafael. > > > > On Wed, Nov 28, 2012 at 01:51:00AM +0100, Rafael J. Wysocki wrote: > > > Having considered that a bit more I'm now thinking that in fact the power > > >