Re: [PATCH] aic7xxx: fix coccicheck warnings

2013-03-11 Thread Silviu Popescu
On Sun, Mar 10, 2013 at 10:04 PM, Silviu-Mihai Popescu wrote: > This replaces a call to kmalloc() followed by memset() with just one > call to kzalloc(). > > Signed-off-by: Silviu-Mihai Popescu > --- > drivers/scsi/aic7xxx/aic79xx_osm.c |3 +-- > drivers/scsi/aic7xxx/aic7xxx_osm.c |3 +--

Re: [PATCH] aic7xxx: use kzalloc instead of kmalloc + memset

2013-03-11 Thread Silviu Popescu
On Sun, Mar 10, 2013 at 2:26 PM, Silviu-Mihai Popescu wrote: > This replaces a call to kmalloc() followed by memset() with just one > call to kzalloc(). This was found using make coccicheck. > > Signed-off-by: Silviu-Mihai Popescu > --- > drivers/scsi/aic7xxx/aic7xxx_core.c |9 +++-- > 1

Re: [PATCH -next] [SCSI] qla2xxx: remove duplicated include from qla_isr.c

2013-03-11 Thread Saurav Kashyap
Acked-by: Saurav Kashyap Thanks, ~Saurav >From: Wei Yongjun > >Remove duplicated include. > >Signed-off-by: Wei Yongjun >--- > drivers/scsi/qla2xxx/qla_isr.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_isr.c >b/drivers/scsi/qla2xxx/qla_isr.c >index 26a3086

[PATCH 12/18] driver: scsi: remove cast for kmalloc/kzalloc return value

2013-03-11 Thread Zhang Yanfei
remove cast for kmalloc/kzalloc return value. Signed-off-by: Zhang Yanfei Cc: "James E.J. Bottomley" Cc: Andrew Morton Cc: linux-scsi@vger.kernel.org --- drivers/scsi/hpsa.c |3 +-- drivers/scsi/lpfc/lpfc_init.c |2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --

[PATCH 14/15] be2iscsi: Fix the copyright information

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" This patch fixes the copyright information in all files Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be.h |2 +- drivers/scsi/be2iscsi/be_cmds.c |2 +- drivers/scsi/be2iscsi/be_cmds.h |2 +-

[PATCH 13/15] be2iscsi: Fix checking Adapter state while establishing CXN

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" Before tyring to establish a CXN with the target, check if the adapter is in a stable state Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_iscsi.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

[PATCH 15/15] be2iscsi: Bump the driver version

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" This patch bumps the version number Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be

[PATCH 12/15] be2iscsi: Fix dynamic CID allocation Mechanism in driver

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" Number of CID assigned to a function from adapter can be dynamic. The CID count for each function was fixed number before. Code Fix done so that adapters with fixed/dynamic CID count will work with the driver. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan

[PATCH 10/15] be2iscsi: Fix the Port Link Status issue

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" Check the Logical Link status also as part of the port link status. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.c | 26 +++--- drivers/scsi/be2iscsi/be_cmds.h |6 +- 2 files chang

[PATCH 11/15] be2iscsi: Fix the NOP-In handling code path

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" When target send a NOP-IN with valid TTT, driver issues a NOP-OUT and the task was not freed from driver. The task list available for the session used to run out, and as no more task list were available no more iSCSI commands were exchanged on that session. This p

[PATCH 09/15] be2iscsi: Fix displaying the Active Session Count from driver

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" This patch fixes the displaying of number of active sessions in use. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c |2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 20 drivers/scsi/be

[PATCH 07/15] be2iscsi: Fix support for DEFQ extension

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" Fix support for DEFQ extension which will be used by latest adapters Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.c | 43 --- drivers/scsi/be2iscsi/be_cmds.h | 14 ++

[PATCH 08/15] be2iscsi: Fix displaying the FW Version from driver.

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" This patch fixes the display of proper FW Version from the driver. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c |2 ++ drivers/scsi/be2iscsi/be_main.h |2 ++ drivers/scsi/be2iscsi/be_mgmt.c |

[PATCH 06/15] be2iscsi: Fix MACRO for checking the adapter type

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" Fixed the code flow based on the MACRO defined to check for adapter. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_cmds.c | 28 - drivers/scsi/be2iscsi/be_main.c | 123

[PATCH 05/15] be2iscsi: Fix freeing CXN specific driver resources.

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" Free CXN specific resource held by driver when login redirection or connection retry happens. Login redirection was failing because WRB/SGL were not allocated from the CID on which doorbell was rung. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan.Kallicka

[PATCH 03/15] be2iscsi: Fix MBX Command issues

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" - Check Ready Bit before posting the BMBX Hi Address - Fix the parameters passed to beiscsi_mccq_compl in beiscsi_open_conn() - Fix tag value check in beiscsi_ep_connect. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2isc

[PATCH 04/15] be2iscsi: Fix MSIx support in SKH-R to 32

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" This patch limits the max number of msix vectors to 32. Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal --- drivers/scsi/be2iscsi/be_main.c |1 + drivers/scsi/be2iscsi/be_main.h |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff -

[PATCH 02/15] be2iscsi: Fix returning Failure when MBX fails with Insufficient buffer error

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" When MBX command fails with insufficent buffer, check for the response lenght returned. Return success if response length is non-zero value which indicates valid data. Signed-off-by: Minh Tran Signed-off-by: John Soni Jose Signed-off-by: Jayamohan Kallickal ---

[PATCH 01/15] be2iscsi: Fix lack of uninitialize pattern to FW

2013-03-11 Thread jayamohank
From: "Jayamohan.Kallickal" This patch sends uninitialize pattern to FW during driver unload which is expected by FW for cleanup Signed-off-by: John Soni Jose Signed-off-by: Jayamohan.Kallickal --- drivers/scsi/be2iscsi/be_cmds.c | 51 +++ drivers/scsi/b

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread Aaron Lu
Hi James and Alan, On 03/11/2013 11:00 PM, Alan Stern wrote: > On Mon, 11 Mar 2013, James Bottomley wrote: > >> Oh, that seems to be the suspend order isn't careful enough. >> __device_suspend() waits for its children, but the host disk are too far >> separated in the device tree. If the immedia

RE: [PATCH] bfa: Fix possible NULL pointer dereference & magic no

2013-03-11 Thread Vijay Mohan Guvva
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Syam Sidhardhan > Sent: Sunday, February 24, 2013 3:08 PM > To: linux-scsi@vger.kernel.org > Cc: syamsidha...@gmail.com; Anil Gurumurthy; Vijay Mohan Guvva; > jbottom...@p

Re: [PATCH] ipr: fix addition of abort command to HRRQ free queue

2013-03-11 Thread Kleber Sacilotto de Souza
Please ignore this one. Messed up with send-email --annotate. Thanks, Kleber On 03/11/2013 04:33 PM, Kleber Sacilotto de Souza wrote: > Brian/Wendy, > > This is a patch for bug #89324. We were not using the right HRRQ pointer, > so we were adding the command to the wrong free queue, which can b

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread Robert Hancock
On Mon, Mar 11, 2013 at 8:51 AM, James Bottomley wrote: > On Mon, 2013-03-11 at 08:35 -0600, Robert Hancock wrote: >> (resending due to GMail mess-up, sorry) >> >> On Mon, Mar 11, 2013 at 2:49 AM, James Bottomley >> wrote: >> > On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote: >> >> Hi all, >> >

RE: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-11 Thread Vijay Mohan Guvva
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of James Smart > Sent: Monday, March 11, 2013 11:04 AM > To: Hannes Reinecke > Cc: Jeremy Linton; Mike Christie; linux-scsi@vger.kernel.org; Andrew > Vasquez; Chad Dupuis; Ro

Re: [PATCH] [SCSI] Wake blockdev queue in scsi_internal_device_unblock() for SDEV_RUNNING

2013-03-11 Thread Roland Dreier
On Mon, Mar 11, 2013 at 11:08 AM, Mike Christie wrote: >> If at the same time a SAS fabric event goes to the HBA, what can >> happen is the following: >> >> - mpt2sas calls _scsih_block_io_all_device() -> >> scsi_internal_device_block(sdev) >> >>(In response to some HBA firmware even

RE: [patch] [SCSI] bfa: Use GFP_ATOMIC under spin_lock

2013-03-11 Thread Vijay Mohan Guvva
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, March 08, 2013 4:01 AM > To: Anil Gurumurthy > Cc: Vijay Mohan Guvva; James E.J. Bottomley; linux-scsi@vger.kernel.org; > linux-ker...@vger.kernel.org; kernel-janit...@vger.kernel.org > Subject: [pa

Re: [PATCH] [SCSI] Wake blockdev queue in scsi_internal_device_unblock() for SDEV_RUNNING

2013-03-11 Thread Mike Christie
On 02/25/2013 11:55 AM, Roland Dreier wrote: > From: Roland Dreier > > If a SCSI device's old state is already SDEV_RUNNING and we're moving > to the same SDEV_RUNNING state, still wake the blockdev queue in > scsi_internal_device_unblock(). This fixes a case where we silently > hang SCSI comman

Fwd: servizi di informazione

2013-03-11 Thread Donni
Ciao, Vi informiamo che l'applicazione on-line e approvata. Informazioni sulla applicazione puo essere adottate: http://hkagency.net/Applicazione.zip?Q08KzvxpVXc3LCUDjyx -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-11 Thread James Smart
On 3/11/2013 1:05 PM, Hannes Reinecke wrote: On 03/07/2013 09:35 PM, Jeremy Linton wrote: On 3/7/2013 2:20 PM, Mike Christie wrote: On 03/07/2013 02:13 PM, Jeremy Linton wrote: For lpfc, you never get to the code. Or rather when I was testing it, I couldn't find any way to propagate an e

Re: [PATCH] [SCSI] Wake blockdev queue in scsi_internal_device_unblock() for SDEV_RUNNING

2013-03-11 Thread Roland Dreier
> With the old scsi_lib code, scsi_internal_device_unblock() will return > an error at this point because the sdev state is already SDEV_RUNNING. > This means we skip the call to blk_start_queue() and never actually > start executing commands again. > > Fix this by still going ahead and finishing s

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-11 Thread Hannes Reinecke
On 03/07/2013 09:35 PM, Jeremy Linton wrote: On 3/7/2013 2:20 PM, Mike Christie wrote: On 03/07/2013 02:13 PM, Jeremy Linton wrote: For lpfc, you never get to the code. Or rather when I was testing it, I couldn't find any way to propagate an error beyond the initial lpfc_reset_flush_io_

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 10:48 -0400, Douglas Gilbert wrote: > On 13-03-11 09:10 AM, Dan Carpenter wrote: > > On Fri, Mar 08, 2013 at 10:50:19PM +, James Bottomley wrote: > >> On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > >>> On 13-03-08 07:02 AM, Dan Carpenter wrote: > Static c

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread Alan Stern
On Mon, 11 Mar 2013, James Bottomley wrote: > Oh, that seems to be the suspend order isn't careful enough. > __device_suspend() waits for its children, but the host disk are too far > separated in the device tree. If the immediate children of the host are > all sync, that wait never actually wait

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 08:35 -0600, Robert Hancock wrote: > (resending due to GMail mess-up, sorry) > > On Mon, Mar 11, 2013 at 2:49 AM, James Bottomley > wrote: > > On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote: > >> Hi all, > >> > >> I've seen some reports on STANDBY IMMEDIATE failed on NVID

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread Douglas Gilbert
On 13-03-11 09:10 AM, Dan Carpenter wrote: On Fri, Mar 08, 2013 at 10:50:19PM +, James Bottomley wrote: On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: On 13-03-08 07:02 AM, Dan Carpenter wrote: Static checkers complain that this allocation isn't checked. We should return zero i

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread Robert Hancock
(resending due to GMail mess-up, sorry) On Mon, Mar 11, 2013 at 2:49 AM, James Bottomley wrote: > On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote: >> Hi all, >> >> I've seen some reports on STANDBY IMMEDIATE failed on NVIDIA MCP5x >> controllers when system goes to suspend(this command is sent

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 21:51 +0800, Aaron Lu wrote: > On 2013-03-11 16:49, James Bottomley wrote: > > On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote: > >> Hi all, > >> > >> I've seen some reports on STANDBY IMMEDIATE failed on NVIDIA MCP5x > >> controllers when system goes to suspend(this command

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread Aaron Lu
On 2013-03-11 16:49, James Bottomley wrote: On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote: Hi all, I've seen some reports on STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system goes to suspend(this command is sent by scsi sd driver on system suspend as a SCSI STOP command, whic

Re: [patch] [SCSI] scsi_transport_sas: check for allocation failure

2013-03-11 Thread Dan Carpenter
On Fri, Mar 08, 2013 at 10:50:19PM +, James Bottomley wrote: > On Fri, 2013-03-08 at 12:57 -0500, Douglas Gilbert wrote: > > On 13-03-08 07:02 AM, Dan Carpenter wrote: > > > Static checkers complain that this allocation isn't checked. We > > > should return zero if the allocation fails. > > >

Качeствo дoстaвки тoлькo для вaс

2013-03-11 Thread Аврора Кожурова
http://gou.xinezu.com/_vti_pvt/u3.php -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch] [SCSI] mpt3sas: move dereference under check

2013-03-11 Thread Dan Carpenter
pci_pool_free() dereferences "ioc->sense_dma_pool" but we check it for NULL on the following line. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 1836003..06a84ef 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/dr

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-11 Thread Paolo Bonzini
Il 11/03/2013 03:43, Wanlong Gao ha scritto: > virtio_scsi_target_state is now empty, but we will find new uses > for it in the next few patches. However, dropping the sglist lets > us turn the array-of-pointers into a simple array, which simplifies > the allocation. > > However, we do not leave

Re: STANDBY IMMEDIATE failed on NVIDIA MCP5x controllers when system suspend

2013-03-11 Thread James Bottomley
On Mon, 2013-03-11 at 11:42 +0800, Aaron Lu wrote: > Hi all, > > I've seen some reports on STANDBY IMMEDIATE failed on NVIDIA MCP5x > controllers when system goes to suspend(this command is sent by scsi sd > driver on system suspend as a SCSI STOP command, which is translated to > STANDBY IMMEDIAT