[OT] LDD3 Query

2013-04-05 Thread Vijay Chauhan
Hi, I am new to Linux Device Driver and reading LDD3. It mentions that the disadvantage of dynamic major number allocation is that you can’t create the device nodes in advance, because the major number assigned to your module will vary. To solve this problem, it says that create a script to

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-05 Thread Wanlong Gao
On 03/28/2013 10:22 AM, Wanlong Gao wrote: On 03/23/2013 07:28 PM, Wanlong Gao wrote: This series implements virtio-scsi queue steering, which gives performance improvements of up to 50% (measured both with QEMU and tcm_vhost backends). This version rebased on Rusty's virtio ring rework

[PATCH 2/5] qla4xxx: Restrict logout from boot target session using session id

2013-04-05 Thread vikas . chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_os.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 0/5] qla4xxx: Updates for scsi misc branch

2013-04-05 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com James, Please apply the following patches to the scsi tree at your earliest convenience. Adheer Chandravanshi (3): qla4xxx: Use correct flash ddb offset for ISP40XX qla4xxx: Restrict logout from boot target session using session id

[PATCH 3/5] qla4xxx: Use correct value for max flash node entries

2013-04-05 Thread vikas . chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Use correct value for max flash node entries supported based on adapter type. Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com ---

[PATCH 4/5] qla4xxx: Added print statements to display AENs

2013-04-05 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Added print statements for following AENs: 1. MBOX_ASTS_INITIALIZATION_FAILED 2. MBOX_ASTS_SYSTEM_WARNING_EVENT 3. MBOX_ASTS_DCBX_CONF_CHANGE 4. MBOX_ASTS_IPV6_DEFAULT_ROUTER_CHANGED Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com ---

[PATCH 1/5] qla4xxx: Use correct flash ddb offset for ISP40XX

2013-04-05 Thread vikas . chaudhary
From: Adheer Chandravanshi adheer.chandravan...@qlogic.com Use correct flash ddb offset to add and delete flash target entries for ISP40XX Signed-off-by: Adheer Chandravanshi adheer.chandravan...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com ---

[PATCH 5/5] qla4xxx: Update driver version to 5.03.00-k8

2013-04-05 Thread vikas . chaudhary
From: Vikas Chaudhary vikas.chaudh...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/qla4xxx/ql4_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index

Re: [PATCH] [SCSI] sd: Do not return success from init_sd if DIF mempool allocation fails

2013-04-05 Thread Ewan Milne
On Thu, 2013-02-14 at 11:36 -0500, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com init_sd() was returning 0 if sd_cdb_cache or sd_cdb_pool could not be allocated. Return -ENOMEM instead, since the sd_disk_class and the blkdevs will be unregistered if this happens.

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-04-05 Thread James Smart
I understand your points. But you will need to contact the different LLD maintainers to ensure receiving a devloss_tmo_callbk() on an rport they had not called fc_remote_port_delete() for. I know there's work on my side to validate it's ok. First glance was ok, but.. -- james s On

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-04-05 Thread James Smart
On 4/4/2013 6:17 AM, Hannes Reinecke wrote: On 03/31/2013 07:44 PM, Tomas Henzl wrote: What we can do is to decode the LUN and compare it to max_lun provided by the driver, I think that sg_luns is able to do that, so what is needed is just to follow the SAM. I have seen reports of problem

Re: [dm-devel] [PATCH] scsi-dh-emc: fix activate vs set_params race

2013-04-05 Thread Mikulas Patocka
On Thu, 4 Apr 2013, Laurence Oberman wrote: I can test it. I have a clarion Cx3 Will get to it next week, traveling tomorrow Laurence Sent from my iPhone OK. So, enable most debug options in kernel configuration and try the patch. Mikulas On Apr 4, 2013, at 7:11 PM, Mike Christie

Re: [OT] LDD3 Query

2013-04-05 Thread Greg KH
On Fri, Apr 05, 2013 at 12:17:54PM +0530, Vijay Chauhan wrote: Hi, I am new to Linux Device Driver and reading LDD3. It mentions that the disadvantage of dynamic major number allocation is that you can’t create the device nodes in advance, because the major number assigned to your module

[PATCH V2 02/18] be2iscsi: Fix returning Failure when MBX fails with Insufficient buffer error

2013-04-05 Thread Jayamohan Kallickal
When MBX command fails with insufficent buffer, check for the response lenght returned. Return success if response length is non-zero value which indicates valid data. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan

[PATCH V2 03/18] be2iscsi: Fix MBX Command issues

2013-04-05 Thread Jayamohan Kallickal
- Check Ready Bit before posting the BMBX Hi Address - Fix the parameters passed to beiscsi_mccq_compl in beiscsi_open_conn() - Fix tag value check in beiscsi_ep_connect. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com

[PATCH V2 04/18] be2iscsi: Fix MSIX support in SKH-R to 32

2013-04-05 Thread Jayamohan Kallickal
This patch limits the max number of msix vectors to 32. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c |1 + drivers/scsi/be2iscsi/be_main.h |2 +- 2 files changed, 2

[PATCH V2 05/18] be2iscsi: Fix freeing CXN specific driver resources.

2013-04-05 Thread Jayamohan Kallickal
Free CXN specific resource held by driver when login redirection or connection retry happens. Login redirection was failing because WRB/SGL were not allocated from the CID on which doorbell was rung. Fixed the issue raised by MikeC Signed-off-by: John Soni Jose sony.joh...@emulex.com

[PATCH V2 06/18] be2iscsi: Fix MACRO for checking the adapter type

2013-04-05 Thread Jayamohan Kallickal
Fixed the code flow based on the MACRO defined to check for adapter. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.c | 28 - drivers/scsi/be2iscsi/be_main.c | 123

[PATCH V2 07/18] be2iscsi: Fix support for DEFQ extension

2013-04-05 Thread Jayamohan Kallickal
Fix support for DEFQ extension which will be used by latest adapters Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.c | 42 +--

[PATCH V2 08/18] be2iscsi: Fix displaying the FW Version from driver.

2013-04-05 Thread Jayamohan Kallickal
The mgmt_hba_attributes structure declared was not proper and because of that the FW response returned for the MBX_CMD was not matching. This issue went unnoticed as mgmt_hba_attribs structure members were never used in the code path. This fix of displaying the FW version had to change the

[PATCH V2 09/18] be2iscsi: Fix displaying the Active Session Count from driver

2013-04-05 Thread Jayamohan Kallickal
This patch fixes the displaying of number of active sessions in use. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.c |2 ++ drivers/scsi/be2iscsi/be_mgmt.c | 20

[PATCH V2 10/18] be2iscsi: Fix the Port Link Status issue

2013-04-05 Thread Jayamohan Kallickal
Check the Logical Link status also as part of the port link status. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_cmds.c | 26 +++--- drivers/scsi/be2iscsi/be_cmds.h |

[PATCH V2 11/18] be2iscsi : Fix the NOP-In handling code path

2013-04-05 Thread Jayamohan Kallickal
When target send a NOP-IN with valid TTT, driver issues a NOP-OUT and the task was not freed from driver. The task list available for the session used to run out, and as no more task list were available no more iSCSI commands were exchanged on that session. This patches fixed the issue, by

[PATCH V2 12/18] be2iscsi: Fix dynamic CID allocation Mechanism in driver

2013-04-05 Thread Jayamohan Kallickal
Number of CID assigned to a function from adapter can be dynamic. The CID count for each function was fixed number before. Code Fix done so that adapters with fixed/dynamic CID count will work with the driver. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan

[PATCH V2 13/18] be2iscsi: Fix checking Adapter state while establishing CXN

2013-04-05 Thread Jayamohan Kallickal
Before tyring to establish a CXN with the target, check if the adapter is in a stable state Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_iscsi.c |7 +++ 1 file changed, 7

[PATCH V2 15/18] be2iscsi: Fix the session cleanup when reboot/shutdown happens

2013-04-05 Thread Jayamohan Kallickal
During reboot/shutdown cycle, the active sessions were not updated. In iSCSI Boot case, the boot session was alive and this fix informs that the machine is going down, so no more ops happens on that session. Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan

[PATCH V2 14/18] be2scsi: Fix the copyright information

2013-04-05 Thread Jayamohan Kallickal
This patch fixes the copyright information in all files Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be.h |2 +- drivers/scsi/be2iscsi/be_cmds.c |2 +-

[PATCH V2 16/18] be2iscsi: Fix possible reentrancy issue in be_iopoll

2013-04-05 Thread Jayamohan Kallickal
From: Shlomo Pongratz shlo...@mellanox.com The driver creates NAPI context per core which is fine, however the above routine declares the ret variable as static! Thus there is only one instance of this variable! When this routine is called from more than one thread of execution, than the

[PATCH V2 17/18] be2iscsi: Fix issue in passing the exp_cmdsn and max_cmdsn

2013-04-05 Thread Jayamohan Kallickal
Command Window value from the CQE was used to calculate the max_cmdsn for that session.The command window value extracted for SKH-R adapter was not proper. The value was extracted from BE adapter completion event. Fixed the issue by getting the cmd_wnd value from SKH-R CQE. The exp_cmdsn

[PATCH V2 18/18] be2iscsi: Bump the driver version

2013-04-05 Thread Jayamohan Kallickal
This patch bumps the version number Signed-off-by: John Soni Jose sony.joh...@emulex.com Signed-off-by: Jayamohan Kallickal jayamohan.kallic...@emulex.com --- drivers/scsi/be2iscsi/be_main.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_main.h

be2iscsi: Patchset for be2iscsi

2013-04-05 Thread Jayamohan Kallickal
Hi James These patches contains updates for the be2iscsi driver cut against scsi.git, branch misc This set of patches fixes the issue MikeC commented on. This patchset consolidates earlier patchset submitted on 11 Mar along with a reentrancy issue fix from Shlomo Pongratz Also, there are