[PATCH] qla2xxx: Fix for locking issue between driver ISR and mailbox routines

2013-04-12 Thread gurinder . shergill
The qla2xxx driver uses ha->mbx_cmd_flags variable to pass information between its ISR and mailbox routines, however, it does so without the protection of any locks. Under certain conditions, this can lead to multiple mailbox command completions being signaled, which, in turn, leads to a false mai

[PATCH, resend] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-12 Thread Steve Magnani
Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered set_media_not_present() in a way that prevents the sd driver from remembering that a non-removable device has reported "Medium Not Present". This condition can occur on hotplug of a (i.e.) USB Mass Storage device whose medium is offli

[GIT PULL] target fixes for v3.9-rc7

2013-04-12 Thread Nicholas A. Bellinger
Hello Linus, Here are remaining target-pending items for v3.9-rc7 code. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The tcm_vhost patches are more than I'd usually include in a -rc7 PULL, but are changes required for v3.9 to work

Re: be2iscsi: Patchset for be2iscsi

2013-04-12 Thread Mike Christie
On 04/05/2013 10:38 PM, Jayamohan Kallickal wrote: > - Fix the session cleanup when reboot or shutdown happens All patches but that one looked ok. Since Jay dropped it for now, then the patchset looks ok to me. Reviewed-by: Mike Christie -- To unsubscribe from this list: send the line "un

[RFC-v4 2/9] iscsi-target: Add iscsit_transport API template

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Add basic struct iscsit_transport API template to allow iscsi-target for running with external transport modules using existing iscsi_target_core.h code. For all external modules, this calls try_module_get() and module_put() to obtain + release an external iscsit_transpo

[RFC-v4 4/9] iscsi-target: Add iser-target parameter keys + setup during login

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds RDMAExtensions, InitiatorRecvDataSegmentLength and TargetRecvDataSegmentLength parameters keys necessary for iser-target login to occur. This includes setting the necessary parameters during login path code within iscsi_login_zero_tsih_s2(), and currently

[RFC-v4 6/9] iscsi-target: Refactor RX PDU logic + export request PDU handling

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch refactors existing traditional iscsi RX side PDU handling to use iscsit_transport, and exports the necessary logic for external transport modules. This includes: - Refactor iscsit_handle_scsi_cmd() into PDU setup / processing - Add updated iscsit_handle_scsi_

[RFC-v4 7/9] iscsi-target: Refactor TX queue logic + export response PDU creation

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch refactors TX immediate + response queue handling to use the new iscsit_transport API callers, and exports the necessary traditional iscsi PDU response creation functions for iser-target to utilize. This includes: - Add iscsit_build_datain_pdu() for DATAIN PDU

[RFC-v4 3/9] iscsi-target: Initial traditional TCP conversion to iscsit_transport

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch performs the initial conversion of existing traditional iscsi to use iscsit_transport API callers. This includes: - iscsi-np cleanups for iscsit_transport_type - Add iscsi-np transport calls w/ ->iscsit_setup_up() and ->iscsit_free_np() - Convert login thread

[RFC-v4 1/9] target: Add export of target_get_sess_cmd symbol

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Export target_get_sess_cmd() symbol so that it can be used by iscsi-target. Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_transport.c |4 ++-- include/target/target_core_fabric.h|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) dif

[RFC-v4 5/9] iscsi-target: Add per transport iscsi_cmd alloc/free

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts struct iscsi_cmd memory allocation + free to use ->iscsit_alloc_cmd() iscsit_transport API caller, and export iscsit_allocate_cmd() symbols Also add iscsi_cmd->release_cmd() to be used seperately from iscsit_transport for connection/session shutdown.

[RFC-v4 8/9] iscsi-target: Add iser network portal attribute

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds a new network portal attribute for iser, that lives under existing iscsi-target configfs layout at: /sys/kernel/config/target/iscsi/$TARGETNAME/$TPGT/np/$PORTAL/iser When lio_target_np_store_iser() is enabled, iscsit_tpg_add_network_portal() will atte

[RFC-v4 0/9] Add support for iSCSI Extensions for RDMA (ISER) target mode

2013-04-12 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, This series is the forth RFC for iSCSI Extensions for RDMA (ISER) target mode support planned for an upcoming v3.10 merge. This series refactors existing traditional iscsi-target mode logic in order for external ib_isert.ko module code to function with areas c

RE: [PATCH V2 15/18] be2iscsi: Fix the session cleanup when reboot/shutdown happens

2013-04-12 Thread Kallickal, Jayamohan
-Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Wednesday, April 10, 2013 4:42 PM To: Jayamohan Kallickal Cc: jbottom...@parallels.com; linux-scsi@vger.kernel.org; Kallickal, Jayamohan; John, Sony Subject: Re: [PATCH V2 15/18] be2iscsi: Fix the session cleanup

Re: [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type

2013-04-12 Thread Chad Dupuis
On Fri, 12 Apr 2013, James Bottomley wrote: [linux-scsi cc added] On Fri, 2013-04-12 at 09:34 +0800, kbuild test robot wrote: tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc head: 9e45dd73234af9a59613dc2989dcc2df2dab847f commit: 8ae6d9c7eb1004bc134813287010d57a863ba

Re: error handler scheduling

2013-04-12 Thread Baruch Even
On Fri, Apr 12, 2013 at 12:42 PM, Ren Mingxin wrote: > > Please let me summarize what this thread has talked about the scsi > eh latency: > > 1) some scsi cmds' timemout values are inappropriate, we can avoid >timeout by: >a) sg_format sets the IMMED bit and use TEST UNIT READY or REQUEST

[GIT PULL] SCSI fixes for 3.9-rc6

2013-04-12 Thread James Bottomley
This is a set of ten bug fixes (and two consisting of copyright year update and version number change) pretty much all of which involve either a crash or a hang except the removal of the random sleep from the qla2xxx driver (which is a coding error so bad, we want it gone before anyone has a chance

Re: [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type

2013-04-12 Thread James Bottomley
[linux-scsi cc added] On Fri, 2013-04-12 at 09:34 +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc > head: 9e45dd73234af9a59613dc2989dcc2df2dab847f > commit: 8ae6d9c7eb1004bc134813287010d57a863ba13b [46/59] [SCSI] qla2xxx: > Enhancements

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-04-12 Thread Chad Dupuis
Our testing of this patch has not shown any issues however I think we would be more comfortable with this change if there was a callback back into the LLDs that want to be notified of the rport state change so we can sync up our internal fibre channel port structures. AFAICT the changes required

[PATCH 4/5] ibmvfc: Suppress ABTS if target gone

2013-04-12 Thread Brian King
Adds support for a new VIOS feature that allows ibmvfc to optimize terminate_rport_io by telling the VIOS the target is no longer accessible on the fabric and that it should not send an ABTS out on the fabric to the device. Signed-off-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.c | 13 ++

[PATCH 3/5] ibmvfc: Send cancel when link is down

2013-04-12 Thread Brian King
If attempting to abort requests due to a fail fail timeout or error handling while the link is down, we cannot send an abort out on the fabric. We can, however, send a cancel to the VIOS. This fixes ibmvfc to send a cancel in this case to prevent error handling from failing and/or escalating. Sig

[PATCH 5/5] ibmvfc: Driver version 1.0.11

2013-04-12 Thread Brian King
Bump driver version to 1.0.11. Signed-off-by: Brian King --- drivers/scsi/ibmvscsi/ibmvfc.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/scsi/ibmvscsi/ibmvfc.h~ibmvfc_version_1_0_11 drivers/scsi/ibmvscsi/ibmvfc.h --- linux/drivers/scsi/ibmvscsi/ibmvfc.h~ibm

[PATCH 2/5] ibmvfc: Support FAST_IO_FAIL in EH handlers

2013-04-12 Thread Brian King
Adds support for receiving FAST_IO_FAIL from fc_block_scsi_eh when in error recovery. This fixes cases of devices being taken offline when they are no longer accessible on the fabric, preventing them from coming back online when the fabric recovers. Signed-off-by: Brian King --- drivers/scsi/i

[PATCH 1/5] ibmvfc: Properly set cancel flags when cancelling abort

2013-04-12 Thread Brian King
The flags on a cancel operation are intended to indicate what, if any, TMF will follow the cancel request. This fixes a case where we were incorrectly setting the abort task set flag on the cancel flag when we were cancelling an abort task set. Signed-off-by: Brian King --- drivers/scsi/ibmvsc

Re: error handler scheduling

2013-04-12 Thread Ren Mingxin
On 03/29/2013 12:02 AM, Elliott, Robert (Server Storage) wrote: There are several possible reasons for SCSI command timeouts: a) the command request did not get to the SCSI target port and logical unit (e.g., error on the wire) b) logical unit is still working on the command

Re: [PATCH 18/26] megaraid: Don't use create_proc_read_entry() [RFC]

2013-04-12 Thread Hannes Reinecke
On 04/11/2013 03:30 PM, David Howells wrote: > Don't use create_proc_read_entry() as that is deprecated, but rather use > proc_create_data() and seq_file instead. > > Signed-off-by: David Howells > cc: Neela Syam Kolli > cc: James E.J. Bottomley > cc: linux-scsi@vger.kernel.org Hmm? What is th