Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

2013-05-02 Thread Or Gerlitz
On Thu, May 2, 2013 at 10:31 PM, Nicholas A. Bellinger wrote: >> We used RAMDISK_MCP backend which was patched to act as NULL device, so >> we can test the raw iSER wire performance. > Btw, I'll be including a similar patch to allow for RAMDISK_NULL to be > configured as a NULL device mode. yep

[PATCH v2]st: provide tape statistics via sysfs

2013-05-02 Thread Seymour, Shane M
New version of statistics patch: - Removed sysfs file containing hint for number of tape drives - Removed disk like stat file - there is now one file per statistic as per feedback from James - Like all other kernel stats these start at zero and keep incrementing (cannot zero them any more) - Imp

Re: [PATCH V4 2/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-05-02 Thread James Bottomley
On Thu, 2013-05-02 at 19:26 -0700, Anand Kumar Santhanam wrote: > James, > > Can you pls let us know the warning flags you are including in your > makefile such that we can check from our end. > Obviously it looks like we did not use -Warray-bounds in this case. Oh good grief, please stop wastin

RE: [PATCH V4 2/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-05-02 Thread Anand Kumar Santhanam
James, Can you pls let us know the warning flags you are including in your makefile such that we can check from our end. Obviously it looks like we did not use -Warray-bounds in this case. Thanks. Regards Anand From: James Bottomley [mailto:james.bottom...@

Re: [PATCH 4/6] scsi_debug: add translation functions between LBA and index of provisioning map

2013-05-02 Thread James Bottomley
On Tue, 2013-04-16 at 22:11 +0900, Akinobu Mita wrote: > The translation from LBA to index of provisioning map (map_storep) is used > in various places (map_state(), map_region(), and unmap_region()). But it > is not correctly calculated if scsi_debug_unmap_alignment is zero. > > This introduces

Re: [PATCH V4 2/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-05-02 Thread James Bottomley
On Thu, 2013-04-18 at 11:25 -0700, Anand wrote: > >From 6e057b9cd46d2f0f1838cf727bf8c0abc6a7b399 Mon Sep 17 00:00:00 2001 > From: Sakthivel K > Date: Wed, 17 Apr 2013 16:26:36 +0530 > Subject: [PATCH V4 2/12] pm80xx: Added SPCv/ve specific ids, variables and > modify for SPC > > Updated pci id t

Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

2013-05-02 Thread Nicholas A. Bellinger
On Thu, 2013-05-02 at 16:58 +0300, Or Gerlitz wrote: > On 30/04/2013 05:59, Nicholas A. Bellinger wrote: > > Hello Linus! > > > > Here are the target pending changes for the v3.10-rc1 merge window. > > > > Please go ahead and pull from: > > > >git://git.kernel.org/pub/scm/linux/kernel/git/nab/t

Re: [PATCH 1/5] scsi: ufs: move the ufshcd_hba_stop to ufshcd.c

2013-05-02 Thread merez
Hi, Can you please rebase the next version on top of the following patches which are the next candidates for merge? Vinayak Holikatti (2): ufs: Add Platform glue driver for ufshcd ufs: Correct the expected data transfersize Dolev Raviv (1): scsi: ufs: add support for query requests Thanks,

RE: [PATCH V3 02/12] pm80xx: Added SPCv/ve specific ids, variables and modify for SPC

2013-05-02 Thread Anand Kumar Santhanam
Hi James, This is a scsi pull request for the PM80xx patchset resubmitted on the 18th April. Pls go ahead and use the patchset for 3.9+ merge. Regards Anand From: Anand Kumar Santhanam Sent: Thu 4/18/2013 11:43 AM To: 'James Bottomley' Cc: 'linux-scsi@vger.ke

Re: [PATCH V2 16/18] be2iscsi: Fix possible reentrancy issue in be_iopoll

2013-05-02 Thread James Bottomley
On Fri, 2013-04-05 at 20:38 -0700, Jayamohan Kallickal wrote: > From: Shlomo Pongratz > > The driver creates "NAPI" context per core which is fine, > however the above routine declares the ret variable as static! > Thus there is only one instance of this variable! > When this routine is calle

Re: initial LIO iSER performance numbers [was: GIT PULL] target updates for v3.10-rc1)

2013-05-02 Thread Or Gerlitz
On 30/04/2013 05:59, Nicholas A. Bellinger wrote: Hello Linus! Here are the target pending changes for the v3.10-rc1 merge window. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next-merge The highlights this round include: - Add

RE: [PATCH 5/5] scsi: ufs: add dme operations

2013-05-02 Thread Seungwon Jeon
On Thursday, May 02, 2013, Subhash Jadavani wrote: > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: > > Add uic command operations including DME_XXX series. > > > > Signed-off-by: Seungwon Jeon > > --- > > drivers/scsi/ufs/ufs-attrs.h | 129 > > drivers/scsi/ufs/ufshcd.c

RE: [PATCH 4/5] scsi: ufs: rework link start-up process

2013-05-02 Thread Seungwon Jeon
On Thursday, May 02, 2013, Subhash Jadavani wrote: > Few minor comments other than what Sujit/Santosh have already commented. I'll take your comments for next send. Thanks, Seungwon Jeon > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: > > Link start-up requires long time with multiphase handshakes

RE: [PATCH 5/5] scsi: ufs: add dme operations

2013-05-02 Thread Seungwon Jeon
On Thursday, May 02, 2013 Santosh Y wrote: > On Thu, May 2, 2013 at 1:36 PM, Santosh Y wrote: > >> +/* > >> + * drivers/scsi/ufs/ufs-attrs.h > >> + * > >> + * Copyright (C) 2013 Samsung Electronics Co., Ltd. > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >

RE: [PATCH 4/5] scsi: ufs: rework link start-up process

2013-05-02 Thread Seungwon Jeon
On Thursday, May 02, 2013, Santosh Y wrote: > On Thu, May 2, 2013 at 10:45 AM, Seungwon Jeon wrote: > > On Tuesday, April 30, 2013, Sujit Reddy Thumma wrote: > >> On 4/30/2013 12:03 PM, Seungwon Jeon wrote: > >> > On Monday, April 29, 2013, Sujit Reddy Thumma wrote: > >> >> On 4/29/2013 3:54 PM, S

RE: [PATCH 1/5] scsi: ufs: move the ufshcd_hba_stop to ufshcd.c

2013-05-02 Thread Seungwon Jeon
On Thursday, May 02, 2013, Santosh Y wrote: > On Wed, Apr 24, 2013 at 9:36 PM, Seungwon Jeon wrote: > > Move the ufshcd_hba_stop from header file. > > > > Signed-off-by: Seungwon Jeon > > --- > > drivers/scsi/ufs/ufshcd.c |9 + > > drivers/scsi/ufs/ufshcd.h |9 - > > 2 fi

Re: [PATCH 5/5] scsi: ufs: add dme operations

2013-05-02 Thread Subhash Jadavani
On 4/24/2013 9:36 PM, Seungwon Jeon wrote: Add uic command operations including DME_XXX series. Signed-off-by: Seungwon Jeon --- drivers/scsi/ufs/ufs-attrs.h | 129 drivers/scsi/ufs/ufshcd.c| 220 +- drivers/scsi/ufs/ufs

[PATCH 3/3] scsi: ufs: add support for query requests

2013-05-02 Thread Santosh Y
From: Dolev Raviv Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posi

[PATCH 1/3] ufs: Add Platform glue driver for ufshcd

2013-05-02 Thread Santosh Y
From: Vinayak Holikatti This patch adds Platform glue driver for ufshcd. Reviewed-by: Arnd Bergmann Reviewed-by: Namjae Jeon Reviewed-by: Subhash Jadavani Reviewed-by: Sujit Reddy Thumma Tested-by: Maya Erez Signed-off-by: Vinayak Holikatti Signed-off-by: Santosh Yaraganavi diff --git a/

[PATCH 2/3] ufs: Correct the expected data transfersize

2013-05-02 Thread Santosh Y
From: Vinayak Holikatti This patch corrects the expected data transfer size of the command UPIU. The current implementation of cmd->transfersize is wrong as it probably equal to sector size. With this implementation the transfer size is updated correctly Reported-by: KOBAYASHI Yoshitake Reviewe

[PATCH 0/3] scsi: ufs: Platform and Query updates

2013-05-02 Thread Santosh Y
Hi James, Please merge the following patches to scsi tree. Thanks, Santosh Dolev Raviv (1): scsi: ufs: add support for query requests Vinayak Holikatti (2): ufs: Add Platform glue driver for ufshcd ufs: Correct the expected data transfersize drivers/scsi/ufs/Kconfig | 12 ++ d

Re: [PATCH 4/5] scsi: ufs: rework link start-up process

2013-05-02 Thread Subhash Jadavani
Few minor comments other than what Sujit/Santosh have already commented. On 4/24/2013 9:36 PM, Seungwon Jeon wrote: Link start-up requires long time with multiphase handshakes between UFS host and device. This affects driver's probe time. This patch let link start-up run asynchronously. And comp

Re: [PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-05-02 Thread Sujit Reddy Thumma
On 5/2/2013 12:49 PM, Santosh Y wrote: -static inline void -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd) +static int ufshcd_send_uic_command(struct ufs_hba *hba, + struct uic_command *uic_cmnd, int retries) { + int err = 0; + unsigned long

Re: [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-02 Thread Sujit Reddy Thumma
On 5/2/2013 12:57 PM, Santosh Y wrote: + +/** + * ufshcd_validate_dev_connection() - Check device connection status + * @hba: per-adapter instance + * + * Send NOP OUT UPIU and wait for NOP IN response to check whether the + * device Transport Protocol (UTP) layer is ready after a reset. + * If t

Re: [PATCH] scsi: Double completion on retry

2013-05-02 Thread Hannes Reinecke
On 05/02/2013 10:31 AM, Hannes Reinecke wrote: > When blk_end_request() returns 'false' in scsi_end_request the > request is invalid after blk_end_request_all(). So we must not > return the then stale request pointer. Doing so will result > in a potential double completion. > And we should be calli

[PATCH] scsi: Double completion on retry

2013-05-02 Thread Hannes Reinecke
When blk_end_request() returns 'false' in scsi_end_request the request is invalid after blk_end_request_all(). So we must not return the then stale request pointer. Doing so will result in a potential double completion. And we should be calling scsi_release_buffers() before blk_end_request_all().

Re: [PATCH V4] scsi: ufs: add support for query requests

2013-05-02 Thread Santosh Y
> + > +/** > + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) > + * @hba - UFS hba > + * @lrb - pointer to local reference block > + */ > +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > +

[PATCH] qla4xxx: Fix iocb_cnt calculation in qla4xxx_send_mbox_iocb()

2013-05-02 Thread vikas.chaudhary
From: Vikas Chaudhary Increment 'ha->iocb_cnt' before adding mbox_iocb to iocb queue. Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_iocb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qla4xxx/ql4_iocb.c b/drivers/scsi/qla4xxx/ql4_iocb.c index 14fec97..fad71ed

Re: [PATCH 1/5] scsi: ufs: move the ufshcd_hba_stop to ufshcd.c

2013-05-02 Thread Santosh Y
On Wed, Apr 24, 2013 at 9:36 PM, Seungwon Jeon wrote: > Move the ufshcd_hba_stop from header file. > > Signed-off-by: Seungwon Jeon > --- > drivers/scsi/ufs/ufshcd.c |9 + > drivers/scsi/ufs/ufshcd.h |9 - > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git

Re: [PATCH 5/5] scsi: ufs: add dme operations

2013-05-02 Thread Santosh Y
On Thu, May 2, 2013 at 1:36 PM, Santosh Y wrote: >> +/* >> + * drivers/scsi/ufs/ufs-attrs.h >> + * >> + * Copyright (C) 2013 Samsung Electronics Co., Ltd. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License

Re: [PATCH 5/5] scsi: ufs: add dme operations

2013-05-02 Thread Santosh Y
> +/* > + * drivers/scsi/ufs/ufs-attrs.h > + * > + * Copyright (C) 2013 Samsung Electronics Co., Ltd. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; eithe

Re: [PATCH 4/5] scsi: ufs: rework link start-up process

2013-05-02 Thread Santosh Y
On Thu, May 2, 2013 at 10:45 AM, Seungwon Jeon wrote: > On Tuesday, April 30, 2013, Sujit Reddy Thumma wrote: >> On 4/30/2013 12:03 PM, Seungwon Jeon wrote: >> > On Monday, April 29, 2013, Sujit Reddy Thumma wrote: >> >> On 4/29/2013 3:54 PM, Seungwon Jeon wrote: >> >>> On Monday, April 29, 2013,

Re: linux-next: Tree for May 1

2013-05-02 Thread Hannes Reinecke
On 05/02/2013 09:37 AM, ZX wrote: > > > On Wed, 1 May 2013, Stephen Rothwell wrote: > >> Hi all, >> >> Please do not add any v3.11 destined work to your linux-next included >> branches until after v3.10-rc1 is released. >> >> Changes since 20130430: >> >> The nfsd tree lost its build failure. >>

Re: [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-02 Thread Santosh Y
> + > +/** > + * ufshcd_validate_dev_connection() - Check device connection status > + * @hba: per-adapter instance > + * > + * Send NOP OUT UPIU and wait for NOP IN response to check whether the > + * device Transport Protocol (UTP) layer is ready after a reset. > + * If the UTP layer at the devic

Re: [PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-05-02 Thread Santosh Y
> -static inline void > -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd) > +static int ufshcd_send_uic_command(struct ufs_hba *hba, > + struct uic_command *uic_cmnd, int retries) > { > + int err = 0; > + unsigned long flags; > + > + if (un

RE: [PATCH 2/5] scsi: ufs: wrap the i/o access operations

2013-05-02 Thread Seungwon Jeon
On Wednesday, May 01, 2013, merez wrote: > Tested-by: Maya Erez > > I also tend to agree with Sujit on the order of the wrappers parameters. Okay, I'll take the views of all(Sujit, Subhash and you) Thanks, Seungwon Jeon > > Thanks, > Maya > > > On 4/26/2013 10:36 AM, Seungwon Jeon wrote: > >>

RE: [PATCH 3/5] scsi: ufs: amend interrupt configuration

2013-05-02 Thread Seungwon Jeon
On Tuesday, April 30, 2013, Subhash Jadavani wrote: > Patch looks good but one minor comment below. > > On 4/24/2013 9:36 PM, Seungwon Jeon wrote: > > It makes interrupt setting more flexible especially > > for disabling. And wrong bit mask is fixed for ver 1.0. > > [17:16] is added for mask. > >