[PATCH V2 6/9] scsi: ufs: fix interrupt status clears

2013-05-14 Thread Dolev Raviv
There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Acked-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index c342a38..f4293d1 100644 --- a/d

[PATCH V2 7/9] scsi: ufs: rework link start-up process

2013-05-14 Thread Dolev Raviv
Link start-up requires long time with multiphase handshakes between UFS host and device. This affects driver's probe time. This patch let link start-up run asynchronously. Link start-up will be executed at the end of prove separately. Along with this change, the following is worked. Defined comple

[PATCH V2 9/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-05-14 Thread Dolev Raviv
Allow UFS device to complete its initialization and accept SCSI commands by setting fDeviceInit flag. The device may take time for this operation and hence the host should poll until fDeviceInit flag is toggled to zero. This step is mandated by UFS device specification for device initialization com

[PATCH V2 8/9] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-14 Thread Dolev Raviv
As part of device initialization sequence, sending NOP OUT UPIU and waiting for NOP IN UPIU response is mandatory. This confirms that the device UFS Transport (UTP) layer is functional and the host can configure the device with further commands. Add support for sending NOP OUT UPIU to check the dev

[PATCH V2 1/9] scsi: ufs: add support for query requests

2013-05-14 Thread Dolev Raviv
Add support for sending UFS query requests through tagged command queuing. This design allows queuing query requests in any open slot along with other SCSI commands. In this way there is no need to save a slot in the requests queue and decrease its size. A query request is posing to a SCSI command

[PATCH V2 2/9] Documentation: devicetree: Add DT bindings for UFS host controller

2013-05-14 Thread Dolev Raviv
Compatible list is used in commit 03b1781 but is not documented. Add necessary device tree bindings to describe on-chip UFS host controllers. Signed-off-by: Sujit Reddy Thumma diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-plt

[PATCH V2 4/9] scsi: ufs: wrap the i/o access operations

2013-05-14 Thread Dolev Raviv
Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Acked-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 7ce40a5..3946b9d 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -71,7 +71,7 @@ en

[PATCH V2 5/9] scsi: ufs: amend interrupt configuration

2013-05-14 Thread Dolev Raviv
It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Acked-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 3946b9d..c342a38

[PATCH V2 3/9] scsi: ufs: Fix the response UPIU length setting

2013-05-14 Thread Dolev Raviv
The response UPIU length should be in DWORD and not in bytes. Signed-off-by: Maya Erez Signed-off-by: Sujit Reddy Thumma Tested-by: Dolev Raviv diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 4ddc8be..7ce40a5 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/uf

[PATCH V2 0/9] ufs patch siries

2013-05-14 Thread Dolev Raviv
This patch series clusters the latest version of all the UFS patches in the SCSI mailing list. It gives a stable functional base line for the UFS driver. It includes the following versions: > [PATCH V5] scsi: ufs: add support for query requests > [PATCH 1/2] Documentation: devicetree: Add DT bindi

[PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds()

2013-05-14 Thread Gu Zheng
>From 18072c1c3506a7e37ee485307a2c343efe5af4d0 Mon Sep 17 00:00:00 2001 From: Gu Zheng Date: Mon, 13 May 2013 15:45:24 +0900 Subject: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds() Introduce a new timestamp function local_time_seconds() to hide the conversion o

[PATCH 2/2] driver/scsi: Use local_time_seconds() to simplify the get local timestamp operation

2013-05-14 Thread Gu Zheng
>From 1abbcf9fa5ce6c9a0b005a445c53b9412b42fa83 Mon Sep 17 00:00:00 2001 From: Gu Zheng Date: Mon, 13 May 2013 14:58:49 +0900 Subject: [PATCH 2/2] driver/scsi: Use local_time_seconds() to simplify the get local timestamp operation Signed-off-by: Gu Zheng --- drivers/scsi/3w-9xxx.c | 14 ++---

RE: [PATCH V1 0/8] ufs patch siries

2013-05-14 Thread Dolev Raviv
Yes, apparently I have, and I missed this mail as well until it was brought to my attention earlier. I apologise for re sending the patch series with mistakes, I withdraw it and let Santosh send it as he see fit. > On Monday, May 13, 2013, Dolev Raviv wrote: >> This patch series clusters the late

Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-14 Thread Gu Zheng
On 05/14/2013 01:23 AM, Yinghai Lu wrote: > On Mon, May 13, 2013 at 9:08 AM, Jiang Liu wrote: >> From: Gu Zheng >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index 4f0bc0a..bc075a3 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -1131,6 +1131,7 @@ static voi

Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-14 Thread Liu Jiang
On 05/14/2013 04:26 PM, Gu Zheng wrote: On 05/14/2013 01:23 AM, Yinghai Lu wrote: On Mon, May 13, 2013 at 9:08 AM, Jiang Liu wrote: From: Gu Zheng diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 4f0bc0a..bc075a3 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1131

Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-14 Thread Yinghai Lu
On Tue, May 14, 2013 at 7:59 AM, Liu Jiang wrote: > On 05/14/2013 04:26 PM, Gu Zheng wrote: > I suggest to use pci_release_dev() instead because it also needs to > release OF related resources. > I will update it in next version. > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > ind

Re: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds()

2013-05-14 Thread John Stultz
On 05/14/2013 12:45 AM, Gu Zheng wrote: From 18072c1c3506a7e37ee485307a2c343efe5af4d0 Mon Sep 17 00:00:00 2001 From: Gu Zheng Date: Mon, 13 May 2013 15:45:24 +0900 Subject: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds() Introduce a new timestamp function loca

[PATCH 0/3] UFSHCD updates

2013-05-14 Thread Santosh Y
Hi James, Please merge the following patches to scsi tree. Thanks, Santosh Geert Uytterhoeven (1): SCSI_UFSHCD should depend on SCSI_DMA Sachin Kamat (1): ufs: Remove redundant platform_set_drvdata() Sujit Reddy Thumma (1): Documentation: devicetree: Add DT bindings for UFS host controll

[PATCH 1/3] ufs: Remove redundant platform_set_drvdata()

2013-05-14 Thread Santosh Y
From: Sachin Kamat Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Signed-off-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 0331

[PATCH 2/3] SCSI_UFSHCD should depend on SCSI_DMA

2013-05-14 Thread Santosh Y
From: Geert Uytterhoeven If NO_DMA=y: drivers/built-in.o: In function `ufshcd_transfer_req_compl': drivers/scsi/ufs/ufshcd.c:1182: undefined reference to `scsi_dma_unmap' drivers/built-in.o: In function `ufshcd_map_sg': drivers/scsi/ufs/ufshcd.c:377: undefined reference to `scsi_dma_map' drivers

[PATCH 3/3] Documentation: devicetree: Add DT bindings for UFS host controller

2013-05-14 Thread Santosh Y
From: Sujit Reddy Thumma Compatible list is used in commit 03b1781 but is not documented. Add necessary device tree bindings to describe on-chip UFS host controllers. Signed-off-by: Sujit Reddy Thumma Signed-off-by: Santosh Y diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.tx

Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-14 Thread Liu Jiang
On Tue 14 May 2013 11:10:33 PM CST, Yinghai Lu wrote: On Tue, May 14, 2013 at 7:59 AM, Liu Jiang wrote: On 05/14/2013 04:26 PM, Gu Zheng wrote: I suggest to use pci_release_dev() instead because it also needs to release OF related resources. I will update it in next version. diff --git a/

Re: [PATCH V2 2/9] Documentation: devicetree: Add DT bindings for UFS host controller

2013-05-14 Thread Olof Johansson
On Tue, May 14, 2013 at 12:08 AM, Dolev Raviv wrote: > Compatible list is used in commit 03b1781 but is not documented. > Add necessary device tree bindings to describe on-chip UFS host > controllers. > > Signed-off-by: Sujit Reddy Thumma > > diff --git a/Documentation/devicetree/bindings/ufs/ufs

Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead

2013-05-14 Thread Yinghai Lu
On Tue, May 14, 2013 at 9:57 AM, Liu Jiang wrote: > On Tue 14 May 2013 11:10:33 PM CST, Yinghai Lu wrote: >> >> On Tue, May 14, 2013 at 7:59 AM, Liu Jiang wrote: >>> >>> On 05/14/2013 04:26 PM, Gu Zheng wrote: >>> I suggest to use pci_release_dev() instead because it also needs to >>> releas

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-14 Thread Martin K. Petersen
> "Jeremy" == Jeremy Linton writes: >> others. We see cases fairly often where a misbehaving target has >> confused the HBA enough that we can not bring the device back without >> doing an HBA firmware reset. Despite I/O completing successfully on >> other targets connected to the same HBA.

Re: SCSI testing/USB devices are amazing

2013-05-14 Thread Martin K. Petersen
> "Ronnie" == ronnie sahlberg writes: Ronnie, Ronnie> I have added tests for the block limits VPD as Ronnie> SCSI.Inquiry.InquiryBlockLimits. It checks that the pagelength Ronnie> is valid. 3C if SBC3 is claimed and 0C if prior to SBC3. Well, there are devices out there that claim SPC3/SBC

Re: [PATCH 1/2] Kernel/time: Introduce a new timestamp function local_time_seconds()

2013-05-14 Thread Gu Zheng
On 05/14/2013 11:57 PM, John Stultz wrote: > On 05/14/2013 12:45 AM, Gu Zheng wrote: >> From 18072c1c3506a7e37ee485307a2c343efe5af4d0 Mon Sep 17 00:00:00 2001 >> From: Gu Zheng >> Date: Mon, 13 May 2013 15:45:24 +0900 >> Subject: [PATCH 1/2] Kernel/time: Introduce a new timestamp function >> lo