Re: [PATCH] qla2x00t: Fix a memory leak in an error path

2013-05-16 Thread Saurav Kashyap
Hi Bart, Instead of doing this I would move this check to the top of the function, something like this -8<-- diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 371bb86..b5f84ae 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/ql

[PATCH 3/3] BusLogic: Use more conventional argument order for logging

2013-05-16 Thread Joe Perches
Subsystem specific logging messages generally use subsystem_(struct subsystem *, fmt, ...) not subsystem_(fmt, struct subsystem *, ...) Convert to use the more generally used kernel style. Signed-off-by: Joe Perches --- drivers/scsi/BusLogic.c | 304 -

[PATCH 2/3] BusLogic: Coalesce formats with multiple string fragments

2013-05-16 Thread Joe Perches
Strings fragments coalesced by the compiler are difficult to grep. Coalesce them instead. Signed-off-by: Joe Perches --- drivers/scsi/BusLogic.c | 66 - 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/BusLogic.c b/driv

[PATCH 1/3] BusLogic: Add __printf verification, fix fallout

2013-05-16 Thread Joe Perches
Make format and arguments match. Signed-off-by: Joe Perches --- drivers/scsi/BusLogic.c | 50 - drivers/scsi/BusLogic.h | 1 + 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c index

[PATCH 0/3] BusLogic: Message logging neatening

2013-05-16 Thread Joe Perches
If you're going through the trouble to fix this CamelCase stuff and make it work on 64 bit, how about a little more cleanup? Joe Perches (3): BusLogic: Add __printf verification, fix fallout BusLogic: Coalesce formats with multiple string fragments BusLogic: Use more conventional argument or

[PATCH] csiostor: Retain default adapter configuration in absence of config file.

2013-05-16 Thread Naresh Kumar Inna
- Retain firmware defined configuration settings in the absence of user-provided configuration by eliminating the global RSS and the PF/VF capabilities mailbox commands. - Remove S_IRUGO from sysfs parameters that don't have 'show' functionality. Signed-off-by: Naresh Kumar Inna --- drivers/scsi

[PATCH v2 0/2] scsi: Port buslogic driver to 64 bits

2013-05-16 Thread Khalid Aziz
This patchset ports buslogic driver to 64-bit. Current buslogic driver is composed of two components - SCCB manager which communicates with adapter to execute SCSI commands (contained in FlashPoint.c), and Linux driver part that interfaces with rest of the kernel (contained in BusLogic.c). SCCB ma

Re: [PATCH] Hard disk S3 resume time optimization

2013-05-16 Thread Tejun Heo
On Thu, May 16, 2013 at 03:44:41PM -0700, Tejun Heo wrote: > So, while I agree about the problem and the solution seems to be > headed the right way of making SCSI suspend/resume asynchronous, > what's going on with patch splitting, submission format and comments? > Please read up on patch submissi

Re: [PATCH] Hard disk S3 resume time optimization

2013-05-16 Thread Tejun Heo
Hello, First of all, if at all possible, please try to fill the message to 80 columns, preferably a bit narrower than that. Most email clients can do it without you knowing. > [The Problem] > The vast majority of time spent in S3 resume is consumed by the ATA > subsystem as it resumes the comput

[PATCH] Hard disk S3 resume time optimization

2013-05-16 Thread Brandt, Todd E
Hello, my name's Todd Brandt and I'm the project owner for Intel Open Source Technology Center's new project to optimize suspend/resume time. Our website is: https://01.org/suspendresume [The Problem] The vast majority of time spent in S3 resume is consumed by the ATA subsystem as it resumes the

[PATCH 0/2] scsi: Port buslogic driver to 64 bits

2013-05-16 Thread Khalid Aziz
This patchset ports buslogic driver to 64-bit. Current buslogic driver is composed of two components - SCCB manager which communicates with adapter to execute SCSI commands (contained in FlashPoint.c), and Linux driver part that interfaces with rest of the kernel (contained in BusLogic.c). SCCB m

Re: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS

2013-05-16 Thread Dan Carpenter
On Thu, May 16, 2013 at 02:01:12PM +, KY Srinivasan wrote: > > Would the right fix be to add some sanity checks in module_init()? > > The check is already there (as I noted above). Look at the function: > storvsc_drv_init(). If the ring size is picked incorrectly, the load is > failed. > Ah

Re: [PATCH V1 2/7] Drivers: hv: Add the GUID fot synthetic fiber channel device

2013-05-16 Thread Greg KH
On Thu, May 16, 2013 at 05:21:14AM -0700, K. Y. Srinivasan wrote: > In preparation for supporting synthetic Fiber Channel device, add the GUID for > this service. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: sen

Re: [PATCH V1 1/7] Drivers: hv: vmbus: Implement multi-channel support

2013-05-16 Thread Greg KH
On Thu, May 16, 2013 at 05:21:13AM -0700, K. Y. Srinivasan wrote: > Starting with Win8, the host supports multiple sub-channels for a given > device. As in the past, the initial channel offer specifies the device and > is associated with both the type and the instance GUIDs. For performance > criti

RE: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS

2013-05-16 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, May 16, 2013 9:55 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; > h...@infrad

Re: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS

2013-05-16 Thread Dan Carpenter
On Thu, May 16, 2013 at 01:37:41PM +, KY Srinivasan wrote: > > > > -Original Message- > > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > > Sent: Thursday, May 16, 2013 8:02 AM > > To: KY Srinivasan > > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > > de...@li

RE: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS

2013-05-16 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Thursday, May 16, 2013 8:02 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; jbottom...@parallels.com; > h...@infrad

Re: [PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS

2013-05-16 Thread Dan Carpenter
On Thu, May 16, 2013 at 05:21:19AM -0700, K. Y. Srinivasan wrote: > Increase the value of STORVSC_MAX_IO_REQUESTS to 200 requests. The current > ringbuffer size can support this higher value. > The ringbuffer size is a module parameter so it's odd to talk about the "current" size. regards, dan c

[PATCH V1 7/7] Drivers: scsi: storvsc: Increase the value of STORVSC_MAX_IO_REQUESTS

2013-05-16 Thread K. Y. Srinivasan
Increase the value of STORVSC_MAX_IO_REQUESTS to 200 requests. The current ringbuffer size can support this higher value. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/scsi/storvsc_drv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/s

[PATCH V1 6/7] Drivers: scsi: storvsc: Support FC devices

2013-05-16 Thread K. Y. Srinivasan
Add support for synthetic Fiber Channel devices. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/scsi/storvsc_drv.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 6bc4e3b..124cf0b

[PATCH V1 5/7] Drivers: scsi: storvsc: Implement multi-channel support

2013-05-16 Thread K. Y. Srinivasan
Implement multi-channel support for the storage devices. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/scsi/storvsc_drv.c | 124 ++-- 1 files changed, 120 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/d

[PATCH V1 3/7] Drivers: scsi: storvsc: Make the scsi timeout a module parameter

2013-05-16 Thread K. Y. Srinivasan
The standard scsi timeout is not appropriate in some of the environments where Hyper-V is deployed. Set this timeout appropriately for all devices managed by this driver. Further make this a module parameter. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/scsi/storvsc_dr

[PATCH V1 4/7] Drivers: scsi: storvsc: Update the storage protocol to win8 level

2013-05-16 Thread K. Y. Srinivasan
Update the storage protocol to the win8 level. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/scsi/storvsc_drv.c | 203 1 files changed, 168 insertions(+), 35 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/sc

[PATCH V1 2/7] Drivers: hv: Add the GUID fot synthetic fiber channel device

2013-05-16 Thread K. Y. Srinivasan
In preparation for supporting synthetic Fiber Channel device, add the GUID for this service. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- include/linux/hyperv.h | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/include/linux/hyperv.h b/include/

[PATCH V1 1/7] Drivers: hv: vmbus: Implement multi-channel support

2013-05-16 Thread K. Y. Srinivasan
Starting with Win8, the host supports multiple sub-channels for a given device. As in the past, the initial channel offer specifies the device and is associated with both the type and the instance GUIDs. For performance critical devices, the host may support multiple sub-channels. The sub-channels

[PATCH V1 0/7] Drivers: hv/scsi: Implement multi-channel support

2013-05-16 Thread K. Y. Srinivasan
This patch-set implements multi-channel support for Hyper-V devices. Also support for synthetic Fiber Channel device is included. The first two patches in the series are the foundational pieces for many of the remaining patches. James, once Greg accepts the first two patches, you can consider the

RE: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support

2013-05-16 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, May 16, 2013 12:02 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux- > s...@vger.kerne

RE: [PATCH 0/6] Drivers: hv/scsi: Implement multi-channel support

2013-05-16 Thread KY Srinivasan
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, May 16, 2013 12:00 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; > oher...@suse.com; jbottom...@parallels.com; h...@infradead.org; linux- > s...@vger.kerne