[PATCH 1/3] target: Remove unused wait_for_tasks bit in target_wait_for_sess_cmds

2013-05-17 Thread Nicholas A. Bellinger
From: Joern Engel Drop unused transport_wait_for_tasks() check in target_wait_for_sess_cmds shutdown code, and convert tcm_qla2xxx + ib_srpt fabric drivers. Cc: Joern Engel Cc: Roland Dreier Signed-off-by: Nicholas Bellinger --- drivers/infiniband/ulp/srpt/ib_srpt.c |2 +- drivers/scsi/

[PATCH 2/3] target: Re-instate sess_wait_list for target_wait_for_sess_cmds

2013-05-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Switch back to pre commit 1c7b13fe652 list splicing logic for active I/O shutdown with tcm_qla2xxx + ib_srpt fabrics. The original commit was done under the incorrect assumption that it's safe to walk se_sess->sess_cmd_list unprotected in target_wait_for_sess_cmds() afte

[PATCH 3/3] ib_srpt: Call target_sess_cmd_list_set_waiting during shutdown_session

2013-05-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Given that srpt_release_channel_work() calls target_wait_for_sess_cmds() to allow outstanding se_cmd_t->cmd_kref a change to complete, the call to perform target_sess_cmd_list_set_waiting() needs to happen in srpt_shutdown_session() Also, this patch adds an explicit call

[PATCH 0/3] target: Re-instate sess_wait_list usage

2013-05-17 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi folks, Here's a short series to re-instate the original sess_wait_list to pre commit 1c7b13fe652 logic, along with the necessary changes to function within ib_srpt code during active I/O shutdown. This has been tested with ib_srpt, but still needs to be verified with

Re: SCSI testing/USB devices are amazing

2013-05-17 Thread ronnie sahlberg
Martin, Thansk for your suggestions. On Tue, May 14, 2013 at 3:43 PM, Martin K. Petersen wrote: >> "Ronnie" == ronnie sahlberg writes: ... > Ronnie> I have added tests for the block limits VPD as > Ronnie> SCSI.Inquiry.InquiryBlockLimits. It checks that the pagelength > Ronnie> is valid. 3C

Re: mpt2sas,mpt3sas watchdog device removal

2013-05-17 Thread Joe Lawrence
On Fri, 17 May 2013 09:29:06 -0600 Bjorn Helgaas wrote: > [+cc linux-pci] > > On Wed, May 15, 2013 at 11:29 AM, Joe Lawrence > wrote: > > From 84ac7a35ebd61e84d4254eae78bb967de17254c2 Mon Sep 17 00:00:00 > > 2001 From: Joe Lawrence > > Date: Wed, 15 May 2013 12:52:31 -0400 > > Subject: [PATCH]

Re: [PATCH 0/3] BusLogic: Message logging neatening

2013-05-17 Thread Khalid Aziz
On 05/17/2013 02:35 PM, Joe Perches wrote: On Fri, 2013-05-17 at 14:18 -0600, Khalid Aziz wrote: On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: If you're going through the trouble to fix this CamelCase stuff and make it work on 64 bit, how about a little more cleanup? Sounds good to me

Re: [PATCH 0/3] BusLogic: Message logging neatening

2013-05-17 Thread Joe Perches
On Fri, 2013-05-17 at 14:18 -0600, Khalid Aziz wrote: > On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > > If you're going through the trouble to fix this CamelCase stuff > > and make it work on 64 bit, how about a little more cleanup? > > Sounds good to me. btw, for the BusLogic code: Th

Re: [PATCH 3/3] BusLogic: Use more conventional argument order for logging

2013-05-17 Thread Khalid Aziz
On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > Subsystem specific logging messages generally use > subsystem_(struct subsystem *, fmt, ...) > not > subsystem_(fmt, struct subsystem *, ...) > > Convert to use the more generally used kernel style. > > Signed-off-by: Joe Perches

Re: [PATCH 2/3] BusLogic: Coalesce formats with multiple string fragments

2013-05-17 Thread Khalid Aziz
On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > Strings fragments coalesced by the compiler are > difficult to grep. Coalesce them instead. > > Signed-off-by: Joe Perches > --- > drivers/scsi/BusLogic.c | 66 > - > 1 file changed, 33 inse

Re: [PATCH 1/3] BusLogic: Add __printf verification, fix fallout

2013-05-17 Thread Khalid Aziz
On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > Make format and arguments match. > > Signed-off-by: Joe Perches > --- > drivers/scsi/BusLogic.c | 50 > - > drivers/scsi/BusLogic.h | 1 + > 2 files changed, 26 insertions(+), 25 deletions(-

Re: [PATCH 0/3] BusLogic: Message logging neatening

2013-05-17 Thread Khalid Aziz
On Thu, 2013-05-16 at 21:58 -0700, Joe Perches wrote: > If you're going through the trouble to fix this CamelCase stuff > and make it work on 64 bit, how about a little more cleanup? Sounds good to me. Thanks, Joe. -- Khalid -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-05-17 Thread Alan Stern
On Fri, 17 May 2013, Brandt, Todd E wrote: > Updates the drivers/base/power subsystem to allow any devices which > have registred as asynchronous and who have not registered "complete" > callbacks to be non-blocking. i.e system resume can finish and return > control to the user while these devices

Re: [PATCH v2 1/2] ATA/SCSI subsystem resume path made fully asynchronous

2013-05-17 Thread Alan Stern
On Fri, 17 May 2013, Brandt, Todd E wrote: > This patch goes through and sets the power.async_suspend flag for every device > in the ATA/SCSI resume path. This includes the ata port, link, and dev > devices, the scsi host and target devices, all their associated transport > devices, the block devi

RE: [PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-05-17 Thread Brandt, Todd E
Hi, will do, thanks for the feedback. I used the goto to make the code addition smaller, but I obviously sacrificed code clarity. From: Greg Kroah-Hartman [gre...@linuxfoundation.org] Sent: Friday, May 17, 2013 12:11 PM To: Brandt, Todd E Cc: linux-...@vge

Re: [PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-05-17 Thread Greg Kroah-Hartman
On Fri, May 17, 2013 at 07:05:33PM +, Brandt, Todd E wrote: > Updates the drivers/base/power subsystem to allow any devices which > have registred as asynchronous and who have not registered "complete" > callbacks to be non-blocking. i.e system resume can finish and return > control to the user

[PATCH v2 2/2] Adds new device resume mode in PM core, async plus non-blocking

2013-05-17 Thread Brandt, Todd E
Updates the drivers/base/power subsystem to allow any devices which have registred as asynchronous and who have not registered "complete" callbacks to be non-blocking. i.e system resume can finish and return control to the user while these devices continue resuming. Changelog: v2: - Update

[PATCH v2 1/2] ATA/SCSI subsystem resume path made fully asynchronous

2013-05-17 Thread Brandt, Todd E
This patch goes through and sets the power.async_suspend flag for every device in the ATA/SCSI resume path. This includes the ata port, link, and dev devices, the scsi host and target devices, all their associated transport devices, the block devices, and block partitions. This allows the entire AT

[PATCH v2 0/2] Hard disk S3 resume time optimization

2013-05-17 Thread Brandt, Todd E
The vast majority of time spent in S3 resume is consumed by the ATA subsystem as it resumes the computer's hard drives. For large hard disks this time can be upwards of 10 seconds, which makes S3 suspend/resume too costly to use frequently. This time needs to be reduced. More details here: https:

Re: mpt2sas,mpt3sas watchdog device removal

2013-05-17 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, May 15, 2013 at 11:29 AM, Joe Lawrence wrote: > From 84ac7a35ebd61e84d4254eae78bb967de17254c2 Mon Sep 17 00:00:00 2001 > From: Joe Lawrence > Date: Wed, 15 May 2013 12:52:31 -0400 > Subject: [PATCH] mpt2sas,mpt3sas: make watchdog instantiated device removal > safe > > Ca

Re: [PATCH] mpt2sas,mpt3sas: make watchdog instantiated device removal safe

2013-05-17 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, May 15, 2013 at 11:26 AM, Joe Lawrence wrote: > From 9fc1a958ad48718216fbdc19405297dd11d11539 Mon Sep 17 00:00:00 2001 > From: Joe Lawrence > Date: Tue, 14 May 2013 15:41:17 -0400 > Subject: [PATCH] mpt2sas,mpt3sas: make watchdog instantiated device removal > safe > > Ca

Re: [PATCH] qla2x00t: Fix a memory leak in an error path

2013-05-17 Thread Bart Van Assche
On 05/17/13 07:00, Saurav Kashyap wrote: Instead of doing this I would move this check to the top of the function, something like this -8<-- diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index 371bb86..b5f84ae 100644 --- a/drivers/scsi/qla2xx

[PATCH RESEND] scsi/trivial: Spelling hsot -> host

2013-05-17 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/scsi/aic7xxx_old/aic7xxx.seq |2 +- drivers/scsi/scsi_error.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx_old/aic7xxx.seq b/drivers/scsi/aic7xxx_old/aic7xxx.seq index 823ff28..dc3bb81