Re: [PATCH 1/3] Percpu tag allocator

2013-06-08 Thread Oleg Nesterov
On 06/08, Nicholas A. Bellinger wrote: > > +unsigned tag_alloc(struct tag_pool *pool, bool wait) > +{ > + struct tag_cpu_freelist *tags; > + unsigned long flags; > + unsigned ret; > +retry: > + preempt_disable(); > + local_irq_save(flags); > + tags = this_cpu_ptr(pool->tag_c

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-08 Thread Akinobu Mita
2013/6/7 Martin K. Petersen : >> "Akinobu" == Akinobu Mita writes: > > Akinobu> So Martin and Douglas, can I have your ACKs on this patch > Akinobu> series for now? > > Only concern is the one I mentioned before: You're mapping and unmapping > the ppage for every 8 bytes of protection informat

Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-08 Thread Akinobu Mita
2013/6/7 Tejun Heo : > Hello, > > On Thu, Jun 06, 2013 at 09:52:56PM +0900, Akinobu Mita wrote: >> +static bool sg_miter_get_next_page(struct sg_mapping_iter *miter) >> +{ >> + if (!miter->__remaining) { >> + struct scatterlist *sg; >> + unsigned long pgoffset; >> + >> +

Re: [PATCH 1/3] lib/scatterlist: introduce sg_pcopy_from_buffer() and sg_pcopy_to_buffer()

2013-06-08 Thread Akinobu Mita
2013/6/6 Imre Deak : > Looks ok to me, perhaps adding the seek functionality to the mapping > iterator would make things more generic and the mapping iterator more > resemble the page iterator. So we'd have a new sg_miter_start_offset and > call it here something like: > > sg_miter_start_offset(&mi

Re: [PATCH 0/10] qla2xxx: Reduce the number of Coverity warnings

2013-06-08 Thread Bart Van Assche
On 06/07/13 21:06, Saurav Kashyap wrote: Thanks for the patches. Please share the warnings reported by Coverity, so that its easy for us to review the patches. Hello Saurav, The Coverity warnings that led me to developing this patch series are as follows: - For patches 1, 2, 3, 8: Logically d