[PATCH 5/8][SCSI] mpt2sas: Infinite loop can occur if MPI2_IOCSTATUS_CONFIG_INVALID_PAGE is not returned

2013-07-25 Thread Sreekanth Reddy
Infinite loop can occur if IOCStatus is not equal to MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions _scsih_search_responding_sas_devices, _scsih_search_responding_raid_devices and _scsih_search_responding_expanders So, Instead of checking for

[PATCH 6/8][SCSI] mpt2sas: when Async scanning is enabled then while scanning, devices are removed but their transport layer entries are not removed

2013-07-25 Thread Sreekanth Reddy
When Async scanning mode is enabled and device scanning is in progress then devices should not be removed. But in actuality, devices are removed but their transport layer entries are not removed. This causes error to add the same device to the transport layer after host reset or diagnostic reset.

[PATCH 7/8][SCSI] mpt2sas: Fix for kernel panic when driver loads with HBA connected to non LUN 0 configured expander

2013-07-25 Thread Sreekanth Reddy
With some enclosures when LUN 0 is not created but LUN 1 or LUN X is created then SCSI scan procedure calls target_alloc, slave_alloc call back functions for LUN 0 and slave_destory() for same LUN 0. In these kind of cases within slave_destroy, pointer to scsi_target in _sas_device structure is

[PATCH 8/8][SCSI] mpt2sas: Bump driver version to v16.100.00.00

2013-07-25 Thread Sreekanth Reddy
Bump driver version to v16.100.00.00. Signed-off-by: Sreekanth Reddy sreekanth.re...@lsi.com --- drivers/scsi/mpt2sas/mpt2sas_base.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.h b/drivers/scsi/mpt2sas/mpt2sas_base.h index

Re: [PATCH] pm80xx: fix Adaptec 71605H hang

2013-07-25 Thread Hans Verkuil
Hi Anand, On 07/25/2013 06:44 AM, Anand Kumar Santhanam wrote: Hi Hans, Are you planning to address the below comment and submit an updated patch? I think there was a misunderstanding there. It was my impression that you would do a follow-up patch for that. I can add the define if you

RE: [PATCH] pm80xx: fix Adaptec 71605H hang

2013-07-25 Thread Anand Kumar Santhanam
Hans, The below #defines are available in pm8001_defs.h /* Inbound/Outbound queue size */ #define IOMB_SIZE_SPC 64 #define IOMB_SIZE_SPCV128 You can use IOMB_SIZE_SPC in pm8001_hwi.c file and IOMB_SIZE_SPCV in pm80xx_hwi.c Regards Anand -Original Message- From: Hans

[PATCHv2 0/3] qla2xxx, qla4xxx: re-use %p[hmM] specifiers to print variables

2013-07-25 Thread Andy Shevchenko
We have nice specifiers in the kernel that helps us to simplify printing of the small buffers (as hexstring) and MAC addresses. Since v1: - rewritten commit messages to reflect changes better - append patch 2/3 - apply ACK to patch 3/3 Andy Shevchenko (1): scsi: qla2xxx: print MAC via %pMR

[PATCHv2 1/3] scsi: qla2xxx: print some variables via %*phC or %*phN format

2013-07-25 Thread Andy Shevchenko
From: Oleksandr Khoshaba oleksandr.khosh...@gmail.com The patch changes a specifier used to output some variables. Instead of using stack for each byte the '%*ph[CN]' allows to take a one pointer and prints entire buffer as a hexadecimal string with the separator ':' or ''. Signed-off-by:

[PATCHv2 2/3] scsi: qla2xxx: print MAC via %pMR

2013-07-25 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/scsi/qla2xxx/qla_attr.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index d7a99ae..f925f07 100644 ---

[PATCHv2 3/3] scsi: qla4xxx: print MAC and SID via %p[mM][R]

2013-07-25 Thread Andy Shevchenko
From: Oleksandr Khoshaba oleksandr.khosh...@gmail.com In the kernel we have nice specifier to print MAC by given pointer to the address in binary form. Signed-off-by: Oleksandr Khoshaba oleksandr.khosh...@gmail.com Acked-by: Vikas Chaudhary vikas.chaudh...@qlogic.com ---

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-25 Thread Alexander Gordeev
On Mon, Jul 22, 2013 at 02:10:36PM -0700, Nicholas A. Bellinger wrote: Np. FYI, you'll want to use the latest commit e7827b351 HEAD from target-pending/scsi-mq, which now has functioning scsi-generic support. Survives a boot, a kernel build and the build's result :) -- Regards, Alexander

Re: [PATCH 5/8][SCSI] mpt2sas: Infinite loop can occur if MPI2_IOCSTATUS_CONFIG_INVALID_PAGE is not returned

2013-07-25 Thread James Bottomley
On Thu, 2013-07-25 at 11:29 +0530, Sreekanth Reddy wrote: Infinite loop can occur if IOCStatus is not equal to MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions _scsih_search_responding_sas_devices, _scsih_search_responding_raid_devices and

Re: [RFC PATCH 1/2] ata: acpi: remove dead code for ata_acpi_(un)bind

2013-07-25 Thread Tejun Heo
On Thu, Jul 25, 2013 at 01:47:02PM +0800, Aaron Lu wrote: Commit 7381fe737 libata-acpi: remove redundent code for power resource handling removed ata_acpi_(un)bind but left their prototypes in libata.h, so remove them. Signed-off-by: Aaron Lu aaron...@intel.com Applied to libata/for-3.12.

Re: [RFC PATCH 2/2] ata: acpi: rework the ata acpi bind support

2013-07-25 Thread Tejun Heo
On Thu, Jul 25, 2013 at 01:47:03PM +0800, Aaron Lu wrote: Binding ACPI handle to SCSI device has several drawbacks, namely: 1 During ATA device initialization time, ACPI handle will be needed while SCSI devices are not created yet. So each time ACPI handle is needed, instead of retrieving

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-07-25 Thread vaughan
On 07/23/2013 01:03 AM, Jörn Engel wrote: On Mon, 22 July 2013 12:40:29 +0800, Vaughan Cao wrote: There is a race when open sg with O_EXCL flag. Also a race may happen between sg_open and sg_remove. Changes from v4: * [3/4] use ERR_PTR series instead of adding another parameter in

Re: [PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

2013-07-25 Thread Martin Peschke
On Mon, 2013-07-15 at 20:52 +0900, Akinobu Mita wrote: With module parameter num_parts 0, partition table is built on the ramdisk storage when loading the driver. Unfortunately, there is an endianness bug in sdebug_build_parts(). So the partition table is not correctly initialized on

Re: [PATCH 1/4] scsi_debug: fix endianness bug in sdebug_build_parts()

2013-07-25 Thread Douglas Gilbert
On 13-07-25 01:10 PM, Martin Peschke wrote: On Mon, 2013-07-15 at 20:52 +0900, Akinobu Mita wrote: With module parameter num_parts 0, partition table is built on the ramdisk storage when loading the driver. Unfortunately, there is an endianness bug in sdebug_build_parts(). So the partition

Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-07-25 Thread Douglas Gilbert
On 13-07-25 11:32 AM, vaughan wrote: On 07/23/2013 01:03 AM, Jörn Engel wrote: On Mon, 22 July 2013 12:40:29 +0800, Vaughan Cao wrote: There is a race when open sg with O_EXCL flag. Also a race may happen between sg_open and sg_remove. Changes from v4: * [3/4] use ERR_PTR series instead of

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-25 Thread Nicholas A. Bellinger
On Thu, 2013-07-25 at 12:16 +0200, Alexander Gordeev wrote: On Mon, Jul 22, 2013 at 02:10:36PM -0700, Nicholas A. Bellinger wrote: Np. FYI, you'll want to use the latest commit e7827b351 HEAD from target-pending/scsi-mq, which now has functioning scsi-generic support. Survives a boot, a

Re: [RFC PATCH 2/2] ata: acpi: rework the ata acpi bind support

2013-07-25 Thread Aaron Lu
On 07/25/2013 10:52 PM, Tejun Heo wrote: On Thu, Jul 25, 2013 at 01:47:03PM +0800, Aaron Lu wrote: Binding ACPI handle to SCSI device has several drawbacks, namely: 1 During ATA device initialization time, ACPI handle will be needed while SCSI devices are not created yet. So each time ACPI

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-25 Thread Jens Axboe
On Thu, Jul 25 2013, Nicholas A. Bellinger wrote: On Thu, 2013-07-25 at 12:16 +0200, Alexander Gordeev wrote: On Mon, Jul 22, 2013 at 02:10:36PM -0700, Nicholas A. Bellinger wrote: Np. FYI, you'll want to use the latest commit e7827b351 HEAD from target-pending/scsi-mq, which now has

Re: Questions about your scsi-mq prototype

2013-07-25 Thread Nicholas A. Bellinger
On Tue, 2013-07-16 at 10:39 -0700, Nicholas A. Bellinger wrote: On Mon, 2013-07-15 at 16:41 -0500, scame...@beardog.cce.hp.com wrote: Hi, I have some questions about your scsi-mq prototype. I have CC'ed Chayan Biswas from Sandisk who is the other guy working with me on the

Re: targetcli -fb now also Apache 2.0 licensed

2013-07-25 Thread Andy Grover
On 07/24/2013 06:19 PM, Nicholas A. Bellinger wrote: Because -fb has had close to zero peer review, and you've not solicited much input (none from us) before making significant changes to rtslib/targetcli over the past 1 1/2 years. For your own private tree this wouldn't matter. However, for a