RE: [PATCH] pm80xx: Fix for 32 bit compilation issue.

2013-08-09 Thread Anand Kumar Santhanam
James, Thanks for the suggestion. This looks better. Will submit an updated patch. Regards Anand -Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Wednesday, August 07, 2013 11:35 PM To: Anand Kumar Santhanam Cc: linux-scsi@vger.kernel.org;

[PATCH V2] pm80xx: Fix for 32 bit compilation issue.

2013-08-09 Thread Anand
From d89ed52c141b7f5599eb09e9d7f1010e1a89dcad Mon Sep 17 00:00:00 2001 From: Anand Kumar Santhanam anandkumar.santha...@pmcs.com Date: Mon, 5 Aug 2013 14:16:52 +0530 Subject: [PATCH V2] pm80xx: Fix for 32 bit compilation issue. pm80xx driver does not compile under 32 bit linux. This patch fixes

Re: [PATCH 11/16] pm8001: clean up unnecessary MSI/MSI-X capability find

2013-08-09 Thread Yijing Wang
On 2013/8/9 10:57, lindar_liu wrote: On 08/08/2013 9:10 PM, Yijing Wang wrote: PCI core will initialize device MSI/MSI-X capability in pci_msi_init_pci_dev(). So device driver should use pci_dev- msi_cap/msix_cap to determine whether the device support MSI/MSI-X instead of using

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Alexander Gordeev
On Mon, Jul 29, 2013 at 07:46:53AM -0400, Tejun Heo wrote: One thing which would probably be worthwhile tho is getting rid of the bitmap based qc tag allocator in libata. That one is just borderline stupid to keep around on any setup which is supposed to be scalable. Hi Tejun, How about this

Re: [PATCH v2] Hard disk S3 resume time optimization

2013-08-09 Thread Oliver Neukum
On Fri, 2013-08-09 at 01:09 +, Brandt, Todd E wrote: static struct ata_force_ent *ata_force_tbl; static int ata_force_tbl_size; +int ata_resume_status; A single global variable for multiple ports? static char ata_force_param_buf[PAGE_SIZE] __initdata; /* param_buf is thrown away

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Tejun Heo
On Fri, Aug 09, 2013 at 10:23:35AM +0200, Alexander Gordeev wrote: On Mon, Jul 29, 2013 at 07:46:53AM -0400, Tejun Heo wrote: One thing which would probably be worthwhile tho is getting rid of the bitmap based qc tag allocator in libata. That one is just borderline stupid to keep around on

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Jens Axboe
On 08/09/2013 02:23 AM, Alexander Gordeev wrote: On Mon, Jul 29, 2013 at 07:46:53AM -0400, Tejun Heo wrote: One thing which would probably be worthwhile tho is getting rid of the bitmap based qc tag allocator in libata. That one is just borderline stupid to keep around on any setup which is

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-09 Thread Ewan Milne
On Thu, 2013-08-08 at 18:15 -0700, James Bottomley wrote: On Thu, 2013-08-08 at 12:08 -0400, Ewan Milne wrote: On Fri, 2013-08-02 at 10:06 -0700, James Bottomley wrote: On Thu, 2013-08-01 at 16:57 -0400, Ewan D. Milne wrote: From: Ewan D. Milne emi...@redhat.com + *

Re: [PATCH v4 08/10] scsi: Generate uevents on certain unit attention codes

2013-08-09 Thread James Bottomley
On Fri, 2013-08-09 at 10:50 -0400, Ewan Milne wrote: On Thu, 2013-08-08 at 18:15 -0700, James Bottomley wrote: OK, I'm fine either way, so I think we're good to go. I sent v5 yesterday. Let me know if you want a v6 with that SPC_3 test removed. (I'll be out next week, if you want to just

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Alexander Gordeev
On Fri, Aug 09, 2013 at 08:24:38AM -0600, Jens Axboe wrote: On 08/09/2013 02:23 AM, Alexander Gordeev wrote: + ap-qc_tags = blk_mq_init_tags(ATA_MAX_QUEUE, 1, NUMA_NO_NODE); + if (!ap-qc_tags) { + kfree(ap); + return NULL; + } This should be

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Jens Axboe
On 08/09/2013 09:07 AM, Alexander Gordeev wrote: On Fri, Aug 09, 2013 at 08:24:38AM -0600, Jens Axboe wrote: On 08/09/2013 02:23 AM, Alexander Gordeev wrote: + ap-qc_tags = blk_mq_init_tags(ATA_MAX_QUEUE, 1, NUMA_NO_NODE); + if (!ap-qc_tags) { + kfree(ap); + return

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Alexander Gordeev
On Fri, Aug 09, 2013 at 09:52:19AM -0600, Jens Axboe wrote: On 08/09/2013 09:07 AM, Alexander Gordeev wrote: diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index dcbc2a4..b131a48 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c @@ -468,10 +468,9 @@ struct blk_mq_tags

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Jens Axboe
On 08/09/2013 10:46 AM, Alexander Gordeev wrote: On Fri, Aug 09, 2013 at 09:52:19AM -0600, Jens Axboe wrote: On 08/09/2013 09:07 AM, Alexander Gordeev wrote: diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index dcbc2a4..b131a48 100644 --- a/block/blk-mq-tag.c +++ b/block/blk-mq-tag.c

Re: [PATCH] IB/iser: Add Discovery support

2013-08-09 Thread Mike Christie
On 08/08/2013 05:44 AM, Or Gerlitz wrote: To run discovery over iSER we need to advertize the CAP_TEXT_NEGO capability towards user space. Also need to make sure the login RX buffer is posted when SendTargets TEXT PDUs are sent. For that end, we use a setting of the ISCSI_PARAM_DISCOVERY_SESS

Re: [PATCH v2] Hard disk S3 resume time optimization

2013-08-09 Thread Alan Stern
Your email messages would be easier to work with if they were wrapped after column 72 or so. On Fri, 9 Aug 2013, Brandt, Todd E wrote: This patch essentially removes the disk spinup wait time from the system S3 resume delay. It can be a very significant improvement on systems with large

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-09 Thread Alexander Gordeev
On Sat, Jul 20, 2013 at 09:48:28AM -0500, Mike Christie wrote: What about the attached only compile tested patch. The patch has the mq block code work like the non mq code for bio cleanups. Not sure if it is related to the patch or not, but it never returns from wait_for_completion_io(wait) in

RE: [PATCH v2] Hard disk S3 resume time optimization

2013-08-09 Thread Brandt, Todd E
I'll redo the ata portion as a separate patch, thanks for the feedback. For the sd.c changes the basic structure hasn't changed from the synchronous version, if any commands come in while the start command is still executing, they're queued up and held until the start has completed. But I'll do

RE: [PATCH v2] Hard disk S3 resume time optimization

2013-08-09 Thread Brandt, Todd E
I apologize for the text wrapping issue, our mail server is very outlook centric and I didn't know the weird formatting issues would happen until the mail showed up on the mailing list. It won't happen again. I'll also change the formatting back to the way it was originally. I tend to be wary