Re: [patch|rfc] block: fix race between request completion and timeout handling

2013-08-28 Thread Hannes Reinecke
On 08/27/2013 04:28 PM, Jeff Moyer wrote: Hi, We have several reports (against a distro kernel) of panics in blk_requeue_request that look like this: kernel BUG at block/blk-core.c:1045! invalid opcode: [#1] SMP last sysfs file:

Re: [PATCH 02/29] qla2xxx: Add support for ISP8044.

2013-08-28 Thread James Bottomley
On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote: From: Atul Deshmukh atul.deshm...@qlogic.com You seem to have stopped running your stuff through checkpatch: WARNING: please, no spaces at the start of a line #317: FILE: drivers/scsi/qla2xxx/qla_gbl.h:479: +uint8_t *, uint32_t,

Re: [patch|rfc] block: fix race between request completion and timeout handling

2013-08-28 Thread Hannes Reinecke
On 08/28/2013 09:04 AM, Hannes Reinecke wrote: On 08/27/2013 04:28 PM, Jeff Moyer wrote: Hi, We have several reports (against a distro kernel) of panics in blk_requeue_request that look like this: kernel BUG at block/blk-core.c:1045! invalid opcode: [#1] SMP last sysfs file:

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #23 from Hannes Reinecke h...@suse.de --- So the firmware does indeed wedge under high load. Given the issues I've had so far with LSI SATL I'm not surprised. Does the same thing happen when running on a single disk, ie without MD?

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #24 from livea...@live.com --- Hello . I used to have the same issues with MD . yes . I'm using BTRFS , I don't know if BTRFS RAID code was ported from MD , but the issue is the same . I didn't try anything other than BTRFS and MD .

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 Bernd Schubert bernd.schub...@fastmail.fm changed: What|Removed |Added CC|

[PATCH v6 1/4] sg: use rwsem to solve race during exclusive open

2013-08-28 Thread Vaughan Cao
A race condition may happen if two threads are both trying to open the same sg with O_EXCL simultaneously. It's possible that they both find fsds list is empty and get_exclude(sdp) returns 0, then they both call set_exclude() and break out from wait_event_interruptible and resume open. Now use

[PATCH v6 2/4] sg: no need sg_open_exclusive_lock

2013-08-28 Thread Vaughan Cao
Open exclusive check is protected by o_sem, no need sg_open_exclusive_lock. @exclude is used to record which type of rwsem we are holding. Signed-off-by: Vaughan Cao vaughan@oracle.com --- drivers/scsi/sg.c | 34 +- 1 file changed, 5 insertions(+), 29

[PATCH v6 4/4] sg: push file descriptor list locking down to per-device locking

2013-08-28 Thread Vaughan Cao
Push file descriptor list locking down to per-device locking. Let sg_index_lock only protect device lookup. sdp-detached is also set and checked with this lock held. Changes from v4: * Since I use ERR_PTR and friends in sg_add_sfp, this patch should also be updated to resolve conflict in

[PATCH v6 3/4] sg: checking sdp-detached isn't protected when open

2013-08-28 Thread Vaughan Cao
@detached is set under the protection of sg_index_lock. Without getting the lock, new sfp will be added during sg removal and there is no chance for it to be picked out. So check with sg_index_lock held in sg_add_sfp(). Changes from v5: * remove sem_out label. Changes from v4: * use ERR_PTR

[PATCH v6 0/4][SCSI] sg: fix race condition in sg_open

2013-08-28 Thread Vaughan Cao
There is a race when open sg with O_EXCL flag. Also a race may happen between sg_open and sg_remove. Changes from v5: Patches based on v3.11-rc7 and passed sg_tst_excl test. * [1/4] * remove unused variables - res,sdp. * fix insane code dealing with sg_add_sfp. * [2/4] resolve

Re: [PATCH v6 1/4] sg: use rwsem to solve race during exclusive open

2013-08-28 Thread James Bottomley
On Wed, 2013-08-28 at 18:07 +0800, Vaughan Cao wrote: @@ -331,17 +330,20 @@ sg_open(struct inode *inode, struct file *filp) } if ((sfp = sg_add_sfp(sdp, dev))) filp-private_data = sfp; - else { + /* retval is already provably zero at this

Re: [PATCH v3 0/6] scsi: ufs: some fixes and updates

2013-08-28 Thread Subhash Jadavani
Hi Santosh, These patches looks good to me (Have already gave Reviewed-by to all patches). Please check if its fine to be pushed to scsi-next? Regards, Subhash On 8/26/2013 8:10 PM, Seungwon Jeon wrote: This path series contain driver's fixes and updates. Changes in v3: - Rebased with

RE: [PATCH v3 1/6] scsi: ufs: find out sense data over scsi status values

2013-08-28 Thread Yaniv Gardi
Tested-by: Yaniv Gardi yga...@codeaurora.org QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation = -Original Message- = From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- = ow...@vger.kernel.org] On

RE: [PATCH v3 3/6] scsi: ufs: add dme configuration primitives

2013-08-28 Thread Yaniv Gardi
Tested-by: Yaniv Gardi yga...@codeaurora.org QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation = -Original Message- = From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- = ow...@vger.kernel.org] On

RE: [PATCH v3 2/6] scsi: ufs: fix the setting interrupt aggregation counter

2013-08-28 Thread Yaniv Gardi
Tested-by: Yaniv Gardi yga...@codeaurora.org QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation = -Original Message- = From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- = ow...@vger.kernel.org] On

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-28 Thread Bart Van Assche
On 08/28/13 00:17, Jörn Engel wrote: Here is a fun patch in an early state. Essentially I want to trace scsi commands, which has already been done long ago. The problem I have is that I care about all the scsi commands for one particular device - without knowing in advance which device it will

RE: [PATCH v3 5/6] scsi: ufs: add operation for the uic power mode change

2013-08-28 Thread Yaniv Gardi
Tested-by: Yaniv Gardi yga...@codeaurora.org QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation = -Original Message- = From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- = ow...@vger.kernel.org] On

RE: [PATCH v3 4/6] scsi: ufs: add unipro attribute IDs

2013-08-28 Thread Yaniv Gardi
Tested-by: Yaniv Gardi yga...@codeaurora.org QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation = -Original Message- = From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- = ow...@vger.kernel.org] On

Re: [patch|rfc] block: fix race between request completion and timeout handling

2013-08-28 Thread Jeff Moyer
Hannes Reinecke h...@suse.de writes: So, looked into things a bit more. It looks as if you're on the right track, although I doubt your patch will fix the issue for me :-( Thing is, you're right there is a race window between requeuing and softirq triggering, which could well be fixed by

hallo!

2013-08-28 Thread denis
Wir bieten persönliche und geschäftliche Kredite ohne Sicherheiten (nur Identifikation) mit 3 % Zinssatz, von € 20.000 bis € 90,000,000, in 1 Jahr auf 20 Jahre Laufzeit. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #26 from livea...@live.com --- Hi . Thanks for your kind help , Bernd . setting /sys/block/sdX(c~j)/device/queue_depth to 1 unfortuantely didn't solve the issue . I put the following in the end of the boot line :

Re: [PATCH 02/29] qla2xxx: Add support for ISP8044.

2013-08-28 Thread Saurav Kashyap
Hi James, Comments inline.. On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote: From: Atul Deshmukh atul.deshm...@qlogic.com You seem to have stopped running your stuff through checkpatch: SK We did run all the patches through checkpatch before submission, did see the warnings and was

[PATCH -next] ufs: fix source address of the read descriptor

2013-08-28 Thread Akinobu Mita
When the query request with read descriptor opcode is completed, the descriptor is copied from response UPIU to the buffer that the caller has specified. Unfortunately the source address of the descriptor is broken due to the unnecessary address-of operator. Signed-off-by: Akinobu Mita

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-08-28 Thread Jiri Kosina
On Tue, 27 Aug 2013, Jiri Kosina wrote: On Tue, 27 Aug 2013, Jiri Kosina wrote: Commit d5dea7d95 (PCI: msi: Disable msi interrupts when we initialize a pci device) makes MSIs be forcibly disabled at boot time. It turns out that this breaks 3ware controller -- if MSIs are disabled

re: [SCSI] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

2013-08-28 Thread Dan Carpenter
Hello 黃清隆, The patch 17628f3a062b: [SCSI] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 from Aug 26, 2013, leads to the following Smatch warning: drivers/scsi/arcmsr/arcmsr_hba.c:3580 arcmsr_hbaD_get_config() warn: signedness bug returning '(-12)'

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-28 Thread Jörn Engel
On Tue, 27 August 2013 20:34:43 -0400, Steven Rostedt wrote: On Tue, 27 Aug 2013 18:41:47 -0400 Jörn Engel jo...@logfs.org wrote: without knowing in advance which device it will be I have to trace all devices, because I don't know the interesting one ahead of time. And after the

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-28 Thread Jörn Engel
On Tue, 27 August 2013 22:09:19 -0700, Nicholas A. Bellinger wrote: On Tue, 2013-08-27 at 18:17 -0400, Jörn Engel wrote: Here is a fun patch in an early state. Essentially I want to trace scsi commands, which has already been done long ago. The problem I have is that I care about all the

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-08-28 Thread Alexander Gordeev
On Thu, Aug 15, 2013 at 07:19:29PM -0700, Nicholas A. Bellinger wrote: Anyways, before digging further into reserved tags logic, Jens, what are your thoughts for addressing this special queue_depth=1 case for libata + the like..? Hi Jens, Have some comments? -- Regards, Alexander Gordeev

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

2013-08-28 Thread Jörn Engel
On Wed, 28 August 2013 14:45:14 +0200, Bart Van Assche wrote: Isn't this facility something that overlaps with what Wireshark can already do today ? Wireshark can already capture SCSI traces for several transport types (iSCSI, USB, ...). For other transports, e.g. FC, I'd prefer to see

re: [SCSI] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

2013-08-28 Thread James Bottomley
Dan Carpenter dan.carpen...@oracle.com wrote: Hello 黃清隆, The patch 17628f3a062b: [SCSI] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 from Aug 26, 2013, leads to the following Smatch warning: drivers/scsi/arcmsr/arcmsr_hba.c:3580 arcmsr_hbaD_get_config() warn:

Re: [PATCH] PCI: add quirk for 3ware 9650SE controller

2013-08-28 Thread Bjorn Helgaas
[+cc another email addr for Adam from git logs] On Wed, Aug 28, 2013 at 9:46 AM, Jiri Kosina jkos...@suse.cz wrote: On Tue, 27 Aug 2013, Jiri Kosina wrote: On Tue, 27 Aug 2013, Jiri Kosina wrote: Commit d5dea7d95 (PCI: msi: Disable msi interrupts when we initialize a pci device) makes

[PATCH 26/29] qla2xxx: Correctly print out/in mailbox registers.

2013-08-28 Thread Saurav Kashyap
From: Joe Carnuccio joe.carnuc...@qlogic.com At mailbox/buffer debug level, print the correct values of the outgoing and incoming mailbox registers. Signed-off-by: Joe Carnuccio joe.carnuc...@qlogic.com Signed-off-by: Saurav Kashyap saurav.kash...@qlogic.com --- drivers/scsi/qla2xxx/qla_mbx.c |

[PATCH -next] target: remove unused including linux/version.h

2013-08-28 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove including linux/version.h that don't need it. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/target/target_core_xcopy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/target/target_core_xcopy.c

[PATCH v7 3/4] sg: checking sdp-detached isn't protected when open

2013-08-28 Thread Vaughan Cao
@detached is set under the protection of sg_index_lock. Without getting the lock, new sfp will be added during sg removal and there is no chance for it to be picked out. So check with sg_index_lock held in sg_add_sfp(). Changes from v6: * fix via IS_ERR Changes from v5: * remove sem_out label.

[PATCH v7 4/4] sg: push file descriptor list locking down to per-device locking

2013-08-28 Thread Vaughan Cao
Push file descriptor list locking down to per-device locking. Let sg_index_lock only protect device lookup. sdp-detached is also set and checked with this lock held. Changes from v4: * Since I use ERR_PTR and friends in sg_add_sfp, this patch should also be updated to resolve conflict in

[PATCH v7 1/4] sg: use rwsem to solve race during exclusive open

2013-08-28 Thread Vaughan Cao
A race condition may happen if two threads are both trying to open the same sg with O_EXCL simultaneously. It's possible that they both find fsds list is empty and get_exclude(sdp) returns 0, then they both call set_exclude() and break out from wait_event_interruptible and resume open. Now use

[PATCH v7 0/4][SCSI] sg: fix race condition in sg_open

2013-08-28 Thread Vaughan Cao
There is a race when open sg with O_EXCL flag. Also a race may happen between sg_open and sg_remove. Changes from v6: * [1/4] remove double if. * [3/4] fix via IS_ERR Changes from v5: Patches based on v3.11-rc7 and passed sg_tst_excl test. * [1/4] * remove unused variables - res,sdp.

[PATCH v7 2/4] sg: no need sg_open_exclusive_lock

2013-08-28 Thread Vaughan Cao
Open exclusive check is protected by o_sem, no need sg_open_exclusive_lock. @exclude is used to record which type of rwsem we are holding. Signed-off-by: Vaughan Cao vaughan@oracle.com --- drivers/scsi/sg.c | 34 +- 1 file changed, 5 insertions(+), 29

[Bug 49461] scsi/bfa/bfad.c:1037: possible off by one in strncpy ?

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=49461 Jeff Zhou jz.researc...@yahoo.com changed: What|Removed |Added CC|

Re: [PATCH 1/1 v1.1] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284 (Resend renew)

2013-08-28 Thread Joe Perches
On Thu, 2013-08-29 at 12:55 +0800, 黃清隆 wrote: Update the patch code. This patch is whitespace damaged. Please send the email to yourself and make sure it applies correctly before resending to the lists. If necessary, read Documentation/email-clients.txt cheers, Joe -- To unsubscribe from

[Bug 60758] module scsi_wait_scan not found kernel panic on boot

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60758 Jeff Zhou jz.researc...@yahoo.com changed: What|Removed |Added CC|

[Bug 60644] MPT2SAS drops all HDDs when under high I/O

2013-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Comment #27 from livea...@live.com --- Hi again . I set up two disks as two seperate BTRFS volumes (No RAID) , and did some tests . One of the disks failed to complete the process given to it , but it wasn't dropped , and checking the