Re: [PATCH 1/7] Introduce scsi_device_being_removed()

2013-09-01 Thread Christoph Hellwig
Looks good. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/7] Rework scsi_internal_device_unblock()

2013-09-01 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/7] Avoid re-enabling I/O after the transport became offline

2013-09-01 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/7] Disallow changing the device state via sysfs into "deleted"

2013-09-01 Thread Christoph Hellwig
On Tue, Aug 20, 2013 at 02:08:39PM +0200, Bart Van Assche wrote: > Changing the state of a SCSI device via sysfs into "cancel", > "cancel-offline" or "deleted" prevents removal of these devices by > scsi_remove_host(). Hence do not allow this. Looks good modulo a minor style nipick below. Reviewe

Re: [PATCH 5/7] Micro-optimize scsi_request_fn()

2013-09-01 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/7] Micro-optimize scsi_next_command()

2013-09-01 Thread Christoph Hellwig
On Tue, Aug 20, 2013 at 02:10:41PM +0200, Bart Van Assche wrote: > Eliminate a get_device() / put_device() pair from scsi_next_command(). > Both are atomic operations hence removing these slightly improves > performance. The same should also be applied to scsi_requeue_command, while it might not m

[PATCH 8/7] scsi: cleanup scsi_requeue_command

2013-09-01 Thread Christoph Hellwig
Avoid a spurious device get/put cycle by using scsi_put_command and folding scsi_unprep_request into scsi_requeue_command. Signed-off-by: Christoph Hellwig diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index 0fc7970..2c30df0 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scs

Re: Odd behavior of a "SAS-2" backplane with SGPIO commands

2013-09-01 Thread Pasi Kärkkäinen
On Fri, Aug 30, 2013 at 05:38:04PM -0400, Rich wrote: >Apparently, only about 4 months. >P17 firmware is out. >Tested on a card which was demonstrating the incorrect behavior before, of >model 9201-16i. >It does appear to contain the fixes for this problem. This is great news,

Re: [PATCH] scsi disk: Use its own buffer for the vpd request

2013-09-01 Thread Bernd Schubert
On 08/31/2013 09:48 PM, Nix wrote: > On 31 Aug 2013, Greg KH said: >> On Fri, Aug 30, 2013 at 11:01:56AM +0100, Nix wrote: >>> On 1 Aug 2013, Bernd Schubert said: >>> Once I noticed that scsi_get_vpd_page() works fine from other function calls and that it is not 0x89, but already 0x0 that

[PATCH] scsi: Convert uses of compare_ether_addr to ether_addr_equal

2013-09-01 Thread Joe Perches
Preliminary to removing compare_ether_addr altogether: Use the new bool function ether_addr_equal to add some clarity and reduce the likelihood for misuse of compare_ether_addr for sorting. Done via cocci script: $ cat compare_ether_addr.cocci @@ expression a,b; @@ - !compare_ether_addr(a,