Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Hannes Reinecke
On 09/10/2013 03:56 PM, Oliver Neukum wrote: > Hi Hannes, > > you objected to this patch saying there's a possibilty that > HS devices may also need this feature, which would require > a quirk. Does this mean that the patch is acceptable only > with an additional predefined quirk, or do you insist

Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Hannes Reinecke
On 09/11/2013 04:14 PM, Alan Stern wrote: > On Tue, 10 Sep 2013, Oliver Neukum wrote: > >> On Tue, 2013-09-10 at 13:25 -0400, Alan Stern wrote: >>> On Tue, 10 Sep 2013, Oliver Neukum wrote: >>> Hi Hannes, you objected to this patch saying there's a possibilty that HS devices ma

Re: [PATCH 8/9] fnic: Fnic Statistics Collection

2013-09-11 Thread James Bottomley
On Mon, 2013-09-09 at 13:31 -0700, Hiral Patel wrote: > This feature gathers active and cumulative per fnic stats for io, > abort, terminate, reset, vlan discovery path and it also includes > various important stats for debugging issues. It also provided > debugfs and ioctl interface for user to re

[PATCH RESEND] scsi_dh_rdac: Add new IBM 1813 product id to rdac devlist

2013-09-11 Thread Stewart, Sean
Add new IBM product id to the RDAC devlist Signed-off-by: Sean Stewart --- diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c b/drivers/scsi/device_handler/scsi_dh_rdac.c index 69c915a..4b9cf93 100644 --- a/drivers/scsi/device_handler/scsi_dh_rdac.c +++ b/drivers/scsi/device_handler/scsi_dh

[PATCH RESUBMIT 1/1] lpfc: remove unnecessary read of PCI_CAP_ID_EXP

2013-09-11 Thread Jon Mason
The PCIE capability offset is saved during PCI bus walking. It will remove an unnecessary search in the PCI configuration space if this value is referenced instead of reacquiring it. Also, pci_is_pcie is a better way of determining if the device is PCIE or not (as it uses the same saved PCIE capa

[PATCH RESUBMIT 0/1] lpfc: remove unnecessary read of PCI_CAP_ID_EXP

2013-09-11 Thread Jon Mason
This is a resubmission of a patch from ~1 year ago, which was a resubmission of a patch series from ~1 year before that. There was originally some confusion regarding this patch, but it has been acked twice now by the driver maintainer. http://www.spinics.net/lists/linux-scsi/msg53169.html http:/

Re: [PATCH 2/9] fnic: host reset returns nonzero value(errno) on success

2013-09-11 Thread James Bottomley
On Mon, 2013-09-09 at 13:31 -0700, Hiral Patel wrote: > From: Narsimhulu Musini > > Fixed appropriate error codes that returns -1 on failure, and 0 on success This is about as undescriptive as they come. What you mean is that fnic_reset() is used directly by the fc transport callback issue_fc_h

Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Steve Magnani
On Wed, 2013-09-11 at 11:42 -0400, Alan Stern wrote: > On Wed, 11 Sep 2013, Oliver Neukum wrote: > > > > I'll try to get a Windows machine for a trace. > > Can you suggest a tracer for Win7? > > I don't know of any, offhand. Maybe Google can help. > > Alternatively, you could install Windows 7

Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Alan Stern
On Wed, 11 Sep 2013, Oliver Neukum wrote: > On Wed, 2013-09-11 at 10:14 -0400, Alan Stern wrote: > > > There are three possibilities: nothing, your proposed patch, and a new > > Nothing is feasible only if Windows uses READ_CAPACITY_10. It seems clear that your patch isn't feasible either, as i

Re: [PATCH] scsi: esas2r: fix potential format string flaw

2013-09-11 Thread Bradley Grove
On 09/11/2013 12:38 AM, Kees Cook wrote: This makes sure format strings cannot leak into the printk call via the constructed buffer. Signed-off-by: Kees Cook --- Acked-by: Bradley Grove Brad -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message

Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Oliver Neukum
On Wed, 2013-09-11 at 10:14 -0400, Alan Stern wrote: > There are three possibilities: nothing, your proposed patch, and a new Nothing is feasible only if Windows uses READ_CAPACITY_10. > quirk flag. The flag is safest, but also the hardest to maintain. Again the same answer. > > I think we ca

[PATCH v2] hpsa: remove unneeded loop

2013-09-11 Thread Tomas Henzl
From: Tomas Henzl Originally this was first patch in a series, but while the other patches were taken into 'for-next', this one was forgotten. The code below is adapted for the 'for=next' branch. The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_

Re: [PATCH 1/3] scsi: Fix erratic device offline during EH

2013-09-11 Thread Jeremy Linton
On 9/2/2013 6:58 AM, Hannes Reinecke wrote: > +static int scsi_eh_action(struct scsi_cmnd *scmd, int rtn) +{ + static > unsigned char tur_command[6] = {TEST_UNIT_READY, 0, 0, 0, 0, 0}; + + if > (scmd->request->cmd_type != REQ_TYPE_BLOCK_PC) { +struct > scsi_driver > *sdrv = scsi

Re: READ_CAPACITY_16 vs. READ_CAPACITY_10

2013-09-11 Thread Alan Stern
On Tue, 10 Sep 2013, Oliver Neukum wrote: > On Tue, 2013-09-10 at 13:25 -0400, Alan Stern wrote: > > On Tue, 10 Sep 2013, Oliver Neukum wrote: > > > > > Hi Hannes, > > > > > > you objected to this patch saying there's a possibilty that > > > HS devices may also need this feature, which would req

Re: [PATCH 2/3] scsi: improved eh timeout handler

2013-09-11 Thread Ren Mingxin
Hi, Hannes: On 09/02/2013 07:58 PM, Hannes Reinecke wrote: If abort succeeds the command is either retried or terminated, depending on the number of allowed retries. However, 'eh_eflags' records the abort, so if the retry would fail again the command is pushed onto the error handler without tryi

Re: [PATCH] [scsi] enclosure: remove all possible sysfs entries before add device

2013-09-11 Thread Joe Jin
On 09/10/13 20:46, James Bottomley wrote: >> > During our test, multipath used, each LUN has 2 paths. when adding second >> > path enclousure did not check if will adding device's symlink existed or >> > no. > The description doesn't look helpful. The problem, presumably in a > remove/re-add test