Re: [dm-devel] SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-23 Thread Hannes Reinecke
On 09/23/2013 08:18 PM, Ewan Milne wrote: > On Fri, 2013-09-20 at 18:03 -0400, Martin K. Petersen wrote: > ... >> Only a handful of the very latest and greatest devices support RSOC. The >> number of devices that support WRITE SAME is orders of magnitude larger. >> >> Last I checked I had exactly 1

Re: [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()

2013-09-23 Thread Jingoo Han
On Tuesday, September 24, 2013 3:55 AM, James Bottomley wrote: > On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote: > > Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > > (device-core: Ensure drvdata = NULL when no driver is bound), > > the driver core clears the driver data to NULL after

[PATCH] [SCSI] remove unnecessary pci_set_drvdata()

2013-09-23 Thread Jingoo Han
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound), the driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingo

Re: [PATCH] ufs: adjust queue settings to PRDT limitations

2013-09-23 Thread Akinobu Mita
> Ideally there should be comment here to explain the reason for this > limitation. I see comments in commit text but not here in code. > Its not general practice to browse through history to understand the reason > behind this limitations. so it always helps to add comments in code itself. OK,

[PATCH] tcm_fc: Convert to per-cpu command map pre-allocation of ft_cmd

2013-09-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts tcm_fc to use transport_init_session_tags() pre-allocation logic of struct ft_cmd using per-cpu session tag pooling in order to effectively avoid memory allocation / release for each received I/O. It adds percpu_ida_alloc() in ft_recv_cmd() to obtain

Re: [PATCH 00/20] [SCSI] remove unnecessary pci_set_drvdata()

2013-09-23 Thread James Bottomley
On Mon, 2013-09-23 at 09:54 +0900, Jingoo Han wrote: > Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound), > the driver core clears the driver data to NULL after device_release > or on probe failure. Thus, it is not needed to manuall

[PATCH 06/10] hpsa: add MSA 2040 to list of external target devices

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f2ef778..b7f405f 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/

[PATCH 00/10] hpsa: September 2013 driver fixes

2013-09-23 Thread Stephen M. Cameron
The following series contains some fixes for hpsa --- Stephen M. Cameron (10): hpsa: do not attempt to flush the cache on locked up controllers hpsa: add 5 second delay after doorbell reset hpsa: do not discard scsi status on aborted commands hpsa: remove unneeded include

[PATCH 03/10] hpsa: do not discard scsi status on aborted commands

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron We inadvertantly discarded the scsi status for aborted commands. For some commands (e.g. reads from tape drives) these can't be retried, and if we discarded the scsi status, the scsi mid layer couldn't notice anything was wrong and the error was not reported. Signed-off-

[PATCH 02/10] hpsa: add 5 second delay after doorbell reset

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron The hardware guys tell us that after initiating a software reset via the doorbell register we need to wait 5 seconds before attempting to talk to the board *at all*. This means that we cannot watch the board to verify it transitions from "ready" to to "not ready" then ba

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 02:27:39PM -0400, Alan Stern wrote: > On Thu, 19 Sep 2013, Russell King wrote: > > > The correct way for a driver to specify the coherent DMA mask is > > not to directly access the field in the struct device, but to use > > dma_set_coherent_mask(). Only arch and bus code s

[PATCH 04/10] hpsa: remove unneeded include of seq_file.h

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron Signed-off-by: Scott Teel Acked-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3e45090..411aef2 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/

Re: SCSI's heuristics for enabling WRITE SAME still need work [was: dm mpath: disable WRITE SAME if it fails]

2013-09-23 Thread Ewan Milne
On Fri, 2013-09-20 at 18:03 -0400, Martin K. Petersen wrote: ... > Only a handful of the very latest and greatest devices support RSOC. The > number of devices that support WRITE SAME is orders of magnitude larger. > > Last I checked I had exactly 1 out of about 100 devices in my lab that > suppor

[PATCH 01/10] hpsa: do not attempt to flush the cache on locked up controllers

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron There's no point in trying since it can't work, and if you do try, it will just hang the system on shutdown. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 09/10] hpsa: cap CCISS_PASSTHRU at 20 concurrent commands.

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron Cap CCISS_BIG_PASSTHRU as well. If an attempt is made to exceed this, ioctl() will return -1 with errno == EAGAIN. This is to prevent a userland program from exhausting all of pci_alloc_consistent memory. I've only seen this problem when running a special test program

[PATCH 08/10] hpsa: bring logical drives online when format completes

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron Now that the driver is hiding logical drives which are undergoing low level format (e.g. drive erase or rapid parity initialization) from the OS, it should bring those drives online when the operation completes. We poll with test unit ready every so often to determine wh

[PATCH 10/10] hpsa: prevent stalled i/o

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron If a fifo full condition is encountered, i/o requests will stack up in the h->reqQ queue. The only thing which empties this queue is start_io, which only gets called when new i/o requests come in. If none are forthcoming, i/o in h->reqQ will be stalled. To fix this, whe

[PATCH 07/10] hpsa: hide logical drives with format in progress from linux

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron SCSI mid layer doesn't seem to handle logical drives undergoing format very well. scsi_add_device on such devices seems to result in hitting those devices with a TUR at a rate of 3Hz for awhile, transitioning to hitting them with a READ(10) at a much higher rate indefini

[PATCH 05/10] hpsa: fix memory leak in CCISS_BIG_PASSTHRU ioctl

2013-09-23 Thread Stephen M. Cameron
From: Stephen M. Cameron We were leaking a command buffer if a DMA mapping error was encountered in the CCISS_BIG_PASSTHRU ioctl. Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/hpsa.c b/d

RE: [PATCH] scsi/isci/phy.c: Code tidiness, delete the redundant function call "sci_change_state(&iphy->sm, SCI_PHY_STOPPED)"

2013-09-23 Thread Dorau, Lukasz
On 07/19/2013 Xinghai Yu wrote: > The "sci_phy_link_layer_initialization()" was called only once in > "sci_phy_initialize()" and it is called before a call of > "sci_change_state(&iphy- > >sm, SCI_PHY_STOPPED)". So the same call in the end of > "sci_phy_link_layer_initialization()" is redundant.

RE: [PATCH 14/19] scsi: Change variable type to bool

2013-09-23 Thread Dorau, Lukasz
On Sunday, September 22, 2013 12:28 AM Peter Senna Tschudin wrote: > > The variable success is only assigned the values true and false. > Change its type to bool. > > The simplified semantic patch that find this problem is as > follows (http://coccinelle.lip6.fr/): > > @exists@ > type T; > ide

Re: Use-after-free in ata_qc_issue

2013-09-23 Thread Tejun Heo
Hello, On Sun, Sep 22, 2013 at 02:51:51PM -0700, Dmitry Vyukov wrote: > > Yeah, could be. IIRC, there's still race condition in block / scsi > > timeout handling. Hmmm... > > Is there an open bug for this? Not that I know of. ISTR a couple threads about it. My memory is quite hazy as usual b

[PATCH] scsi disk: Reduce buffer size for vpd request

2013-09-23 Thread Bernd Schubert
From: Bernd Schubert Somehow older areca firmware versions have issues with scsi_get_vpd_page() and a large buffer, the firmware seems to crash and the scsi error-handler will start endless recovery retries. Limiting the buf-size to 64-bytes fixes this issue with older firmware versions (<1.49

Re: [PATCH 37/51] DMA-API: usb: use new dma_coerce_mask_and_coherent()

2013-09-23 Thread Nicolas Ferre
On 20/09/2013 00:02, Russell King : Signed-off-by: Russell King --- drivers/usb/chipidea/ci_hdrc_imx.c |4 +--- drivers/usb/dwc3/dwc3-exynos.c |4 +--- drivers/usb/host/ehci-atmel.c |4 +--- For Atmel driver: Acked-by: Nicolas Ferre [..] diff --git a/drivers/usb/ho

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Nicolas Ferre
On 20/09/2013 00:01, Russell King : The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and bus code should access this member directly. Convert all direct write accesses to using t

Re: [PATCH V7 6/6] scsi: ufs: Improve UFS fatal error handling

2013-09-23 Thread vinayak holikatti
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma wrote: > Error handling in UFS driver is broken and resets the host controller > for fatal errors without re-initialization. Correct the fatal error > handling sequence according to UFS Host Controller Interface (HCI) > v1.1 specification. > > o

Re: [PATCH V7 5/6] scsi: ufs: Fix device and host reset methods

2013-09-23 Thread vinayak holikatti
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma wrote: > As of now SCSI initiated error handling is broken because, > the reset APIs don't try to bring back the device initialized and > ready for further transfers. > > In case of timeouts, the scsi error handler takes care of handling aborts >

Re: [PATCH V7 3/6] scsi: ufs: Fix broken task management command implementation

2013-09-23 Thread vinayak holikatti
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma wrote: > Currently, sending Task Management (TM) command to the card might > be broken in some scenarios as listed below: > > Problem: If there are more than 8 TM commands the implementation > returns error to the caller. > Fix: Wait

Re: [PATCH V7 4/6] scsi: ufs: Fix hardware race conditions while aborting a command

2013-09-23 Thread vinayak holikatti
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma wrote: > There is a possible race condition in the hardware when the abort > command is issued to terminate the ongoing SCSI command as described > below: > > - A bit in the door-bell register is set in the controller for a > new SCSI command.

Re: [PATCH V7 2/6] scsi: ufs: make undeclared functions static

2013-09-23 Thread vinayak holikatti
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma wrote: > Make undeclared functions static and declare exported symbols > to suppress warnings from sparse tool. > > Signed-off-by: Sujit Reddy Thumma > --- > drivers/scsi/ufs/ufshcd.c | 4 ++-- > drivers/scsi/ufs/ufshcd.h | 2 ++ > 2 files chan

Re: [PATCH V7 1/6] scsi: ufs: fix endianness sparse warnings

2013-09-23 Thread vinayak holikatti
On Thu, Sep 19, 2013 at 4:44 PM, Sujit Reddy Thumma wrote: > > Fix many warnings with incorrect endian assumptions > which makes the code unportable to new architectures. > > The UFS specification defines the byte order as big-endian > for UPIU structure and little-endian for the host controller >

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 03:55:33PM +0530, Vinod Koul wrote: > On Fri, Sep 20, 2013 at 12:15:39AM +0100, Russell King wrote: > > register_platform_device_full() can setup the DMA mask provided the > > appropriate member is set in struct platform_device_info. So lets > > make that be the case. This

Re: [alsa-devel] [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Sat, Sep 21, 2013 at 09:00:00PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 20, 2013 at 07:26:27PM +0200, Heiko Stübner wrote: > > Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: > > > The DMA API requires drivers to call the appropriate dma_set_mask() > > > functions

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Vinod Koul
On Fri, Sep 20, 2013 at 12:15:39AM +0100, Russell King wrote: > register_platform_device_full() can setup the DMA mask provided the > appropriate member is set in struct platform_device_info. So lets > make that be the case. This avoids a direct reference to the DMA > masks by this driver. > > S

Re: [alsa-devel] [PATCH 23/51] DMA-API: dma: pl08x: add dma_set_mask_and_coherent() call

2013-09-23 Thread Vinod Koul
On Thu, Sep 19, 2013 at 10:48:01PM +0100, Russell King wrote: > The DMA API requires drivers to call the appropriate dma_set_mask() > functions before doing any DMA mapping. Add this required call to > the AMBA PL08x driver. > > Signed-off-by: Russell King Acked-by: Vinod Koul ~Vinod > --- >

[Bug 60758] module scsi_wait_scan not found kernel panic on boot

2013-09-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60758 --- Comment #37 from zakrzews...@wp.pl --- I forgot to add it. I will try again soon. -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body o

Re: [PATCH] ufs: adjust queue settings to PRDT limitations

2013-09-23 Thread Subhash Jadavani
On 9/21/2013 12:06 PM, Akinobu Mita wrote: The data byte count field of PRDT indicates the length of data block which is a segment of data transfer for SCSI commands. The value of this field shall have Dword granularity and the the maximum of length is 256KB. This adjusts dma pad mask and max s