Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-11 Thread Alexander Gordeev
On Thu, Oct 10, 2013 at 07:17:18PM -0400, Mark Lord wrote: Just to help us all understand the loop issue.. Here's an example of driver code which uses the existing MSI-X interfaces, for a device which can work with either 16, 8, 4, 2, or 1 MSI-X interrupt. This is from a new driver I'm

Re: scsi-mq updated to latest linux-block/new-queue

2013-10-11 Thread Christoph Hellwig
On Thu, Oct 10, 2013 at 09:32:41PM +0200, Alexander Gordeev wrote: I wonder, if blk-mq- prefix should remain?.. This s code seems pretty much generic to me. Seems like nowdays you should just use the percpu-ida allocator directly, Shaohua Li hast just sent patches to switch blk-mq over to it as

Re: scsi-mq updated to latest linux-block/new-queue

2013-10-11 Thread Jens Axboe
On 10/11/2013 06:19 AM, Christoph Hellwig wrote: On Thu, Oct 10, 2013 at 09:32:41PM +0200, Alexander Gordeev wrote: I wonder, if blk-mq- prefix should remain?.. This s code seems pretty much generic to me. Seems like nowdays you should just use the percpu-ida allocator directly, Shaohua Li

[PATCH] target: Pass through I/O topology for block backstores

2013-10-11 Thread Andy Grover
In addition to block size (already implemented), passing through alignment offset, logical-to-phys block exponent, I/O granularity and optimal I/O length will allow initiators to properly handle layout on LUNs with 4K block sizes. Tested with various weird values via scsi_debug module. One thing

Re: [PATCH] target: Pass through I/O topology for block backstores

2013-10-11 Thread Christoph Hellwig
On Fri, Oct 11, 2013 at 10:40:06AM -0700, Andy Grover wrote: In addition to block size (already implemented), passing through alignment offset, logical-to-phys block exponent, I/O granularity and optimal I/O length will allow initiators to properly handle layout on LUNs with 4K block sizes.

Re: [PATCH] target: Pass through I/O topology for block backstores

2013-10-11 Thread Andy Grover
On 10/11/2013 11:03 AM, Christoph Hellwig wrote: On Fri, Oct 11, 2013 at 10:40:06AM -0700, Andy Grover wrote: In addition to block size (already implemented), passing through alignment offset, logical-to-phys block exponent, I/O granularity and optimal I/O length will allow initiators to

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-11 Thread Mark Lord
On 13-10-11 04:41 AM, Alexander Gordeev wrote: On Thu, Oct 10, 2013 at 07:17:18PM -0400, Mark Lord wrote: Just to help us all understand the loop issue.. Here's an example of driver code which uses the existing MSI-X interfaces, for a device which can work with either 16, 8, 4, 2, or 1 MSI-X

Possible locking bug in pm8xxx/pm8001

2013-10-11 Thread Jason Seba
The pm8xxx driver uses a per-adapter spinlock (pm8001_ha-lock) which is usually acquired and released with the irqsave routines. However, some functions which are called with the lock held (mpi_sata_completion, mpi_sata_event, pm8001_chip_sata_req) will temporary release the lock to complete a