Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

2013-11-11 Thread Or Gerlitz
On 12/11/2013 06:34, Nicholas A. Bellinger wrote: Once iscsi_conn_queue_work() is invoked here to start process context execution of iscsi_xmitworker() -> iscsi_data_xmit() code, AFAICT there is no logic in place within iscsi_data_xmit() to honor the last received MaxCmdSN. Or to put it another

Re: [PATCH v2 3/5] ata: Add APM X-Gene SATA driver

2013-11-11 Thread Loc Ho
Hi Arnd/Olof, I looked over the phy code for USB and NET. There isn't such PHY infrastructure for SATA from what I can tell. It seems like I will need to put this all together. I am thinking about porting the USB version over (with changes for SATA) and put it under "./drivers/ata/phy". Any sugges

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

2013-11-11 Thread Nicholas A. Bellinger
On Mon, 2013-11-11 at 20:39 -0600, Michael Christie wrote: > > > On Nov 11, 2013, at 8:32 PM, Michael Christie wrote: > > > > Mike, any idea as to how this might be happening on the initiator > > side..? > >> > >> > >> > >> M, just noticed a bit of very suspicious logic in open

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

2013-11-11 Thread Michael Christie
> On Nov 11, 2013, at 8:32 PM, Michael Christie wrote: > > > >>> On Nov 11, 2013, at 7:31 PM, "Nicholas A. Bellinger" >>> wrote: >>> On Mon, 2013-11-11 at 16:48 -0800, Nicholas A. Bellinger wrote: > On Mon, 2013-11-11 at 16:42 -0800, Nicholas A. Bellinger wrote: > On Mon, 2013

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

2013-11-11 Thread Michael Christie
> On Nov 11, 2013, at 7:31 PM, "Nicholas A. Bellinger" > wrote: > >> On Mon, 2013-11-11 at 16:48 -0800, Nicholas A. Bellinger wrote: >>> On Mon, 2013-11-11 at 16:42 -0800, Nicholas A. Bellinger wrote: On Mon, 2013-11-11 at 13:17 -0800, Nicholas A. Bellinger wrote: Hi Moussa & Co, >>>

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

2013-11-11 Thread Nicholas A. Bellinger
On Mon, 2013-11-11 at 17:31 -0800, Nicholas A. Bellinger wrote: > On Mon, 2013-11-11 at 16:48 -0800, Nicholas A. Bellinger wrote: > > On Mon, 2013-11-11 at 16:42 -0800, Nicholas A. Bellinger wrote: > > > On Mon, 2013-11-11 at 13:17 -0800, Nicholas A. Bellinger wrote: > > > > Hi Moussa & Co, > > > >

Re: [PATCH 1/2] target: Pass through I/O topology for block backstores

2013-11-11 Thread Martin K. Petersen
> "Andy" == Andy Grover writes: Andy> In addition to block size (already implemented), passing through Andy> alignment offset, logical-to-phys block exponent, I/O granularity Andy> and optimal I/O length will allow initiators to properly handle Andy> layout on LUNs with 4K block sizes. Looks

Re: CmdSN greather than MaxCmdSN protocol error in LIO Iser

2013-11-11 Thread Nicholas A. Bellinger
On Mon, 2013-11-11 at 16:48 -0800, Nicholas A. Bellinger wrote: > On Mon, 2013-11-11 at 16:42 -0800, Nicholas A. Bellinger wrote: > > On Mon, 2013-11-11 at 13:17 -0800, Nicholas A. Bellinger wrote: > > > Hi Moussa & Co, > > > > > > On Mon, 2013-11-11 at 19:05 +, Moussa Ba (moussaba) wrote: > >

[RFC PATCH 0/2] wd719x: Introduce Western Digital WD7193/7197/7296 PCI SCSI card driver

2013-11-11 Thread Ondrej Zary
Hello, this is an attempt to provide a new driver for Western Digital WD7193, WD7197 and WD7296 PCI SCSI controllers based on WD33C296A chip. It's based on old and ugly wd719x driver written back in 2.0 days, then hacked to 2.2 and finally to 2.4 kernels. Most of the code is rewritten: from ~410

[RFC PATCH 2/2] wd719x: Introduce Western Digital WD7193/7197/7296 PCI SCSI card driver

2013-11-11 Thread Ondrej Zary
Introduce wd719x, a driver for Western Digital WD7193, WD7197 and WD7296 PCI SCSI controllers based on WD33C296A chip. Tested with WD7193 card. Signed-off-by: Ondrej Zary --- drivers/scsi/Kconfig |8 + drivers/scsi/Makefile |1 + drivers/scsi/wd719x.c | 1008

[RFC PATCH 1/2] eeprom-93cx6: Add (read-only) support for 8-bit mode

2013-11-11 Thread Ondrej Zary
Add read-only support for EEPROMs configured in 8-bit mode (ORG pin connected to GND). This will be used by wd719x driver. Signed-off-by: Ondrej Zary --- drivers/misc/eeprom/eeprom_93cx6.c | 62 +++- include/linux/eeprom_93cx6.h |4 +++ 2 files changed

Re: [PATCH v2 5/5] Documentation: Add documentation for APM X-Gene SATA DTS binding

2013-11-11 Thread Arnd Bergmann
On Monday 11 November 2013, Loc Ho wrote: > Hi Arnd, > > >> --- > >> .../devicetree/bindings/ata/apm-xgene.txt | 84 > >> > > > > Please Cc the devicetree-discuss mailing list for the binding submission. > [Loc Ho] > I did cc on the first version. But this email >

Re: [PATCH v2 5/5] Documentation: Add documentation for APM X-Gene SATA DTS binding

2013-11-11 Thread Loc Ho
Hi Arnd, >> --- >> .../devicetree/bindings/ata/apm-xgene.txt | 84 >> > > Please Cc the devicetree-discuss mailing list for the binding submission. [Loc Ho] I did cc on the first version. But this email 'devicetree-disc...@lists.ozlabs.org' bounced on me. >> +- in

Re: [PATCH/RESEND v2 0/2] SATA disk resume time optimization

2013-11-11 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/11/2013 11:59 AM, Todd E Brandt wrote: > 500ms is actually quite alot when you compare it with android or > iOS, or even with other subsystems like USB. USB is the second > worst offender after SATA disks and it tends to take around 600ms > for m

Re: [PATCH/RESEND v2 0/2] SATA disk resume time optimization

2013-11-11 Thread Todd E Brandt
500ms is actually quite alot when you compare it with android or iOS, or even with other subsystems like USB. USB is the second worst offender after SATA disks and it tends to take around 600ms for most standard systems with an onboard webcam, and with other devices plugged in ever longer. I thi

[PATCH 2/2] target: Core does not need blkdev.h

2013-11-11 Thread Andy Grover
Target core does not depend on the block layer, only backstores that use the block layer do. Signed-off-by: Andy Grover --- drivers/target/target_core_rd.c|1 - drivers/target/target_core_stat.c |1 - drivers/target/target_core_transport.c |1 - 3 files changed, 0 insert

[PATCH 1/2] target: Pass through I/O topology for block backstores

2013-11-11 Thread Andy Grover
In addition to block size (already implemented), passing through alignment offset, logical-to-phys block exponent, I/O granularity and optimal I/O length will allow initiators to properly handle layout on LUNs with 4K block sizes. Tested with various weird values via scsi_debug module. One thing

[PATCH 0/2] target: I/O topology for block backstores

2013-11-11 Thread Andy Grover
Hi Nab, Here's a patch from October, along with a trivial cleanup. hch had concerns about the four function pointers added to struct se_subsystem_api, but was OK with it for now. Please apply -- Andy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a messag

[PATCH V1 3/3] pm80xx: Tasklets synchronization fix.

2013-11-11 Thread Anand
>From c3bcd7c02e1fa487edbab4c1d5182daca066db61 Mon Sep 17 00:00:00 2001 From: Nikith Ganigarakoppal Date: Mon, 11 Nov 2013 15:28:14 +0530 Subject: [PATCH V1 3/3] pm80xx: Tasklets synchronization fix. When multiple vectors are used, the vector variable is over written, resulting in unhandled oper

[PATCH V1 2/3] pm80xx: Resetting the phy state.

2013-11-11 Thread Anand
>From 800d934dd22f3ef5d7f52d900295d371d17004bd Mon Sep 17 00:00:00 2001 From: Nikith Ganigarakoppal Date: Wed, 30 Oct 2013 16:23:47 +0530 Subject: [PATCH V1 2/3] pm80xx: Resetting the phy state. Setting the phy state for hard reset response. After sending hard reset for a device ,phy down event s

[PATCH V1 1/3] pm80xx: Fix for direct attached device.

2013-11-11 Thread Anand
>From cf6a06ddf571464571f826109bb1e5a0667c7751 Mon Sep 17 00:00:00 2001 From: Nikith Ganigarakoppal Date: Wed, 30 Oct 2013 16:13:22 +0530 Subject: [PATCH V1 1/3] pm80xx: Fix for direct attached device. In case of direct attached SATA device delay is not enough. It will give crash for set device s

[PATCH 0/3]: pm8001 driver bug fixes.

2013-11-11 Thread Anand
>From c3bcd7c02e1fa487edbab4c1d5182daca066db61 Mon Sep 17 00:00:00 2001 From: Nikith Ganigarakoppal Date: Mon, 11 Nov 2013 19:41:51 +0530 Subject: [PATCH 0/3]: pm8001 driver bug fixes. Nikith Ganigarakoppal (3): pm80xx: Fix for direct attached device. pm80xx: Resetting the phy state. pm80x

Re: [PATCH 3/6] sd: don't bother spinning up disks on resume

2013-11-11 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/11/2013 8:08 AM, Sergei Shtylyov wrote: >> -unsigned manage_start_stop:1;/* Let HLD (sd) manage >> start/stop */ +unsigned manage_start_stop:2;/* Let HLD >> (sd) manage start/stop */ > > I think you should better document this 2

Re: [PATCH 4/6] libata: resume in the background

2013-11-11 Thread Sergei Shtylyov
On 10-11-2013 1:03, Phillip Susi wrote: Don't block the resume path waiting for the disk to spin up. --- drivers/ata/libata-core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 686c441..128ce0d 1006

Re: [PATCH 3/6] sd: don't bother spinning up disks on resume

2013-11-11 Thread Sergei Shtylyov
Hello. On 10-11-2013 1:03, Phillip Susi wrote: Don't bother forcing disks to spin up on resume, as they will do so automatically when accessed, and forcing them to spin up slows down the resume. Add a second bit to the manage_start_stop flag to restore the previous behavior. --- drivers/scsi

Re: [PATCH 2/6] libata: avoid waking disk to check power

2013-11-11 Thread Sergei Shtylyov
Hello. On 10-11-2013 1:03, Phillip Susi wrote: When a disk is in SLEEP mode it can not respond to commands, including the CHECK POWER command. Instead of waking up the sleeping disk, fake the reply to the CHECK POWER command to indicate the disk is in standby mode. This prevents udisks from w

[PATCH 3/5] scsi: Unlock accesses to eh_deadline

2013-11-11 Thread Hannes Reinecke
32bit accesses are guaranteed to be atomic, so we can remove the spinlock when checking for eh_deadline. We only need to make sure to catch any updates which might happened during the call to time_before(); if so we just recheck with the correct value. Signed-off-by: Hannes Reinecke --- drivers/

[PATCH 1/5] scsi: Fix erratic device offline during EH

2013-11-11 Thread Hannes Reinecke
From: James Bottomley Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8 (Handle disk devices which can not process medium access commands) was introduced to offline any device which cannot process medium access commands. However, commit 3eef6257de48ff84a5d98ca533685df8a3beaeb8 (Reduce error recover

[PATCH 5/5] scsi: Update documentation

2013-11-11 Thread Hannes Reinecke
The documentation has gone out-of-sync, so update it to the current status. Signed-off-by: Hannes Reinecke --- Documentation/scsi/scsi_eh.txt | 69 +++-- Documentation/scsi/scsi_mid_low_api.txt | 9 - drivers/scsi/scsi.c | 6 +-- 3 f

[PATCH 4/5] scsi: Set the minimum valid value of 'eh_deadline' as 0

2013-11-11 Thread Hannes Reinecke
From: Ren Mingxin The former minimum valid value of 'eh_deadline' is 1s, which means the earliest occasion to shorten EH is 1 second later since a command is failed or timed out. But if we want to skip EH steps ASAP, we have to wait until the first EH step is finished. If the duration of the firs

[PATCH 2/5] scsi: improved eh timeout handler

2013-11-11 Thread Hannes Reinecke
When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI command, so there is no need to enter the error handler. This patch implements a new scsi_abort_command() f

[PATCHv11 0/5] New EH command timeout handler

2013-11-11 Thread Hannes Reinecke
Hi all, this patchset implements a new SCSI EH command timeout handler which will be sending command aborts inline without actually engaging SCSI EH. SCSI EH will only be invoked if command abort fails. In addition the commands will be returned directly if the command abort succeeded, cutting dow

Re: [PATCH 11/11] pm80xx : gpio feature support for motherboard controllers

2013-11-11 Thread Jack Wang
Hi James, About this gpio feature, do you think it's OK to implement with IOCTL or we can use exist bsg interface in libsas and add another function call? Regards, Jack On 11/11/2013 06:57 AM, Viswas G wrote: > Hi Jack, > > The GPIO feature we implemented here is for controlling and configuring

Re: [PATCH v2 3/5] ata: Add APM X-Gene SATA driver

2013-11-11 Thread Arnd Bergmann
On Sunday 10 November 2013, Olof Johansson wrote: > > > diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile > > index 46518c6..022f9d1 100644 > > --- a/drivers/ata/Makefile > > +++ b/drivers/ata/Makefile > > @@ -11,6 +11,8 @@ obj-$(CONFIG_SATA_SIL24) += sata_sil24.o > > obj-$(CONFIG_SATA