LSF/MM 2014 Call For Proposals

2013-12-20 Thread Mel Gorman
The annual Linux Storage, Filesystem and Memory Management Summit for 2014 will be held on March 24th and 25th before the Linux Foundation Collaboration summit at The Meritage Resort, Napa Valley, CA. http://events.linuxfoundation.org/events/linux-storage-filesystem-and-mm-summit

Re: [PATCH 0/2] pm80xx: Fix ATTO pm8001 based HBA support

2013-12-20 Thread Jack Wang
On 12/19/2013 04:50 PM, Bradley Grove wrote: Addresses issues that we uncovered during testing with our HBAs. For the most part, we just enabled code that was already being used for other vendor's HBAs. Bradley Grove (2): pm80xx: Read saved WWN from NVMD for ATTO pm8001 based HBAs.

[PATCH 00/16] scsi_dh_alua updates

2013-12-20 Thread Hannes Reinecke
Hi James, here's an update for the ALUA device handler I've been hoarding for quite some time. The major bit here is the asynchronous RTPG handling. With the original design we would treat every LUN independently, despite the fact that several LUNs might in fact belong to the same target port

[PATCH 06/16] scsi_dh_alua: use local buffer for VPD inquiry

2013-12-20 Thread Hannes Reinecke
VPD inquiry need to be done only once, so we can be using a local buffer here. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 45 ++ 1 file changed, 27 insertions(+), 18 deletions(-) diff --git

[PATCH 07/16] scsi_dh_alua: Use separate alua_port_group structure

2013-12-20 Thread Hannes Reinecke
The port group needs to be a separate structure as several LUNs might belong to the same group. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 220 ++--- 1 file changed, 139 insertions(+), 81 deletions(-) diff --git

[PATCH 02/16] scsi_dh_alua: use flag for RTPG extended header

2013-12-20 Thread Hannes Reinecke
We should be using a flag when RTPG extended header is not supported, that saves us sending RTPG twice for older arrays. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH 08/16] scsi_dh_alua: parse target device id

2013-12-20 Thread Hannes Reinecke
VPD descriptor association 0x2 in VPD page 0x83 identification descrioptors can be used to identify the array / target device. Some tricks need to be taken for EMC and HP, which put the array identification into the standard inquiry. Signed-off-by: Hannes Reinecke h...@suse.de ---

[PATCH 13/16] scsi_dh_alua: Clarify logging message

2013-12-20 Thread Hannes Reinecke
We should be diffentiating between an invalid TPGS setting and unsupported. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c

[PATCH 14/16] scsi_dh: invoke callback if -activate is not present

2013-12-20 Thread Hannes Reinecke
When -activate isn't present we still need to invoke the callbacks, otherwise the system might stall. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/device_handler/scsi_dh.c

[PATCH 04/16] scsi_dh_alua: Make stpg synchronous

2013-12-20 Thread Hannes Reinecke
We should be issuing STPG synchronously as we need to evaluate the return code on failure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 192 + 1 file changed, 89 insertions(+), 103 deletions(-) diff --git

[PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG

2013-12-20 Thread Hannes Reinecke
The current ALUA device_handler has two drawbacks: - We're sending a 'SET TARGET PORT GROUP' command to every LUN, disregarding the fact that several LUNs might be in a port group and will be automatically switched whenever _any_ LUN within that port group receives the command. - Whenever a

[PATCH 10/16] scsi_dh_alua: Do not attach to management devices

2013-12-20 Thread Hannes Reinecke
Management devices should be ignored when detecting ALUA capabilites. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c

[PATCH 11/16] scsi_dh_alua: multipath failover fails with error 15

2013-12-20 Thread Hannes Reinecke
When a path is already optimized multipath failover will fail with the message Could not failover device X:Y: Handler scsi_dh_alua Error 15 Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[PATCH 03/16] scsi_dh_alua: Pass buffer as function argument

2013-12-20 Thread Hannes Reinecke
Pass in the buffer as a function argument for submit_vpd() and submit_rtpg(). Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 44 -- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git

[PATCH 12/16] scsi_dh: return individual errors in scsi_dh_activate()

2013-12-20 Thread Hannes Reinecke
When calling scsi_dh_activate() we should be returning individual errors and not lumping all into one. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git

[PATCH 05/16] scsi_dh_alua: put sense buffer on stack

2013-12-20 Thread Hannes Reinecke
There is no need to have the sense buffer as part of the per-device structure, we can put the sense buffer on the stack. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 09/16] scsi_dh_alua: simplify sense code handling

2013-12-20 Thread Hannes Reinecke
Most sense code is already handled in the generic code, so we shouldn't be adding special cases here. However, when doing so we need to check for unit attention whenever we're sending an internal command. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/device_handler/scsi_dh_alua.c

Re: [PATCH 00/10] scsi: avoid linebreaks in syslog output

2013-12-20 Thread Tomas Henzl
Hi Hannes, James, I'm wondering what happened to this patch-set? I think it could make parsing of the output for userspace programs much easier. Are there some problems still to solve or is this just forgotten? Thanks, Tomas On 10/12/2012 10:33 AM, Hannes Reinecke wrote: This patchset updates

Re: [PATCH 00/10] scsi: avoid linebreaks in syslog output

2013-12-20 Thread Hannes Reinecke
On 12/20/2013 02:25 PM, Tomas Henzl wrote: Hi Hannes, James, I'm wondering what happened to this patch-set? I think it could make parsing of the output for userspace programs much easier. Are there some problems still to solve or is this just forgotten? Oh, no. Quite the contrary. As James

Re: [PATCH 00/10] scsi: avoid linebreaks in syslog output

2013-12-20 Thread Tomas Henzl
On 12/20/2013 02:31 PM, Hannes Reinecke wrote: On 12/20/2013 02:25 PM, Tomas Henzl wrote: Hi Hannes, James, I'm wondering what happened to this patch-set? I think it could make parsing of the output for userspace programs much easier. Are there some problems still to solve or is this just

[LSF/MM TOPIC] [ATTEND] scsi_eh updates

2013-12-20 Thread Hannes Reinecke
Hi all, (before leaving for holiday ...) I'd like to attend LSF 2014. During that I'd like to discuss the current status of the SCSI EH and the future planned updates. As discussed during last year's LSF the SCSI error handler should be updated to handle modern SCSI transports better. While

[PATCH 0/6] iscsi changes for scsi-misc

2013-12-20 Thread michaelc
The following patches are some features and fixes for scsi-misc. James, if you were going to merge the libiscsi locking changes here http://www.spinics.net/lists/linux-scsi/msg69903.html do not bother. The qlogic patches that were just merged had a conflict. The patches in the following emails

[PATCH 2/6] SCSI/libiscsi: Reduce locking contention in fast path

2013-12-20 Thread michaelc
From: Shlomo Pongratz shlo...@mellanox.com Replace the session lock with two locks, a forward lock and a backwards lock named frwd_lock and back_lock respectively. The forward lock protects resources that change while sending a request to the target, such as cmdsn, queued_cmdsn, and allocating

[PATCH 1/6] SCSI/libiscsi: Restructure iscsi_tcp r2t response logic

2013-12-20 Thread michaelc
From: Shlomo Pongratz shlo...@mellanox.com Restructure the iscsi_tcp_r2t_rsp routine in order to avoid allocating r2t from r2tpool.queue and returning it back in case the parameters rhdr-data_length and or rhdr-data_offset prohibit the requing. Since the values of these parameters are known

[PATCH 6/6] iscsi_tcp: check for valid session before accessing

2013-12-20 Thread michaelc
From: Mike Christie micha...@cs.wisc.edu Check that the session is setup before accessing its connection. This fixes a oops where userspace tries to get the ip address before the session is bound to a host. Signed-off-by: Mike Christie micha...@cs.wisc.edu --- drivers/scsi/iscsi_tcp.c |3

[PATCH 3/6] SCSI/libiscsi: Remove unneeded code

2013-12-20 Thread michaelc
From: Shlomo Pongratz shlo...@mellanox.com We never will have a closed window and something on one of those lists. Signed-off-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Shlomo Pongratz shlo...@mellanox.com --- drivers/scsi/libiscsi.c | 12 1 files changed, 0

[PATCH 4/6] be2iscsi: fix lun test in device reset callout

2013-12-20 Thread michaelc
From: Mike Christie micha...@cs.wisc.edu We want to be checking the scsi_cmnd's lun against the possible tasks in the driver. Current check tests task against itself which was useless. Signed-off-by: Mike Christie micha...@cs.wisc.edu --- drivers/scsi/be2iscsi/be_main.c |2 +- 1 files

[PATCH 5/6] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2013-12-20 Thread michaelc
From: Ethan Zhao ethan.ker...@gmail.com Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Signed-off-by: Ethan Zhao ethan.ker...@gmail.com Signed-off-by: Mike Christie micha...@cs.wisc.edu ---

Re: [PATCH 2/2] target_core_spc: bounds check for spc_emulate_inquiry()

2013-12-20 Thread Paolo Bonzini
Il 20/12/2013 07:47, Hannes Reinecke ha scritto: How about changing the local buffer to heap memory instead, and bumping SE_INQUIRY_BUF to 1024 bytes..? Ok. But then we should have a quick check at the start if (cmd-data_length SE_INQUIRY_BUF) len = cmd-data_length else len =

[PATCH] drivers: target: target_core_mod: use div64_u64_rem() instead of operator '%' for u64

2013-12-20 Thread Chen Gang
In kernel, need use div64_u64_rem() instead of operator '%' for u64, or can not pass compiling (with allmodconfig under metag): MODPOST 2909 modules ERROR: __umoddi3 [drivers/target/target_core_mod.ko] undefined! Also need u64 type cast for u32 variable multiply u32 variable, or will cause