Re: [PATCH v2 0/9] Phase out pci_enable_msi_block()

2014-01-17 Thread Alexander Gordeev
On Fri, Jan 17, 2014 at 02:00:32PM -0700, Bjorn Helgaas wrote: > > As the release is supposedly this weekend, do you prefer > > the patches to go to your tree or to individual trees after > > the release? > > I'd be happy to merge them, except for the fact that they probably > wouldn't have any ti

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 7:18 PM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > On 01/17/2014 05:17 PM, Dan Williams wrote: >> Well, "at all" is overstating it. The system was idle and now >> it's being woken up to do some work. Inactivity timers are >> invalidated a

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/17/2014 08:41 PM, Alan Stern wrote: > The intention is that this will help on systems with more than one > disk drive. The one containing the core OS files and the journal > will certainly spin up right away, but the others may not. I am hop

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/17/2014 08:24 PM, Todd E Brandt wrote: > 10 seconds?! The only possible way that could happen is if the test > unit ready SCSI command actually triggered an ata port wakeup; at > which point you've already done the one thing you were trying not

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/17/2014 05:17 PM, Dan Williams wrote: > Well, "at all" is overstating it. The system was idle and now > it's being woken up to do some work. Inactivity timers are > invalidated and now the decision becomes minimize access latency, > or lazily

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Alan Stern
On Fri, 17 Jan 2014, Dan Williams wrote: > > The intention is that this will help on systems with more than one > > disk drive. The one containing the core OS files and the journal will > > certainly spin up right away, but the others may not. > > > > To tell the truth, I'm not sure how useful th

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 5:41 PM, Alan Stern wrote: > On Fri, 17 Jan 2014, Tejun Heo wrote: > >> On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote: >> > You will have to argue this point with Phillip. >> > >> > If necessary, we could add a sysfs attribute to force a spin-up during >> > sys

Re: [PATCH v4 1/2] asynchronous ata port resume

2014-01-17 Thread Dan Williams
On Wed, Jan 15, 2014 at 8:38 PM, Todd E Brandt wrote: > On resume, the ATA port driver currently waits until the AHCI controller > finishes executing the port wakeup command. This patch changes the > ata_port_resume callback to issue the wakeup and then return immediately, > thus allowing the next

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Alan Stern
On Fri, 17 Jan 2014, Tejun Heo wrote: > On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote: > > You will have to argue this point with Phillip. > > > > If necessary, we could add a sysfs attribute to force a spin-up during > > system resume. Or you could disable runtime PM for the disk,

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Todd E Brandt
On Fri, Jan 17, 2014 at 03:24:33PM -0500, Tejun Heo wrote: > On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote: > > You will have to argue this point with Phillip. > > > > If necessary, we could add a sysfs attribute to force a spin-up during > > system resume. Or you could disable runti

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Todd E Brandt
On Fri, Jan 17, 2014 at 09:57:47AM -0500, Alan Stern wrote: > On Thu, 16 Jan 2014, Todd E Brandt wrote: > > > On Thu, Jan 16, 2014 at 03:05:40PM -0500, Alan Stern wrote: > > > On Thu, 16 Jan 2014, Todd E Brandt wrote: > > > > > > > > Does this plan sound reasonable to everyone? Are there importa

Re: [GIT PULL] target fixes for v3.13

2014-01-17 Thread Linus Torvalds
On Thu, Jan 16, 2014 at 4:09 PM, Nicholas A. Bellinger wrote: > > This change allows the percpu_ida tag allocator to optionally use > interruptible sleep that iscsi-target expects, while still leaving the > functionality + interface for existing percpu_ida consumers unchanged. I'm not pulling thi

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 12:49 PM, Phillip Susi wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 1/17/2014 2:31 PM, Dan Williams wrote: >> Once dpm_resume of the disk is asynchronous, is there much >> incremental gain by further deferring spin up? The drawback of >> doing on-demand

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-17 Thread Martin K. Petersen
> "nab" == Nicholas A Bellinger writes: >> That breaks partial completion, though. I'll take a look at Kent's >> changes... nab> Ping..? Any updates on a proper bugfix for this..? I did put your patch in my queue and have been working on a fix for the partial completion case. The latter re

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Alexei Starovoitov
On Fri, Jan 17, 2014 at 1:02 PM, Markus Trippelsdorf wrote: > On 2014.01.17 at 11:58 -0800, Alexei Starovoitov wrote: >> On Fri, Jan 17, 2014 at 9:58 AM, Alexei Starovoitov >> wrote: >> > On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz >> > wrote: >> >> Hi >> >> >> >> My story is very simply...

Re: XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2014-01-17 Thread Peter PalĂșch
Gentlemen, First of all, thank you very much for looking into this issue. Alan, for the sake of keeping the thread tidy in archives, I am not going to change the $SUBJECT of this e-mail but I wholeheartedly agree that this is not an xHCI issue. Mea culpa; I did not know that at the time I fir

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Markus Trippelsdorf
On 2014.01.17 at 11:58 -0800, Alexei Starovoitov wrote: > On Fri, Jan 17, 2014 at 9:58 AM, Alexei Starovoitov > wrote: > > On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz > > wrote: > >> Hi > >> > >> My story is very simply... > >> I applied the following patch: > >> > >> diff --git a/drivers/scs

Re: [PATCH v2 0/9] Phase out pci_enable_msi_block()

2014-01-17 Thread Bjorn Helgaas
On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev wrote: > This series is against "next" branch in Bjorn's repo: > git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > > Changes from v1 to v2: > - added a regression fix "ahci: Fix broken fallback to single > MSI mode" as patch 1/

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/17/2014 3:24 PM, Tejun Heo wrote: > Isn't immediate spin-up trivial to implement from anywhere? I'm > not sure whether we'll end up defaulting to the lazy behavior or > not but if we do requiring userland to echo something to sysfs to > configure

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Phillip Susi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/17/2014 2:31 PM, Dan Williams wrote: > Once dpm_resume of the disk is asynchronous, is there much > incremental gain by further deferring spin up? The drawback of > doing on-demand resume of the disk is that you incur the full > resume latency ri

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Andi Kleen
Alexei Starovoitov writes: > > disable Value Range Propagation pass: > -fdisable-tree-vrp1 -fdisable-tree-vrp2 > > and complete unroll pass: > -fdisable-tree-cunrolli Can you file a gcc bug with test case? -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this li

Re: XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2014-01-17 Thread Douglas Gilbert
On 14-01-17 02:35 AM, Hannes Reinecke wrote: On 01/16/2014 09:48 PM, Alan Stern wrote: It's now clear that this is _not_ an XHCI issue, contrary to what $SUBJECT says. On Thu, 16 Jan 2014, Peter PalĂșch wrote: Alan, I am attaching the usbmon trace after the drive has been plugged into the USB

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Tejun Heo
On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote: > You will have to argue this point with Phillip. > > If necessary, we could add a sysfs attribute to force a spin-up during > system resume. Or you could disable runtime PM for the disk, but that > has its own disadvantages. Isn't imme

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Alan Stern
On Fri, 17 Jan 2014, Dan Williams wrote: > Once dpm_resume of the disk is asynchronous, is there much incremental > gain by further deferring spin up? The drawback of doing on-demand > resume of the disk is that you incur the full resume latency right > when you need the data. System resume is a

[PATCH 1/1] scsi: hpsa resubmit all PCI IDs

2014-01-17 Thread Mike Miller
From: Mike Miller This patch has every ID we have in our svn repository. Some controllers were cancelled, others added, now the cancelled ones are back. This patch made against linux-3.13.0-rc8. Now the tables are in sync with one another. Thanks to Tomas Henzl for pointing out the earlier proble

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Alexei Starovoitov
On Fri, Jan 17, 2014 at 9:58 AM, Alexei Starovoitov wrote: > On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz wrote: >> Hi >> >> My story is very simply... >> I applied the following patch: >> >> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c >> --- a/drivers/scsi/isci/init.c >> +

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 6:57 AM, Alan Stern wrote: > On Thu, 16 Jan 2014, Todd E Brandt wrote: >> My patch makes ata port and scsi disk resume 'non-blocking' (asynchronous >> with respect to system resume). Which means once they're called the power >> manager pays no more attention to them and wil

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Tejun Heo
Hello, James. On Fri, Jan 17, 2014 at 10:39:37AM -0800, James Bottomley wrote: > The specific worry is the writeback cache. If the flush fails and we > power down with dirty blocks in the cache, those blocks are lost but the > filesystem still thinks they're committed. I think as long as you're

Re: Disk spin-up optimization during system resume

2014-01-17 Thread James Bottomley
On Fri, 2014-01-17 at 05:21 -0500, Tejun Heo wrote: > Hello, > > On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote: > > The START-STOP may result in an error. What do you do in that case? > > At least for libata, worrying about suspend/resume failures don't make > whole lot of sense.

Re: [PATCH 0/24] qla4xxx: 5.04.00-k4: Updates for scsi "misc" branch

2014-01-17 Thread Mike Christie
On 12/16/2013 05:49 AM, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > James, > > Please apply the following patches to the scsi tree at your earliest > convenience. > These patches are on top of other qla4xxx patch posted on list here: > http://marc.info/?l=linux-scsi&m=13851180

Re: [PATCH V1 16/24] qla4xxx: Fix failure of mbox 0x31

2014-01-17 Thread Mike Christie
On 01/17/2014 03:43 AM, vikas.chaudh...@qlogic.com wrote: > From: Vikas Chaudhary > > Issue: > While unloading driver MBOX 0x31 fail as DDB logout (MBOX 0x56) > operation is not completed. > > Fix: > Wait for DDB Logout completion before MBOX 0x31 > > Signed-off-by: Vikas Chaudhary > --- > dr

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Alan Stern
On Fri, 17 Jan 2014, Tejun Heo wrote: > Hello, > > On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote: > > The START-STOP may result in an error. What do you do in that case? > > At least for libata, worrying about suspend/resume failures don't make > whole lot of sense. If suspend f

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Alexei Starovoitov
On Fri, Jan 17, 2014 at 5:37 AM, Dorau, Lukasz wrote: > Hi > > My story is very simply... > I applied the following patch: > > diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c > --- a/drivers/scsi/isci/init.c > +++ b/drivers/scsi/isci/init.c > @@ -698,8 +698,11 @@ static int isci_p

[LSF/MM TOPIC] [ATTEND] new generation copy offload (ODX)

2014-01-17 Thread Douglas Gilbert
Hannes Reinecke and I would like to attend LSF and present a talk on the new generation copy offload (a.k.a. ODX). Most discussions about copy offload at the storage level are based on T10's 15 year old xcopy(LID1), specifically its disk->disk copy. This year T10 hopes to standardize a new genera

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 5:40 PM Sebastian Riemer wrote: > On 17.01.2014 14:55, Dorau, Lukasz wrote: > > > > Some additional information: > > > > The loop 'for' in macro ' for_each_isci_host ' defined as > (drivers/scsi/isci/host.h:313): > > > > #define for_each_isci_host(id, ihost, pdev) \ >

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Sebastian Riemer
On 17.01.2014 14:55, Dorau, Lukasz wrote: > On Friday, January 17, 2014 2:37 PM Dorau, Lukasz > wrote: >> >> Hi >> >> My story is very simply... >> I applied the following patch: >> >> diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c >> --- a/drivers/scsi/isci/init.c >> +++ b/driv

[PATCH v2 0/9] Phase out pci_enable_msi_block()

2014-01-17 Thread Alexander Gordeev
This series is against "next" branch in Bjorn's repo: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git Changes from v1 to v2: - added a regression fix "ahci: Fix broken fallback to single MSI mode" as patch 1/9; - the series is reordered to move the regression fix in front;

Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Hannes Reinecke
On 01/17/2014 04:17 PM, Miller, Mike (OS Dev) wrote: > > >> -Original Message- >> From: Tomas Henzl [mailto:the...@redhat.com] >> Sent: Friday, January 17, 2014 9:14 AM >> To: Miller, Mike (OS Dev); Andrew Morton; James E. J. Bottomley >> Cc: LKML; LKML-scsi; h...@suse.de; Stephen M. Came

RE: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Friday, January 17, 2014 9:31 AM > To: Miller, Mike (OS Dev) > Cc: Tomas Henzl; Andrew Morton; James E. J. Bottomley; LKML; LKML-scsi; > Stephen M. Cameron > Subject: Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's th

[PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range()

2014-01-17 Thread Alexander Gordeev
As result deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() and pci_enable_msix_range() interfaces. Signed-off-by: Alexander Gordeev --- drivers/scsi/ipr.c |

[PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix()

2014-01-17 Thread Alexander Gordeev
There is no need to call pci_disable_msi() or pci_disable_msix() in case the call to pci_enable_msi() or pci_enable_msix() failed. Signed-off-by: Alexander Gordeev --- drivers/scsi/ipr.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/ipr.c b/drivers/

Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Tomas Henzl
On 01/17/2014 04:31 PM, Hannes Reinecke wrote: > On 01/17/2014 04:17 PM, Miller, Mike (OS Dev) wrote: >> >>> -Original Message- >>> From: Tomas Henzl [mailto:the...@redhat.com] >>> Sent: Friday, January 17, 2014 9:14 AM >>> To: Miller, Mike (OS Dev); Andrew Morton; James E. J. Bottomley >>>

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Steve Magnani
On 01/17/2014 08:55 AM, Dorau, Lukasz wrote: On Friday, January 17, 2014 2:58 PM Richard Weinberger wrote: Can you reproduce this using a standalone test? I.e: #include int main() { assert(2 < 2 != 1); return 0; } No, I can't of course. The test might need to be more

RE: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Miller, Mike (OS Dev)
> -Original Message- > From: Tomas Henzl [mailto:the...@redhat.com] > Sent: Friday, January 17, 2014 9:14 AM > To: Miller, Mike (OS Dev); Andrew Morton; James E. J. Bottomley > Cc: LKML; LKML-scsi; h...@suse.de; Stephen M. Cameron > Subject: Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's th

Re: [PATCH 1/1] scsi: hpsa, add all PCI ID's that HP has in svn

2014-01-17 Thread Tomas Henzl
On 01/16/2014 08:51 PM, Mike Miller wrote: > From: Mike Miller > > This patch has every ID we have in our svn repository. Some controllers were > cancelled, others added, now the cancelled ones are back. Apparently the > debate rages on about which controllers are cancelled, which are not, > whate

Re: [PATCH] scsi_error: disable eh_deadline if no host_reset_handler is set

2014-01-17 Thread Hannes Reinecke
On 01/07/2014 02:33 PM, Ewan Milne wrote: > On Thu, 2013-12-12 at 12:08 +0100, Hannes Reinecke wrote: >> When the host template doesn't declare an eh_host_reset_handler >> the eh_deadline mechanism is pointless and will set the >> device to offline. So disable eh_deadline if no >> eh_host_reset_han

[PATCH] scsi_error: disable eh_deadline if no host_reset_handler is set

2014-01-17 Thread Hannes Reinecke
When the host template doesn't declare an eh_host_reset_handler the eh_deadline mechanism is pointless and will set the device to offline. So disable eh_deadline if no eh_host_reset_handler is present. Cc: Ewan Milne Signed-off-by: Hannes Reinecke --- drivers/scsi/hosts.c | 2 +- drivers/s

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Alan Stern
On Thu, 16 Jan 2014, Todd E Brandt wrote: > On Thu, Jan 16, 2014 at 03:05:40PM -0500, Alan Stern wrote: > > On Thu, 16 Jan 2014, Todd E Brandt wrote: > > > > > > Does this plan sound reasonable to everyone? Are there important > > > > aspects I haven't considered (such as interactions between th

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 2:58 PM Richard Weinberger wrote: > > Can you reproduce this using a standalone test? > I.e: > #include > > int main() > { > assert(2 < 2 != 1); > > return 0; > } > No, I can't of course. Lukasz -- To unsubscribe from this list: send the line "u

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE]

2014-01-17 Thread David Laight
From: walt > Oy, Sarah! ;) I put the ASMedia adapter in my older amd64 machine, and, well, > the stupid thing Just Works(TM) with kernel 3.12.7! (Yes, with the same disk > docking station, too.) > > I can't believe the adapter works perfectly in a different computer. Have you > seen this kind o

Re: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Richard Weinberger
On Fri, Jan 17, 2014 at 2:37 PM, Dorau, Lukasz wrote: > Hi > > My story is very simply... > I applied the following patch: > > diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c > --- a/drivers/scsi/isci/init.c > +++ b/drivers/scsi/isci/init.c > @@ -698,8 +698,11 @@ static int isci_p

RE: Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
On Friday, January 17, 2014 2:37 PM Dorau, Lukasz wrote: > > Hi > > My story is very simply... > I applied the following patch: > > diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c > --- a/drivers/scsi/isci/init.c > +++ b/drivers/scsi/isci/init.c > @@ -698,8 +698,11 @@ static i

Why is (2 < 2) true? Is it a gcc bug?

2014-01-17 Thread Dorau, Lukasz
Hi My story is very simply... I applied the following patch: diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -698,8 +698,11 @@ static int isci_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)

Re: [PATCH 16/24] qla4xxx: Fix failure of mbox 0x31

2014-01-17 Thread Vikas Chaudhary
On 17/01/14 2:00 PM, "Mike Christie" wrote: > >> +static void qla4xxx_destroy_ddb(struct scsi_qla_host *ha, >> +struct ddb_entry *ddb_entry) >> +{ >> +struct dev_db_entry *fw_ddb_entry = NULL; >> +dma_addr_t fw_ddb_entry_dma; >> +unsigned long wtime; >> +uint32_t ddb

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Tejun Heo
Hello, On Fri, Jan 17, 2014 at 11:16:49AM +0100, Oliver Neukum wrote: > The START-STOP may result in an error. What do you do in that case? At least for libata, worrying about suspend/resume failures don't make whole lot of sense. If suspend failed, just proceed with suspend. If the device can'

[PATCH V1 16/24] qla4xxx: Fix failure of mbox 0x31

2014-01-17 Thread vikas.chaudhary
From: Vikas Chaudhary Issue: While unloading driver MBOX 0x31 fail as DDB logout (MBOX 0x56) operation is not completed. Fix: Wait for DDB Logout completion before MBOX 0x31 Signed-off-by: Vikas Chaudhary --- drivers/scsi/qla4xxx/ql4_os.c | 56 --- 1 fi

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Oliver Neukum
On Thu, 2014-01-16 at 11:59 -0500, Alan Stern wrote: > Since the START-STOP and TEST UNIT READY (or REQUEST SENSE or > whatever) > commands are likely to take a long time, they should all be carried > out > asynchronously with respect to the resume procedure. I don't know > what > the best way i

Re: [PATCH 06/16] scsi_dh_alua: use local buffer for VPD inquiry

2014-01-17 Thread Hannes Reinecke
On 01/17/2014 10:04 AM, Mike Christie wrote: > On 12/20/2013 06:13 AM, Hannes Reinecke wrote: >> VPD inquiry need to be done only once, so we can be using >> a local buffer here. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/scsi/device_handler/scsi_dh_alua.c | 45 >> ++-

Re: [PATCH 06/16] scsi_dh_alua: use local buffer for VPD inquiry

2014-01-17 Thread Mike Christie
On 12/20/2013 06:13 AM, Hannes Reinecke wrote: > VPD inquiry need to be done only once, so we can be using > a local buffer here. > > Signed-off-by: Hannes Reinecke > --- > drivers/scsi/device_handler/scsi_dh_alua.c | 45 > ++ > 1 file changed, 27 insertions(+), 18 d

Re: [PATCH 5/7] be2iscsi: Fix doorbell format for EQ/CQ/RQ s per SLI spec.

2014-01-17 Thread Mike Christie
On 01/12/2014 06:42 PM, Jayamohan Kallickal wrote: > diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c > index b14949a..4e1074a 100644 > --- a/drivers/scsi/be2iscsi/be_cmds.c > +++ b/drivers/scsi/be2iscsi/be_cmds.c > @@ -436,10 +436,20 @@ static void beiscsi_cq_notify(

Re: [PATCH 4/7] be2iscsi : Fix statistics update in the driver.

2014-01-17 Thread Mike Christie
On 01/12/2014 06:42 PM, Jayamohan Kallickal wrote: > > diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h > index 0076119..d21ad9e 100644 > --- a/drivers/scsi/be2iscsi/be_main.h > +++ b/drivers/scsi/be2iscsi/be_main.h > @@ -449,6 +449,25 @@ struct beiscsi_conn { >

Re: [PATCH 16/24] qla4xxx: Fix failure of mbox 0x31

2014-01-17 Thread Mike Christie
> +static void qla4xxx_destroy_ddb(struct scsi_qla_host *ha, > + struct ddb_entry *ddb_entry) > +{ > + struct dev_db_entry *fw_ddb_entry = NULL; > + dma_addr_t fw_ddb_entry_dma; > + unsigned long wtime; > + uint32_t ddb_state; > + int options; > + int status; >

Re: [PATCH 2/6] SCSI/libiscsi: Reduce locking contention in fast path

2014-01-17 Thread Mike Christie
On 12/20/2013 12:53 PM, micha...@cs.wisc.edu wrote: > From: Shlomo Pongratz > > Replace the session lock with two locks, a forward lock and > a backwards lock named frwd_lock and back_lock respectively. . > > Signed-off-by: Shlomo Pongratz > Signed-off-by: Or Gerlitz > [minor fix up to a