Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-22 Thread Hannes Reinecke
On 05/21/2014 03:30 PM, Bart Van Assche wrote: scmd->abort_work is only scheduled after the block layer has marked the request associated with a command as complete and for commands that are not on the eh_cmd_q list. A SCSI command is only requeued after the scmd->abort_work handler has started (

Re: [PATCH 39/42] qla2xxx: ABTS cause double free of qla_tgt_cmd +.

2014-05-22 Thread Nicholas A. Bellinger
Hi Saurav + Quinn, Just curious if this fix needs to be CC'ed to stable as well, or if it's something that is only triggered with the preceding T10 DIF support patch in place..? --nab On Fri, 2014-04-11 at 16:54 -0400, Saurav Kashyap wrote: > From: Quinn Tran > > Fix double free problem within

[PATCH-scsi-for-next] tcm_qla2xxx: Set correct protection flags when DIF/DIX is enabled

2014-05-22 Thread Nicholas A. Bellinger
From: Nicholas Bellinger With the advent of per session protection flags in v3.15-rc1 code, a target fabric driver supporting T10 PI needs to declare it's own protection capabilities at transport_init_session() time. This patch updates tcm_qla2xxx_check_initiator_node_acl() to extract the T10 PI

[PATCH 1/1] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

2014-05-22 Thread K. Y. Srinivasan
Hyper-V hosts can support multiple targets and multiple channels and larger number of LUNs per target. Update the code to reflect this. With this patch we can correctly enumerate all the paths in a multi-path storage environment. MS-TFS: 173725 Signed-off-by: K. Y. Srinivasan Cc: --- drivers

RE: dangling pointers and/or reentrancy in scmd_eh_abort_handler?

2014-05-22 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Paolo Bonzini > Sent: Wednesday, 21 May, 2014 3:34 PM > To: Mark Wu; linux-scsi@vger.kernel.org > Subject: Re: dangling pointers and/or reentrancy in > scmd_eh_abort_han

RE: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

2014-05-22 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Thursday, May 22, 2014 7:38 AM > To: KY Srinivasan > Cc: Andy Whitcroft; Ian Abbott; linux-scsi@vger.kernel.org; > de...@linuxdriverproject.org; Haiyang Zhang; Tim Gardner > Subject: Re: [P

[PATCH] scsi_transport_sas: move bsg destructor into sas_rphy_remove

2014-05-22 Thread Joe Lawrence
The recent change in sysfs, bcdde7e221a8750f9b62b6d0bd31b72ea4ad9309 "sysfs: make __sysfs_remove_dir() recursive" revealed an asymmetric rphy device creation/deletion sequence in scsi_transport_sas: modprobe mpt2sas sas_rphy_add device_add A rphy->dev device_add B

Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type

2014-05-22 Thread Nicholas A. Bellinger
Hi Fengguang, On Thu, 2014-05-22 at 11:13 +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git > for-next > head: 4baaa7d589e24bfe87dfd6c7a1229108be404a28 > commit: 4baaa7d589e24bfe87dfd6c7a1229108be404a28 [20/20] virtio-scsi: Enable >

Re: [PATCH-v2 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD

2014-05-22 Thread Nicholas A. Bellinger
On Thu, 2014-05-22 at 10:37 +0200, Paolo Bonzini wrote: > Il 22/05/2014 04:26, Nicholas A. Bellinger ha scritto: > > From: Nicholas Bellinger > > > > This patch updates virtscsi_probe() to setup necessary Scsi_Host > > level protection resources. (currently hardcoded to 1) > > > > It changes virts

Re: [PATCH-v2 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits

2014-05-22 Thread Nicholas A. Bellinger
On Thu, 2014-05-22 at 09:57 +0300, Michael S. Tsirkin wrote: > On Thu, May 22, 2014 at 02:26:17AM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds a virtio_scsi_cmd_req_pi header as recommened by > > Paolo that contains do_pi_niov + di_pi_niov elements used

Re: [PATCH] [SCSI] mptfusion: remove check for CONFIG_FUSION_MAX_FC_SGE

2014-05-22 Thread Paul Bolle
On Thu, 2014-05-22 at 19:58 +, Address Change LSI wrote: > The person you are trying to email is no longer receiving email @lsi.com. > Please try sending to them at > Avago Technologies using firstname.lastn...@avagotech.com. > > Please Note: Your original message has been forwarded to this r

[PATCH] [SCSI] mptfusion: remove check for CONFIG_FUSION_MAX_FC_SGE

2014-05-22 Thread Paul Bolle
A check for CONFIG_FUSION_MAX_FC_SGE was added in v2.6.31. But the related Kconfig symbol was never added to the tree. Remove this check, as it always evaluates to false. Signed-off-by: Paul Bolle --- Compile tested only. drivers/message/fusion/mptbase.h | 10 -- 1 file changed, 10 dele

Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-22 Thread Bart Van Assche
On 05/22/14 18:22, Paolo Bonzini wrote: > Il 21/05/2014 15:30, Bart Van Assche ha scritto: >> +static bool scmd_being_handled_in_other_context(struct scsi_cmnd *scmd) >> +{ >> +struct Scsi_Host *shost = scmd->device->host; >> +struct scsi_cmnd *c; >> +unsigned long flags; >> +bool r

Re: [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects

2014-05-22 Thread Mike Christie
On 05/19/2014 06:32 AM, vikas.chaudh...@qlogic.com wrote: > From: Tej Parkash > > Signed-off-by: Tej Parkash > Signed-off-by: Vikas Chaudhary > --- > drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c > b/drivers/scsi

Re: [PATCH RFC] Remove the cancel_delayed_work() call from scsi_put_command()

2014-05-22 Thread Paolo Bonzini
Il 21/05/2014 15:30, Bart Van Assche ha scritto: +static bool scmd_being_handled_in_other_context(struct scsi_cmnd *scmd) +{ + struct Scsi_Host *shost = scmd->device->host; + struct scsi_cmnd *c; + unsigned long flags; + bool ret = false; + + if (!blk_rq_completed(sc

Re: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

2014-05-22 Thread James Bottomley
On Thu, 2014-05-22 at 10:49 +, KY Srinivasan wrote: > > > > -Original Message- > > From: Andy Whitcroft [mailto:a...@canonical.com] > > Sent: Wednesday, May 21, 2014 7:25 AM > > To: Ian Abbott > > Cc: linux-scsi@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan; > > Haiyang

Re: [PATCH-v2 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits

2014-05-22 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, May 22, 2014 at 02:26:17AM +, Nicholas A. Bellinger wrote: >> From: Nicholas Bellinger >> >> This patch adds a virtio_scsi_cmd_req_pi header as recommened by >> Paolo that contains do_pi_niov + di_pi_niov elements used for >> signaling when protection i

RE: [PATCH 0/2] scsi: hyper-v storvsc changes by Ubuntu

2014-05-22 Thread KY Srinivasan
> -Original Message- > From: Andy Whitcroft [mailto:a...@canonical.com] > Sent: Wednesday, May 21, 2014 7:25 AM > To: Ian Abbott > Cc: linux-scsi@vger.kernel.org; de...@linuxdriverproject.org; KY Srinivasan; > Haiyang Zhang; James E.J. Bottomley; Tim Gardner > Subject: Re: [PATCH 0/2] scs

Re: [PATCH 5/5] scsi: use 64-bit value for 'max_luns'

2014-05-22 Thread Christoph Hellwig
On Tue, May 20, 2014 at 01:03:11PM +0200, Hannes Reinecke wrote: > Now that we're using 64-bit LUNs internally we need to increase > the size of max_luns to 64 bits, too. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the bo

Re: [PATCH 4/5] scsi: use 64-bit LUNs

2014-05-22 Thread Christoph Hellwig
On Tue, May 20, 2014 at 01:03:10PM +0200, Hannes Reinecke wrote: > The SCSI standard defines 64-bit values for LUNs, and large arrays > employing large or hierarchical LUN numbers become more and more > common. > > So update the linux SCSI stack to use 64-bit LUN numbers. > > Signed-off-by: Hanne

Re: [PATCH 3/5] qla2xxx: Restrict max_lun to 16-bit for older HBAs

2014-05-22 Thread Christoph Hellwig
On Tue, May 20, 2014 at 01:03:09PM +0200, Hannes Reinecke wrote: > Older HBAs are only capable of supporting 16-bit LUNs, > so we need to make sure to adjust max_lun accordingly. > > Signed-off-by: Hannes Reinecke > Acked-by: Chad Dupuis Looks good, Reviewed-by: Christoph Hellwig This is pro

Re: [PATCH 2/5] scsi_scan: Restrict sequential scan to 256 LUNs

2014-05-22 Thread Christoph Hellwig
On Tue, May 20, 2014 at 01:03:08PM +0200, Hannes Reinecke wrote: > Sequential scan for more than 256 LUNs is very fragile as > LUNs might not be numbered sequentially after that point. > > SAM revisions later than SCSI-3 impose a structure on > LUNs larger than 256, making LUN numbers between 256

Re: [PATCH RESEND] scsi: Output error messages using structured printk in single line

2014-05-22 Thread Christoph Hellwig
On Wed, May 21, 2014 at 08:30:58AM +0200, Hannes Reinecke wrote: > While this works reasonably well for most things, printing out > decoded sense with just one line (and not end up in massive switch() > statements) is near impossible. > > Plus you'll end up having to use a static buffer at one poi

Re: [PATCH 1/5] scsi: Remove CONFIG_SCSI_MULTI_LUN

2014-05-22 Thread Christoph Hellwig
On Tue, May 20, 2014 at 01:03:07PM +0200, Hannes Reinecke wrote: > Obsolete; either use 'max_lun' if the host supports only a > limited number of LUNs or BLIST_NOLUN if the target has > problems addressing more than one LUN. > > Signed-off-by: Hannes Reinecke Looks good, Reviewed-by: Christoph

Re: [PATCH-v2 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 04:26, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger This patch updates virtscsi_probe() to setup necessary Scsi_Host level protection resources. (currently hardcoded to 1) It changes virtscsi_add_cmd() to attach outgoing / incoming protection SGLs preceeding the dat

Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support

2014-05-22 Thread Paolo Bonzini
Il 22/05/2014 04:26, Nicholas A. Bellinger ha scritto: From: Nicholas Bellinger Hi MST, MKP, Paolo & Co, Here is the v2 patch series for adding T1O protection information (PI) SGL passthrough support between virtio-scsi LLD + vhost-scsi fabric endpoints. Following MST's recommendation, it inc

[Bug 76681] Adaptec 7805H SAS HBA (pm80xx) cannot survive ACPI S3 or ACPI S4

2014-05-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=76681 Jack Wang changed: What|Removed |Added CC||xjtu...@gmail.com --- Comment #1 from Jack Wa